drm/amdgpu: make a correction on comment
Subsystems (2)
PATCH 1/1 drm/amdgpu: make a correction on comment
Current AMDGPU_VM_RESERVED_VRAM is updated to 8M.
--- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h +1 -1
@@ -116,7 +116,7 @@ struct amdgpu_mem_stats;#define AMDGPU_VM_FAULT_STOP_FIRST 1#define AMDGPU_VM_FAULT_STOP_ALWAYS 2 -/* Reserve 4MB VRAM for page tables */ +/* Reserve 8MB VRAM for page tables */ #define AMDGPU_VM_RESERVED_VRAM (8ULL << 20)/*
Signature · 1 line
2.25.1
Am 02.01.24 um 21:56 schrieb James Zhu:
Quoted 3 lines
Current
AMDGPU_VM_RESERVED_VRAMis updated to 8M.Signed-off-by James Zhu <[email protected]>
Maybe remove the value completely from the comment, just something like "How much memory be reserved for page tables".
Either way Reviewed-by: Christian König <[email protected]>
Quoted 17 lines
--- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h +1
-1@@ -116,7 +116,7 @@ struct amdgpu_mem_stats;#define AMDGPU_VM_FAULT_STOP_FIRST 1#define AMDGPU_VM_FAULT_STOP_ALWAYS 2 -/* Reserve 4MB VRAM for page tables */ +/* Reserve 8MB VRAM for page tables */ #define AMDGPU_VM_RESERVED_VRAM (8ULL << 20)/*
Quoted 6 lines · Christian König
Am 02.01.24 um 21:56 schrieb James Zhu:
Quoted 3 lines
Current
AMDGPU_VM_RESERVED_VRAMis updated to 8M.Signed-off-by James Zhu <[email protected]>Maybe remove the value completely from the comment, just something like "How much memory be reserved for page tables".
[JZ] This will work better. Thanks!
Quoted 19 lines
Either way Reviewed-by: Christian König <[email protected]>
Quoted 15 lines
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h| 2 +-1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h +0
-0@@ -116,7 +116,7 @@ struct amdgpu_mem_stats; #define AMDGPU_VM_FAULT_STOP_FIRST 1 #define AMDGPU_VM_FAULT_STOP_ALWAYS 2-/* Reserve 4MB VRAM for page tables */
+/* Reserve 8MB VRAM for page tables */ #define AMDGPU_VM_RESERVED_VRAM (8ULL << 20) /*