Skip to contentSkip to conversation

soc/tegra: fix build failure on Tegra241

PATCH In review Arnd Bergmann 3 participants 3 messages Jan 3, 2024 – Jan 30, 2024 Tegra architecture support

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 soc/tegra: fix build failure on Tegra241

From: Arnd Bergmann <[email protected]>

If all the other SoCs are disabled, the driver fails to build:

drivers/soc/tegra/fuse/fuse-tegra30.c:684:17: error: 'tegra30_fuse_read' undeclared here (not in a function); did you mean 'tegra_fuse_readl'?

  684 |         .read = tegra30_fuse_read,
      |                 ^~~~~~~~~~~~~~~~~
      |                 tegra_fuse_readl
drivers/soc/tegra/fuse/fuse-tegra30.c:694:17: error: 'tegra30_fuse_init' undeclared here (not in a function); did you mean 'tegra_fuse_info'?
  694 |         .init = tegra30_fuse_init,
      |                 ^~~~~~~~~~~~~~~~~

Fix the list of SoCs using this function to include the newly added one.

Fixes dee509eb9cd5 ("soc/tegra: fuse: Add support for Tegra241")
---
 drivers/soc/tegra/fuse/fuse-tegra30.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/soc/tegra/fuse/fuse-tegra30.c +2 -1
index 2070d36c510d..eb14e5ff5a0a 100644
@@ -38,7 +38,8 @@
     defined(CONFIG_ARCH_TEGRA_210_SOC) || \
     defined(CONFIG_ARCH_TEGRA_186_SOC) || \
     defined(CONFIG_ARCH_TEGRA_194_SOC) || \
-    defined(CONFIG_ARCH_TEGRA_234_SOC)
+    defined(CONFIG_ARCH_TEGRA_234_SOC) || \
+    defined(CONFIG_ARCH_TEGRA_241_SOC)
 static u32 tegra30_fuse_read_early(struct tegra_fuse *fuse, unsigned int offset)
 {
 	if (WARN_ON(!fuse->base))
Signature · 1 line
2.39.2
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 25 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

If all the other SoCs are disabled, the driver fails to build:

drivers/soc/tegra/fuse/fuse-tegra30.c:684:17: error: 'tegra30_fuse_read' undeclared here (not in a function); did you mean 'tegra_fuse_readl'?

   684 |         .read = tegra30_fuse_read,
       |                 ^~~~~~~~~~~~~~~~~
       |                 tegra_fuse_readl
drivers/soc/tegra/fuse/fuse-tegra30.c:694:17: error: 'tegra30_fuse_init' undeclared here (not in a function); did you mean 'tegra_fuse_info'?
   694 |         .init = tegra30_fuse_init,
       |                 ^~~~~~~~~~~~~~~~~

Fix the list of SoCs using this function to include the newly added one.

Fixes dee509eb9cd5 ("soc/tegra: fuse: Add support for Tegra241")
---
  drivers/soc/tegra/fuse/fuse-tegra30.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
drivers/soc/tegra/fuse/fuse-tegra30.c +0 -0
index 2070d36c510d..eb14e5ff5a0a 100644

drivers/soc/tegra/fuse/fuse-tegra30.c line 45

Quoted 9 lines
drivers/soc/tegra/fuse/fuse-tegra30.c +2 -1
@@ -38,7 +38,8 @@
      defined(CONFIG_ARCH_TEGRA_210_SOC) || \
      defined(CONFIG_ARCH_TEGRA_186_SOC) || \
      defined(CONFIG_ARCH_TEGRA_194_SOC) || \
-    defined(CONFIG_ARCH_TEGRA_234_SOC)
+    defined(CONFIG_ARCH_TEGRA_234_SOC) || \
+    defined(CONFIG_ARCH_TEGRA_241_SOC)
  static u32 tegra30_fuse_read_early(struct tegra_fuse *fuse, unsigned int offset)
  {
  	if (WARN_ON(!fuse->base))

Thanks for fixing!

Jon

Signature · 1 line
nvpublic
Reviewed-by on v1 1/1
#2 lore raw
In reply to Arnd Bergmann
Quoted 40 lines · Arnd Bergmann

External email: Use caution opening links or attachments

From: Arnd Bergmann <[email protected]>

If all the other SoCs are disabled, the driver fails to build:

drivers/soc/tegra/fuse/fuse-tegra30.c:684:17: error:
'tegra30_fuse_read' undeclared here (not in a function); did you mean 'tegra_fuse_readl'?
  684 |         .read = tegra30_fuse_read,
      |                 ^~~~~~~~~~~~~~~~~
      |                 tegra_fuse_readl drivers/soc/tegra/fuse/fuse-tegra30.c:694:17: error:
'tegra30_fuse_init' undeclared here (not in a function); did you mean 'tegra_fuse_info'?
  694 |         .init = tegra30_fuse_init,
      |                 ^~~~~~~~~~~~~~~~~

Fix the list of SoCs using this function to include the newly added one.

Fixes dee509eb9cd5 ("soc/tegra: fuse: Add support for Tegra241")

---
 drivers/soc/tegra/fuse/fuse-tegra30.c | 3 ++-

 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/soc/tegra/fuse/fuse-tegra30.c +2 -1
index 2070d36c510d..eb14e5ff5a0a 100644
@@ -38,7 +38,8 @@
      defined(CONFIG_ARCH_TEGRA_210_SOC) || \
      defined(CONFIG_ARCH_TEGRA_186_SOC) || \
      defined(CONFIG_ARCH_TEGRA_194_SOC) || \
-    defined(CONFIG_ARCH_TEGRA_234_SOC)
+    defined(CONFIG_ARCH_TEGRA_234_SOC) || \
+    defined(CONFIG_ARCH_TEGRA_241_SOC)
Quoted 7 lines

 static u32 tegra30_fuse_read_early(struct tegra_fuse *fuse, unsigned int offset)
 {
        if (WARN_ON(!fuse->base))
--
2.39.2

Thanks Arnd!