ice: Add a new counter for Rx EIPE errors
Subsystems (3)
PATCH 1/1 ice: Add a new counter for Rx EIPE errors
From: Aniruddha Paul <[email protected]>
HW incorrectly reports EIPE errors on encapsulated packets with L2 padding inside inner packet. HW shows outer UDP/IPV4 packet checksum errors as part of the EIPE flags of the Rx descriptor. These are reported only if checksum offload is enabled and L3/L4 parsed flag is valid in Rx descriptor.
When that error is reported by HW, we don't act on it instead of incrementing main Rx errors statistic as it would normally happen.
Add a new statistic to count these errors since we still want to print them.
--- drivers/net/ethernet/intel/ice/ice.h | 1 + drivers/net/ethernet/intel/ice/ice_ethtool.c | 1 + drivers/net/ethernet/intel/ice/ice_txrx_lib.c | 8 ++++++-- 3 files changed, 8 insertions(+), 2 deletions(-)
drivers/net/ethernet/intel/ice/ice.h +1 -0
@@ -606,6 +606,7 @@ struct ice_pf {wait_queue_head_t reset_wait_queue;u32 hw_csum_rx_error; +u32 hw_rx_eipe_error;u32 oicr_err_reg;struct msi_map oicr_irq;/* Other interrupt cause MSIX vector */ struct msi_map ll_ts_irq;/* LL_TS interrupt MSIX vector */
drivers/net/ethernet/intel/ice/ice_ethtool.c +1 -0
@@ -129,6 +129,7 @@ static const struct ice_stats ice_gstrings_pf_stats[] = {ICE_PF_STAT ("rx_oversize.nic" , stats.rx_oversize),ICE_PF_STAT ("rx_jabber.nic" , stats.rx_jabber),ICE_PF_STAT ("rx_csum_bad.nic" , hw_csum_rx_error), +ICE_PF_STAT ("rx_eipe_error.nic" , hw_rx_eipe_error),ICE_PF_STAT ("rx_dropped.nic" , stats.eth.rx_discards),ICE_PF_STAT ("rx_crc_errors.nic" , stats.crc_errors), ICE_PF_STAT("illegal_bytes.nic", stats.illegal_bytes),
drivers/net/ethernet/intel/ice/ice_txrx_lib.c +6 -2
@@ -143,8 +143,12 @@ ice_rx_csum(struct ice_rx_ring *ring, struct sk_buff *skb, ipv6 = (decoded.outer_ip ==ICE_RX_PTYPE_OUTER_IP ) && (decoded.outer_ip_ver ==ICE_RX_PTYPE_OUTER_IPV6 ); -if (ipv4 && (rx_status0 & (BIT (ICE_RX_FLEX_DESC_STATUS0_XSUM_IPE_S ) | -BIT (ICE_RX_FLEX_DESC_STATUS0_XSUM_EIPE_S )))) +if (ipv4 && (rx_status0 & (BIT (ICE_RX_FLEX_DESC_STATUS0_XSUM_EIPE_S )))) { + ring->vsi->back->hw_rx_eipe_error++; +return ; + } + +if (ipv4 && (rx_status0 & (BIT (ICE_RX_FLEX_DESC_STATUS0_XSUM_IPE_S )))) goto checksum_fail;if (ipv6 && (rx_status0 & (BIT (ICE_RX_FLEX_DESC_STATUS0_IPV6EXADD_S ))))
Signature · 1 line
2.31.1
Quoted 12 lines · Jan Sokolowski
From: Aniruddha Paul <[email protected]>
HW incorrectly reports EIPE errors on encapsulated packets with L2 padding inside inner packet. HW shows outer UDP/IPV4 packet checksum errors as part of the EIPE flags of the Rx descriptor. These are reported only if checksum offload is enabled and L3/L4 parsed flag is valid in Rx descriptor.
When that error is reported by HW, we don't act on it instead of incrementing main Rx errors statistic as it would normally happen.
Quoted 7 lines
Add a new statistic to count these errors since we still want to print them.
Signed-off-by Aniruddha Paul <[email protected]>Reviewed-by Przemek Kitszel <[email protected]>Reviewed-by Jan Glaza <[email protected]>Signed-off-by Jan Sokolowski <[email protected]>
Quoted 26 lines
-----Original Message-----
From: Intel-wired-lan <[email protected]> On Behalf Of Jan Sokolowski
Sent: Wednesday, January 3, 2024 7:41 PM
To: [email protected]
Cc: [email protected]; Sokolowski, Jan <[email protected]>; Kitszel, Przemyslaw <[email protected]>; Glaza, Jan <[email protected]>; Aniruddha Paul <[email protected]>
Subject: [Intel-wired-lan] [PATCH iwl-next v1] ice: Add a new counter for Rx EIPE errorsFrom: Aniruddha Paul <[email protected]>
HW incorrectly reports EIPE errors on encapsulated packets with L2 padding inside inner packet. HW shows outer UDP/IPV4 packet checksum errors as part of the EIPE flags of the Rx descriptor. These are reported only if checksum offload is enabled and L3/L4 parsed flag is valid in Rx descriptor.
When that error is reported by HW, we don't act on it instead of incrementing main Rx errors statistic as it would normally happen.
Add a new statistic to count these errors since we still want to print them.
Signed-off-by Aniruddha Paul <[email protected]>Reviewed-by Przemek Kitszel <[email protected]>Reviewed-by Jan Glaza <[email protected]>Signed-off-by Jan Sokolowski <[email protected]>
Quoted 6 lines
--- drivers/net/ethernet/intel/ice/ice.h | 1 + drivers/net/ethernet/intel/ice/ice_ethtool.c | 1 + drivers/net/ethernet/intel/ice/ice_txrx_lib.c | 8 ++++++-- 3 files changed, 8 insertions(+), 2 deletions(-)