x86/vdso: shrink vdso/vdso32-setup.i via IWYU
Subsystems (3)
PATCH v2 1/1 x86/vdso: shrink vdso/vdso32-setup.i via IWYU
This diff uses an open source tool include-what-you-use (IWYU) to modify the include list, changing indirect includes to direct includes. IWYU is implemented using the IWYUScripts github repository which is a tool that is currently undergoing development. These changes seek to improve build times.
This change to vdso/vdso32-setup.c resulted in a preprocessed size of vdso/vdso32-setup.i from 44009 lines to 18572 lines (-58%) for the x86 defconfig.
---
Changes in v2:
- Fixed messed up signed-off-by tag
- Link to v1: https://lore.kernel.org/r/[email protected]
--- arch/x86/entry/vdso/vdso32-setup.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-)
arch/x86/entry/vdso/vdso32-setup.c +4 -6
@@ -8,13 +8,11 @@*/ #include <linux/init.h> -#include <linux/smp.h> -#include <linux/kernel.h> -#include <linux/mm_types.h> -#include <linux/elf.h> +#include <linux/kstrtox.h> +#include <linux/printk.h> +#include <linux/stddef.h> -#include <asm/processor.h> -#include <asm/vdso.h> +#include <asm/cache.h> #ifdef CONFIG_COMPAT_VDSO #define VDSO_DEFAULT 0
---
base-commit: f5837722ffecbbedf1b1dbab072a063565f0dad1
change-id: 20231228-vdso32setup-8e336d60ac3e
Best regards,
Signature · 1 line
Tanzir Hasan <[email protected]>
Hi,
Quoted 10 lines · Tanzir Hasan
This diff uses an open source tool include-what-you-use (IWYU) to modify the include list, changing indirect includes to direct includes. IWYU is implemented using the IWYUScripts github repository which is a tool that is currently undergoing development. These changes seek to improve build times.
This change to
vdso/vdso32-setup.cresulted in a preprocessed size of vdso/vdso32-setup.i from 44009 lines to 18572 lines (-58%) for the x86 defconfig.
Quoted 8 lines
Reviewed-by Nick Desaulniers <[email protected]>Tested-by Nick Desaulniers <[email protected]>Signed-off-by Tanzir Hasan <[email protected]>---
Changes in v2:
- Fixed messed up signed-off-by tag
- Link to v1: https://lore.kernel.org/r/[email protected]
---
I built 10 x86_64 randconfigs with KCONFIG_SEEDs:
1: 0xF411D996
2: 0x47DADF74
3: 0x431DBDD9
4: 0xC411E812
5: 0x308B62A0
6: 0xD91AA814
7: 0x11DF23E8
8: 0x629EBA88
9: 0x4B88CEC8
10: 0xED145212
They all built just fine.
As for the semantics of this patch, dropping a giant header like kernel.h seems great and the rest of the includes are reasonable. For that,
Quoted 30 lines
arch/x86/entry/vdso/vdso32-setup.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-)arch/x86/entry/vdso/vdso32-setup.c +4
-7@@ -8,13 +8,11 @@*/ #include <linux/init.h> -#include <linux/smp.h> -#include <linux/kernel.h> -#include <linux/mm_types.h> -#include <linux/elf.h> +#include <linux/kstrtox.h> +#include <linux/printk.h> +#include <linux/stddef.h> -#include <asm/processor.h> -#include <asm/vdso.h> +#include <asm/cache.h> #ifdef CONFIG_COMPAT_VDSO #define VDSO_DEFAULT 0 ---base-commit:
f5837722ffecbbedf1b1dbab072a063565f0dad1
change-id: 20231228-vdso32setup-8e336d60ac3e
Quoted 4 lines
Best regards,
--
Tanzir Hasan <[email protected]>
Thanks
Justin