Skip to contentSkip to conversation

arm-bsp/trusted-firmware-m: update libmetal and open-amp to a release

PATCH Applied Jon Mason 2 participants 3 messages Jan 5, 2024 – Jan 6, 2024

lore
Share & tools
lore

Jon Mason

author
#0 lore raw

PATCH 1/2 arm-bsp/trusted-firmware-m: update libmetal and open-amp to a release

The SHAs for both libmetal and open-amp are intermediate SHAs, which are only a few patches behind the v2021.04.0 tags. Update to those tags and make the necessary changes to get them working.

---
 ...modify-path-to-libmetal-version-file.patch | 27 +++++++++++++++++++
 .../trusted-firmware-m-corstone1000.inc       | 12 +++++----
 2 files changed, 34 insertions(+), 5 deletions(-)
 create mode 100644 meta-arm-bsp/recipes-bsp/trusted-firmware-m/files/0001-cmake-modify-path-to-libmetal-version-file.patch
meta-arm-bsp/recipes-bsp/trusted-firmware-m/files/0001-cmake-modify-path-to-libmetal-version-file.patch new file +27 -0
new file mode 100644
index 00000000..68785f6c
@@ -0,0 +1,27 @@
+From dfdfd7f829f74b46f14470eae968c39b910fd11c Mon Sep 17 00:00:00 2001
+From: Jon Mason <[email protected]>
+Date: Thu, 14 Dec 2023 09:01:02 -0500
+Subject: [PATCH] cmake: modify path to libmetal version file
+
+Commit ad87802d6e01e97946de20b6c2fa28aed184ed20 changed how the
+versioning is done and created a version file.  Due to this change,
+the VERSION file is not being found when building because the source dir
+is pointing to tf-m.  Modify to point where we want it.
+
+Upstream-Status: Inappropriate [Build workaround]
+
+Signed-off-by: Jon Mason <[email protected]>
+---
+ cmake/options.cmake | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/cmake/options.cmake b/cmake/options.cmake
+index 4b866164c390..004126a40da1 100644
+--- a/cmake/options.cmake
++++ b/cmake/options.cmake
+@@ -1,4 +1,4 @@
+-file(READ ${CMAKE_SOURCE_DIR}/VERSION ver)
++file(READ ${CMAKE_SOURCE_DIR}/../libmetal/VERSION ver)
+ 
+ string(REGEX MATCH "VERSION_MAJOR = ([0-9]*)" _ ${ver})
+ set(PROJECT_VERSION_MAJOR ${CMAKE_MATCH_1})
meta-arm-bsp/recipes-bsp/trusted-firmware-m/trusted-firmware-m-corstone1000.inc +7 -5
index 7cf3b944..8d91c523 100644
@@ -11,18 +11,20 @@ TFM_PLATFORM_IS_FVP ?= "FALSE"
 EXTRA_OECMAKE += "-DPLATFORM_IS_FVP=${TFM_PLATFORM_IS_FVP}"
 EXTRA_OECMAKE += "-DCC312_LEGACY_DRIVER_API_ENABLED=ON"
 
-# libmetal
+# libmetal v2021.04.0
 LICENSE += "& BSD-3-Clause"
 LIC_FILES_CHKSUM += "file://../libmetal/LICENSE.md;md5=fe0b8a4beea8f0813b606d15a3df3d3c"
-SRC_URI += "git://github.com/OpenAMP/libmetal.git;protocol=https;branch=main;name=libmetal;destsuffix=git/libmetal"
-SRCREV_libmetal = "f252f0e007fbfb8b3a52b1d5901250ddac96baad"
+SRC_URI += "git://github.com/OpenAMP/libmetal.git;protocol=https;branch=main;name=libmetal;destsuffix=git/libmetal \
+            file://0001-cmake-modify-path-to-libmetal-version-file.patch;patchdir=../libmetal \
+           "
+SRCREV_libmetal = "59e2f084d31a60a95c99ab130227674fd365764b"
 EXTRA_OECMAKE += "-DLIBMETAL_SRC_PATH=${S}/../libmetal -DLIBMETAL_BIN_PATH=${B}/libmetal-build"
 
-# OpenAMP
+# OpenAMP v2021.04.0
 LICENSE += "& BSD-2-Clause & BSD-3-Clause"
 LIC_FILES_CHKSUM += "file://../openamp/LICENSE.md;md5=a8d8cf662ef6bf9936a1e1413585ecbf"
 SRC_URI += "git://github.com/OpenAMP/open-amp.git;protocol=https;branch=main;name=openamp;destsuffix=git/openamp"
-SRCREV_openamp = "347397decaa43372fc4d00f965640ebde042966d"
+SRCREV_openamp = "c3f12991991d187d47637d88e8a66076f23d0c8c"
 EXTRA_OECMAKE += "-DLIBOPENAMP_SRC_PATH=${S}/../openamp -DLIBOPENAMP_BIN_PATH=${B}/libopenamp-build"
 
 
Signature · 1 line
2.30.2
author
#1 lore raw

PATCH 2/2 arm-bsp/trusted-firmware-m: update libmetal and open-amp to 2023.04.0

---
 ...-cmake-modify-path-to-libmetal-version-file.patch | 10 +++++-----
 .../trusted-firmware-m-corstone1000.inc              | 12 ++++++------
 2 files changed, 11 insertions(+), 11 deletions(-)
meta-arm-bsp/recipes-bsp/trusted-firmware-m/files/0001-cmake-modify-path-to-libmetal-version-file.patch +5 -5
index 68785f6c..d53524ad 100644
@@ -1,6 +1,6 @@
-From dfdfd7f829f74b46f14470eae968c39b910fd11c Mon Sep 17 00:00:00 2001
+From 6b38b9990c4dab0cb8524506ef129d4f326f3800 Mon Sep 17 00:00:00 2001
 From: Jon Mason <[email protected]>
-Date: Thu, 14 Dec 2023 09:01:02 -0500
+Date: Thu, 14 Dec 2023 09:23:09 -0500
 Subject: [PATCH] cmake: modify path to libmetal version file
 
 Commit ad87802d6e01e97946de20b6c2fa28aed184ed20 changed how the
@@ -16,12 +16,12 @@ Signed-off-by: Jon Mason <[email protected]>
  1 file changed, 1 insertion(+), 1 deletion(-)
 
 diff --git a/cmake/options.cmake b/cmake/options.cmake
-index 4b866164c390..004126a40da1 100644
+index a7b4ef8bdf03..a06009b6acc4 100644
 --- a/cmake/options.cmake
 +++ b/cmake/options.cmake
 @@ -1,4 +1,4 @@
--file(READ ${CMAKE_SOURCE_DIR}/VERSION ver)
-+file(READ ${CMAKE_SOURCE_DIR}/../libmetal/VERSION ver)
+-file(READ ${LIBMETAL_ROOT_DIR}/VERSION ver)
++file(READ ${LIBMETAL_ROOT_DIR}/../libmetal/VERSION ver)
  
  string(REGEX MATCH "VERSION_MAJOR = ([0-9]*)" _ ${ver})
  set(PROJECT_VERSION_MAJOR ${CMAKE_MATCH_1})
meta-arm-bsp/recipes-bsp/trusted-firmware-m/trusted-firmware-m-corstone1000.inc +6 -6
index 8d91c523..f4623f50 100644
@@ -11,20 +11,20 @@ TFM_PLATFORM_IS_FVP ?= "FALSE"
 EXTRA_OECMAKE += "-DPLATFORM_IS_FVP=${TFM_PLATFORM_IS_FVP}"
 EXTRA_OECMAKE += "-DCC312_LEGACY_DRIVER_API_ENABLED=ON"
 
-# libmetal v2021.04.0
+# libmetal v2023.04.0
 LICENSE += "& BSD-3-Clause"
-LIC_FILES_CHKSUM += "file://../libmetal/LICENSE.md;md5=fe0b8a4beea8f0813b606d15a3df3d3c"
+LIC_FILES_CHKSUM += "file://../libmetal/LICENSE.md;md5=f4d5df0f12dcea1b1a0124219c0dbab4"
 SRC_URI += "git://github.com/OpenAMP/libmetal.git;protocol=https;branch=main;name=libmetal;destsuffix=git/libmetal \
             file://0001-cmake-modify-path-to-libmetal-version-file.patch;patchdir=../libmetal \
            "
-SRCREV_libmetal = "59e2f084d31a60a95c99ab130227674fd365764b"
+SRCREV_libmetal = "28fa2351d6a8121ce6c1c2ac5ee43ce08d38dbae"
 EXTRA_OECMAKE += "-DLIBMETAL_SRC_PATH=${S}/../libmetal -DLIBMETAL_BIN_PATH=${B}/libmetal-build"
 
-# OpenAMP v2021.04.0
+# OpenAMP v2023.04.0
 LICENSE += "& BSD-2-Clause & BSD-3-Clause"
-LIC_FILES_CHKSUM += "file://../openamp/LICENSE.md;md5=a8d8cf662ef6bf9936a1e1413585ecbf"
+LIC_FILES_CHKSUM += "file://../openamp/LICENSE.md;md5=ab88daf995c0bd0071c2e1e55f3d3505"
 SRC_URI += "git://github.com/OpenAMP/open-amp.git;protocol=https;branch=main;name=openamp;destsuffix=git/openamp"
-SRCREV_openamp = "c3f12991991d187d47637d88e8a66076f23d0c8c"
+SRCREV_openamp = "accac4d3610cbb268f3c3fe3c31dc45dd4c4dd17"
 EXTRA_OECMAKE += "-DLIBOPENAMP_SRC_PATH=${S}/../openamp -DLIBOPENAMP_BIN_PATH=${B}/libopenamp-build"
 
 
Signature · 1 line
2.30.2
Applied
#2 lore raw
In reply to Jon Mason
Quoted 5 lines · Jon Mason

The SHAs for both libmetal and open-amp are intermediate SHAs, which are only a few patches behind the v2021.04.0 tags. Update to those tags and make the necessary changes to get them working.

Applied, thanks!

[1/2] arm-bsp/trusted-firmware-m: update libmetal and open-amp to a release

      commit: 01e60aa0e3fd78028118c5602ce58e316e07d04f
[2/2] arm-bsp/trusted-firmware-m: update libmetal and open-amp to 2023.04.0
      commit: 2cc6f05f3e091c33661e7bee1a23a57966076b0d

Best regards,

Signature · 1 line
Jon Mason <[email protected]>