net/ice: refine queue start stop
PATCH 1/1 net/ice: refine queue start stop
Not necessary to return fail when starting or stopping a queue if the queue was already at required state.
--- drivers/net/ice/ice_rxtx.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)
drivers/net/ice/ice_rxtx.c +16 -0
@@ -673,6 +673,10 @@ ice_rx_queue_start(struct rte_eth_dev *dev, uint16_t rx_queue_id)return -EINVAL ; } +if (dev->data->rx_queue_state[rx_queue_id] == +RTE_ETH_QUEUE_STATE_STARTED ) +return 0 ; +if (dev->data->dev_conf.rxmode.offloads &RTE_ETH_RX_OFFLOAD_TIMESTAMP ) rxq->ts_enable = true; err =ice_program_hw_rx_queue (rxq);
@@ -717,6 +721,10 @@ ice_rx_queue_stop(struct rte_eth_dev *dev, uint16_t rx_queue_id)if (rx_queue_id < dev->data->nb_rx_queues) { rxq = dev->data->rx_queues[rx_queue_id]; +if (dev->data->rx_queue_state[rx_queue_id] == +RTE_ETH_QUEUE_STATE_STOPPED ) +return 0 ; + err =ice_switch_rx_queue (hw, rxq->reg_idx, false);if (err) { PMD_DRV_LOG(ERR, "Failed to switch RX queue %u off",
@@ -758,6 +766,10 @@ ice_tx_queue_start(struct rte_eth_dev *dev, uint16_t tx_queue_id)return -EINVAL ; } +if (dev->data->tx_queue_state[tx_queue_id] == +RTE_ETH_QUEUE_STATE_STARTED ) +return 0 ; + buf_len =ice_struct_size (txq_elem, txqs,1 ); txq_elem =ice_malloc (hw, buf_len);if (!txq_elem)
@@ -1066,6 +1078,10 @@ ice_tx_queue_stop(struct rte_eth_dev *dev, uint16_t tx_queue_id)return -EINVAL ; } +if (dev->data->tx_queue_state[tx_queue_id] == +RTE_ETH_QUEUE_STATE_STOPPED ) +return 0 ; + q_ids[0 ] = txq->reg_idx; q_teids[0 ] = txq->q_teid;
Signature · 1 line
2.31.1
Quoted 70 lines
-----Original Message-----
From: Zhang, Qi Z <[email protected]>
Sent: Friday, January 5, 2024 9:37 PM
To: Yang, Qiming <[email protected]>; Wu, Wenjun1 <[email protected]>
Cc: [email protected]; Zhang, Qi Z <[email protected]>
Subject: [PATCH] net/ice: refine queue start stopNot necessary to return fail when starting or stopping a queue if the queue was already at required state.
Signed-off-by Qi Zhang <[email protected]>--- drivers/net/ice/ice_rxtx.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)drivers/net/ice/ice_rxtx.c index renamed from drivers/net/ice/ice_rxtx.c +0
-0
73e47ae92d..3286bb08fe100644drivers/net/ice/ice_rxtx.c +4
-0@@ -673,6 +673,10 @@ ice_rx_queue_start(struct rte_eth_dev *dev, uint16_t rx_queue_id)return -EINVAL ; } +if (dev->data->rx_queue_state[rx_queue_id] == +RTE_ETH_QUEUE_STATE_STARTED ) +return 0 ; +if (dev->data->dev_conf.rxmode.offloads &RTE_ETH_RX_OFFLOAD_TIMESTAMP )drivers/net/ice/ice_rxtx.c +4
-0rxq->ts_enable = true; err =ice_program_hw_rx_queue (rxq);@@ -717,6 +721,10 @@ ice_rx_queue_stop(struct rte_eth_dev *dev, uint16_t rx_queue_id)if (rx_queue_id < dev->data->nb_rx_queues) { rxq = dev->data->rx_queues[rx_queue_id]; +if (dev->data->rx_queue_state[rx_queue_id] == +RTE_ETH_QUEUE_STATE_STOPPED ) +return 0 ; + err =ice_switch_rx_queue (hw, rxq->reg_idx, false);if (err) {PMD_DRV_LOG(ERR, "Failed to switch RX queue %u
off", @@ -758,6 +766,10 @@ice_tx_queue_start(struct rte_eth_dev *dev, uint16_t tx_queue_id)drivers/net/ice/ice_rxtx.c +8
-1return -EINVAL ; } +if (dev->data->tx_queue_state[tx_queue_id] == +RTE_ETH_QUEUE_STATE_STARTED ) +return 0 ; + buf_len =ice_struct_size (txq_elem, txqs,1 ); txq_elem =ice_malloc (hw, buf_len);if (!txq_elem)@@ -1066,6 +1078,10 @@ ice_tx_queue_stop(struct rte_eth_dev *dev, uint16_t tx_queue_id)return -EINVAL ; } +if (dev->data->tx_queue_state[tx_queue_id] == +RTE_ETH_QUEUE_STATE_STOPPED ) +return 0 ; + q_ids[0 ] = txq->reg_idx; q_teids[0 ] = txq->q_teid; --
Quoted 1 line
2.31.1
Zhang, Qi Z
AppliedQuoted 80 lines
-----Original Message-----
From: Wu, Wenjun1 <[email protected]>
Sent: Friday, January 5, 2024 2:03 PM
To: Zhang, Qi Z <[email protected]>; Yang, Qiming <[email protected]>
Cc: [email protected]
Subject: RE: [PATCH] net/ice: refine queue start stopQuoted 44 lines
-----Original Message-----
From: Zhang, Qi Z <[email protected]>
Sent: Friday, January 5, 2024 9:37 PM
To: Yang, Qiming <[email protected]>; Wu, Wenjun1 <[email protected]>
Cc: [email protected]; Zhang, Qi Z <[email protected]>
Subject: [PATCH] net/ice: refine queue start stopNot necessary to return fail when starting or stopping a queue if the queue was already at required state.
Signed-off-by Qi Zhang <[email protected]>--- drivers/net/ice/ice_rxtx.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)drivers/net/ice/ice_rxtx.c +4
-0@@ -673,6 +673,10 @@ ice_rx_queue_start(struct rte_eth_dev *dev, uint16_t rx_queue_id)return -EINVAL ; } +if (dev->data->rx_queue_state[rx_queue_id] == +RTE_ETH_QUEUE_STATE_STARTED ) +return 0 ; +if (dev->data->dev_conf.rxmode.offloads &RTE_ETH_RX_OFFLOAD_TIMESTAMP )drivers/net/ice/ice_rxtx.c +4
-0rxq->ts_enable = true; err =ice_program_hw_rx_queue (rxq);@@ -717,6 +721,10 @@ ice_rx_queue_stop(struct rte_eth_dev *dev, uint16_t rx_queue_id)if (rx_queue_id < dev->data->nb_rx_queues) { rxq = dev->data->rx_queues[rx_queue_id]; +if (dev->data->rx_queue_state[rx_queue_id] == +RTE_ETH_QUEUE_STATE_STOPPED ) +return 0 ; + err =ice_switch_rx_queue (hw, rxq->reg_idx, false);if (err) {Quoted 1 line
PMD_DRV_LOG(ERR, "Failed to switch RX queue %u
off", @@ -758,6
Quoted 24 lines
+766,10 @@
ice_tx_queue_start(struct rte_eth_dev *dev, uint16_t tx_queue_id)drivers/net/ice/ice_rxtx.c +8
-0return -EINVAL ; } +if (dev->data->tx_queue_state[tx_queue_id] == +RTE_ETH_QUEUE_STATE_STARTED ) +return 0 ; + buf_len =ice_struct_size (txq_elem, txqs,1 ); txq_elem =ice_malloc (hw, buf_len);if (!txq_elem)@@ -1066,6 +1078,10 @@ ice_tx_queue_stop(struct rte_eth_dev *dev, uint16_t tx_queue_id)return -EINVAL ; } +if (dev->data->tx_queue_state[tx_queue_id] == +RTE_ETH_QUEUE_STATE_STOPPED ) +return 0 ; + q_ids[0 ] = txq->reg_idx; q_teids[0 ] = txq->q_teid;
Quoted 4 lines
Quoted 2 lines
--
2.31.1Acked-by Wenjun Wu <[email protected]>
Applied to dpdk-next-net-intel.
Thanks
Qi