Skip to contentSkip to conversation

p7zip: fix CVE-2018-5996 & CVE-2016-9296

PATCH In review aszh07 3 participants 3 messages Jan 5, 2024 – Feb 6, 2024

lore
Share & tools
lore

aszh07

author
#0 lore raw

PATCH 1/1 p7zip: fix CVE-2018-5996 & CVE-2016-9296

From: Zahir Hussain <[email protected]>

References:
https://nvd.nist.gov/vuln/detail/CVE-2018-5996
https://nvd.nist.gov/vuln/detail/CVE-2016-9296

Upstream patches:
https://sources.debian.org/data/non-free/p/p7zip-rar/16.02-3/debian/patches/06-CVE-2018-5996.patch
https://snapshot.debian.org/archive/debian-debug/20180205T215659Z/pool/main/p/p7zip/p7zip_16.02%2Bdfsg-6.debian.tar.xz

---
 .../p7zip/files/CVE-2016-9296.patch           |  30 +++
 .../p7zip/files/CVE-2018-5996.patch           | 228 ++++++++++++++++++
 meta-oe/recipes-extended/p7zip/p7zip_16.02.bb |   2 +
 3 files changed, 260 insertions(+)
 create mode 100644 meta-oe/recipes-extended/p7zip/files/CVE-2016-9296.patch
 create mode 100644 meta-oe/recipes-extended/p7zip/files/CVE-2018-5996.patch
meta-oe/recipes-extended/p7zip/files/CVE-2016-9296.patch new file +30 -0
new file mode 100644
index 000000000..42ea716be
@@ -0,0 +1,30 @@
+From: Robert Luberda <[email protected]>
+Date: Sat, 19 Nov 2016 08:48:08 +0100
+Subject: Fix nullptr dereference (CVE-2016-9296)
+
+Patch taken from https://sourceforge.net/p/p7zip/bugs/185/
+
+CVE: CVE-2016-9296
+
+Upstream-Status: Backport [https://snapshot.debian.org/archive/debian-debug/20180205T215659Z/pool/main/p/p7zip/p7zip_16.02%2Bdfsg-6.debian.tar.xz]
+
+Signed-off-by: Zahir Hussain <[email protected]>
+Signed-off-by: aszh07 <[email protected]>
+---
+ CPP/7zip/Archive/7z/7zIn.cpp | 3 ++-
+ 1 file changed, 2 insertions(+), 1 deletion(-)
+
+diff --git a/CPP/7zip/Archive/7z/7zIn.cpp b/CPP/7zip/Archive/7z/7zIn.cpp
+index b0c6b98..7c6dde2 100644
+--- a/CPP/7zip/Archive/7z/7zIn.cpp
++++ b/CPP/7zip/Archive/7z/7zIn.cpp
+@@ -1097,7 +1097,8 @@ HRESULT CInArchive::ReadAndDecodePackedStreams(
+       if (CrcCalc(data, unpackSize) != folders.FolderCRCs.Vals[i])
+         ThrowIncorrect();
+   }
+-  HeadersSize += folders.PackPositions[folders.NumPackStreams];
++  if (folders.PackPositions)
++      HeadersSize += folders.PackPositions[folders.NumPackStreams];
+   return S_OK;
+ }
+ 
meta-oe/recipes-extended/p7zip/files/CVE-2018-5996.patch new file +228 -0

228 lines not on this page · raw message

meta-oe/recipes-extended/p7zip/p7zip_16.02.bb +2 -0
index 04923116c..e795482eb 100644
@@ -10,6 +10,8 @@ SRC_URI = "http://downloads.sourceforge.net/p7zip/p7zip/${PV}/p7zip_${PV}_src_al
            file://CVE-2017-17969.patch \
            file://0001-Fix-narrowing-errors-Wc-11-narrowing.patch \
            file://change_numMethods_from_bool_to_unsigned.patch \
+           file://CVE-2018-5996.patch \
+           file://CVE-2016-9296.patch \
            "
 
 SRC_URI[md5sum] = "a0128d661cfe7cc8c121e73519c54fbf"
Signature · 1 line
2.17.1
#1 lore raw

Hello,

Why this patch is not taken yet? Is there any issues with the patch?

Thanks,
Ranjitsinh

#2 lore raw
Quoted 3 lines · Ranjitsinh Rathod via lists.openembedded.org

Hello,

Why this patch is not taken yet? Is there any issues with the patch?

My filters where messed up for this branch.  I wiil process shortly

- armin

Quoted 12 lines

Thanks,
Ranjitsinh

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#108566): https://lists.openembedded.org/g/openembedded-devel/message/108566
Mute This Topic: https://lists.openembedded.org/mt/103548665/3616698
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-