Skip to contentSkip to conversation

mm-ratelimit-stat-flush-from-workingset-shrinker.patch removed from -mm tree

merged mm-stable Andrew Morton 1 participant 1 message Jan 5, 2024

lore
Share & tools
lore

Andrew Morton

author tree notice Applied
#0 lore raw

The quilt patch titled
Subject: mm: ratelimit stat flush from workingset shrinker
has been removed from the -mm tree. Its filename was
mm-ratelimit-stat-flush-from-workingset-shrinker.patch

This patch was dropped because it was merged into the mm-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

------------------------------------------------------
From: Shakeel Butt <[email protected]>
Subject: mm: ratelimit stat flush from workingset shrinker
Date: Thu, 28 Dec 2023 07:30:55 +0000

One of our workloads (Postgres 14 + sysbench OLTP) regressed on newer upstream kernel and on further investigation, it seems like the cause is the always synchronous rstat flush in the count_shadow_nodes() added by the commit f82e6bf9bb9b ("mm: memcg: use rstat for non-hierarchical stats"). On further inspection it seems like we don't really need accurate stats in this function as it was already approximating the amount of appropriate shadow entries to keep for maintaining the refault information. Since there is already 2 sec periodic rstat flush, we don't need exact stats here. Let's ratelimit the rstat flush in this code path.

Fixes f82e6bf9bb9b ("mm: memcg: use rstat for non-hierarchical stats")
Cc Johannes Weiner <[email protected]>
Cc Yosry Ahmed <[email protected]>
Cc Yu Zhao <[email protected]>
Cc Michal Hocko <[email protected]>
Cc Roman Gushchin <[email protected]>
Cc Muchun Song <[email protected]>

---

 mm/workingset.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
mm/workingset.c renamed from mm/workingset.c~mm-ratelimit-stat-flush-from-workingset-shrinker +1 -1
@@ -680,7 +680,7 @@ static unsigned long count_shadow_nodes(
 		struct lruvec *lruvec;
 		int i;
 
-		mem_cgroup_flush_stats(sc->memcg);
+		mem_cgroup_flush_stats_ratelimited(sc->memcg);
 		lruvec = mem_cgroup_lruvec(sc->memcg, NODE_DATA(sc->nid));
 		for (pages = 0, i = 0; i < NR_LRU_LISTS; i++)
 			pages += lruvec_page_state_local(lruvec,

_

Patches currently in -mm which might be from [email protected] are