Skip to contentSkip to conversation

4.14.335-rc2 review

PATCH In review Greg Kroah-Hartman 3 participants 4 messages Jan 6, 2024 – Jan 7, 2024 Stable branch

lore
Share & tools
lore

Greg Kroah-Hartman

author maintainer
#0 lore raw

cover 4.14.335-rc2 review

This is the start of the stable review cycle for the 4.14.335 release. There are 20 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.

Responses should be made by Mon, 08 Jan 2024 08:40:01 +0000. Anything received after that time might be too late.

The whole patch series can be found in one patch at:

	https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.14.335-rc2.gz

or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.14.y
and the diffstat can be found below.

thanks,

greg k-h

-------------
Pseudo-Shortlog of commits:

Greg Kroah-Hartman <[email protected]>

    Linux 4.14.335-rc2

Sarthak Kukreti <[email protected]>
block: Don't invalidate pagecache for invalid falloc modes

Mikulas Patocka <[email protected]>
dm-integrity: don't modify bio's immutable bio_vec in integrity_metadata()

Rouven Czerwinski <[email protected]>
net: rfkill: gpio: set GPIO direction

Fedor Pchelkin <[email protected]>
net: 9p: avoid freeing uninit memory in p9pdu_vreadf

Luiz Augusto von Dentz <[email protected]>
Bluetooth: hci_event: Fix not checking if HCI_OP_INQUIRY has been sent

Reinhard Speyerer <[email protected]>
USB: serial: option: add Quectel RM500Q R13 firmware support

Slark Xiao <[email protected]>
USB: serial: option: add Foxconn T99W265 with new baseline

Alper Ak <[email protected]>
USB: serial: option: add Quectel EG912Y module support

Mark Glover <[email protected]>
USB: serial: ftdi_sio: update Actisense PIDs constant names

Johannes Berg <[email protected]>
wifi: cfg80211: fix certs build to not depend on file order

Chen-Yu Tsai <[email protected]>
wifi: cfg80211: Add my certificate

Javier Carrasco <[email protected]>
iio: common: ms_sensors: ms_sensors_i2c: fix humidity conversion time table

Haoran Liu <[email protected]>
Input: ipaq-micro-keys - add error handling for devm_kmemdup

Su Hui <[email protected]>
iio: imu: inv_mpu6050: fix an error code problem in inv_mpu6050_read_raw

Liu Jian <[email protected]>
net: check vlan filter feature in vlan_vids_add_by_dev() and vlan_vids_del_by_dev()

Zhipeng Lu <[email protected]>
ethernet: atheros: fix a memleak in atl1e_setup_ring_resources

Eric Dumazet <[email protected]>
net: sched: ife: fix potential use-after-free

Johannes Berg <[email protected]>
wifi: mac80211: mesh_plink: fix matches_local logic

Heiko Carstens <[email protected]>
s390/vx: fix save/restore of fpu kernel context

Kunwu Chan <[email protected]>
ARM: OMAP2+: Fix null pointer dereference and memory leak in omap_soc_device_init

-------------

Diffstat:

 Makefile                                        |  4 +-
 arch/arm/mach-omap2/id.c                        |  5 ++
 arch/s390/include/asm/fpu/api.h                 |  2 +-
 drivers/iio/common/ms_sensors/ms_sensors_i2c.c  |  4 +-
 drivers/iio/imu/inv_mpu6050/inv_mpu_core.c      |  4 +-
 drivers/input/keyboard/ipaq-micro-keys.c        |  3 +
 drivers/md/dm-integrity.c                       | 11 ++--
 drivers/net/ethernet/atheros/atl1e/atl1e_main.c |  5 +-
 drivers/usb/serial/ftdi_sio.c                   |  6 +-
 drivers/usb/serial/ftdi_sio_ids.h               |  6 +-
 drivers/usb/serial/option.c                     |  5 ++
 fs/block_dev.c                                  |  9 ++-
 net/8021q/vlan_core.c                           |  9 ++-
 net/9p/protocol.c                               | 17 +++--
 net/bluetooth/hci_event.c                       |  3 +-
 net/ife/ife.c                                   |  1 +
 net/mac80211/mesh_plink.c                       | 10 +--
 net/rfkill/rfkill-gpio.c                        |  8 +++
 net/wireless/certs/wens.hex                     | 87 +++++++++++++++++++++++++
 19 files changed, 167 insertions(+), 32 deletions(-)
#1 lore raw
Quoted 10 lines · Greg Kroah-Hartman

This is the start of the stable review cycle for the 4.14.335 release. There are 20 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.

Responses should be made by Mon, 08 Jan 2024 08:40:01 +0000. Anything received after that time might be too late.

The whole patch series can be found in one patch at:

Quoted 8 lines
        https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.14.335-rc2.gz

or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.14.y
and the diffstat can be found below.

thanks,

greg k-h

As Daniel reported on RC1 about this failure.
Following build failures noticed on 4.14.335-rc2

Arm64 with Clang 17:

-----8<-----
/builds/linux/net/8021q/vlan_core.c:332:39: error: incompatible
integer to pointer conversion passing '__be16' (aka 'unsigned short') to parameter of type 'const struct vlan_vi
d_info *' [-Wint-conversion]

     332 |                 if (!vlan_hw_filter_capable(by_dev, vid_info->proto))
         |                                                     ^~~~~~~~~~~~~~~

/builds/linux/net/8021q/vlan_core.c:169:38: note: passing argument
to parameter 'vid_info' here
169 | const struct
vlan_vid_info *vid_info)
| ^
/builds/linux/net/8021q/vlan_core.c:344:39: error: incompatible
integer to pointer conversion passing '__be16' (aka 'unsigned short') to parameter of type 'const struct vlan_vi
d_info *' [-Wint-conversion]

     344 |                 if (!vlan_hw_filter_capable(by_dev, vid_info->proto))
         |                                                     ^~~~~~~~~~~~~~~

/builds/linux/net/8021q/vlan_core.c:169:38: note: passing argument
to parameter 'vid_info' here
169 | const struct
vlan_vid_info *vid_info)
| ^
/builds/linux/net/8021q/vlan_core.c:366:39: error: incompatible
integer to pointer conversion passing '__be16' (aka 'unsigned short') to parameter of type 'const struct vlan_vid_info *' [-Wint-conversion]

     366 |                 if (!vlan_hw_filter_capable(by_dev, vid_info->proto))
         |                                                     ^~~~~~~~~~~~~~~

/builds/linux/net/8021q/vlan_core.c:169:38: note: passing argument
to parameter 'vid_info' here
169 | const struct
vlan_vid_info *vid_info)
| ^
3 errors generated.
make[3]: *** [/builds/linux/scripts/Makefile.build:329:
net/8021q/vlan_core.o] Error 1
----->8-----

Bisection in this case points to:

commit f33474044777425b3578d4e8b22a003f034ae214
Author: Liu Jian <[email protected]>
Date: Sat Dec 16 15:52:18 2023 +0800

net: check vlan filter feature in vlan_vids_add_by_dev() and
vlan_vids_del_by_dev()

       [ Upstream commit 01a564bab4876007ce35f312e16797dfe40e4823 ]

Reproducer:

tuxmake --runtime podman --target-arch arm64 --toolchain clang-17
--kconfig defconfig LD=ld.lld LLVM_IAS=0

Greetings!

Daniel Díaz
[email protected]

- Naresh

author maintainer
#2 lore raw
Quoted 73 lines · Naresh Kamboju
Quoted 10 lines · Greg Kroah-Hartman

This is the start of the stable review cycle for the 4.14.335 release. There are 20 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.

Responses should be made by Mon, 08 Jan 2024 08:40:01 +0000. Anything received after that time might be too late.

The whole patch series can be found in one patch at:

Quoted 8 lines
        https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.14.335-rc2.gz

or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.14.y
and the diffstat can be found below.

thanks,

greg k-h

As Daniel reported on RC1 about this failure.
Following build failures noticed on 4.14.335-rc2

Arm64 with Clang 17:

-----8<-----
/builds/linux/net/8021q/vlan_core.c:332:39: error: incompatible
integer to pointer conversion passing '__be16' (aka 'unsigned short') to parameter of type 'const struct vlan_vi
d_info *' [-Wint-conversion]

     332 |                 if (!vlan_hw_filter_capable(by_dev, vid_info->proto))
         |                                                     ^~~~~~~~~~~~~~~

/builds/linux/net/8021q/vlan_core.c:169:38: note: passing argument
to parameter 'vid_info' here
169 | const struct
vlan_vid_info *vid_info)
| ^
/builds/linux/net/8021q/vlan_core.c:344:39: error: incompatible
integer to pointer conversion passing '__be16' (aka 'unsigned short') to parameter of type 'const struct vlan_vi
d_info *' [-Wint-conversion]

     344 |                 if (!vlan_hw_filter_capable(by_dev, vid_info->proto))
         |                                                     ^~~~~~~~~~~~~~~

/builds/linux/net/8021q/vlan_core.c:169:38: note: passing argument
to parameter 'vid_info' here
169 | const struct
vlan_vid_info *vid_info)
| ^
/builds/linux/net/8021q/vlan_core.c:366:39: error: incompatible
integer to pointer conversion passing '__be16' (aka 'unsigned short') to parameter of type 'const struct vlan_vid_info *' [-Wint-conversion]

     366 |                 if (!vlan_hw_filter_capable(by_dev, vid_info->proto))
         |                                                     ^~~~~~~~~~~~~~~

/builds/linux/net/8021q/vlan_core.c:169:38: note: passing argument
to parameter 'vid_info' here
169 | const struct
vlan_vid_info *vid_info)
| ^
3 errors generated.
make[3]: *** [/builds/linux/scripts/Makefile.build:329:
net/8021q/vlan_core.o] Error 1
----->8-----

Bisection in this case points to:

commit f33474044777425b3578d4e8b22a003f034ae214
Author: Liu Jian <[email protected]>
Date: Sat Dec 16 15:52:18 2023 +0800

net: check vlan filter feature in vlan_vids_add_by_dev() and
vlan_vids_del_by_dev()

Quoted 8 lines
       [ Upstream commit 01a564bab4876007ce35f312e16797dfe40e4823 ]

Reproducer:

   tuxmake --runtime podman --target-arch arm64 --toolchain clang-17

--kconfig defconfig LD=ld.lld LLVM_IAS=0

Oops, sorry about that, I missed it, I'll go drop this one now, thanks.

greg k-h

Tested-by on the v1 series
#3 lore raw
In reply to Greg Kroah-Hartman

Hi!

Quoted 4 lines

This is the start of the stable review cycle for the 4.14.335 release. There are 20 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.

CIP testing did not find any problems here:

https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-4.14.y

Best regards,
Pavel

Signature · 2 lines
DENX Software Engineering GmbH,        Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany