PCI: xilinx-xdma: Fix uninitialized symbols in xilinx_pl_dma_pcie_setup_irq()
Krzysztof Wilczyński
maintainerPATCH 1/1 PCI: xilinx-xdma: Fix uninitialized symbols in xilinx_pl_dma_pcie_setup_irq()
The error paths that follow calls to the devm_request_irq() functions within the xilinx_pl_dma_pcie_setup_irq() reference an uninitialized symbol each that also so happens to be incorrect.
Thus, fix this omission and reference the correct variable when invoking a given dev_err() function following an error.
This problem was found using smatch via the 0-DAY CI Kernel Test service:
drivers/pci/controller/pcie-xilinx-dma-pl.c:638 xilinx_pl_dma_pcie_setup_irq() error: uninitialized symbol 'irq'. drivers/pci/controller/pcie-xilinx-dma-pl.c:645 xilinx_pl_dma_pcie_setup_irq() error: uninitialized symbol 'irq'.
--- drivers/pci/controller/pcie-xilinx-dma-pl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/pci/controller/pcie-xilinx-dma-pl.c +2 -2
@@ -635,14 +635,14 @@ static int xilinx_pl_dma_pcie_setup_irq(struct pl_dma_pcie *port) err =devm_request_irq (dev, port->intx_irq, xilinx_pl_dma_pcie_intx_flow,IRQF_SHARED |IRQF_NO_THREAD ,NULL , port);if (err) { -dev_err (dev,"Failed to request INTx IRQ %d\n" , irq); +dev_err (dev,"Failed to request INTx IRQ %d\n" , port->intx_irq);return err; } err =devm_request_irq (dev, port->irq, xilinx_pl_dma_pcie_event_flow,IRQF_SHARED |IRQF_NO_THREAD ,NULL , port);if (err) { -dev_err (dev,"Failed to request event IRQ %d\n" , irq); +dev_err (dev,"Failed to request event IRQ %d\n" , port->irq);return err; }
Signature · 1 line
2.43.0
Krzysztof Wilczyński
maintainerHello,
Quoted 11 lines
The error paths that follow calls to the
devm_request_irq()functions within thexilinx_pl_dma_pcie_setup_irq()reference an uninitialized symbol each that also so happens to be incorrect.Thus, fix this omission and reference the correct variable when invoking a given
dev_err()function following an error.This problem was found using smatch via the 0-DAY CI Kernel Test service:
drivers/pci/controller/pcie-xilinx-dma-pl.c:638xilinx_pl_dma_pcie_setup_irq()error: uninitialized symbol 'irq'.drivers/pci/controller/pcie-xilinx-dma-pl.c:645xilinx_pl_dma_pcie_setup_irq()error: uninitialized symbol 'irq'.
We need to get this fixed, so I applied this change to controller/xilinx, as I would like to ensure that it will be included with the rest of the changes for the 6.8 release
[1/1] PCI: xilinx-xdma: Fix uninitialized symbols in xilinx_pl_dma_pcie_setup_irq()
https://git.kernel.org/pci/pci/c/7aa5f8fcd6d9 Krzysztof