Skip to contentSkip to conversation

binder: remove redundant variable page_addr

PATCH In review Colin Ian King 2 participants 2 messages Jan 6, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 binder: remove redundant variable page_addr

From: Colin Ian King <[email protected]>

Variable page_addr is being assigned a value that is never read. The variable is redundant and can be removed.

Cleans up clang scan build warning:
warning: Value stored to 'page_addr' is never read [deadcode.DeadStores]

---
 drivers/android/binder_alloc.c | 2 --
 1 file changed, 2 deletions(-)
drivers/android/binder_alloc.c +0 -2
index ea5e1ba2d0d7..ed4ca6689c75 100644
@@ -925,7 +925,6 @@ void binder_alloc_deferred_release(struct binder_alloc *alloc)
 		int i;
 
 		for (i = 0; i < alloc->buffer_size / PAGE_SIZE; i++) {
-			unsigned long page_addr;
 			bool on_lru;
 
 			if (!alloc->pages[i].page_ptr)
@@ -933,7 +932,6 @@ void binder_alloc_deferred_release(struct binder_alloc *alloc)
 
 			on_lru = list_lru_del_obj(&binder_freelist,
 					      &alloc->pages[i].lru);
-			page_addr = alloc->buffer + i * PAGE_SIZE;
 			binder_alloc_debug(BINDER_DEBUG_BUFFER_ALLOC,
 				     "%s: %d: page %d %s\n",
 				     __func__, alloc->pid, i,
Signature · 1 line
2.43.0
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 36 lines · Colin Ian King

From: Colin Ian King <[email protected]>

Variable page_addr is being assigned a value that is never read. The variable is redundant and can be removed.

Cleans up clang scan build warning:
warning: Value stored to 'page_addr' is never read [deadcode.DeadStores]

---
 drivers/android/binder_alloc.c | 2 --
 1 file changed, 2 deletions(-)
drivers/android/binder_alloc.c +0 -2
index ea5e1ba2d0d7..ed4ca6689c75 100644
@@ -925,7 +925,6 @@ void binder_alloc_deferred_release(struct binder_alloc *alloc)
 		int i;
 
 		for (i = 0; i < alloc->buffer_size / PAGE_SIZE; i++) {
-			unsigned long page_addr;
 			bool on_lru;
 
 			if (!alloc->pages[i].page_ptr)
@@ -933,7 +932,6 @@ void binder_alloc_deferred_release(struct binder_alloc *alloc)
 
 			on_lru = list_lru_del_obj(&binder_freelist,
 					      &alloc->pages[i].lru);
-			page_addr = alloc->buffer + i * PAGE_SIZE;
 			binder_alloc_debug(BINDER_DEBUG_BUFFER_ALLOC,
 				     "%s: %d: page %d %s\n",
 				     __func__, alloc->pid, i,
Signature · 1 line
2.43.0

Thanks Colin. I was waiting for this warning to hit mainline so that I could add the following tags to the fix:

Fixes 162c79731448 ("binder: avoid user addresses in debug logs")

Feel free to take them for a v2 if you'd like. Either way,

--
Carlos Llamas