block: Treat sequential write preferred zone type as invalid
Subsystems (2)
Damien Le Moal
maintainerPATCH 1/1 block: Treat sequential write preferred zone type as invalid
With the removal of the support for host-aware zoned devices, blk_revalidate_zone_cb() should never see the zone type BLK_ZONE_TYPE_SEQWRITE_PREF (sequential write preffered zones). Treat this zone type as being invalid.
--- block/blk-zoned.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
block/blk-zoned.c +1 -1
@@ -498,7 +498,6 @@ static int blk_revalidate_zone_cb(struct blk_zone *zone, unsigned int idx,set_bit (idx, args->conv_zones_bitmap);break ;case BLK_ZONE_TYPE_SEQWRITE_REQ : -case BLK_ZONE_TYPE_SEQWRITE_PREF :if (!args->seq_zones_wlock) { args->seq_zones_wlock =blk_alloc_zone_bitmap (q->node, args->nr_zones);
@@ -506,6 +505,7 @@ static int blk_revalidate_zone_cb(struct blk_zone *zone, unsigned int idx,return -ENOMEM ; }break ; +case BLK_ZONE_TYPE_SEQWRITE_PREF :default :pr_warn ("%s: Invalid zone type 0x%x at sectors %llu\n" , disk->disk_name, (int )zone->type, zone->start);
Signature · 1 line
2.43.0
Quoted 4 lines · Damien Le Moal
With the removal of the support for host-aware zoned devices,
blk_revalidate_zone_cb()should never see the zone typeBLK_ZONE_TYPE_SEQWRITE_PREF(sequential write preffered zones). Treat this zone type as being invalid.
Looks good:
Quoted 6 lines · Damien Le Moal
With the removal of the support for host-aware zoned devices,
blk_revalidate_zone_cb()should never see the zone typeBLK_ZONE_TYPE_SEQWRITE_PREF(sequential write preffered zones). Treat this zone type as being invalid.
Applied, thanks!
[1/1] block: Treat sequential write preferred zone type as invalid
commit: 587371ed783b046f22ba7a5e1cc9a19ae35123b4
Best regards,
Signature · 1 line
Jens Axboe