Skip to contentSkip to conversation

ACPI: resource: Skip IRQ override on ASUS ExpertBook B1502CGA

PATCH Applied Michael Maltsev 2 participants 2 messages Jan 7, 2024 – Jan 9, 2024 ACPI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ACPI: resource: Skip IRQ override on ASUS ExpertBook B1502CGA

Like the ASUS ExpertBook B1502CBA and various ASUS laptops, the ASUS ExpertBook B1502CGA has an ACPI DSDT table that describes IRQ 1 as ActiveLow while the kernel overrides it to Edge_High.

	$ sudo dmesg | grep DMI
	[    0.000000] DMI: ASUSTeK COMPUTER INC. ASUS EXPERTBOOK B1502CGA_B1502CGA/B1502CGA, BIOS B1502CGA.303 06/05/2023
	$ grep -A 40 PS2K dsdt.dsl | grep IRQ -A 1
	                IRQ (Level, ActiveLow, Exclusive, )
	                    {1}

This prevents the keyboard from working. To fix this issue, add this laptop to the skip_override_table so that the kernel does not override IRQ 1.

---
 drivers/acpi/resource.c | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/acpi/resource.c +7 -0
index c297e40c5bdc..b0c3da70f809 100644
@@ -453,6 +453,13 @@ static const struct dmi_system_id asus_laptop[] = {
 			DMI_MATCH(DMI_BOARD_NAME, "B1402CVA"),
 		},
 	},
+	{
+		.ident = "Asus ExpertBook B1502CGA",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+			DMI_MATCH(DMI_BOARD_NAME, "B1502CGA"),
+		},
+	},
 	{
 		.ident = "Asus ExpertBook B2402CBA",
 		.matches = {
Signature · 1 line
2.39.2
maintainer Applied
#1 lore raw
Quoted 28 lines · Michael Maltsev

Like the ASUS ExpertBook B1502CBA and various ASUS laptops, the ASUS ExpertBook B1502CGA has an ACPI DSDT table that describes IRQ 1 as ActiveLow while the kernel overrides it to Edge_High.

        $ sudo dmesg | grep DMI
        [    0.000000] DMI: ASUSTeK COMPUTER INC. ASUS EXPERTBOOK B1502CGA_B1502CGA/B1502CGA, BIOS B1502CGA.303 06/05/2023
        $ grep -A 40 PS2K dsdt.dsl | grep IRQ -A 1
                        IRQ (Level, ActiveLow, Exclusive, )
                            {1}

This prevents the keyboard from working. To fix this issue, add this laptop to the skip_override_table so that the kernel does not override IRQ 1.

---
 drivers/acpi/resource.c | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/acpi/resource.c +1 -0
index c297e40c5bdc..b0c3da70f809 100644
@@ -453,6 +453,13 @@ static const struct dmi_system_id asus_laptop[] = {
                        DMI_MATCH(DMI_BOARD_NAME, "B1402CVA"),
                },
        },
+       {

drivers/acpi/resource.c static const struct dmi_system_id asus_laptop[] = {

Quoted 10 lines
drivers/acpi/resource.c +6 -1
+               .ident = "Asus ExpertBook B1502CGA",
+               .matches = {
+                       DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+                       DMI_MATCH(DMI_BOARD_NAME, "B1502CGA"),
+               },
+       },
        {
                .ident = "Asus ExpertBook B2402CBA",
                .matches = {
--

Applied as 6.8-rc1 material, but I've replaced the unnecessary .ident field with a comment.

Thanks!