appendix/toyrcu: Trivial fixups
cover appendix/toyrcu: Trivial fixups
This patchset contains trivial fixups for appendix/toyrcu/, which found while doing Korean translation[1].
[1] https://github.com/sjp38/perfbook-ko_KR
SeongJae Park (3):
appendix/toyrcu: Add missing parentheses appendix/toyrcu: Use \co{} for spin tool appendix/toyrcu: Add missing parentheses for rcu_quiescent_state()
appendix/toyrcu/toyrcu.tex | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
Signature · 1 line
2.17.1
PATCH 1/3 appendix/toyrcu: Add missing parentheses
A sentence on toyrcu.tex is missing enclosing code with parentheses, unlike other parts on the sentence. Add the parentheses to be consistent.
--- appendix/toyrcu/toyrcu.tex | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
appendix/toyrcu/toyrcu.tex +1 -1
@@ -391,7 +391,7 @@ shows the read-side primitives of an RCU implementation that uses a pair of reference counters (\co{rcu_refcnt[]}), along with a global index that selects one counter out of the pair (\co{rcu_idx}), -a per-thread nesting counter \co{rcu_nesting}, +a per-thread nesting counter (\co{rcu_nesting}), a per-thread snapshot of the global index (\co{rcu_read_idx}), and a global lock (\co{rcu_gp_lock}), which are themselves shown in
Signature · 1 line
2.17.1
PATCH 2/3 appendix/toyrcu: Use \co{} for spin tool
In reply to SeongJae Parkformalregress.tex is using \co{} for spin tool, especially when mentionging it together with Promela. A sentence in toyrcu.tex is not using \co{} for same representation. Use \co{} for consistency.
--- appendix/toyrcu/toyrcu.tex | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
appendix/toyrcu/toyrcu.tex +1 -1
@@ -535,7 +535,7 @@ checking of \co{rcu_refcnt}. data element. Exercise for the reader: - Use a tool such as Promela/spin to determine which (if any) of + Use a tool such as Promela/\co{spin} to determine which (if any) of the memory barriers in \cref{lst:app:toyrcu:RCU Update Using Global Reference-Count Pair} are really needed.
Signature · 1 line
2.17.1
PATCH 3/3 appendix/toyrcu: Add missing parentheses for rcu_quiescent_state()
In reply to SeongJae ParkSome sentences on toyrcu.tex is missing parentheses for rcu_quiescent_state(). Add those.
--- appendix/toyrcu/toyrcu.tex | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
appendix/toyrcu/toyrcu.tex +3 -3
@@ -1447,13 +1447,13 @@ re-ordered with the \clnrefrange{gp1}{gp2}. \begin{fcvref}[ln:defer:rcu_qs:read_lock_unlock:qs] Doesn't the additional memory barrier shown on \clnref{mb2} of \cref{lst:app:toyrcu:Quiescent-State-Based RCU Read Side} - greatly increase the overhead of \co{rcu_quiescent_state}? + greatly increase the overhead of \co{rcu_quiescent_state()}? \end{fcvref} }\QuickQuizAnswer{ \begin{fcvref}[ln:defer:rcu_qs:read_lock_unlock:qs] Indeed it does! An application using this implementation of RCU should therefore - invoke \co{rcu_quiescent_state} sparingly, instead using + invoke \co{rcu_quiescent_state()} sparingly, instead using \co{rcu_read_lock()} and \co{rcu_read_unlock()} most of the time.
@@ -1574,7 +1574,7 @@ certain types of library functions. effect extended beyond the enclosing \co{rcu_read_lock()} and \co{rcu_read_unlock()}, out to the previous and next call to \co{rcu_quiescent_state()}. - This \co{rcu_quiescent_state} can be thought of as an + This \co{rcu_quiescent_state()} can be thought of as an \co{rcu_read_unlock()} immediately followed by an \co{rcu_read_lock()}.
Signature · 1 line
2.17.1
Paul E. McKenney
AppliedQuoted 9 lines · SeongJae Park
This patchset contains trivial fixups for appendix/toyrcu/, which found while doing Korean translation[1].
[1] https://github.com/sjp38/perfbook-ko_KR
SeongJae Park (3):
appendix/toyrcu: Add missing parentheses appendix/toyrcu: Use \co{} for spin tool appendix/toyrcu: Add missing parentheses forrcu_quiescent_state()
Queued and pushed, thank you!
Thanx, Paul
Quoted 6 lines
appendix/toyrcu/toyrcu.tex | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)Signature · 1 line
2.17.1