Skip to contentSkip to conversation

arm: dts: Add Itap Delay Value For High Speed DDR

PATCH In review Bhavya Kapoor 3 participants 7 messages Jan 8, 2024 – Jan 19, 2024 Arm (32-bit)

lore
Share & tools
lore
#0 lore raw

cover arm: dts: Add Itap Delay Value For High Speed DDR

This Series adds Itap Delay Value for DDR52 speed mode for eMMC in J7200 SoC and for DDR50 speed mode for MMCSD in J721s2 SoC.

Bhavya Kapoor (2):
arm: dts: k3-j7200-main: Add Itap Delay Value For DDR52 speed mode
arm: dts: k3-j721s2-main: Add Itap Delay Value For DDR50 speed mode

 arch/arm/dts/k3-j7200-main.dtsi  | 1 +
 arch/arm/dts/k3-j721s2-main.dtsi | 1 +
 2 files changed, 2 insertions(+)
Signature · 1 line
2.40.1
#1 lore raw

PATCH 1/2 arm: dts: k3-j7200-main: Add Itap Delay Value For DDR52 speed mode

DDR52 speed mode is enabled for eMMC in J7200 but its Itap Delay Value is not present in the device tree. Thus, add Itap Delay Value for eMMC High Speed DDR which is DDR52 speed mode for J7200 SoC according to datasheet for J7200 [1].

[1] Refer to : section 7.9.5.16.1 MMCSD0 - eMMC Interface, in

	J7200 datasheet

- https://www.ti.com/lit/ds/symlink/dra821u-q1.pdf

---
 arch/arm/dts/k3-j7200-main.dtsi | 1 +
 1 file changed, 1 insertion(+)
arch/arm/dts/k3-j7200-main.dtsi +1 -0
index cdb1d6b2a9..18531ba803 100644
@@ -647,6 +647,7 @@
 		ti,otap-del-sel-hs400 = <0x5>;
 		ti,itap-del-sel-legacy = <0x10>;
 		ti,itap-del-sel-mmc-hs = <0xa>;
+		ti,itap-del-sel-ddr52 = <0x3>;
 		ti,strobe-sel = <0x77>;
 		ti,clkbuf-sel = <0x7>;
 		ti,trm-icp = <0x8>;
Signature · 1 line
2.40.1
#2 lore raw

PATCH 2/2 arm: dts: k3-j721s2-main: Add Itap Delay Value For DDR50 speed mode

In reply to Bhavya Kapoor

DDR50 speed mode is enabled for MMCSD in J721s2 but its Itap Delay Value is not present in the device tree. Thus, add Itap Delay Value for MMCSD Ultra High Speed DDR which is DDR50 speed mode for J721s2 SoC according to datasheet for J721s2 [1].

[1] Refer to : section 7.10.5.17.2 MMC1/2 - SD/SDIO Interface, in J721s2 datasheet
- https://www.ti.com/lit/ds/symlink/tda4vl-q1.pdf

---
 arch/arm/dts/k3-j721s2-main.dtsi | 1 +
 1 file changed, 1 insertion(+)
arch/arm/dts/k3-j721s2-main.dtsi +1 -0
index 084f8f5b66..8a86f6ce8e 100644
@@ -766,6 +766,7 @@
 		ti,itap-del-sel-sd-hs = <0x0>;
 		ti,itap-del-sel-sdr12 = <0x0>;
 		ti,itap-del-sel-sdr25 = <0x0>;
+		ti,itap-del-sel-ddr50 = <0x2>;
 		ti,clkbuf-sel = <0x7>;
 		ti,trm-icp = <0x8>;
 		dma-coherent;
Signature · 1 line
2.40.1
#3 lore raw
In reply to Bhavya Kapoor

Hi Bhavya!

On January 8, 2024 thus sayeth Bhavya Kapoor:

Quoted 9 lines

This Series adds Itap Delay Value for DDR52 speed mode for eMMC in J7200 SoC and for DDR50 speed mode for MMCSD in J721s2 SoC.

Bhavya Kapoor (2):
arm: dts: k3-j7200-main: Add Itap Delay Value For DDR52 speed mode
arm: dts: k3-j721s2-main: Add Itap Delay Value For DDR50 speed mode

 arch/arm/dts/k3-j7200-main.dtsi  | 1 +
 arch/arm/dts/k3-j721s2-main.dtsi | 1 +

Because of the periodic syncs with the kernel, modifying these dt files in U-Boot will cause confusion. (Which node is correct why did we have to do this in U-Boot and not in the Kernel... bla bla bla) If they absolutely need to go in now please override these nodes in the *-u-boot.dtsi files with a comment so we can keep track of these changes during the next sync with Linux.

~Bryan

#4 lore raw
Quoted 12 lines · Bryan Brattlof

Hi Bhavya!

On January 8, 2024 thus sayeth Bhavya Kapoor:

Quoted 9 lines

This Series adds Itap Delay Value for DDR52 speed mode for eMMC in J7200 SoC and for DDR50 speed mode for MMCSD in J721s2 SoC.

Bhavya Kapoor (2):
arm: dts: k3-j7200-main: Add Itap Delay Value For DDR52 speed mode
arm: dts: k3-j721s2-main: Add Itap Delay Value For DDR50 speed mode

  arch/arm/dts/k3-j7200-main.dtsi  | 1 +
  arch/arm/dts/k3-j721s2-main.dtsi | 1 +
Quoted 8 lines

Because of the periodic syncs with the kernel, modifying these dt files in U-Boot will cause confusion. (Which node is correct why did we have to do this in U-Boot and not in the Kernel... bla bla bla) If they absolutely need to go in now please override these nodes in the *-u-boot.dtsi files with a comment so we can keep track of these changes during the next sync with Linux.

~Bryan

Hi Bryan, Fyi, This patch went in kernel as well.

Can be tracked below-

https://lore.kernel.org/all/[email protected]/

So , kernel and uboot dt files will remain in sync.

~B-Kapoor

#5 lore raw

On January 10, 2024 thus sayeth Bhavya Kapoor:

Quoted 23 lines · Bryan Brattlof
Quoted 12 lines

Hi Bhavya!

On January 8, 2024 thus sayeth Bhavya Kapoor:

Quoted 9 lines

This Series adds Itap Delay Value for DDR52 speed mode for eMMC in J7200 SoC and for DDR50 speed mode for MMCSD in J721s2 SoC.

Bhavya Kapoor (2):
arm: dts: k3-j7200-main: Add Itap Delay Value For DDR52 speed mode
arm: dts: k3-j721s2-main: Add Itap Delay Value For DDR50 speed mode

  arch/arm/dts/k3-j7200-main.dtsi  | 1 +
  arch/arm/dts/k3-j721s2-main.dtsi | 1 +
Quoted 8 lines

Because of the periodic syncs with the kernel, modifying these dt files in U-Boot will cause confusion. (Which node is correct why did we have to do this in U-Boot and not in the Kernel... bla bla bla) If they absolutely need to go in now please override these nodes in the *-u-boot.dtsi files with a comment so we can keep track of these changes during the next sync with Linux.

~Bryan

Quoted 8 lines

Hi Bryan, Fyi, This patch went in kernel as well.

Can be tracked below-

https://lore.kernel.org/all/[email protected]/

So , kernel and uboot dt files will remain in sync.

Sorry I may be missing something. Why do we need these properties in U-Boot now? Why not wait 2 weeks for the v6.8-rc1 tag in Linux and sync everything all at once?

~Bryan

#6 lore raw
Quoted 28 lines · Bryan Brattlof

On January 10, 2024 thus sayeth Bhavya Kapoor:

Quoted 27 lines · Bryan Brattlof
Quoted 12 lines

Hi Bhavya!

On January 8, 2024 thus sayeth Bhavya Kapoor:

Quoted 9 lines

This Series adds Itap Delay Value for DDR52 speed mode for eMMC in J7200 SoC and for DDR50 speed mode for MMCSD in J721s2 SoC.

Bhavya Kapoor (2):
arm: dts: k3-j7200-main: Add Itap Delay Value For DDR52 speed mode
arm: dts: k3-j721s2-main: Add Itap Delay Value For DDR50 speed mode

  arch/arm/dts/k3-j7200-main.dtsi  | 1 +
  arch/arm/dts/k3-j721s2-main.dtsi | 1 +
Quoted 8 lines

Because of the periodic syncs with the kernel, modifying these dt files in U-Boot will cause confusion. (Which node is correct why did we have to do this in U-Boot and not in the Kernel... bla bla bla) If they absolutely need to go in now please override these nodes in the *-u-boot.dtsi files with a comment so we can keep track of these changes during the next sync with Linux.

~Bryan

Hi Bryan, Fyi, This patch went in kernel as well.

Can be tracked below-

Quoted 8 lines
Quoted 4 lines

https://lore.kernel.org/all/[email protected]/

So , kernel and uboot dt files will remain in sync.

Sorry I may be missing something. Why do we need these properties in U-Boot now? Why not wait 2 weeks for the v6.8-rc1 tag in Linux and sync everything all at once?

I agree. NAK for the series. Please get this part of dts sync.

Signature · 3 lines
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D