Skip to contentSkip to conversation

mt7988: initial DT changes

PATCH In review Rafał Miłecki 4 participants 7 messages Jan 8, 2024 – Jan 22, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

v2 cover mt7988: initial DT changes

From: Rafał Miłecki <[email protected]>

This work is based on linux-next content and was successfully verified using "dtbs_check". It's initial code for MT7988A that will get extended as we get more bindings available (pinctrl is big blocker right now).

AngeloGioacchino, Matthias: is this something you could queue in
git://git.kernel.org/pub/scm/linux/kernel/git/mediatek/linux
for v6.9?

Rafał Miłecki (3):
dt-bindings: arm64: mediatek: Add MT7988A and BPI-R4
arm64: dts: mediatek: Add initial MT7988A and BPI-R4
arm64: dts: mediatek: mt7988: add clock controllers

 .../devicetree/bindings/arm/mediatek.yaml     |   4 +
 arch/arm64/boot/dts/mediatek/Makefile         |   1 +
 .../dts/mediatek/mt7988a-bananapi-bpi-r4.dts  |  11 ++
 arch/arm64/boot/dts/mediatek/mt7988a.dtsi     | 136 ++++++++++++++++++
 4 files changed, 152 insertions(+)
 create mode 100644 arch/arm64/boot/dts/mediatek/mt7988a-bananapi-bpi-r4.dts
 create mode 100644 arch/arm64/boot/dts/mediatek/mt7988a.dtsi
Signature · 1 line
2.35.3
#1 lore raw

PATCH v2 1/3 dt-bindings: arm64: mediatek: Add MT7988A and BPI-R4

From: Rafał Miłecki <[email protected]>

MT7988A is another MediaTek's SoC with just 1 device available right
now: Banana Pi BPI-R4.

---
 Documentation/devicetree/bindings/arm/mediatek.yaml | 4 ++++
 1 file changed, 4 insertions(+)
Documentation/devicetree/bindings/arm/mediatek.yaml +4 -0
index 6f2f64ae76fc..92dbfb862757 100644
@@ -91,6 +91,10 @@ properties:
           - enum:
               - mediatek,mt7986b-rfb
           - const: mediatek,mt7986b
+      - items:
+          - enum:
+              - bananapi,bpi-r4
+          - const: mediatek,mt7988a
       - items:
           - enum:
               - mediatek,mt8127-moose
Signature · 1 line
2.35.3
#3 lore raw

PATCH v2 2/3 arm64: dts: mediatek: Add initial MT7988A and BPI-R4

In reply to Rafał Miłecki

From: Rafał Miłecki <[email protected]>

MT7988A (AKA MediaTek Filogic 880) is a quad-core ARM Cortex-A73 platform designed for Wi-Fi 7 devices (there is no wireless on SoC though). The first public MT7988A device is Banana Pi BPI-R4.

Many SoC parts remain to be added (they need their own bindings or depend on missing clocks). Those present block however are correct and having base .dtsi will help testing & working on missing stuff.

---
V2: Drop thermal zones & reserved memory from .dtsi (those don't belong
there and we also need thermal controller first). Fix compatible.

 arch/arm64/boot/dts/mediatek/Makefile         |  1 +
 .../dts/mediatek/mt7988a-bananapi-bpi-r4.dts  | 11 +++
 arch/arm64/boot/dts/mediatek/mt7988a.dtsi     | 97 +++++++++++++++++++
 3 files changed, 109 insertions(+)
 create mode 100644 arch/arm64/boot/dts/mediatek/mt7988a-bananapi-bpi-r4.dts
 create mode 100644 arch/arm64/boot/dts/mediatek/mt7988a.dtsi
arch/arm64/boot/dts/mediatek/Makefile +1 -0
index 1e6f91731e92..0a189d5d8006 100644
@@ -15,6 +15,7 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-nor.dtbo
 dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-sd.dtbo
 dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-rfb.dtb
 dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986b-rfb.dtb
+dtb-$(CONFIG_ARCH_MEDIATEK) += mt7988a-bananapi-bpi-r4.dtb
 dtb-$(CONFIG_ARCH_MEDIATEK) += mt8167-pumpkin.dtb
 dtb-$(CONFIG_ARCH_MEDIATEK) += mt8173-elm.dtb
 dtb-$(CONFIG_ARCH_MEDIATEK) += mt8173-elm-hana.dtb
arch/arm64/boot/dts/mediatek/mt7988a-bananapi-bpi-r4.dts new file +11 -0
new file mode 100644
index 000000000000..efc4ad0b08b8
@@ -0,0 +1,11 @@
+// SPDX-License-Identifier: GPL-2.0-only OR MIT
+
+/dts-v1/;
+
+#include "mt7988a.dtsi"
+
+/ {
+	compatible = "bananapi,bpi-r4", "mediatek,mt7988a";
+	model = "Banana Pi BPI-R4";
+	chassis-type = "embedded";
+};
arch/arm64/boot/dts/mediatek/mt7988a.dtsi new file +97 -0

97 lines not on this page · raw message

Signature · 1 line
2.35.3
#4 lore raw

PATCH v2 3/3 arm64: dts: mediatek: mt7988: add clock controllers

In reply to Rafał Miłecki

From: Rafał Miłecki <[email protected]>

Add bindings of on-SoC clocks.

---
V2: New PATCH in the series thanks to Daniel's bindings work

 arch/arm64/boot/dts/mediatek/mt7988a.dtsi | 41 ++++++++++++++++++++++-
 1 file changed, 40 insertions(+), 1 deletion(-)
arch/arm64/boot/dts/mediatek/mt7988a.dtsi +40 -1
index 5a778188ac21..bba97de4fb44 100644
@@ -78,12 +78,51 @@ gic: interrupt-controller@c000000 {
 			#interrupt-cells = <3>;
 		};
 
-		watchdog@1001c000 {
+		clock-controller@10001000 {
+			compatible = "mediatek,mt7988-infracfg", "syscon";
+			reg = <0 0x10001000 0 0x1000>;
+			#clock-cells = <1>;
+		};
+
+		clock-controller@1001b000 {
+			compatible = "mediatek,mt7988-topckgen", "syscon";
+			reg = <0 0x1001b000 0 0x1000>;
+			#clock-cells = <1>;
+		};
+
+		watchdog: watchdog@1001c000 {
 			compatible = "mediatek,mt7988-wdt";
 			reg = <0 0x1001c000 0 0x1000>;
 			interrupts = <GIC_SPI 110 IRQ_TYPE_LEVEL_HIGH>;
 			#reset-cells = <1>;
 		};
+
+		clock-controller@1001e000 {
+			compatible = "mediatek,mt7988-apmixedsys";
+			reg = <0 0x1001e000 0 0x1000>;
+			#clock-cells = <1>;
+		};
+
+		clock-controller@11f40000 {
+			compatible = "mediatek,mt7988-xfi-pll";
+			reg = <0 0x11f40000 0 0x1000>;
+			resets = <&watchdog 16>;
+			#clock-cells = <1>;
+		};
+
+		clock-controller@15000000 {
+			compatible = "mediatek,mt7988-ethsys", "syscon";
+			reg = <0 0x15000000 0 0x1000>;
+			#clock-cells = <1>;
+			#reset-cells = <1>;
+		};
+
+		clock-controller@15031000 {
+			compatible = "mediatek,mt7988-ethwarp";
+			reg = <0 0x15031000 0 0x1000>;
+			#clock-cells = <1>;
+			#reset-cells = <1>;
+		};
 	};
 
 	timer {
Signature · 1 line
2.35.3
Reviewed-by on v2 3/3
#5 lore raw

Re: [PATCH V2 3/3] arm64: dts: mediatek: mt7988: add clock controllers

Quoted 5 lines · Rafał Miłecki

From: Rafał Miłecki <[email protected]>

Add bindings of on-SoC clocks.

Quoted 66 lines

---
V2: New PATCH in the series thanks to Daniel's bindings work

 arch/arm64/boot/dts/mediatek/mt7988a.dtsi | 41 ++++++++++++++++++++++-
 1 file changed, 40 insertions(+), 1 deletion(-)
arch/arm64/boot/dts/mediatek/mt7988a.dtsi +40 -1
index 5a778188ac21..bba97de4fb44 100644
@@ -78,12 +78,51 @@ gic: interrupt-controller@c000000 {
 			#interrupt-cells = <3>;
 		};
 
-		watchdog@1001c000 {
+		clock-controller@10001000 {
+			compatible = "mediatek,mt7988-infracfg", "syscon";
+			reg = <0 0x10001000 0 0x1000>;
+			#clock-cells = <1>;
+		};
+
+		clock-controller@1001b000 {
+			compatible = "mediatek,mt7988-topckgen", "syscon";
+			reg = <0 0x1001b000 0 0x1000>;
+			#clock-cells = <1>;
+		};
+
+		watchdog: watchdog@1001c000 {
 			compatible = "mediatek,mt7988-wdt";
 			reg = <0 0x1001c000 0 0x1000>;
 			interrupts = <GIC_SPI 110 IRQ_TYPE_LEVEL_HIGH>;
 			#reset-cells = <1>;
 		};
+
+		clock-controller@1001e000 {
+			compatible = "mediatek,mt7988-apmixedsys";
+			reg = <0 0x1001e000 0 0x1000>;
+			#clock-cells = <1>;
+		};
+
+		clock-controller@11f40000 {
+			compatible = "mediatek,mt7988-xfi-pll";
+			reg = <0 0x11f40000 0 0x1000>;
+			resets = <&watchdog 16>;
+			#clock-cells = <1>;
+		};
+
+		clock-controller@15000000 {
+			compatible = "mediatek,mt7988-ethsys", "syscon";
+			reg = <0 0x15000000 0 0x1000>;
+			#clock-cells = <1>;
+			#reset-cells = <1>;
+		};
+
+		clock-controller@15031000 {
+			compatible = "mediatek,mt7988-ethwarp";
+			reg = <0 0x15031000 0 0x1000>;
+			#clock-cells = <1>;
+			#reset-cells = <1>;
+		};
 	};
 
 	timer {
Signature · 1 line
2.35.3
maintainer
#6 lore raw
In reply to Rafał Miłecki
Quoted 10 lines · Rafał Miłecki

From: Rafał Miłecki <[email protected]>

This work is based on linux-next content and was successfully verified using "dtbs_check". It's initial code for MT7988A that will get extended as we get more bindings available (pinctrl is big blocker right now).

AngeloGioacchino, Matthias: is this something you could queue in
git://git.kernel.org/pub/scm/linux/kernel/git/mediatek/linux
for v6.9?

Series applied, thanks!

Quoted 13 lines

Rafał Miłecki (3):
dt-bindings: arm64: mediatek: Add MT7988A and BPI-R4
arm64: dts: mediatek: Add initial MT7988A and BPI-R4
arm64: dts: mediatek: mt7988: add clock controllers

  .../devicetree/bindings/arm/mediatek.yaml     |   4 +
  arch/arm64/boot/dts/mediatek/Makefile         |   1 +
  .../dts/mediatek/mt7988a-bananapi-bpi-r4.dts  |  11 ++
  arch/arm64/boot/dts/mediatek/mt7988a.dtsi     | 136 ++++++++++++++++++
  4 files changed, 152 insertions(+)

create mode 100644 arch/arm64/boot/dts/mediatek/mt7988a-bananapi-bpi-r4.dts create mode 100644 arch/arm64/boot/dts/mediatek/mt7988a.dtsi