netfilter: nf_tables: validate .maxattr at expression registration
Subsystems (2)
Pablo Neira Ayuso
maintainerPATCH 1/1 netfilter: nf_tables: validate .maxattr at expression registration
struct nft_expr_info allows to store up to NFT_EXPR_MAXATTR (16) attributes when parsing netlink attributes.
Rise a warning in case there is ever a nft expression whose .maxattr goes beyond this number of expressions, in such case, struct nft_expr_info needs to be updated.
Signed-off-by Pablo Neira Ayuso <[email protected]>
--- net/netfilter/nf_tables_api.c | 3 +++ 1 file changed, 3 insertions(+)
net/netfilter/nf_tables_api.c +3 -0
@@ -2968,6 +2968,9 @@ static int nf_tables_delchain(struct sk_buff *skb, const struct nfnl_info *info,*/ int nft_register_expr (struct nft_expr_type *type) { +if (WARN_ON_ONCE (type->maxattr >NFT_EXPR_MAXATTR )) +return -ENOMEM ; +nfnl_lock (NFNL_SUBSYS_NFTABLES );if (type->family ==NFPROTO_UNSPEC )list_add_tail_rcu (&type->list, &nf_tables_expressions);
Signature · 1 line
2.30.2