Skip to contentSkip to conversation

drm/ci: Add msm tests

PATCH Applied Rob Clark 4 participants 11 messages Jan 8, 2024 – Jan 15, 2024

Subsystems (4)
lore
Share & tools
lore

Rob Clark

author
#0 lore raw

PATCH 1/1 drm/ci: Add msm tests

From: Rob Clark <[email protected]>

The msm tests should skip on non-msm hw, so I think it should be safe to enable everywhere.

---
 drivers/gpu/drm/ci/testlist.txt | 49 +++++++++++++++++++++++++++++++++
 1 file changed, 49 insertions(+)
drivers/gpu/drm/ci/testlist.txt +49 -0
index f82cd90372f4..eaeb751bb0ad 100644
@@ -2910,3 +2910,52 @@ kms_writeback@writeback-invalid-parameters
 kms_writeback@writeback-fb-id
 kms_writeback@writeback-check-output
 prime_mmap_kms@buffer-sharing
+msm_shrink@copy-gpu-sanitycheck-8
+msm_shrink@copy-gpu-sanitycheck-32
+msm_shrink@copy-gpu-8
+msm_shrink@copy-gpu-32
+msm_shrink@copy-gpu-madvise-8
+msm_shrink@copy-gpu-madvise-32
+msm_shrink@copy-gpu-oom-8
+msm_shrink@copy-gpu-oom-32
+msm_shrink@copy-mmap-sanitycheck-8
+msm_shrink@copy-mmap-sanitycheck-32
+msm_shrink@copy-mmap-8
+msm_shrink@copy-mmap-32
+msm_shrink@copy-mmap-madvise-8
+msm_shrink@copy-mmap-madvise-32
+msm_shrink@copy-mmap-oom-8
+msm_shrink@copy-mmap-oom-32
+msm_shrink@copy-mmap-dmabuf-sanitycheck-8
+msm_shrink@copy-mmap-dmabuf-sanitycheck-32
+msm_shrink@copy-mmap-dmabuf-8
+msm_shrink@copy-mmap-dmabuf-32
+msm_shrink@copy-mmap-dmabuf-madvise-8
+msm_shrink@copy-mmap-dmabuf-madvise-32
+msm_shrink@copy-mmap-dmabuf-oom-8
+msm_shrink@copy-mmap-dmabuf-oom-32
+msm_mapping@ring
+msm_mapping@sqefw
+msm_mapping@shadow
+msm_submitoverhead@submitbench-10-bos
+msm_submitoverhead@submitbench-10-bos-no-implicit-sync
+msm_submitoverhead@submitbench-100-bos
+msm_submitoverhead@submitbench-100-bos-no-implicit-sync
+msm_submitoverhead@submitbench-250-bos
+msm_submitoverhead@submitbench-250-bos-no-implicit-sync
+msm_submitoverhead@submitbench-500-bos
+msm_submitoverhead@submitbench-500-bos-no-implicit-sync
+msm_submitoverhead@submitbench-1000-bos
+msm_submitoverhead@submitbench-1000-bos-no-implicit-sync
+msm_recovery@hangcheck
+msm_recovery@gpu-fault
+msm_recovery@gpu-fault-parallel
+msm_recovery@iova-fault
+msm_submit@empty-submit
+msm_submit@invalid-queue-submit
+msm_submit@invalid-flags-submit
+msm_submit@invalid-in-fence-submit
+msm_submit@invalid-duplicate-bo-submit
+msm_submit@invalid-cmd-idx-submit
+msm_submit@invalid-cmd-type-submit
+msm_submit@valid-submit
Signature · 1 line
2.43.0
#1 lore raw
Quoted 10 lines · Rob Clark

From: Rob Clark <[email protected]>

The msm tests should skip on non-msm hw, so I think it should be safe to enable everywhere.

---
  drivers/gpu/drm/ci/testlist.txt | 49 +++++++++++++++++++++++++++++++++
  1 file changed, 49 insertions(+)

I do see that all these tests use igt_msm_dev_open() to make sure it opens only the MSM card.

But if igt_msm_dev_open() fails, I dont see a igt_require() on some of the tests to skip them. So how will it safely skip on non-msm HW?

Unless i am missing something here ....

Quoted 57 lines
drivers/gpu/drm/ci/testlist.txt +49 -0
index f82cd90372f4..eaeb751bb0ad 100644
@@ -2910,3 +2910,52 @@ kms_writeback@writeback-invalid-parameters
  kms_writeback@writeback-fb-id
  kms_writeback@writeback-check-output
  prime_mmap_kms@buffer-sharing
+msm_shrink@copy-gpu-sanitycheck-8
+msm_shrink@copy-gpu-sanitycheck-32
+msm_shrink@copy-gpu-8
+msm_shrink@copy-gpu-32
+msm_shrink@copy-gpu-madvise-8
+msm_shrink@copy-gpu-madvise-32
+msm_shrink@copy-gpu-oom-8
+msm_shrink@copy-gpu-oom-32
+msm_shrink@copy-mmap-sanitycheck-8
+msm_shrink@copy-mmap-sanitycheck-32
+msm_shrink@copy-mmap-8
+msm_shrink@copy-mmap-32
+msm_shrink@copy-mmap-madvise-8
+msm_shrink@copy-mmap-madvise-32
+msm_shrink@copy-mmap-oom-8
+msm_shrink@copy-mmap-oom-32
+msm_shrink@copy-mmap-dmabuf-sanitycheck-8
+msm_shrink@copy-mmap-dmabuf-sanitycheck-32
+msm_shrink@copy-mmap-dmabuf-8
+msm_shrink@copy-mmap-dmabuf-32
+msm_shrink@copy-mmap-dmabuf-madvise-8
+msm_shrink@copy-mmap-dmabuf-madvise-32
+msm_shrink@copy-mmap-dmabuf-oom-8
+msm_shrink@copy-mmap-dmabuf-oom-32
+msm_mapping@ring
+msm_mapping@sqefw
+msm_mapping@shadow
+msm_submitoverhead@submitbench-10-bos
+msm_submitoverhead@submitbench-10-bos-no-implicit-sync
+msm_submitoverhead@submitbench-100-bos
+msm_submitoverhead@submitbench-100-bos-no-implicit-sync
+msm_submitoverhead@submitbench-250-bos
+msm_submitoverhead@submitbench-250-bos-no-implicit-sync
+msm_submitoverhead@submitbench-500-bos
+msm_submitoverhead@submitbench-500-bos-no-implicit-sync
+msm_submitoverhead@submitbench-1000-bos
+msm_submitoverhead@submitbench-1000-bos-no-implicit-sync
+msm_recovery@hangcheck
+msm_recovery@gpu-fault
+msm_recovery@gpu-fault-parallel
+msm_recovery@iova-fault
+msm_submit@empty-submit
+msm_submit@invalid-queue-submit
+msm_submit@invalid-flags-submit
+msm_submit@invalid-in-fence-submit
+msm_submit@invalid-duplicate-bo-submit
+msm_submit@invalid-cmd-idx-submit
+msm_submit@invalid-cmd-type-submit
+msm_submit@valid-submit
author
#2 lore raw
Quoted 15 lines · Abhinav Kumar
Quoted 10 lines · Rob Clark

From: Rob Clark <[email protected]>

The msm tests should skip on non-msm hw, so I think it should be safe to enable everywhere.

---
  drivers/gpu/drm/ci/testlist.txt | 49 +++++++++++++++++++++++++++++++++
  1 file changed, 49 insertions(+)
Quoted 7 lines

I do see that all these tests use igt_msm_dev_open() to make sure it opens only the MSM card.

But if igt_msm_dev_open() fails, I dont see a igt_require() on some of the tests to skip them. So how will it safely skip on non-msm HW?

Unless i am missing something here ....

hmm, at the time I added the initial msm tests, and igt_msm_dev_open(), I verified that they skipped on intel.. but since then I'd switched from intel to sc8280xp device for primary dev device, so I'd need to re-test to remember how it works. If these aren't skipping on !msm, it is a bug

BR,
-R

Quoted 57 lines
Quoted 57 lines
drivers/gpu/drm/ci/testlist.txt +49 -0
index f82cd90372f4..eaeb751bb0ad 100644
@@ -2910,3 +2910,52 @@ kms_writeback@writeback-invalid-parameters
  kms_writeback@writeback-fb-id
  kms_writeback@writeback-check-output
  prime_mmap_kms@buffer-sharing
+msm_shrink@copy-gpu-sanitycheck-8
+msm_shrink@copy-gpu-sanitycheck-32
+msm_shrink@copy-gpu-8
+msm_shrink@copy-gpu-32
+msm_shrink@copy-gpu-madvise-8
+msm_shrink@copy-gpu-madvise-32
+msm_shrink@copy-gpu-oom-8
+msm_shrink@copy-gpu-oom-32
+msm_shrink@copy-mmap-sanitycheck-8
+msm_shrink@copy-mmap-sanitycheck-32
+msm_shrink@copy-mmap-8
+msm_shrink@copy-mmap-32
+msm_shrink@copy-mmap-madvise-8
+msm_shrink@copy-mmap-madvise-32
+msm_shrink@copy-mmap-oom-8
+msm_shrink@copy-mmap-oom-32
+msm_shrink@copy-mmap-dmabuf-sanitycheck-8
+msm_shrink@copy-mmap-dmabuf-sanitycheck-32
+msm_shrink@copy-mmap-dmabuf-8
+msm_shrink@copy-mmap-dmabuf-32
+msm_shrink@copy-mmap-dmabuf-madvise-8
+msm_shrink@copy-mmap-dmabuf-madvise-32
+msm_shrink@copy-mmap-dmabuf-oom-8
+msm_shrink@copy-mmap-dmabuf-oom-32
+msm_mapping@ring
+msm_mapping@sqefw
+msm_mapping@shadow
+msm_submitoverhead@submitbench-10-bos
+msm_submitoverhead@submitbench-10-bos-no-implicit-sync
+msm_submitoverhead@submitbench-100-bos
+msm_submitoverhead@submitbench-100-bos-no-implicit-sync
+msm_submitoverhead@submitbench-250-bos
+msm_submitoverhead@submitbench-250-bos-no-implicit-sync
+msm_submitoverhead@submitbench-500-bos
+msm_submitoverhead@submitbench-500-bos-no-implicit-sync
+msm_submitoverhead@submitbench-1000-bos
+msm_submitoverhead@submitbench-1000-bos-no-implicit-sync
+msm_recovery@hangcheck
+msm_recovery@gpu-fault
+msm_recovery@gpu-fault-parallel
+msm_recovery@iova-fault
+msm_submit@empty-submit
+msm_submit@invalid-queue-submit
+msm_submit@invalid-flags-submit
+msm_submit@invalid-in-fence-submit
+msm_submit@invalid-duplicate-bo-submit
+msm_submit@invalid-cmd-idx-submit
+msm_submit@invalid-cmd-type-submit
+msm_submit@valid-submit
author
#3 lore raw
Quoted 23 lines · Rob Clark
Quoted 21 lines · Abhinav Kumar
Quoted 10 lines · Rob Clark

From: Rob Clark <[email protected]>

The msm tests should skip on non-msm hw, so I think it should be safe to enable everywhere.

---
  drivers/gpu/drm/ci/testlist.txt | 49 +++++++++++++++++++++++++++++++++
  1 file changed, 49 insertions(+)

I do see that all these tests use igt_msm_dev_open() to make sure it opens only the MSM card.

But if igt_msm_dev_open() fails, I dont see a igt_require() on some of the tests to skip them. So how will it safely skip on non-msm HW?

Quoted 7 lines
Quoted 1 line

Unless i am missing something here ....

hmm, at the time I added the initial msm tests, and igt_msm_dev_open(), I verified that they skipped on intel.. but since then I'd switched from intel to sc8280xp device for primary dev device, so I'd need to re-test to remember how it works. If these aren't skipping on !msm, it is a bug

I double checked, these tests skip in drm_open_driver() with "No known gpu found for chipset flags 0x64 (msm)", so no problem to run them on all CI runners.

BR,
-R

Quoted 60 lines

BR,
-R

Quoted 57 lines
Quoted 57 lines
drivers/gpu/drm/ci/testlist.txt +49 -0
index f82cd90372f4..eaeb751bb0ad 100644
@@ -2910,3 +2910,52 @@ kms_writeback@writeback-invalid-parameters
  kms_writeback@writeback-fb-id
  kms_writeback@writeback-check-output
  prime_mmap_kms@buffer-sharing
+msm_shrink@copy-gpu-sanitycheck-8
+msm_shrink@copy-gpu-sanitycheck-32
+msm_shrink@copy-gpu-8
+msm_shrink@copy-gpu-32
+msm_shrink@copy-gpu-madvise-8
+msm_shrink@copy-gpu-madvise-32
+msm_shrink@copy-gpu-oom-8
+msm_shrink@copy-gpu-oom-32
+msm_shrink@copy-mmap-sanitycheck-8
+msm_shrink@copy-mmap-sanitycheck-32
+msm_shrink@copy-mmap-8
+msm_shrink@copy-mmap-32
+msm_shrink@copy-mmap-madvise-8
+msm_shrink@copy-mmap-madvise-32
+msm_shrink@copy-mmap-oom-8
+msm_shrink@copy-mmap-oom-32
+msm_shrink@copy-mmap-dmabuf-sanitycheck-8
+msm_shrink@copy-mmap-dmabuf-sanitycheck-32
+msm_shrink@copy-mmap-dmabuf-8
+msm_shrink@copy-mmap-dmabuf-32
+msm_shrink@copy-mmap-dmabuf-madvise-8
+msm_shrink@copy-mmap-dmabuf-madvise-32
+msm_shrink@copy-mmap-dmabuf-oom-8
+msm_shrink@copy-mmap-dmabuf-oom-32
+msm_mapping@ring
+msm_mapping@sqefw
+msm_mapping@shadow
+msm_submitoverhead@submitbench-10-bos
+msm_submitoverhead@submitbench-10-bos-no-implicit-sync
+msm_submitoverhead@submitbench-100-bos
+msm_submitoverhead@submitbench-100-bos-no-implicit-sync
+msm_submitoverhead@submitbench-250-bos
+msm_submitoverhead@submitbench-250-bos-no-implicit-sync
+msm_submitoverhead@submitbench-500-bos
+msm_submitoverhead@submitbench-500-bos-no-implicit-sync
+msm_submitoverhead@submitbench-1000-bos
+msm_submitoverhead@submitbench-1000-bos-no-implicit-sync
+msm_recovery@hangcheck
+msm_recovery@gpu-fault
+msm_recovery@gpu-fault-parallel
+msm_recovery@iova-fault
+msm_submit@empty-submit
+msm_submit@invalid-queue-submit
+msm_submit@invalid-flags-submit
+msm_submit@invalid-in-fence-submit
+msm_submit@invalid-duplicate-bo-submit
+msm_submit@invalid-cmd-idx-submit
+msm_submit@invalid-cmd-type-submit
+msm_submit@valid-submit
Reviewed-by
#4 lore raw
Quoted 32 lines · Rob Clark
Quoted 23 lines · Rob Clark
Quoted 21 lines · Abhinav Kumar
Quoted 10 lines · Rob Clark

From: Rob Clark <[email protected]>

The msm tests should skip on non-msm hw, so I think it should be safe to enable everywhere.

---
   drivers/gpu/drm/ci/testlist.txt | 49 +++++++++++++++++++++++++++++++++
   1 file changed, 49 insertions(+)

I do see that all these tests use igt_msm_dev_open() to make sure it opens only the MSM card.

But if igt_msm_dev_open() fails, I dont see a igt_require() on some of the tests to skip them. So how will it safely skip on non-msm HW?

Quoted 7 lines
Quoted 1 line

Unless i am missing something here ....

hmm, at the time I added the initial msm tests, and igt_msm_dev_open(), I verified that they skipped on intel.. but since then I'd switched from intel to sc8280xp device for primary dev device, so I'd need to re-test to remember how it works. If these aren't skipping on !msm, it is a bug

Quoted 7 lines

I double checked, these tests skip in drm_open_driver() with "No known gpu found for chipset flags 0x64 (msm)", so no problem to run them on all CI runners.

BR,
-R

Ack, thanks for checking

Quoted 61 lines
Quoted 61 lines

BR,
-R

Quoted 57 lines
Quoted 57 lines
drivers/gpu/drm/ci/testlist.txt +49 -0
index f82cd90372f4..eaeb751bb0ad 100644
@@ -2910,3 +2910,52 @@ kms_writeback@writeback-invalid-parameters
   kms_writeback@writeback-fb-id
   kms_writeback@writeback-check-output
   prime_mmap_kms@buffer-sharing
+msm_shrink@copy-gpu-sanitycheck-8
+msm_shrink@copy-gpu-sanitycheck-32
+msm_shrink@copy-gpu-8
+msm_shrink@copy-gpu-32
+msm_shrink@copy-gpu-madvise-8
+msm_shrink@copy-gpu-madvise-32
+msm_shrink@copy-gpu-oom-8
+msm_shrink@copy-gpu-oom-32
+msm_shrink@copy-mmap-sanitycheck-8
+msm_shrink@copy-mmap-sanitycheck-32
+msm_shrink@copy-mmap-8
+msm_shrink@copy-mmap-32
+msm_shrink@copy-mmap-madvise-8
+msm_shrink@copy-mmap-madvise-32
+msm_shrink@copy-mmap-oom-8
+msm_shrink@copy-mmap-oom-32
+msm_shrink@copy-mmap-dmabuf-sanitycheck-8
+msm_shrink@copy-mmap-dmabuf-sanitycheck-32
+msm_shrink@copy-mmap-dmabuf-8
+msm_shrink@copy-mmap-dmabuf-32
+msm_shrink@copy-mmap-dmabuf-madvise-8
+msm_shrink@copy-mmap-dmabuf-madvise-32
+msm_shrink@copy-mmap-dmabuf-oom-8
+msm_shrink@copy-mmap-dmabuf-oom-32
+msm_mapping@ring
+msm_mapping@sqefw
+msm_mapping@shadow
+msm_submitoverhead@submitbench-10-bos
+msm_submitoverhead@submitbench-10-bos-no-implicit-sync
+msm_submitoverhead@submitbench-100-bos
+msm_submitoverhead@submitbench-100-bos-no-implicit-sync
+msm_submitoverhead@submitbench-250-bos
+msm_submitoverhead@submitbench-250-bos-no-implicit-sync
+msm_submitoverhead@submitbench-500-bos
+msm_submitoverhead@submitbench-500-bos-no-implicit-sync
+msm_submitoverhead@submitbench-1000-bos
+msm_submitoverhead@submitbench-1000-bos-no-implicit-sync
+msm_recovery@hangcheck
+msm_recovery@gpu-fault
+msm_recovery@gpu-fault-parallel
+msm_recovery@iova-fault
+msm_submit@empty-submit
+msm_submit@invalid-queue-submit
+msm_submit@invalid-flags-submit
+msm_submit@invalid-in-fence-submit
+msm_submit@invalid-duplicate-bo-submit
+msm_submit@invalid-cmd-idx-submit
+msm_submit@invalid-cmd-type-submit
+msm_submit@valid-submit
maintainer
#5 lore raw
In reply to Rob Clark

Hi Rob,

Quoted 57 lines · Rob Clark

From: Rob Clark <[email protected]>

The msm tests should skip on non-msm hw, so I think it should be safe to enable everywhere.

---
  drivers/gpu/drm/ci/testlist.txt | 49 +++++++++++++++++++++++++++++++++
  1 file changed, 49 insertions(+)
drivers/gpu/drm/ci/testlist.txt +39 -0
index f82cd90372f4..eaeb751bb0ad 100644
@@ -2910,3 +2910,52 @@ kms_writeback@writeback-invalid-parameters
  kms_writeback@writeback-fb-id
  kms_writeback@writeback-check-output
  prime_mmap_kms@buffer-sharing
+msm_shrink@copy-gpu-sanitycheck-8
+msm_shrink@copy-gpu-sanitycheck-32
+msm_shrink@copy-gpu-8
+msm_shrink@copy-gpu-32
+msm_shrink@copy-gpu-madvise-8
+msm_shrink@copy-gpu-madvise-32
+msm_shrink@copy-gpu-oom-8
+msm_shrink@copy-gpu-oom-32
+msm_shrink@copy-mmap-sanitycheck-8
+msm_shrink@copy-mmap-sanitycheck-32
+msm_shrink@copy-mmap-8
+msm_shrink@copy-mmap-32
+msm_shrink@copy-mmap-madvise-8
+msm_shrink@copy-mmap-madvise-32
+msm_shrink@copy-mmap-oom-8
+msm_shrink@copy-mmap-oom-32
+msm_shrink@copy-mmap-dmabuf-sanitycheck-8
+msm_shrink@copy-mmap-dmabuf-sanitycheck-32
+msm_shrink@copy-mmap-dmabuf-8
+msm_shrink@copy-mmap-dmabuf-32
+msm_shrink@copy-mmap-dmabuf-madvise-8
+msm_shrink@copy-mmap-dmabuf-madvise-32
+msm_shrink@copy-mmap-dmabuf-oom-8
+msm_shrink@copy-mmap-dmabuf-oom-32
+msm_mapping@ring
+msm_mapping@sqefw
+msm_mapping@shadow
+msm_submitoverhead@submitbench-10-bos
+msm_submitoverhead@submitbench-10-bos-no-implicit-sync
+msm_submitoverhead@submitbench-100-bos
+msm_submitoverhead@submitbench-100-bos-no-implicit-sync
+msm_submitoverhead@submitbench-250-bos
+msm_submitoverhead@submitbench-250-bos-no-implicit-sync
+msm_submitoverhead@submitbench-500-bos
+msm_submitoverhead@submitbench-500-bos-no-implicit-sync
+msm_submitoverhead@submitbench-1000-bos
+msm_submitoverhead@submitbench-1000-bos-no-implicit-sync
+msm_recovery@hangcheck
+msm_recovery@gpu-fault

drivers/gpu/drm/ci/testlist.txt kms_writeback@writeback-invalid-parameters · line 2961

Quoted 10 lines
drivers/gpu/drm/ci/testlist.txt +10 -0
+msm_recovery@gpu-fault-parallel
+msm_recovery@iova-fault
+msm_submit@empty-submit
+msm_submit@invalid-queue-submit
+msm_submit@invalid-flags-submit
+msm_submit@invalid-in-fence-submit
+msm_submit@invalid-duplicate-bo-submit
+msm_submit@invalid-cmd-idx-submit
+msm_submit@invalid-cmd-type-submit
+msm_submit@valid-submit

I tested this patch with latest drm-misc/drm-misc-next and there was some failures seen for the newly added msm tests. I have updated the xfails with below commit,

https://gitlab.freedesktop.org/vigneshraman/linux/-/commit/d012893597a661d6ebbb755bf2607dfb055524a1

I will notify the maintainers about the flaky tests, update the url in the flakes.txt, and submit a separate patch for this change.

Regards,
Vignesh

author
#6 lore raw
Quoted 77 lines · Vignesh Raman

Hi Rob,

Quoted 57 lines · Rob Clark

From: Rob Clark <[email protected]>

The msm tests should skip on non-msm hw, so I think it should be safe to enable everywhere.

---
  drivers/gpu/drm/ci/testlist.txt | 49 +++++++++++++++++++++++++++++++++
  1 file changed, 49 insertions(+)
drivers/gpu/drm/ci/testlist.txt +39 -0
index f82cd90372f4..eaeb751bb0ad 100644
@@ -2910,3 +2910,52 @@ kms_writeback@writeback-invalid-parameters
  kms_writeback@writeback-fb-id
  kms_writeback@writeback-check-output
  prime_mmap_kms@buffer-sharing
+msm_shrink@copy-gpu-sanitycheck-8
+msm_shrink@copy-gpu-sanitycheck-32
+msm_shrink@copy-gpu-8
+msm_shrink@copy-gpu-32
+msm_shrink@copy-gpu-madvise-8
+msm_shrink@copy-gpu-madvise-32
+msm_shrink@copy-gpu-oom-8
+msm_shrink@copy-gpu-oom-32
+msm_shrink@copy-mmap-sanitycheck-8
+msm_shrink@copy-mmap-sanitycheck-32
+msm_shrink@copy-mmap-8
+msm_shrink@copy-mmap-32
+msm_shrink@copy-mmap-madvise-8
+msm_shrink@copy-mmap-madvise-32
+msm_shrink@copy-mmap-oom-8
+msm_shrink@copy-mmap-oom-32
+msm_shrink@copy-mmap-dmabuf-sanitycheck-8
+msm_shrink@copy-mmap-dmabuf-sanitycheck-32
+msm_shrink@copy-mmap-dmabuf-8
+msm_shrink@copy-mmap-dmabuf-32
+msm_shrink@copy-mmap-dmabuf-madvise-8
+msm_shrink@copy-mmap-dmabuf-madvise-32
+msm_shrink@copy-mmap-dmabuf-oom-8
+msm_shrink@copy-mmap-dmabuf-oom-32
+msm_mapping@ring
+msm_mapping@sqefw
+msm_mapping@shadow
+msm_submitoverhead@submitbench-10-bos
+msm_submitoverhead@submitbench-10-bos-no-implicit-sync
+msm_submitoverhead@submitbench-100-bos
+msm_submitoverhead@submitbench-100-bos-no-implicit-sync
+msm_submitoverhead@submitbench-250-bos
+msm_submitoverhead@submitbench-250-bos-no-implicit-sync
+msm_submitoverhead@submitbench-500-bos
+msm_submitoverhead@submitbench-500-bos-no-implicit-sync
+msm_submitoverhead@submitbench-1000-bos
+msm_submitoverhead@submitbench-1000-bos-no-implicit-sync
+msm_recovery@hangcheck
+msm_recovery@gpu-fault

drivers/gpu/drm/ci/testlist.txt kms_writeback@writeback-invalid-parameters · line 2961

Quoted 10 lines
drivers/gpu/drm/ci/testlist.txt +10 -0
+msm_recovery@gpu-fault-parallel
+msm_recovery@iova-fault
+msm_submit@empty-submit
+msm_submit@invalid-queue-submit
+msm_submit@invalid-flags-submit
+msm_submit@invalid-in-fence-submit
+msm_submit@invalid-duplicate-bo-submit
+msm_submit@invalid-cmd-idx-submit
+msm_submit@invalid-cmd-type-submit
+msm_submit@valid-submit

I tested this patch with latest drm-misc/drm-misc-next and there was some failures seen for the newly added msm tests. I have updated the xfails with below commit,

Quoted 4 lines

https://gitlab.freedesktop.org/vigneshraman/linux/-/commit/d012893597a661d6ebbb755bf2607dfb055524a1

I will notify the maintainers about the flaky tests, update the url in the flakes.txt, and submit a separate patch for this change.

Thanks, it looks like you also have a relatively recent igt (there were some msm_submit fails until I fixed the test)..

BR,
-R

Quoted 2 lines

Regards,
Vignesh

author
#7 lore raw
Quoted 80 lines · Rob Clark
Quoted 77 lines · Vignesh Raman

Hi Rob,

Quoted 57 lines · Rob Clark

From: Rob Clark <[email protected]>

The msm tests should skip on non-msm hw, so I think it should be safe to enable everywhere.

---
  drivers/gpu/drm/ci/testlist.txt | 49 +++++++++++++++++++++++++++++++++
  1 file changed, 49 insertions(+)
drivers/gpu/drm/ci/testlist.txt +39 -0
index f82cd90372f4..eaeb751bb0ad 100644
@@ -2910,3 +2910,52 @@ kms_writeback@writeback-invalid-parameters
  kms_writeback@writeback-fb-id
  kms_writeback@writeback-check-output
  prime_mmap_kms@buffer-sharing
+msm_shrink@copy-gpu-sanitycheck-8
+msm_shrink@copy-gpu-sanitycheck-32
+msm_shrink@copy-gpu-8
+msm_shrink@copy-gpu-32
+msm_shrink@copy-gpu-madvise-8
+msm_shrink@copy-gpu-madvise-32
+msm_shrink@copy-gpu-oom-8
+msm_shrink@copy-gpu-oom-32
+msm_shrink@copy-mmap-sanitycheck-8
+msm_shrink@copy-mmap-sanitycheck-32
+msm_shrink@copy-mmap-8
+msm_shrink@copy-mmap-32
+msm_shrink@copy-mmap-madvise-8
+msm_shrink@copy-mmap-madvise-32
+msm_shrink@copy-mmap-oom-8
+msm_shrink@copy-mmap-oom-32
+msm_shrink@copy-mmap-dmabuf-sanitycheck-8
+msm_shrink@copy-mmap-dmabuf-sanitycheck-32
+msm_shrink@copy-mmap-dmabuf-8
+msm_shrink@copy-mmap-dmabuf-32
+msm_shrink@copy-mmap-dmabuf-madvise-8
+msm_shrink@copy-mmap-dmabuf-madvise-32
+msm_shrink@copy-mmap-dmabuf-oom-8
+msm_shrink@copy-mmap-dmabuf-oom-32
+msm_mapping@ring
+msm_mapping@sqefw
+msm_mapping@shadow
+msm_submitoverhead@submitbench-10-bos
+msm_submitoverhead@submitbench-10-bos-no-implicit-sync
+msm_submitoverhead@submitbench-100-bos
+msm_submitoverhead@submitbench-100-bos-no-implicit-sync
+msm_submitoverhead@submitbench-250-bos
+msm_submitoverhead@submitbench-250-bos-no-implicit-sync
+msm_submitoverhead@submitbench-500-bos
+msm_submitoverhead@submitbench-500-bos-no-implicit-sync
+msm_submitoverhead@submitbench-1000-bos
+msm_submitoverhead@submitbench-1000-bos-no-implicit-sync
+msm_recovery@hangcheck
+msm_recovery@gpu-fault

drivers/gpu/drm/ci/testlist.txt kms_writeback@writeback-invalid-parameters · line 2961

Quoted 10 lines
drivers/gpu/drm/ci/testlist.txt +10 -0
+msm_recovery@gpu-fault-parallel
+msm_recovery@iova-fault
+msm_submit@empty-submit
+msm_submit@invalid-queue-submit
+msm_submit@invalid-flags-submit
+msm_submit@invalid-in-fence-submit
+msm_submit@invalid-duplicate-bo-submit
+msm_submit@invalid-cmd-idx-submit
+msm_submit@invalid-cmd-type-submit
+msm_submit@valid-submit

I tested this patch with latest drm-misc/drm-misc-next and there was some failures seen for the newly added msm tests. I have updated the xfails with below commit,

Quoted 4 lines
Quoted 4 lines

https://gitlab.freedesktop.org/vigneshraman/linux/-/commit/d012893597a661d6ebbb755bf2607dfb055524a1

I will notify the maintainers about the flaky tests, update the url in the flakes.txt, and submit a separate patch for this change.

Oh, you should probably move msm_mapping@* to skips on sdm845. I had a closer look at those, and they are failing due to a bootloader/fw issue. We work around this in mesa CI with these two patches:

https://gitlab.freedesktop.org/gfx-ci/linux/-/commit/4b49f902ec6f2bb382cbbf489870573f4b43371e
https://gitlab.freedesktop.org/gfx-ci/linux/-/commit/38cdf4c5559771e2474ae0fecef8469f65147bc1

But given that sdm845 is similar to sc7180 as far as kernel gpu driver, it is probably just better to skip these on sdm845 (with a comment referring to the hack patches we use in mesa CI)

BR,
-R

Quoted 9 lines

Thanks, it looks like you also have a relatively recent igt (there were some msm_submit fails until I fixed the test)..

BR,
-R

Quoted 2 lines

Regards,
Vignesh

maintainer
#8 lore raw

Hi Rob,

Quoted 90 lines · Rob Clark
Quoted 80 lines · Rob Clark
Quoted 77 lines · Vignesh Raman

Hi Rob,

Quoted 57 lines · Rob Clark

From: Rob Clark <[email protected]>

The msm tests should skip on non-msm hw, so I think it should be safe to enable everywhere.

---
   drivers/gpu/drm/ci/testlist.txt | 49 +++++++++++++++++++++++++++++++++
   1 file changed, 49 insertions(+)
drivers/gpu/drm/ci/testlist.txt +39 -0
index f82cd90372f4..eaeb751bb0ad 100644
@@ -2910,3 +2910,52 @@ kms_writeback@writeback-invalid-parameters
   kms_writeback@writeback-fb-id
   kms_writeback@writeback-check-output
   prime_mmap_kms@buffer-sharing
+msm_shrink@copy-gpu-sanitycheck-8
+msm_shrink@copy-gpu-sanitycheck-32
+msm_shrink@copy-gpu-8
+msm_shrink@copy-gpu-32
+msm_shrink@copy-gpu-madvise-8
+msm_shrink@copy-gpu-madvise-32
+msm_shrink@copy-gpu-oom-8
+msm_shrink@copy-gpu-oom-32
+msm_shrink@copy-mmap-sanitycheck-8
+msm_shrink@copy-mmap-sanitycheck-32
+msm_shrink@copy-mmap-8
+msm_shrink@copy-mmap-32
+msm_shrink@copy-mmap-madvise-8
+msm_shrink@copy-mmap-madvise-32
+msm_shrink@copy-mmap-oom-8
+msm_shrink@copy-mmap-oom-32
+msm_shrink@copy-mmap-dmabuf-sanitycheck-8
+msm_shrink@copy-mmap-dmabuf-sanitycheck-32
+msm_shrink@copy-mmap-dmabuf-8
+msm_shrink@copy-mmap-dmabuf-32
+msm_shrink@copy-mmap-dmabuf-madvise-8
+msm_shrink@copy-mmap-dmabuf-madvise-32
+msm_shrink@copy-mmap-dmabuf-oom-8
+msm_shrink@copy-mmap-dmabuf-oom-32
+msm_mapping@ring
+msm_mapping@sqefw
+msm_mapping@shadow
+msm_submitoverhead@submitbench-10-bos
+msm_submitoverhead@submitbench-10-bos-no-implicit-sync
+msm_submitoverhead@submitbench-100-bos
+msm_submitoverhead@submitbench-100-bos-no-implicit-sync
+msm_submitoverhead@submitbench-250-bos
+msm_submitoverhead@submitbench-250-bos-no-implicit-sync
+msm_submitoverhead@submitbench-500-bos
+msm_submitoverhead@submitbench-500-bos-no-implicit-sync
+msm_submitoverhead@submitbench-1000-bos
+msm_submitoverhead@submitbench-1000-bos-no-implicit-sync
+msm_recovery@hangcheck
+msm_recovery@gpu-fault

drivers/gpu/drm/ci/testlist.txt kms_writeback@writeback-invalid-parameters · line 2961

Quoted 10 lines
drivers/gpu/drm/ci/testlist.txt +10 -0
+msm_recovery@gpu-fault-parallel
+msm_recovery@iova-fault
+msm_submit@empty-submit
+msm_submit@invalid-queue-submit
+msm_submit@invalid-flags-submit
+msm_submit@invalid-in-fence-submit
+msm_submit@invalid-duplicate-bo-submit
+msm_submit@invalid-cmd-idx-submit
+msm_submit@invalid-cmd-type-submit
+msm_submit@valid-submit

I tested this patch with latest drm-misc/drm-misc-next and there was some failures seen for the newly added msm tests. I have updated the xfails with below commit,

Quoted 4 lines
Quoted 4 lines

https://gitlab.freedesktop.org/vigneshraman/linux/-/commit/d012893597a661d6ebbb755bf2607dfb055524a1

I will notify the maintainers about the flaky tests, update the url in the flakes.txt, and submit a separate patch for this change.

Oh, you should probably move msm_mapping@* to skips on sdm845. I had a closer look at those, and they are failing due to a bootloader/fw issue. We work around this in mesa CI with these two patches:

Quoted 6 lines

https://gitlab.freedesktop.org/gfx-ci/linux/-/commit/4b49f902ec6f2bb382cbbf489870573f4b43371e
https://gitlab.freedesktop.org/gfx-ci/linux/-/commit/38cdf4c5559771e2474ae0fecef8469f65147bc1

But given that sdm845 is similar to sc7180 as far as kernel gpu driver, it is probably just better to skip these on sdm845 (with a comment referring to the hack patches we use in mesa CI)

I have sent a patch with these changes,

https://lore.kernel.org/dri-devel/[email protected]/T/#u

Thanks.

Regards,
Vignesh

Acked-by
#9 lore raw
Quoted 18 lines · Vignesh Raman

Hi Rob,

Quoted 15 lines · Rob Clark
Quoted 14 lines · Rob Clark
Quoted 11 lines · Vignesh Raman

Hi Rob,

Quoted 6 lines · Rob Clark

From: Rob Clark <[email protected]>

The msm tests should skip on non-msm hw, so I think it should be safe to enable everywhere.

Quoted 76 lines
Quoted 76 lines
Quoted 67 lines
Quoted 67 lines
Quoted 52 lines

---
   drivers/gpu/drm/ci/testlist.txt | 49
+++++++++++++++++++++++++++++++++

   1 file changed, 49 insertions(+)
drivers/gpu/drm/ci/testlist.txt +0 -0
index f82cd90372f4..eaeb751bb0ad 100644
@@ -2910,3 +2910,52 @@ kms_writeback@writeback-invalid-parameters

   kms_writeback@writeback-fb-id
   kms_writeback@writeback-check-output
   prime_mmap_kms@buffer-sharing

drivers/gpu/drm/ci/testlist.txt +39 -0
+msm_shrink@copy-gpu-sanitycheck-8
+msm_shrink@copy-gpu-sanitycheck-32
+msm_shrink@copy-gpu-8
+msm_shrink@copy-gpu-32
+msm_shrink@copy-gpu-madvise-8
+msm_shrink@copy-gpu-madvise-32
+msm_shrink@copy-gpu-oom-8
+msm_shrink@copy-gpu-oom-32
+msm_shrink@copy-mmap-sanitycheck-8
+msm_shrink@copy-mmap-sanitycheck-32
+msm_shrink@copy-mmap-8
+msm_shrink@copy-mmap-32
+msm_shrink@copy-mmap-madvise-8
+msm_shrink@copy-mmap-madvise-32
+msm_shrink@copy-mmap-oom-8
+msm_shrink@copy-mmap-oom-32
+msm_shrink@copy-mmap-dmabuf-sanitycheck-8
+msm_shrink@copy-mmap-dmabuf-sanitycheck-32
+msm_shrink@copy-mmap-dmabuf-8
+msm_shrink@copy-mmap-dmabuf-32
+msm_shrink@copy-mmap-dmabuf-madvise-8
+msm_shrink@copy-mmap-dmabuf-madvise-32
+msm_shrink@copy-mmap-dmabuf-oom-8
+msm_shrink@copy-mmap-dmabuf-oom-32
+msm_mapping@ring
+msm_mapping@sqefw
+msm_mapping@shadow
+msm_submitoverhead@submitbench-10-bos
+msm_submitoverhead@submitbench-10-bos-no-implicit-sync
+msm_submitoverhead@submitbench-100-bos
+msm_submitoverhead@submitbench-100-bos-no-implicit-sync
+msm_submitoverhead@submitbench-250-bos
+msm_submitoverhead@submitbench-250-bos-no-implicit-sync
+msm_submitoverhead@submitbench-500-bos
+msm_submitoverhead@submitbench-500-bos-no-implicit-sync
+msm_submitoverhead@submitbench-1000-bos
+msm_submitoverhead@submitbench-1000-bos-no-implicit-sync
+msm_recovery@hangcheck
+msm_recovery@gpu-fault

drivers/gpu/drm/ci/testlist.txt kms_writeback@writeback-invalid-parameters · line 2961

Quoted 10 lines
drivers/gpu/drm/ci/testlist.txt +10 -0
+msm_recovery@gpu-fault-parallel
+msm_recovery@iova-fault
+msm_submit@empty-submit
+msm_submit@invalid-queue-submit
+msm_submit@invalid-flags-submit
+msm_submit@invalid-in-fence-submit
+msm_submit@invalid-duplicate-bo-submit
+msm_submit@invalid-cmd-idx-submit
+msm_submit@invalid-cmd-type-submit
+msm_submit@valid-submit

I tested this patch with latest drm-misc/drm-misc-next and there was some failures seen for the newly added msm tests. I have updated the xfails with below commit,

Quoted 4 lines
Quoted 4 lines

https://gitlab.freedesktop.org/vigneshraman/linux/-/commit/d012893597a661d6ebbb755bf2607dfb055524a1

I will notify the maintainers about the flaky tests, update the url in the flakes.txt, and submit a separate patch for this change.

Oh, you should probably move msm_mapping@* to skips on sdm845.  I had a closer look at those, and they are failing due to a bootloader/fw issue.  We work around this in mesa CI with these two patches:

Quoted 8 lines
Quoted 6 lines

https://gitlab.freedesktop.org/gfx-ci/linux/-/commit/4b49f902ec6f2bb382cbbf489870573f4b43371e
https://gitlab.freedesktop.org/gfx-ci/linux/-/commit/38cdf4c5559771e2474ae0fecef8469f65147bc1

But given that sdm845 is similar to sc7180 as far as kernel gpu driver, it is probably just better to skip these on sdm845 (with a comment referring to the hack patches we use in mesa CI)

I have sent a patch with these changes,

Thanks!

Helen

Quoted 8 lines

https://lore.kernel.org/dri-devel/[email protected]/T/#u

Thanks.

Regards,
Vignesh

Applied
#10 lore raw
In reply to Rob Clark
Quoted 6 lines · Rob Clark

From: Rob Clark <[email protected]>

The msm tests should skip on non-msm hw, so I think it should be safe to enable everywhere.

Applied to drm-misc-next.

Thanks
Helen

Quoted 61 lines
---
  drivers/gpu/drm/ci/testlist.txt | 49 +++++++++++++++++++++++++++++++++
  1 file changed, 49 insertions(+)
drivers/gpu/drm/ci/testlist.txt +49 -0
index f82cd90372f4..eaeb751bb0ad 100644
@@ -2910,3 +2910,52 @@ kms_writeback@writeback-invalid-parameters
  kms_writeback@writeback-fb-id
  kms_writeback@writeback-check-output
  prime_mmap_kms@buffer-sharing
+msm_shrink@copy-gpu-sanitycheck-8
+msm_shrink@copy-gpu-sanitycheck-32
+msm_shrink@copy-gpu-8
+msm_shrink@copy-gpu-32
+msm_shrink@copy-gpu-madvise-8
+msm_shrink@copy-gpu-madvise-32
+msm_shrink@copy-gpu-oom-8
+msm_shrink@copy-gpu-oom-32
+msm_shrink@copy-mmap-sanitycheck-8
+msm_shrink@copy-mmap-sanitycheck-32
+msm_shrink@copy-mmap-8
+msm_shrink@copy-mmap-32
+msm_shrink@copy-mmap-madvise-8
+msm_shrink@copy-mmap-madvise-32
+msm_shrink@copy-mmap-oom-8
+msm_shrink@copy-mmap-oom-32
+msm_shrink@copy-mmap-dmabuf-sanitycheck-8
+msm_shrink@copy-mmap-dmabuf-sanitycheck-32
+msm_shrink@copy-mmap-dmabuf-8
+msm_shrink@copy-mmap-dmabuf-32
+msm_shrink@copy-mmap-dmabuf-madvise-8
+msm_shrink@copy-mmap-dmabuf-madvise-32
+msm_shrink@copy-mmap-dmabuf-oom-8
+msm_shrink@copy-mmap-dmabuf-oom-32
+msm_mapping@ring
+msm_mapping@sqefw
+msm_mapping@shadow
+msm_submitoverhead@submitbench-10-bos
+msm_submitoverhead@submitbench-10-bos-no-implicit-sync
+msm_submitoverhead@submitbench-100-bos
+msm_submitoverhead@submitbench-100-bos-no-implicit-sync
+msm_submitoverhead@submitbench-250-bos
+msm_submitoverhead@submitbench-250-bos-no-implicit-sync
+msm_submitoverhead@submitbench-500-bos
+msm_submitoverhead@submitbench-500-bos-no-implicit-sync
+msm_submitoverhead@submitbench-1000-bos
+msm_submitoverhead@submitbench-1000-bos-no-implicit-sync
+msm_recovery@hangcheck
+msm_recovery@gpu-fault
+msm_recovery@gpu-fault-parallel
+msm_recovery@iova-fault
+msm_submit@empty-submit
+msm_submit@invalid-queue-submit
+msm_submit@invalid-flags-submit
+msm_submit@invalid-in-fence-submit
+msm_submit@invalid-duplicate-bo-submit
+msm_submit@invalid-cmd-idx-submit
+msm_submit@invalid-cmd-type-submit
+msm_submit@valid-submit