Skip to contentSkip to conversation

riscv: sophgo: milkv_duo: add support for Milk-V Duo board

PATCH Superseded Kongyang Liu 2 participants 7 messages Jan 7, 2024 – Jan 11, 2024

Subsystems (2)

v1 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

cover riscv: sophgo: milkv_duo: add support for Milk-V Duo board

The Milk-V Duo board is built upon Sophgo's CV1800B SoC, featuring two XuanTie C906 CPUs running at 1.0GHz and 700MHz, respectively.

This series introduces fundamental support for the Milk-V Duo board, encompassing UART, CPU, and PLIC support. This ensures that U-Boot can operate in serial console mode.

Kongyang Liu (4):
riscv: sophgo: milkv_duo: initial support added
riscv: dts: sophgo: Add basic device tree for Milk-V Duo board
configs: milkv_duo_defconfig: Add initial config
doc: sophgo: milkv_duo: document Milk-V Duo board

 arch/riscv/Kconfig                   |   4 +
 arch/riscv/dts/Makefile              |   1 +
 arch/riscv/dts/cv1800b-milkv-duo.dts |  38 +++++++++
 arch/riscv/dts/cv1800b.dtsi          | 123 +++++++++++++++++++++++++++
 board/sophgo/milkv_duo/Kconfig       |  28 ++++++
 board/sophgo/milkv_duo/MAINTAINERS   |   6 ++
 board/sophgo/milkv_duo/Makefile      |   5 ++
 board/sophgo/milkv_duo/board.c       |   9 ++
 configs/milkv_duo_defconfig          |  24 ++++++
 doc/board/index.rst                  |   1 +
 doc/board/sophgo/index.rst           |   8 ++
 doc/board/sophgo/milkv_duo.rst       |  50 +++++++++++
 include/configs/milkv_duo.h          |  16 ++++
 13 files changed, 313 insertions(+)
 create mode 100644 arch/riscv/dts/cv1800b-milkv-duo.dts
 create mode 100644 arch/riscv/dts/cv1800b.dtsi
 create mode 100644 board/sophgo/milkv_duo/Kconfig
 create mode 100644 board/sophgo/milkv_duo/MAINTAINERS
 create mode 100644 board/sophgo/milkv_duo/Makefile
 create mode 100644 board/sophgo/milkv_duo/board.c
 create mode 100644 configs/milkv_duo_defconfig
 create mode 100644 doc/board/sophgo/index.rst
 create mode 100644 doc/board/sophgo/milkv_duo.rst
 create mode 100644 include/configs/milkv_duo.h
Signature · 1 line
2.41.0
#1 lore raw

PATCH 1/4 riscv: sophgo: milkv_duo: initial support added

Add support for Sophgo's Milk-V Duo board, only minimal device tree and serial console are enabled, and it can boot via vendor first stage bootloader.

---

 arch/riscv/Kconfig                 |  4 ++++
 board/sophgo/milkv_duo/Kconfig     | 28 ++++++++++++++++++++++++++++
 board/sophgo/milkv_duo/MAINTAINERS |  6 ++++++
 board/sophgo/milkv_duo/Makefile    |  5 +++++
 board/sophgo/milkv_duo/board.c     |  9 +++++++++
 include/configs/milkv_duo.h        | 16 ++++++++++++++++
 6 files changed, 68 insertions(+)
 create mode 100644 board/sophgo/milkv_duo/Kconfig
 create mode 100644 board/sophgo/milkv_duo/MAINTAINERS
 create mode 100644 board/sophgo/milkv_duo/Makefile
 create mode 100644 board/sophgo/milkv_duo/board.c
 create mode 100644 include/configs/milkv_duo.h
arch/riscv/Kconfig +4 -0
index 6d0d812ddb..de99ce3a28 100644
@@ -14,6 +14,9 @@ config TARGET_ANDES_AE350
 config TARGET_MICROCHIP_ICICLE
 	bool "Support Microchip PolarFire-SoC Icicle Board"
 
+config TARGET_MILKV_DUO
+	bool "Support Milk-v Duo Board"
+
 config TARGET_OPENPITON_RISCV64
 	bool "Support RISC-V cores on OpenPiton SoC"
 
@@ -80,6 +83,7 @@ source "board/openpiton/riscv64/Kconfig"
 source "board/sifive/unleashed/Kconfig"
 source "board/sifive/unmatched/Kconfig"
 source "board/sipeed/maix/Kconfig"
+source "board/sophgo/milkv_duo/Kconfig"
 source "board/starfive/visionfive2/Kconfig"
 source "board/thead/th1520_lpi4a/Kconfig"
 
board/sophgo/milkv_duo/Kconfig new file +28 -0
new file mode 100644
index 0000000000..2a458f291c
@@ -0,0 +1,28 @@
+if TARGET_MILKV_DUO
+
+config SYS_BOARD
+	default "milkv_duo"
+
+config SYS_VENDOR
+	default "sophgo"
+
+config SYS_CPU
+	default "generic"
+
+config SYS_CONFIG_NAME
+	default "milkv_duo"
+
+config TEXT_BASE
+	default 0x80200000
+
+config ENV_SIZE
+	default 0x20000
+
+config ENV_SECT_SIZE
+	default 0x40000
+
+config BOARD_SPECIFIC_OPTIONS
+	def_bool y
+	select GENERIC_RISCV
+
+endif
board/sophgo/milkv_duo/MAINTAINERS new file +6 -0
new file mode 100644
index 0000000000..651a0592f7
@@ -0,0 +1,6 @@
+Milk-V Duo
+M:	Kongyang Liu <[email protected]>
+S:	Maintained
+F:	board/sophgo/milkv_duo/
+F:	configs/milkv_duo_defconfig
+F:	doc/board/sophgo/milkv_duo.rst
board/sophgo/milkv_duo/Makefile new file +5 -0
new file mode 100644
index 0000000000..a087013f5c
@@ -0,0 +1,5 @@
+# SPDX-License-Identifier: GPL-2.0+
+#
+# Copyright (c) 2024, Kongyang Liu <[email protected]>
+
+obj-y := board.o
board/sophgo/milkv_duo/board.c new file +9 -0
new file mode 100644
index 0000000000..eaa47be173
@@ -0,0 +1,9 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Copyright (c) 2024, Kongyang Liu <[email protected]>
+ */
+
+int board_init(void)
+{
+	return 0;
+}
include/configs/milkv_duo.h new file +16 -0
new file mode 100644
index 0000000000..dd1d146c50
@@ -0,0 +1,16 @@
+/* SPDX-License-Identifier: GPL-2.0+ */
+/*
+ * Copyright (c) 2024, Kongyang Liu <[email protected]>
+ *
+ */
+
+#ifndef __CONFIG_H
+#define __CONFIG_H
+
+#define CFG_SYS_SDRAM_BASE         0x80000000
+
+#define CFG_EXTRA_ENV_SETTINGS                 \
+	"consoledev=ttyS0"                         \
+	"baudrate=115200\0"                        \
+
+#endif /* __CONFIG_H */
Signature · 1 line
2.41.0
#2 lore raw

Re: [PATCH 1/4] riscv: sophgo: milkv_duo: initial support added

Quoted 6 lines · Kongyang Liu

Add support for Sophgo's Milk-V Duo board, only minimal device tree and serial console are enabled, and it can boot via vendor first stage bootloader.

Quoted 8 lines

---

 arch/riscv/Kconfig                 |  4 ++++
 board/sophgo/milkv_duo/Kconfig     | 28 ++++++++++++++++++++++++++++
 board/sophgo/milkv_duo/MAINTAINERS |  6 ++++++
 board/sophgo/milkv_duo/Makefile    |  5 +++++
 board/sophgo/milkv_duo/board.c     |  9 +++++++++
 include/configs/milkv_duo.h        | 16 ++++++++++++++++

The defconfig patch should be folded in to this one.

[snip]

Quoted 6 lines
board/sophgo/milkv_duo/board.c new file +0 -0
new file mode 100644
index 0000000000..eaa47be173

board/sophgo/milkv_duo/board.c line 9

Quoted 9 lines
board/sophgo/milkv_duo/board.c new file +9 -0
@@ -0,0 +1,9 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Copyright (c) 2024, Kongyang Liu <[email protected]>
+ */
+
+int board_init(void)
+{
+	return 0;
+}

Shouldn't you enable caches here?

Quoted 10 lines
include/configs/milkv_duo.h new file +4 -0
new file mode 100644
index 0000000000..dd1d146c50
@@ -0,0 +1,16 @@
+/* SPDX-License-Identifier: GPL-2.0+ */
+/*
+ * Copyright (c) 2024, Kongyang Liu <[email protected]>
+ *

include/configs/milkv_duo.h line 14

Quoted 10 lines
include/configs/milkv_duo.h new file +10 -0
+ */
+
+#ifndef __CONFIG_H
+#define __CONFIG_H
+
+#define CFG_SYS_SDRAM_BASE         0x80000000
+
+#define CFG_EXTRA_ENV_SETTINGS                 \
+	"consoledev=ttyS0"                         \
+	"baudrate=115200\0"                        \

We shouldn't need to set baudrate, it will be handled for us. Is consoledev something that must be set? Can it all be done in a plain text environment anyhow? Thanks.

Signature · 1 line
Tom
author
#3 lore raw

Re: [PATCH 1/4] riscv: sophgo: milkv_duo: initial support added

Quoted 11 lines · Tom Rini <[email protected]> 于2024年1月9日周二 04:42写道:
Quoted 8 lines · Kongyang Liu

Add support for Sophgo's Milk-V Duo board, only minimal device tree and serial console are enabled, and it can boot via vendor first stage bootloader.

---

Quoted 9 lines
Quoted 6 lines
 arch/riscv/Kconfig                 |  4 ++++
 board/sophgo/milkv_duo/Kconfig     | 28 ++++++++++++++++++++++++++++
 board/sophgo/milkv_duo/MAINTAINERS |  6 ++++++
 board/sophgo/milkv_duo/Makefile    |  5 +++++
 board/sophgo/milkv_duo/board.c     |  9 +++++++++
 include/configs/milkv_duo.h        | 16 ++++++++++++++++

The defconfig patch should be folded in to this one.

I will fold it in next version.

Quoted 10 lines

[snip]

Quoted 9 lines
board/sophgo/milkv_duo/board.c new file +3 -0
new file mode 100644
index 0000000000..eaa47be173
@@ -0,0 +1,9 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Copyright (c) 2024, Kongyang Liu <[email protected]>
Quoted 9 lines

board/sophgo/milkv_duo/board.c line 9

Quoted 6 lines
board/sophgo/milkv_duo/board.c new file +6 -0
+ */
+
+int board_init(void)
+{
+     return 0;
+}

Shouldn't you enable caches here?

Enable caches will cause other problems, and I will implement it in subsequent patches.

Quoted 16 lines
Quoted 16 lines
include/configs/milkv_duo.h new file +10 -0
new file mode 100644
index 0000000000..dd1d146c50
@@ -0,0 +1,16 @@
+/* SPDX-License-Identifier: GPL-2.0+ */
+/*
+ * Copyright (c) 2024, Kongyang Liu <[email protected]>
+ *
+ */
+
+#ifndef __CONFIG_H
+#define __CONFIG_H
+
+#define CFG_SYS_SDRAM_BASE         0x80000000
Quoted 9 lines

include/configs/milkv_duo.h line 14

Quoted 4 lines
include/configs/milkv_duo.h new file +4 -0
+
+#define CFG_EXTRA_ENV_SETTINGS                 \
+     "consoledev=ttyS0"                         \
+     "baudrate=115200\0"                        \

We shouldn't need to set baudrate, it will be handled for us. Is consoledev something that must be set? Can it all be done in a plain text environment anyhow? Thanks.

I will check and detele it if it is unnecessary.

Best regards
Kongyang Liu

Quoted 2 lines

--
Tom

#4 lore raw

PATCH 2/4 riscv: dts: sophgo: Add basic device tree for Milk-V Duo board

In reply to Kongyang Liu

Import device tree from Linux kernel to add basic support for CPU, PLIC, UART and Timer. The name cv1800b in the filename represent the chip used on Milk-V Duo board.

---

 arch/riscv/dts/Makefile              |   1 +
 arch/riscv/dts/cv1800b-milkv-duo.dts |  38 +++++++++
 arch/riscv/dts/cv1800b.dtsi          | 123 +++++++++++++++++++++++++++
 3 files changed, 162 insertions(+)
 create mode 100644 arch/riscv/dts/cv1800b-milkv-duo.dts
 create mode 100644 arch/riscv/dts/cv1800b.dtsi
arch/riscv/dts/Makefile +1 -0
index be6c8a4227..b9e1678676 100644
@@ -2,6 +2,7 @@
 
 dtb-$(CONFIG_TARGET_ANDES_AE350) += ae350_32.dtb ae350_64.dtb
 dtb-$(CONFIG_TARGET_MICROCHIP_ICICLE) += mpfs-icicle-kit.dtb
+dtb-$(CONFIG_TARGET_MILKV_DUO) += cv1800b-milkv-duo.dtb
 dtb-$(CONFIG_TARGET_QEMU_VIRT) += qemu-virt32.dtb qemu-virt64.dtb
 dtb-$(CONFIG_TARGET_OPENPITON_RISCV64) += openpiton-riscv64.dtb
 dtb-$(CONFIG_TARGET_SIFIVE_UNLEASHED) += hifive-unleashed-a00.dtb
arch/riscv/dts/cv1800b-milkv-duo.dts new file +38 -0
new file mode 100644
index 0000000000..3af9e34b3b
@@ -0,0 +1,38 @@
+// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+/*
+ * Copyright (C) 2023 Jisheng Zhang <[email protected]>
+ */
+
+/dts-v1/;
+
+#include "cv1800b.dtsi"
+
+/ {
+	model = "Milk-V Duo";
+	compatible = "milkv,duo", "sophgo,cv1800b";
+
+	aliases {
+		serial0 = &uart0;
+		serial1 = &uart1;
+		serial2 = &uart2;
+		serial3 = &uart3;
+		serial4 = &uart4;
+	};
+
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+
+	memory@80000000 {
+		device_type = "memory";
+		reg = <0x80000000 0x3f40000>;
+	};
+};
+
+&osc {
+	clock-frequency = <25000000>;
+};
+
+&uart0 {
+	status = "okay";
+};
arch/riscv/dts/cv1800b.dtsi new file +123 -0

123 lines not on this page · raw message

Signature · 1 line
2.41.0
#5 lore raw

PATCH 3/4 configs: milkv_duo_defconfig: Add initial config

In reply to Kongyang Liu

Add basic config for Milk-V Duo board which make it capable of booting into serial console.

---

 configs/milkv_duo_defconfig | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)
 create mode 100644 configs/milkv_duo_defconfig
configs/milkv_duo_defconfig new file +24 -0
new file mode 100644
index 0000000000..c4782639ef
@@ -0,0 +1,24 @@
+CONFIG_RISCV=y
+CONFIG_SYS_MALLOC_LEN=0x820000
+CONFIG_SYS_MALLOC_F_LEN=0x2000
+CONFIG_NR_DRAM_BANKS=1
+CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y
+CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0x82300000
+CONFIG_DEFAULT_DEVICE_TREE="cv1800b-milkv-duo"
+CONFIG_IDENT_STRING="milkv_duo"
+CONFIG_SYS_LOAD_ADDR=0x80080000
+CONFIG_TARGET_MILKV_DUO=y
+CONFIG_ARCH_RV64I=y
+CONFIG_RISCV_SMODE=y
+CONFIG_FIT=y
+CONFIG_SUPPORT_RAW_INITRD=y
+CONFIG_HUSH_PARSER=y
+CONFIG_SYS_PROMPT="milkv_duo# "
+CONFIG_SYS_MAXARGS=64
+CONFIG_SYS_CBSIZE=512
+CONFIG_SYS_PBSIZE=544
+CONFIG_SYS_BOOTM_LEN=0x4000000
+CONFIG_ENV_OVERWRITE=y
+CONFIG_SYS_NS16550=y
+CONFIG_SYS_NS16550_MEM32=y
+# CONFIG_EFI_LOADER is not set
Signature · 1 line
2.41.0
#6 lore raw

PATCH 4/4 doc: sophgo: milkv_duo: document Milk-V Duo board

In reply to Kongyang Liu

Add document for Milk-V Duo board which based on Sophgo's CV1800B SoC.

---

 doc/board/index.rst            |  1 +
 doc/board/sophgo/index.rst     |  8 ++++++
 doc/board/sophgo/milkv_duo.rst | 50 ++++++++++++++++++++++++++++++++++
 3 files changed, 59 insertions(+)
 create mode 100644 doc/board/sophgo/index.rst
 create mode 100644 doc/board/sophgo/milkv_duo.rst
doc/board/index.rst +1 -0
index 531e547e7e..a0bd534742 100644
@@ -45,6 +45,7 @@ Board-specific doc
    sifive/index
    sipeed/index
    socionext/index
+   sophgo/index
    st/index
    starfive/index
    ste/index
doc/board/sophgo/index.rst new file +8 -0
new file mode 100644
index 0000000000..e097afdac6
@@ -0,0 +1,8 @@
+.. SPDX-License-Identifier: GPL-2.0+
+
+Sophgo
+======
+.. toctree::
+   :maxdepth: 1
+
+   milkv_duo
doc/board/sophgo/milkv_duo.rst new file +50 -0

50 lines not on this page · raw message

Signature · 1 line
2.41.0