Skip to contentSkip to conversation

drm/vmwgfx: Add SVGA_3D_CMD_DEFINE_GB_SURFACE_V4 to command array.

PATCH In review Ian Forbes 2 participants 2 messages Jan 8, 2024 – Jan 10, 2024

Subsystems (3)
lore
Share & tools
lore

Ian Forbes

author
#0 lore raw

PATCH 1/1 drm/vmwgfx: Add SVGA_3D_CMD_DEFINE_GB_SURFACE_V4 to command array.

Without this definition device errors will display the command name as (null) when debug logging is enabled.

---
 drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c +2 -0
index 36987ef3fc30..472c4821528f 100644
@@ -3603,6 +3603,8 @@ static const struct vmw_cmd_entry vmw_cmd_entries[SVGA_3D_CMD_MAX] = {
 		    &vmw_cmd_dx_bind_streamoutput, true, false, true),
 	VMW_CMD_DEF(SVGA_3D_CMD_DX_DEFINE_RASTERIZER_STATE_V2,
 		    &vmw_cmd_dx_so_define, true, false, true),
+	VMW_CMD_DEF(SVGA_3D_CMD_DEFINE_GB_SURFACE_V4,
+		    &vmw_cmd_invalid, false, false, true),
 };
 
 bool vmw_cmd_describe(const void *buf, u32 *size, char const **cmd)
Signature · 1 line
2.34.1
maintainer
#1 lore raw
Quoted 23 lines · Ian Forbes

Without this definition device errors will display the command name as (null) when debug logging is enabled.

---
 drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c +2 -1
index 36987ef3fc30..472c4821528f 100644
@@ -3603,6 +3603,8 @@ static const struct vmw_cmd_entry vmw_cmd_entries[SVGA_3D_CMD_MAX] = {
                    &vmw_cmd_dx_bind_streamoutput, true, false, true),
        VMW_CMD_DEF(SVGA_3D_CMD_DX_DEFINE_RASTERIZER_STATE_V2,
                    &vmw_cmd_dx_so_define, true, false, true),
+       VMW_CMD_DEF(SVGA_3D_CMD_DEFINE_GB_SURFACE_V4,
+                   &vmw_cmd_invalid, false, false, true),
 };
 
 bool vmw_cmd_describe(const void *buf, u32 *size, char const **cmd)
--
Quoted 2 lines

2.34.1

Looks good, but in the future you want to both find the change that initially added SVGA_3D_CMD_DEFINE_GB_SURFACE_V4 and do "dim fixes" to get the proper "Fixes:..." line to add to the commit description and either use ./scripts/get_maintainer.pl or at least make sure the maintainers are included in the patch by hand.

z