Skip to contentSkip to conversation

lib/intel_cmds_info: Add MEM_COPY/SET support for Lunarlake

PATCH In review [email protected] 4 participants 5 messages Jan 9, 2024 – Jan 11, 2024 Library code

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 lib/intel_cmds_info: Add MEM_COPY/SET support for Lunarlake

From: Sai Gowtham Ch <[email protected]>

Enable MEM_COPY/SET instructions support for Lunarlake, which allows to validate MEM_COPY/SET tests.

---
 lib/intel_cmds_info.c | 2 ++
 1 file changed, 2 insertions(+)
lib/intel_cmds_info.c +2 -0
index 56073bd6d..669d3e500 100644
@@ -182,6 +182,8 @@ const struct intel_cmds_info xe2_cmds_info  = {
 	.blt_cmds = {
 		[XY_FAST_COPY] = &dg2_xy_fast_copy,
 		[XY_BLOCK_COPY] = &xe2_xy_block_copy,
+		[MEM_COPY] = &pvc_mem_copy,
+		[MEM_SET] = &pvc_mem_set,
 	}
 };
 
Signature · 1 line
2.39.1
#1 lore raw

✗ Fi.CI.BAT: failure for lib/intel_cmds_info: Add MEM_COPY/SET support for Lunarlake

== Series Details ==

== Series Details ==

Series: lib/intel_cmds_info: Add MEM_COPY/SET support for Lunarlake
URL : https://patchwork.freedesktop.org/series/128359/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_14100 -> IGTPW_10492
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with IGTPW_10492 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes
introduced in IGTPW_10492, please notify your bug team ([email protected]) to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10492/index.html

Participating hosts (38 -> 35)
------------------------------

Missing (3): bat-dg2-8 fi-snb-2520m fi-bsw-n3050

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_10492:

### IGT changes ###

#### Possible regressions ####

* igt@i915_selftest@live@hangcheck:
- fi-skl-guc: [PASS][1] -> [DMESG-FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14100/fi-skl-guc/igt@i915_selftest@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10492/fi-skl-guc/igt@i915_selftest@[email protected]

Known issues
------------

Here are the changes found in IGTPW_10492 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@debugfs_test@basic-hwmon:
- bat-jsl-1: NOTRUN -> [SKIP][3] ([i915#9318])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10492/bat-jsl-1/igt@[email protected]

* igt@gem_huc_copy@huc-copy:
- bat-jsl-1: NOTRUN -> [SKIP][4] ([i915#2190])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10492/bat-jsl-1/igt@[email protected]

* igt@gem_lmem_swapping@verify-random:
- bat-jsl-1: NOTRUN -> [SKIP][5] ([i915#4613]) +3 other tests skip
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10492/bat-jsl-1/igt@[email protected]

* igt@i915_suspend@basic-s3-without-i915:
- bat-atsm-1: NOTRUN -> [SKIP][6] ([i915#6645])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10492/bat-atsm-1/igt@[email protected]

* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- bat-jsl-1: NOTRUN -> [SKIP][7] ([i915#4103]) +1 other test skip
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10492/bat-jsl-1/igt@[email protected]

* igt@kms_dsc@dsc-basic:
- bat-jsl-1: NOTRUN -> [SKIP][8] ([i915#3555] / [i915#9886])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10492/bat-jsl-1/igt@[email protected]

* igt@kms_force_connector_basic@force-load-detect:
- bat-jsl-1: NOTRUN -> [SKIP][9] ([fdo#109285])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10492/bat-jsl-1/igt@[email protected]

* igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1:
- bat-rplp-1: [PASS][10] -> [ABORT][11] ([i915#8668] / [i915#9368])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14100/bat-rplp-1/igt@kms_pipe_crc_basic@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10492/bat-rplp-1/igt@kms_pipe_crc_basic@[email protected]

* igt@kms_pipe_crc_basic@suspend-read-crc:
- bat-atsm-1: NOTRUN -> [SKIP][12] ([i915#1836])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10492/bat-atsm-1/igt@[email protected]

* igt@kms_setmode@basic-clone-single-crtc:
- bat-jsl-1: NOTRUN -> [SKIP][13] ([i915#3555])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10492/bat-jsl-1/igt@[email protected]

#### Possible fixes ####

* igt@i915_selftest@live@hangcheck:
- bat-atsm-1: [INCOMPLETE][14] -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14100/bat-atsm-1/igt@i915_selftest@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10492/bat-atsm-1/igt@i915_selftest@[email protected]

[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[i915#1836]: https://gitlab.freedesktop.org/drm/intel/issues/1836
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#6645]: https://gitlab.freedesktop.org/drm/intel/issues/6645
[i915#8668]: https://gitlab.freedesktop.org/drm/intel/issues/8668
[i915#9318]: https://gitlab.freedesktop.org/drm/intel/issues/9318
[i915#9368]: https://gitlab.freedesktop.org/drm/intel/issues/9368
[i915#9886]: https://gitlab.freedesktop.org/drm/intel/issues/9886

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_7663 -> IGTPW_10492

CI-20190529: 20190529
CI_DRM_14100: 88035acade648815ca1e0c27c44abd96b258c7e7 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_10492: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10492/index.html
IGT_7663: b5eca7b97430309e320874594feaeaa8e770e25e @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

Testlist changes
----------------

-igt@xe_live_ktest@mocs

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10492/index.html

#2 lore raw

✓ CI.xeBAT: success for lib/intel_cmds_info: Add MEM_COPY/SET support for Lunarlake

In reply to [email protected]
== Series Details ==

== Series Details ==

Series: lib/intel_cmds_info: Add MEM_COPY/SET support for Lunarlake
URL : https://patchwork.freedesktop.org/series/128359/
State : success

== Summary ==

CI Bug Log - changes from XEIGT_7663_BAT -> XEIGTPW_10492_BAT
====================================================

Summary
-------

**SUCCESS**

No regressions found.

Participating hosts (4 -> 4)
------------------------------

No changes in participating hosts

Known issues
------------

Here are the changes found in XEIGTPW_10492_BAT that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@kms_flip@basic-flip-vs-wf_vblank@c-edp1:
- bat-adlp-7: [PASS][1] -> [FAIL][2] ([Intel XE#480])
[1]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7663/bat-adlp-7/igt@kms_flip@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10492/bat-adlp-7/igt@kms_flip@[email protected]

* igt@kms_frontbuffer_tracking@basic:
- bat-adlp-7: [PASS][3] -> [DMESG-FAIL][4] ([Intel XE#1033])
[3]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7663/bat-adlp-7/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10492/bat-adlp-7/igt@[email protected]

#### Possible fixes ####

* igt@kms_flip@basic-flip-vs-wf_vblank@a-edp1:
- bat-adlp-7: [FAIL][5] ([Intel XE#480]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7663/bat-adlp-7/igt@kms_flip@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10492/bat-adlp-7/igt@kms_flip@[email protected]

* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12:
- bat-dg2-oem2: [FAIL][7] ([Intel XE#400] / [Intel XE#616]) -> [PASS][8] +2 other tests pass
[7]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7663/bat-dg2-oem2/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10492/bat-dg2-oem2/igt@[email protected]

* igt@xe_prime_self_import@basic-with_one_bo:
- bat-atsm-2: [FAIL][9] ([Intel XE#999]) -> [PASS][10] +1 other test pass
[9]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7663/bat-atsm-2/igt@xe_prime_self_import@basic-with_one_bo.html
[10]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10492/bat-atsm-2/igt@xe_prime_self_import@basic-with_one_bo.html
- bat-pvc-2: [FAIL][11] ([Intel XE#999]) -> [PASS][12] +1 other test pass
[11]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7663/bat-pvc-2/igt@xe_prime_self_import@basic-with_one_bo.html
[12]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10492/bat-pvc-2/igt@xe_prime_self_import@basic-with_one_bo.html

[Intel XE#1033]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1033
[Intel XE#400]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/400
[Intel XE#480]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/480
[Intel XE#616]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/616
[Intel XE#999]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/999

Build changes
-------------

* IGT: IGT_7663 -> IGTPW_10492
* Linux: xe-604-a3e6b7b90ce1ff725d7585cbd2c9279e6e39b914 -> xe-607-eacbcdb537a2774959d012206aba22848fdade26

IGTPW_10492: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10492/index.html
IGT_7663: b5eca7b97430309e320874594feaeaa8e770e25e @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
xe-604-a3e6b7b90ce1ff725d7585cbd2c9279e6e39b914: a3e6b7b90ce1ff725d7585cbd2c9279e6e39b914 xe-607-eacbcdb537a2774959d012206aba22848fdade26: eacbcdb537a2774959d012206aba22848fdade26

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10492/index.html

Reviewed-by on v1 1/1
#3 lore raw
In reply to [email protected]
Quoted 26 lines · On Tue, Jan 09, 2024 at 03:26:02PM +0530, [email protected] wrote:

From: Sai Gowtham Ch <[email protected]>

Enable MEM_COPY/SET instructions support for Lunarlake, which allows to validate MEM_COPY/SET tests.

---
 lib/intel_cmds_info.c | 2 ++
 1 file changed, 2 insertions(+)
lib/intel_cmds_info.c +2 -0
index 56073bd6d..669d3e500 100644
@@ -182,6 +182,8 @@ const struct intel_cmds_info xe2_cmds_info  = {
 	.blt_cmds = {
 		[XY_FAST_COPY] = &dg2_xy_fast_copy,
 		[XY_BLOCK_COPY] = &xe2_xy_block_copy,
+		[MEM_COPY] = &pvc_mem_copy,
+		[MEM_SET] = &pvc_mem_set,
 	}
 };
 
Signature · 1 line
2.39.1

Looks good and works fine:

--
Zbigniew

Acked-by on v1 1/1
#4 lore raw
In reply to [email protected]
Quoted 11 lines

-----Original Message-----
From: igt-dev <[email protected]> On Behalf Of [email protected]
Sent: Tuesday, January 9, 2024 3:26 PM
To: [email protected]; Ch, Sai Gowtham <[email protected]>
Subject: [PATCH i-g-t] lib/intel_cmds_info: Add MEM_COPY/SET support for Lunarlake

Quoted 6 lines

From: Sai Gowtham Ch <[email protected]>

Enable MEM_COPY/SET instructions support for Lunarlake, which allows to validate MEM_COPY/SET tests.

Thanks,
Rahul

Quoted 19 lines
---
 lib/intel_cmds_info.c | 2 ++
 1 file changed, 2 insertions(+)
lib/intel_cmds_info.c index renamed from lib/intel_cmds_info.c +0 -0

56073bd6d..669d3e500 100644

lib/intel_cmds_info.c +2 -1
@@ -182,6 +182,8 @@ const struct intel_cmds_info xe2_cmds_info  = {
 	.blt_cmds = {
 		[XY_FAST_COPY] = &dg2_xy_fast_copy,
 		[XY_BLOCK_COPY] = &xe2_xy_block_copy,
+		[MEM_COPY] = &pvc_mem_copy,
+		[MEM_SET] = &pvc_mem_set,
 	}
 };
 
--

2.39.1