Skip to contentSkip to conversation

MAINTAINERS: add Yosry Ahmed as a zswap reviewer

PATCH In review Yosry Ahmed 6 participants 12 messages Jan 9, 2024 – Jan 17, 2024 Memory management

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 MAINTAINERS: add Yosry Ahmed as a zswap reviewer

I have been actively contributing to zswap and reviewing zswap patches for a while, and I am already getting CC'd on most of them. Add myself as a reviewer. While we are at it, add missing zswap files to the entry in MAINTAINERS.

---
 MAINTAINERS | 3 +++
 1 file changed, 3 insertions(+)
MAINTAINERS +3 -0
index f71c525405e02..c00224777babb 100644
@@ -24125,8 +24125,11 @@ ZSWAP COMPRESSED SWAP CACHING
 M:	Seth Jennings <[email protected]>
 M:	Dan Streetman <[email protected]>
 M:	Vitaly Wool <[email protected]>
+R:	Yosry Ahmed <[email protected]>
 L:	[email protected]
 S:	Maintained
+F:	Documentation/admin-guide/mm/zswap.rst
+F:	include/linux/zswap.h
 F:	mm/zswap.c
 
 THE REST
Signature · 1 line
2.43.0.275.g3460e3d667-goog
Acked-by on v1 1/1
#1 lore raw
Quoted 6 lines · Yosry Ahmed

I have been actively contributing to zswap and reviewing zswap patches for a while, and I am already getting CC'd on most of them. Add myself as a reviewer. While we are at it, add missing zswap files to the entry in MAINTAINERS.

because I agree with what you're saying. However, I think that maintainers entry could use some more help. You, me and Nhat have been doing most of the recent development and reviewing of changes in that space. Those patches have been largely met with radio silence by the existing maintainers, which makes me think the folks currently listed have moved on to other projects and/or aren't able to spend as many cycles on zswap anymore. Maybe it's time to update the list?

get_maintainers.pl says this:

  [hannes@column linux]$ ./scripts/get_maintainer.pl --git -f mm/zswap.c
  Johannes Weiner <[email protected]> (maintainer:ZSWAP COMPRESSED SWAP CACHING,commit_signer:14/29=48%,authored:5/29=17%,added_lines:121/551=22%,removed_lines:192/440=44%)
  Yosry Ahmed <[email protected]> (maintainer:ZSWAP COMPRESSED SWAP CACHING,commit_signer:11/29=38%,authored:3/29=10%,added_lines:86/551=16%,removed_lines:44/440=10%)
  Nhat Pham <[email protected]> (maintainer:ZSWAP COMPRESSED SWAP CACHING,commit_signer:9/29=31%)

How about the below? Dan, Seth, Vitaly, what do you think?

Thanks

---

From 9170b8a17029550bac6b315edbd0db21504ec5d3 Mon Sep 17 00:00:00 2001
From: Johannes Weiner <[email protected]>
Date: Tue, 9 Jan 2024 13:50:53 -0500
Subject: [PATCH] mm: zswap: switch maintainers to recently active developers
and reviewers

---
 MAINTAINERS | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
MAINTAINERS +5 -3
index f71c525405e0..b65538e85e9c 100644
@@ -24122,11 +24122,13 @@ N:	zstd
 K:	zstd
 
 ZSWAP COMPRESSED SWAP CACHING
-M:	Seth Jennings <[email protected]>
-M:	Dan Streetman <[email protected]>
-M:	Vitaly Wool <[email protected]>
+M:	Johannes Weiner <[email protected]>
+M:	Yosry Ahmed <[email protected]>
+M:	Nhat Pham <[email protected]>
 L:	[email protected]
 S:	Maintained
+F:	Documentation/admin-guide/mm/zswap.rst
+F:	include/linux/zswap.h
 F:	mm/zswap.c
 
 THE REST
Signature · 1 line
2.43.0
Acked-by
#2 lore raw
Quoted 11 lines · Johannes Weiner
Quoted 6 lines · Yosry Ahmed

I have been actively contributing to zswap and reviewing zswap patches for a while, and I am already getting CC'd on most of them. Add myself as a reviewer. While we are at it, add missing zswap files to the entry in MAINTAINERS.

Quoted 7 lines

because I agree with what you're saying. However, I think that maintainers entry could use some more help. You, me and Nhat have been doing most of the recent development and reviewing of changes in that space. Those patches have been largely met with radio silence by the existing maintainers, which makes me think the folks currently listed have moved on to other projects and/or aren't able to spend as many cycles on zswap anymore. Maybe it's time to update the list?

Agree. We've been working on zswap + cc-ed for code review for awhile now. Might as well make it official :)

Quoted 14 lines

get_maintainers.pl says this:

  [hannes@column linux]$ ./scripts/get_maintainer.pl --git -f mm/zswap.c
  Johannes Weiner <[email protected]> (maintainer:ZSWAP COMPRESSED SWAP CACHING,commit_signer:14/29=48%,authored:5/29=17%,added_lines:121/551=22%,removed_lines:192/440=44%)
  Yosry Ahmed <[email protected]> (maintainer:ZSWAP COMPRESSED SWAP CACHING,commit_signer:11/29=38%,authored:3/29=10%,added_lines:86/551=16%,removed_lines:44/440=10%)
  Nhat Pham <[email protected]> (maintainer:ZSWAP COMPRESSED SWAP CACHING,commit_signer:9/29=31%)

How about the below? Dan, Seth, Vitaly, what do you think?

Thanks

---

Quoted 7 lines

From 9170b8a17029550bac6b315edbd0db21504ec5d3 Mon Sep 17 00:00:00 2001
From: Johannes Weiner <[email protected]>
Date: Tue, 9 Jan 2024 13:50:53 -0500
Subject: [PATCH] mm: zswap: switch maintainers to recently active developers
and reviewers

Quoted 27 lines
---
 MAINTAINERS | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
MAINTAINERS +5 -4
index f71c525405e0..b65538e85e9c 100644
@@ -24122,11 +24122,13 @@ N:    zstd
 K:     zstd
 
 ZSWAP COMPRESSED SWAP CACHING
-M:     Seth Jennings <[email protected]>
-M:     Dan Streetman <[email protected]>
-M:     Vitaly Wool <[email protected]>
+M:     Johannes Weiner <[email protected]>
+M:     Yosry Ahmed <[email protected]>
+M:     Nhat Pham <[email protected]>
 L:     [email protected]
 S:     Maintained
+F:     Documentation/admin-guide/mm/zswap.rst
+F:     include/linux/zswap.h
 F:     mm/zswap.c
 
 THE REST
--

2.43.0

#3 lore raw
In reply to Johannes Weiner
Quoted 19 lines · Johannes Weiner
Quoted 6 lines · Yosry Ahmed

I have been actively contributing to zswap and reviewing zswap patches for a while, and I am already getting CC'd on most of them. Add myself as a reviewer. While we are at it, add missing zswap files to the entry in MAINTAINERS.

because I agree with what you're saying. However, I think that maintainers entry could use some more help. You, me and Nhat have been doing most of the recent development and reviewing of changes in that space. Those patches have been largely met with radio silence by the existing maintainers, which makes me think the folks currently listed have moved on to other projects and/or aren't able to spend as many cycles on zswap anymore. Maybe it's time to update the list?

Quoted 8 lines

get_maintainers.pl says this:

  [hannes@column linux]$ ./scripts/get_maintainer.pl --git -f mm/zswap.c
  Johannes Weiner <[email protected]> (maintainer:ZSWAP COMPRESSED SWAP CACHING,commit_signer:14/29=48%,authored:5/29=17%,added_lines:121/551=22%,removed_lines:192/440=44%)
  Yosry Ahmed <[email protected]> (maintainer:ZSWAP COMPRESSED SWAP CACHING,commit_signer:11/29=38%,authored:3/29=10%,added_lines:86/551=16%,removed_lines:44/440=10%)
  Nhat Pham <[email protected]> (maintainer:ZSWAP COMPRESSED SWAP CACHING,commit_signer:9/29=31%)

How about the below? Dan, Seth, Vitaly, what do you think?

Speaking only for myself of course, ACK to the below; obviously I haven't been doing any zswap maintaining for a long while. Thanks to you all for continuing to develop and maintain it!

Quoted 39 lines

Thanks

---

From 9170b8a17029550bac6b315edbd0db21504ec5d3 Mon Sep 17 00:00:00 2001
From: Johannes Weiner <[email protected]>
Date: Tue, 9 Jan 2024 13:50:53 -0500
Subject: [PATCH] mm: zswap: switch maintainers to recently active developers
and reviewers

---
 MAINTAINERS | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
MAINTAINERS +5 -4
index f71c525405e0..b65538e85e9c 100644
@@ -24122,11 +24122,13 @@ N:    zstd
 K:     zstd
 
 ZSWAP COMPRESSED SWAP CACHING
-M:     Seth Jennings <[email protected]>
-M:     Dan Streetman <[email protected]>
-M:     Vitaly Wool <[email protected]>
+M:     Johannes Weiner <[email protected]>
+M:     Yosry Ahmed <[email protected]>
+M:     Nhat Pham <[email protected]>
 L:     [email protected]
 S:     Maintained
+F:     Documentation/admin-guide/mm/zswap.rst
+F:     include/linux/zswap.h
 F:     mm/zswap.c
 
 THE REST
--

2.43.0

Acked-by
#4 lore raw
In reply to Johannes Weiner
Quoted 52 lines · Johannes Weiner
Quoted 6 lines · Yosry Ahmed

I have been actively contributing to zswap and reviewing zswap patches for a while, and I am already getting CC'd on most of them. Add myself as a reviewer. While we are at it, add missing zswap files to the entry in MAINTAINERS.

because I agree with what you're saying. However, I think that maintainers entry could use some more help. You, me and Nhat have been doing most of the recent development and reviewing of changes in that space. Those patches have been largely met with radio silence by the existing maintainers, which makes me think the folks currently listed have moved on to other projects and/or aren't able to spend as many cycles on zswap anymore. Maybe it's time to update the list?

get_maintainers.pl says this:

  [hannes@column linux]$ ./scripts/get_maintainer.pl --git -f mm/zswap.c
  Johannes Weiner <[email protected]> (maintainer:ZSWAP COMPRESSED SWAP CACHING,commit_signer:14/29=48%,authored:5/29=17%,added_lines:121/551=22%,removed_lines:192/440=44%)
  Yosry Ahmed <[email protected]> (maintainer:ZSWAP COMPRESSED SWAP CACHING,commit_signer:11/29=38%,authored:3/29=10%,added_lines:86/551=16%,removed_lines:44/440=10%)
  Nhat Pham <[email protected]> (maintainer:ZSWAP COMPRESSED SWAP CACHING,commit_signer:9/29=31%)

How about the below? Dan, Seth, Vitaly, what do you think?

Thanks

---

From 9170b8a17029550bac6b315edbd0db21504ec5d3 Mon Sep 17 00:00:00 2001
From: Johannes Weiner <[email protected]>
Date: Tue, 9 Jan 2024 13:50:53 -0500
Subject: [PATCH] mm: zswap: switch maintainers to recently active developers
and reviewers

---
 MAINTAINERS | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
MAINTAINERS +0 -1
index f71c525405e0..b65538e85e9c 100644
@@ -24122,11 +24122,13 @@ N:    zstd
 K:     zstd
 
 ZSWAP COMPRESSED SWAP CACHING
-M:     Seth Jennings <[email protected]>

MAINTAINERS N: zstd · line 24132

Quoted 10 lines
MAINTAINERS +5 -2
-M:     Dan Streetman <[email protected]>
-M:     Vitaly Wool <[email protected]>
+M:     Johannes Weiner <[email protected]>
+M:     Yosry Ahmed <[email protected]>
+M:     Nhat Pham <[email protected]>
 L:     [email protected]
 S:     Maintained
+F:     Documentation/admin-guide/mm/zswap.rst
+F:     include/linux/zswap.h
 F:     mm/zswap.c

Sorry I should have used the proper ack:

Quoted 4 lines
MAINTAINERS +0 -1
 THE REST
--

2.43.0

#5 lore raw
In reply to Johannes Weiner
Quoted 1 line

How about the below? Dan, Seth, Vitaly, what do you think?

Fine with me as well. Happy to see others continuing to develop on this!

Quoted 67 lines · Johannes Weiner
Quoted 6 lines · Yosry Ahmed

I have been actively contributing to zswap and reviewing zswap patches for a while, and I am already getting CC'd on most of them. Add myself as a reviewer. While we are at it, add missing zswap files to the entry in MAINTAINERS.

because I agree with what you're saying. However, I think that maintainers entry could use some more help. You, me and Nhat have been doing most of the recent development and reviewing of changes in that space. Those patches have been largely met with radio silence by the existing maintainers, which makes me think the folks currently listed have moved on to other projects and/or aren't able to spend as many cycles on zswap anymore. Maybe it's time to update the list?

get_maintainers.pl says this:

  [hannes@column linux]$ ./scripts/get_maintainer.pl --git -f mm/zswap.c
  Johannes Weiner <[email protected]> (maintainer:ZSWAP COMPRESSED SWAP CACHING,commit_signer:14/29=48%,authored:5/29=17%,added_lines:121/551=22%,removed_lines:192/440=44%)
  Yosry Ahmed <[email protected]> (maintainer:ZSWAP COMPRESSED SWAP CACHING,commit_signer:11/29=38%,authored:3/29=10%,added_lines:86/551=16%,removed_lines:44/440=10%)
  Nhat Pham <[email protected]> (maintainer:ZSWAP COMPRESSED SWAP CACHING,commit_signer:9/29=31%)

How about the below? Dan, Seth, Vitaly, what do you think?

Thanks

---

From 9170b8a17029550bac6b315edbd0db21504ec5d3 Mon Sep 17 00:00:00 2001
From: Johannes Weiner <[email protected]>
Date: Tue, 9 Jan 2024 13:50:53 -0500
Subject: [PATCH] mm: zswap: switch maintainers to recently active developers
and reviewers

---
 MAINTAINERS | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
MAINTAINERS +5 -4
index f71c525405e0..b65538e85e9c 100644
@@ -24122,11 +24122,13 @@ N:    zstd
 K:     zstd
 
 ZSWAP COMPRESSED SWAP CACHING
-M:     Seth Jennings <[email protected]>
-M:     Dan Streetman <[email protected]>
-M:     Vitaly Wool <[email protected]>
+M:     Johannes Weiner <[email protected]>
+M:     Yosry Ahmed <[email protected]>
+M:     Nhat Pham <[email protected]>
 L:     [email protected]
 S:     Maintained
+F:     Documentation/admin-guide/mm/zswap.rst
+F:     include/linux/zswap.h
 F:     mm/zswap.c
 
 THE REST
--

2.43.0

#6 lore raw
In reply to Johannes Weiner
Quoted 52 lines · Johannes Weiner
Quoted 6 lines · Yosry Ahmed

I have been actively contributing to zswap and reviewing zswap patches for a while, and I am already getting CC'd on most of them. Add myself as a reviewer. While we are at it, add missing zswap files to the entry in MAINTAINERS.

because I agree with what you're saying. However, I think that maintainers entry could use some more help. You, me and Nhat have been doing most of the recent development and reviewing of changes in that space. Those patches have been largely met with radio silence by the existing maintainers, which makes me think the folks currently listed have moved on to other projects and/or aren't able to spend as many cycles on zswap anymore. Maybe it's time to update the list?

get_maintainers.pl says this:

  [hannes@column linux]$ ./scripts/get_maintainer.pl --git -f mm/zswap.c
  Johannes Weiner <[email protected]> (maintainer:ZSWAP COMPRESSED SWAP CACHING,commit_signer:14/29=48%,authored:5/29=17%,added_lines:121/551=22%,removed_lines:192/440=44%)
  Yosry Ahmed <[email protected]> (maintainer:ZSWAP COMPRESSED SWAP CACHING,commit_signer:11/29=38%,authored:3/29=10%,added_lines:86/551=16%,removed_lines:44/440=10%)
  Nhat Pham <[email protected]> (maintainer:ZSWAP COMPRESSED SWAP CACHING,commit_signer:9/29=31%)

How about the below? Dan, Seth, Vitaly, what do you think?

Thanks

---

From 9170b8a17029550bac6b315edbd0db21504ec5d3 Mon Sep 17 00:00:00 2001
From: Johannes Weiner <[email protected]>
Date: Tue, 9 Jan 2024 13:50:53 -0500
Subject: [PATCH] mm: zswap: switch maintainers to recently active developers
and reviewers

---
 MAINTAINERS | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
MAINTAINERS +0 -1
index f71c525405e0..b65538e85e9c 100644
@@ -24122,11 +24122,13 @@ N:    zstd
 K:     zstd
 
 ZSWAP COMPRESSED SWAP CACHING
-M:     Seth Jennings <[email protected]>

MAINTAINERS N: zstd · line 24132

Quoted 10 lines
MAINTAINERS +5 -2
-M:     Dan Streetman <[email protected]>
-M:     Vitaly Wool <[email protected]>
+M:     Johannes Weiner <[email protected]>
+M:     Yosry Ahmed <[email protected]>
+M:     Nhat Pham <[email protected]>
 L:     [email protected]
 S:     Maintained
+F:     Documentation/admin-guide/mm/zswap.rst
+F:     include/linux/zswap.h
 F:     mm/zswap.c

Probably a bit too late, but should we also merge the zpool entry with the zswap entry? I can send a follow up if we are in agreement.

#7 lore raw
Quoted 52 lines · Yosry Ahmed
Quoted 50 lines · Johannes Weiner
Quoted 6 lines · Yosry Ahmed

I have been actively contributing to zswap and reviewing zswap patches for a while, and I am already getting CC'd on most of them. Add myself as a reviewer. While we are at it, add missing zswap files to the entry in MAINTAINERS.

because I agree with what you're saying. However, I think that maintainers entry could use some more help. You, me and Nhat have been doing most of the recent development and reviewing of changes in that space. Those patches have been largely met with radio silence by the existing maintainers, which makes me think the folks currently listed have moved on to other projects and/or aren't able to spend as many cycles on zswap anymore. Maybe it's time to update the list?

get_maintainers.pl says this:

  [hannes@column linux]$ ./scripts/get_maintainer.pl --git -f mm/zswap.c
  Johannes Weiner <[email protected]> (maintainer:ZSWAP COMPRESSED SWAP CACHING,commit_signer:14/29=48%,authored:5/29=17%,added_lines:121/551=22%,removed_lines:192/440=44%)
  Yosry Ahmed <[email protected]> (maintainer:ZSWAP COMPRESSED SWAP CACHING,commit_signer:11/29=38%,authored:3/29=10%,added_lines:86/551=16%,removed_lines:44/440=10%)
  Nhat Pham <[email protected]> (maintainer:ZSWAP COMPRESSED SWAP CACHING,commit_signer:9/29=31%)

How about the below? Dan, Seth, Vitaly, what do you think?

Thanks

---

From 9170b8a17029550bac6b315edbd0db21504ec5d3 Mon Sep 17 00:00:00 2001
From: Johannes Weiner <[email protected]>
Date: Tue, 9 Jan 2024 13:50:53 -0500
Subject: [PATCH] mm: zswap: switch maintainers to recently active developers
and reviewers

---
 MAINTAINERS | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
MAINTAINERS +0 -0
index f71c525405e0..b65538e85e9c 100644
@@ -24122,11 +24122,13 @@ N:    zstd
 K:     zstd
 
Quoted 15 lines

MAINTAINERS N: zstd · line 24132

Quoted 12 lines
MAINTAINERS +5 -3
 ZSWAP COMPRESSED SWAP CACHING
-M:     Seth Jennings <[email protected]>
-M:     Dan Streetman <[email protected]>
-M:     Vitaly Wool <[email protected]>
+M:     Johannes Weiner <[email protected]>
+M:     Yosry Ahmed <[email protected]>
+M:     Nhat Pham <[email protected]>
 L:     [email protected]
 S:     Maintained
+F:     Documentation/admin-guide/mm/zswap.rst
+F:     include/linux/zswap.h
 F:     mm/zswap.c

Probably a bit too late, but should we also merge the zpool entry with the zswap entry? I can send a follow up if we are in agreement.

Sure, if Dan doesn't mind.

Also, maybe we can eventually deprecate that interface too, once we have retired zbud + z3fold and no new allocators are invented after a while? Similar to how frontswap is killed that is.

#8 lore raw
Quoted 70 lines · Nhat Pham
Quoted 52 lines · Yosry Ahmed
Quoted 50 lines · Johannes Weiner
Quoted 6 lines · Yosry Ahmed

I have been actively contributing to zswap and reviewing zswap patches for a while, and I am already getting CC'd on most of them. Add myself as a reviewer. While we are at it, add missing zswap files to the entry in MAINTAINERS.

because I agree with what you're saying. However, I think that maintainers entry could use some more help. You, me and Nhat have been doing most of the recent development and reviewing of changes in that space. Those patches have been largely met with radio silence by the existing maintainers, which makes me think the folks currently listed have moved on to other projects and/or aren't able to spend as many cycles on zswap anymore. Maybe it's time to update the list?

get_maintainers.pl says this:

  [hannes@column linux]$ ./scripts/get_maintainer.pl --git -f mm/zswap.c
  Johannes Weiner <[email protected]> (maintainer:ZSWAP COMPRESSED SWAP CACHING,commit_signer:14/29=48%,authored:5/29=17%,added_lines:121/551=22%,removed_lines:192/440=44%)
  Yosry Ahmed <[email protected]> (maintainer:ZSWAP COMPRESSED SWAP CACHING,commit_signer:11/29=38%,authored:3/29=10%,added_lines:86/551=16%,removed_lines:44/440=10%)
  Nhat Pham <[email protected]> (maintainer:ZSWAP COMPRESSED SWAP CACHING,commit_signer:9/29=31%)

How about the below? Dan, Seth, Vitaly, what do you think?

Thanks

---

From 9170b8a17029550bac6b315edbd0db21504ec5d3 Mon Sep 17 00:00:00 2001
From: Johannes Weiner <[email protected]>
Date: Tue, 9 Jan 2024 13:50:53 -0500
Subject: [PATCH] mm: zswap: switch maintainers to recently active developers
and reviewers

---
 MAINTAINERS | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
MAINTAINERS +0 -0
index f71c525405e0..b65538e85e9c 100644
@@ -24122,11 +24122,13 @@ N:    zstd
 K:     zstd
 
Quoted 15 lines

MAINTAINERS N: zstd · line 24132

Quoted 12 lines
MAINTAINERS +5 -3
 ZSWAP COMPRESSED SWAP CACHING
-M:     Seth Jennings <[email protected]>
-M:     Dan Streetman <[email protected]>
-M:     Vitaly Wool <[email protected]>
+M:     Johannes Weiner <[email protected]>
+M:     Yosry Ahmed <[email protected]>
+M:     Nhat Pham <[email protected]>
 L:     [email protected]
 S:     Maintained
+F:     Documentation/admin-guide/mm/zswap.rst
+F:     include/linux/zswap.h
 F:     mm/zswap.c

Probably a bit too late, but should we also merge the zpool entry with the zswap entry? I can send a follow up if we are in agreement.

Quoted 1 line

Sure, if Dan doesn't mind.

Yep fine with me. Thanks!

Quoted 4 lines

Also, maybe we can eventually deprecate that interface too, once we have retired zbud + z3fold and no new allocators are invented after a while? Similar to how frontswap is killed that is.

#9 lore raw
In reply to Yosry Ahmed

Den sön 14 jan. 2024 19:54Yosry Ahmed <[email protected]> skrev:

Quoted 52 lines · Johannes Weiner
Quoted 50 lines · Yosry Ahmed
Quoted 6 lines

I have been actively contributing to zswap and reviewing zswap patches for a while, and I am already getting CC'd on most of them. Add myself as a reviewer. While we are at it, add missing zswap files to the entry in MAINTAINERS.

because I agree with what you're saying. However, I think that maintainers entry could use some more help. You, me and Nhat have been doing most of the recent development and reviewing of changes in that space. Those patches have been largely met with radio silence by the existing maintainers, which makes me think the folks currently listed have moved on to other projects and/or aren't able to spend as many cycles on zswap anymore. Maybe it's time to update the list?

get_maintainers.pl says this:

  [hannes@column linux]$ ./scripts/get_maintainer.pl --git -f mm/zswap.c
  Johannes Weiner <[email protected]> (maintainer:ZSWAP COMPRESSED SWAP CACHING,commit_signer:14/29=48%,authored:5/29=17%,added_lines:121/551=22%,removed_lines:192/440=44%)
  Yosry Ahmed <[email protected]> (maintainer:ZSWAP COMPRESSED SWAP CACHING,commit_signer:11/29=38%,authored:3/29=10%,added_lines:86/551=16%,removed_lines:44/440=10%)
  Nhat Pham <[email protected]> (maintainer:ZSWAP COMPRESSED SWAP CACHING,commit_signer:9/29=31%)

How about the below? Dan, Seth, Vitaly, what do you think?

Thanks

---

From 9170b8a17029550bac6b315edbd0db21504ec5d3 Mon Sep 17 00:00:00 2001
From: Johannes Weiner <[email protected]>
Date: Tue, 9 Jan 2024 13:50:53 -0500
Subject: [PATCH] mm: zswap: switch maintainers to recently active developers
and reviewers

---
 MAINTAINERS | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
MAINTAINERS +0 -0
index f71c525405e0..b65538e85e9c 100644
@@ -24122,11 +24122,13 @@ N:    zstd
 K:     zstd
 
Quoted 15 lines

MAINTAINERS N: zstd · line 24132

Quoted 12 lines
MAINTAINERS +5 -3
 ZSWAP COMPRESSED SWAP CACHING
-M:     Seth Jennings <[email protected]>
-M:     Dan Streetman <[email protected]>
-M:     Vitaly Wool <[email protected]>
+M:     Johannes Weiner <[email protected]>
+M:     Yosry Ahmed <[email protected]>
+M:     Nhat Pham <[email protected]>
 L:     [email protected]
 S:     Maintained
+F:     Documentation/admin-guide/mm/zswap.rst
+F:     include/linux/zswap.h
 F:     mm/zswap.c

Probably a bit too late, but should we also merge the zpool entry with the zswap entry? I can send a follow up if we are in agreement.

I am afraid we are not. That would be one more step in the wrong direction.

~Vitaly

#10 lore raw
Quoted 5 lines
Quoted 2 lines

Probably a bit too late, but should we also merge the zpool entry with the zswap entry? I can send a follow up if we are in agreement.

I am afraid we are not. That would be one more step in the wrong direction.

Do you mind elaborating the reason? Zpool is only to abstract the zswap allocators, it makes sense that it is tightly coupled with zswap, no?

#11 lore raw
Quoted 10 lines · Yosry Ahmed
Quoted 6 lines
Quoted 3 lines

Probably a bit too late, but should we also merge the zpool entry with the zswap entry? I can send a follow up if we are in agreement.

I am afraid we are not. That would be one more step in the wrong direction.

Do you mind elaborating the reason? Zpool is only to abstract the zswap allocators, it makes sense that it is tightly coupled with zswap, no?

Hmm, I must admit I misread your sentence. Sorry about that. Please disregard my previous comment, merging zpool with zswap sounds good to me.

~Vitaly