Skip to contentSkip to conversation

drm/amd/pm: Enable smu v13_0_6 eccinfo in firmware query mode

PATCH In review Candice Li 1 participant 2 messages Jan 10, 2024

Subsystems (3)
lore
Share & tools
lore

Candice Li

author
#0 lore raw

PATCH 1/1 drm/amd/pm: Enable smu v13_0_6 eccinfo in firmware query mode

smu v13_0_6 eccinfo is supported in firmware query mode only.

---
 drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c +5 -2
index 4ebc6b421c2cb4..8f78294e4a6195 100644
@@ -2896,8 +2896,11 @@ static int smu_v13_0_6_select_xgmi_plpd_policy(struct smu_context *smu,
 static ssize_t smu_v13_0_6_get_ecc_info(struct smu_context *smu,
 			void *table)
 {
-	/* Support ecc info by default */
-	return 0;
+	struct amdgpu_device *adev = smu->adev;
+	unsigned int error_query_mode;
+
+	return (amdgpu_ras_get_error_query_mode(adev, &error_query_mode) &&
+		error_query_mode == AMDGPU_RAS_FIRMWARE_ERROR_QUERY);
 }
 
 static const struct pptable_funcs smu_v13_0_6_ppt_funcs = {
Signature · 1 line
2.25.1
#1 lore raw

[AMD Official Use Only - General]

Sorry, please ignore the patch.

Thanks,
Candice

-----Original Message-----
From: Li, Candice <[email protected]>
Sent: Wednesday, January 10, 2024 10:11 AM
To: [email protected]
Cc: Li, Candice <[email protected]>
Subject: [PATCH] drm/amd/pm: Enable smu v13_0_6 eccinfo in firmware query mode

smu v13_0_6 eccinfo is supported in firmware query mode only.

---
 drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c +5 -2
index 4ebc6b421c2cb4..8f78294e4a6195 100644
@@ -2896,8 +2896,11 @@ static int smu_v13_0_6_select_xgmi_plpd_policy(struct smu_context *smu,
 static ssize_t smu_v13_0_6_get_ecc_info(struct smu_context *smu,
                        void *table)
 {
-       /* Support ecc info by default */
-       return 0;
+       struct amdgpu_device *adev = smu->adev;
+       unsigned int error_query_mode;
+
+       return (amdgpu_ras_get_error_query_mode(adev, &error_query_mode) &&
+               error_query_mode == AMDGPU_RAS_FIRMWARE_ERROR_QUERY);
 }
 
 static const struct pptable_funcs smu_v13_0_6_ppt_funcs = {

--
2.25.1