Skip to contentSkip to conversation

disable large folios for shmem file used by xfs xfile

PATCH In review Christoph Hellwig 7 participants 21 messages Jan 10, 2024 – Feb 8, 2024

Subsystems (6)
lore
Share & tools
lore
#0 lore raw

Hi all,

Darrick reported that the fairly new XFS xfile code blows up when force enabling large folio for shmem. This series fixes this quickly by disabling large folios for this particular shmem file for now until it can be fixed properly, which will be a lot more invasive.

I've added most of you to the CC list as I suspect most other users of shmem_file_setup and friends will have similar issues.

#1 lore raw

PATCH 1/2 mm: add a mapping_clear_large_folios helper

Users of shmem_kernel_file_setup might not be able to deal with large folios (yet). Give them a way to disable large folio support on their mapping.

---
 include/linux/pagemap.h | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
include/linux/pagemap.h +14 -0
index 06142ff7f9ce0e..352d1f8423292c 100644
@@ -343,6 +343,20 @@ static inline void mapping_set_large_folios(struct address_space *mapping)
 	__set_bit(AS_LARGE_FOLIO_SUPPORT, &mapping->flags);
 }
 
+/**
+ * mapping_clear_large_folios() - Disable large folio support for a mapping
+ * @mapping: The mapping.
+ *
+ * This can be called to undo the effect of mapping_set_large_folios().
+ *
+ * Context: This should not be called while the inode is active as it
+ * is non-atomic.
+ */
+static inline void mapping_clear_large_folios(struct address_space *mapping)
+{
+	__clear_bit(AS_LARGE_FOLIO_SUPPORT, &mapping->flags);
+}
+
 /*
  * Large folio support currently depends on THP.  These dependencies are
  * being worked on but are not yet fixed.
Signature · 1 line
2.39.2
#2 lore raw

PATCH 2/2 xfs: disable large folio support in xfile_create

In reply to Christoph Hellwig

The xfarray code will crash if large folios are force enabled using:

echo force > /sys/kernel/mm/transparent_hugepage/shmem_enabled

Fixing this will require a bit of an API change, and prefeably sorting out the hwpoison story for pages vs folio and where it is placed in the shmem API. For now use this one liner to disable large folios.

---
 fs/xfs/scrub/xfile.c | 5 +++++
 1 file changed, 5 insertions(+)
fs/xfs/scrub/xfile.c +5 -0
index 090c3ead43fdf1..1a8d1bedd0b0dc 100644
@@ -94,6 +94,11 @@ xfile_create(
 
 	lockdep_set_class(&inode->i_rwsem, &xfile_i_mutex_key);
 
+	/*
+	 * We're not quite ready for large folios yet.
+	 */
+	mapping_clear_large_folios(inode->i_mapping);
+
 	trace_xfile_create(xf);
 
 	*xfilep = xf;
Signature · 1 line
2.39.2
Reviewed-by on v1 2/2
#3 lore raw

Re: [PATCH 2/2] xfs: disable large folio support in xfile_create

Quoted 10 lines · Christoph Hellwig

The xfarray code will crash if large folios are force enabled using:

echo force > /sys/kernel/mm/transparent_hugepage/shmem_enabled

Fixing this will require a bit of an API change, and prefeably sorting out the hwpoison story for pages vs folio and where it is placed in the shmem API. For now use this one liner to disable large folios.

Can someone who knows more about shmem.c than I do please review
https://lore.kernel.org/linux-xfs/[email protected]/
so that I can feel slightly more confident as hch and I sort through the xfile.c issues?

For this patch,

--D

Quoted 24 lines
---
 fs/xfs/scrub/xfile.c | 5 +++++
 1 file changed, 5 insertions(+)
fs/xfs/scrub/xfile.c +5 -0
index 090c3ead43fdf1..1a8d1bedd0b0dc 100644
@@ -94,6 +94,11 @@ xfile_create(
 
 	lockdep_set_class(&inode->i_rwsem, &xfile_i_mutex_key);
 
+	/*
+	 * We're not quite ready for large folios yet.
+	 */
+	mapping_clear_large_folios(inode->i_mapping);
+
 	trace_xfile_create(xf);
 
 	*xfilep = xf;
Signature · 1 line
2.39.2
#4 lore raw

Re: [PATCH 2/2] xfs: disable large folio support in xfile_create

Quoted 12 lines · Darrick J. Wong
Quoted 10 lines · Christoph Hellwig

The xfarray code will crash if large folios are force enabled using:

echo force > /sys/kernel/mm/transparent_hugepage/shmem_enabled

Fixing this will require a bit of an API change, and prefeably sorting out the hwpoison story for pages vs folio and where it is placed in the shmem API. For now use this one liner to disable large folios.

Quoted 7 lines

Can someone who knows more about shmem.c than I do please review
https://lore.kernel.org/linux-xfs/[email protected]/
so that I can feel slightly more confident as hch and I sort through the xfile.c issues?

For this patch,

...except that I'm still getting 2M THPs even with this enabled, so I guess either we get to fix it now, or create our own private tmpfs mount so that we can pass in huge=never, similar to what i915 does. :(

--D

Quoted 27 lines

--D

Quoted 24 lines
---
 fs/xfs/scrub/xfile.c | 5 +++++
 1 file changed, 5 insertions(+)
fs/xfs/scrub/xfile.c +5 -0
index 090c3ead43fdf1..1a8d1bedd0b0dc 100644
@@ -94,6 +94,11 @@ xfile_create(
 
 	lockdep_set_class(&inode->i_rwsem, &xfile_i_mutex_key);
 
+	/*
+	 * We're not quite ready for large folios yet.
+	 */
+	mapping_clear_large_folios(inode->i_mapping);
+
 	trace_xfile_create(xf);
 
 	*xfilep = xf;
Signature · 1 line
2.39.2
maintainer
#5 lore raw

Re: [PATCH 2/2] xfs: disable large folio support in xfile_create

Quoted 12 lines · On Wed, 10 Jan 2024 12:04:51 -0800 "Darrick J. Wong" <[email protected]> wrote:
Quoted 12 lines
Quoted 6 lines

Fixing this will require a bit of an API change, and prefeably sorting out the hwpoison story for pages vs folio and where it is placed in the shmem API. For now use this one liner to disable large folios.

Can someone who knows more about shmem.c than I do please review
https://lore.kernel.org/linux-xfs/[email protected]/
so that I can feel slightly more confident as hch and I sort through the xfile.c issues?

Quoted 6 lines
Quoted 2 lines

For this patch,

...except that I'm still getting 2M THPs even with this enabled, so I guess either we get to fix it now, or create our own private tmpfs mount so that we can pass in huge=never, similar to what i915 does. :(

What is "this"? Are you saying that $Subject doesn't work, or that the above-linked please-review patch doesn't work?

maintainer
#6 lore raw

Re: [PATCH 2/2] xfs: disable large folio support in xfile_create

Quoted 17 lines · Andrew Morton
Quoted 15 lines · On Wed, 10 Jan 2024 12:04:51 -0800 "Darrick J. Wong" <[email protected]> wrote:
Quoted 14 lines
Quoted 6 lines

Fixing this will require a bit of an API change, and prefeably sorting out the hwpoison story for pages vs folio and where it is placed in the shmem API. For now use this one liner to disable large folios.

Can someone who knows more about shmem.c than I do please review
https://lore.kernel.org/linux-xfs/[email protected]/
so that I can feel slightly more confident as hch and I sort through the xfile.c issues?

For this patch,

Quoted 6 lines
Quoted 3 lines

...except that I'm still getting 2M THPs even with this enabled, so I guess either we get to fix it now, or create our own private tmpfs mount so that we can pass in huge=never, similar to what i915 does. :(

What is "this"? Are you saying that $Subject doesn't work, or that the above-linked please-review patch doesn't work?

shmem pays no attention to the mapping_large_folio_support() flag, so the proposed fix doesn't work. It ought to, but it has its own way of doing it that predates mapping_large_folio_support existing.

#7 lore raw

Re: [PATCH 2/2] xfs: disable large folio support in xfile_create

Quoted 22 lines · Matthew Wilcox
Quoted 21 lines · Andrew Morton
Quoted 18 lines · On Wed, 10 Jan 2024 12:04:51 -0800 "Darrick J. Wong" <[email protected]> wrote:
Quoted 7 lines
Quoted 6 lines

Fixing this will require a bit of an API change, and prefeably sorting out the hwpoison story for pages vs folio and where it is placed in the shmem API. For now use this one liner to disable large folios.

Quoted 7 lines

Can someone who knows more about shmem.c than I do please review
https://lore.kernel.org/linux-xfs/[email protected]/
so that I can feel slightly more confident as hch and I sort through the xfile.c issues?

For this patch,

...except that I'm still getting 2M THPs even with this enabled, so I guess either we get to fix it now, or create our own private tmpfs mount so that we can pass in huge=never, similar to what i915 does. :(

Quoted 6 lines
Quoted 2 lines

What is "this"? Are you saying that $Subject doesn't work, or that the above-linked please-review patch doesn't work?

shmem pays no attention to the mapping_large_folio_support() flag, so the proposed fix doesn't work. It ought to, but it has its own way of doing it that predates mapping_large_folio_support existing.

Yep. It turned out to be easier to fix xfile.c to deal with large folios than I thought it would be. Or so I think. We'll see what happens on fstestscloud overnight.

--D

maintainer
#8 lore raw

Re: [PATCH 2/2] xfs: disable large folio support in xfile_create

Quoted 26 lines · On Thu, 11 Jan 2024 18:22:50 -0800 "Darrick J. Wong" <[email protected]> wrote:
Quoted 25 lines · Matthew Wilcox
Quoted 23 lines · Andrew Morton
Quoted 12 lines · On Wed, 10 Jan 2024 12:04:51 -0800 "Darrick J. Wong" <[email protected]> wrote:
Quoted 12 lines
Quoted 6 lines

Fixing this will require a bit of an API change, and prefeably sorting out the hwpoison story for pages vs folio and where it is placed in the shmem API. For now use this one liner to disable large folios.

Can someone who knows more about shmem.c than I do please review
https://lore.kernel.org/linux-xfs/[email protected]/
so that I can feel slightly more confident as hch and I sort through the xfile.c issues?

Quoted 6 lines
Quoted 2 lines

For this patch,

...except that I'm still getting 2M THPs even with this enabled, so I guess either we get to fix it now, or create our own private tmpfs mount so that we can pass in huge=never, similar to what i915 does. :(

What is "this"? Are you saying that $Subject doesn't work, or that the above-linked please-review patch doesn't work?

Quoted 7 lines
Quoted 3 lines

shmem pays no attention to the mapping_large_folio_support() flag, so the proposed fix doesn't work. It ought to, but it has its own way of doing it that predates mapping_large_folio_support existing.

Yep. It turned out to be easier to fix xfile.c to deal with large folios than I thought it would be. Or so I think. We'll see what happens on fstestscloud overnight.

Where do we stand with this? Should I merge these two patches into 6.8-rcX, cc:stable?

#9 lore raw

Re: [PATCH 2/2] xfs: disable large folio support in xfile_create

Quoted 32 lines · Andrew Morton
Quoted 30 lines · On Thu, 11 Jan 2024 18:22:50 -0800 "Darrick J. Wong" <[email protected]> wrote:
Quoted 28 lines · Matthew Wilcox
Quoted 17 lines · Andrew Morton
Quoted 15 lines · On Wed, 10 Jan 2024 12:04:51 -0800 "Darrick J. Wong" <[email protected]> wrote:
Quoted 14 lines
Quoted 6 lines

Fixing this will require a bit of an API change, and prefeably sorting out the hwpoison story for pages vs folio and where it is placed in the shmem API. For now use this one liner to disable large folios.

Can someone who knows more about shmem.c than I do please review
https://lore.kernel.org/linux-xfs/[email protected]/
so that I can feel slightly more confident as hch and I sort through the xfile.c issues?

For this patch,

Quoted 6 lines
Quoted 3 lines

...except that I'm still getting 2M THPs even with this enabled, so I guess either we get to fix it now, or create our own private tmpfs mount so that we can pass in huge=never, similar to what i915 does. :(

What is "this"? Are you saying that $Subject doesn't work, or that the above-linked please-review patch doesn't work?

shmem pays no attention to the mapping_large_folio_support() flag, so the proposed fix doesn't work. It ought to, but it has its own way of doing it that predates mapping_large_folio_support existing.

Quoted 6 lines
Quoted 3 lines

Yep. It turned out to be easier to fix xfile.c to deal with large folios than I thought it would be. Or so I think. We'll see what happens on fstestscloud overnight.

Where do we stand with this? Should I merge these two patches into 6.8-rcX, cc:stable?

This patchset doesn't actually fix the problem, so no, let's not merge it.

For 6.9 we'll make xfile.c clean w.r.t. large folios:
https://lore.kernel.org/linux-xfs/[email protected]/

I don't think we need a 6.8 backport since xfile.c is only used by an experimental feature that is default n in kconfig.

--D

maintainer
#10 lore raw
In reply to Christoph Hellwig
Quoted 9 lines · Christoph Hellwig

Hi all,

Darrick reported that the fairly new XFS xfile code blows up when force enabling large folio for shmem. This series fixes this quickly by disabling large folios for this particular shmem file for now until it can be fixed properly, which will be a lot more invasive.

I've added most of you to the CC list as I suspect most other users of shmem_file_setup and friends will have similar issues.

The graphics users _want_ to use large folios. I'm pretty sure they've been tested with this. It's just XFS that didn't know about this feature of shmem.

#11 lore raw

Quoting Matthew Wilcox (2024-01-10 14:37:18)

Quoted 8 lines · Christoph Hellwig
Quoted 7 lines

Hi all,

Darrick reported that the fairly new XFS xfile code blows up when force enabling large folio for shmem. This series fixes this quickly by disabling large folios for this particular shmem file for now until it can be fixed properly, which will be a lot more invasive.

Quoted 5 lines
Quoted 2 lines

I've added most of you to the CC list as I suspect most other users of shmem_file_setup and friends will have similar issues.

The graphics users _want_ to use large folios. I'm pretty sure they've been tested with this.

Correct. We've done quite a bit of optimization in userspace and enabling in kernel to take advantage of page sizes of 2M and beyond.

However we specifically pass "huge=within_size" to vfs_kern_mount when creating a private mount of tmpfs for the purpose of i915 created allocations.

Older hardware also had some address hashing bugs where 2M aligned memory caused a lot of collisions in TLB so we don't enable it always.

You can see drivers/gpu/drm/i915/gem/i915_gemfs.c function i915_gemfs_init for details and references.

So in short, functionality wise we should be fine either default for using 2M pages or not. If they become the default, we'd probably want an option that would still be able to prevent them for performance regression reasons on older hardware.

Regards, Joonas

Quoted 2 lines

It's just XFS that didn't know about this
feature of shmem.

#12 lore raw

Quoting Joonas Lahtinen (2024-01-10 17:20:24)

Quoted 25 lines

Quoting Matthew Wilcox (2024-01-10 14:37:18)

Quoted 8 lines · Christoph Hellwig
Quoted 7 lines

Hi all,

Darrick reported that the fairly new XFS xfile code blows up when force enabling large folio for shmem. This series fixes this quickly by disabling large folios for this particular shmem file for now until it can be fixed properly, which will be a lot more invasive.

Quoted 5 lines
Quoted 2 lines

I've added most of you to the CC list as I suspect most other users of shmem_file_setup and friends will have similar issues.

The graphics users _want_ to use large folios. I'm pretty sure they've been tested with this.

Correct. We've done quite a bit of optimization in userspace and enabling in kernel to take advantage of page sizes of 2M and beyond.

However we specifically pass "huge=within_size" to vfs_kern_mount when creating a private mount of tmpfs for the purpose of i915 created allocations.

Older hardware also had some address hashing bugs where 2M aligned memory caused a lot of collisions in TLB so we don't enable it always.

Quoted 7 lines

You can see drivers/gpu/drm/i915/gem/i915_gemfs.c function i915_gemfs_init for details and references.

So in short, functionality wise we should be fine either default for using 2M pages or not. If they become the default, we'd probably want an option that would still be able to prevent them for performance regression reasons on older hardware.

To maybe write out my concern better:

Is there plan to enable huge pages by default in shmem?

If not I guess we should be pretty good with the way current code is, force enabling them just might bring out some performance, so we might want to add a warning for that.

If there is, then we'll probably want to in sync with those default changes apply a similar call to block them on older HW.

Regards, Joonas

Quoted 5 lines

Regards, Joonas

Quoted 2 lines

It's just XFS that didn't know about this
feature of shmem.

maintainer
#13 lore raw
Quoted 11 lines · Joonas Lahtinen

Quoting Joonas Lahtinen (2024-01-10 17:20:24)

Quoted 10 lines

However we specifically pass "huge=within_size" to vfs_kern_mount when creating a private mount of tmpfs for the purpose of i915 created allocations.

Older hardware also had some address hashing bugs where 2M aligned memory caused a lot of collisions in TLB so we don't enable it always.

You can see drivers/gpu/drm/i915/gem/i915_gemfs.c function i915_gemfs_init for details and references.

Quoted 8 lines
Quoted 4 lines

So in short, functionality wise we should be fine either default for using 2M pages or not. If they become the default, we'd probably want an option that would still be able to prevent them for performance regression reasons on older hardware.

To maybe write out my concern better:

Is there plan to enable huge pages by default in shmem?

Not in the next kernel release, but eventually the plan is to allow arbitrary order folios to be used in shmem. So you could ask it to create a 256kB folio for you, if that's the right size to manage memory in.

How shmem and its various users go about choosing the right size is not quite clear to me yet. Perhaps somebody else will do it before I get to it; I have a lot of different sub-projects to work on at the moment, and shmem isn't blocking any of them. And I have a sneaking suspicion that more work is needed in the swap code to deal with arbitrary order folios, so that's another reason for me to delay looking at this ;-)

#14 lore raw
Quoted 26 lines · Matthew Wilcox
Quoted 11 lines · Joonas Lahtinen

Quoting Joonas Lahtinen (2024-01-10 17:20:24)

Quoted 10 lines

However we specifically pass "huge=within_size" to vfs_kern_mount when creating a private mount of tmpfs for the purpose of i915 created allocations.

Older hardware also had some address hashing bugs where 2M aligned memory caused a lot of collisions in TLB so we don't enable it always.

You can see drivers/gpu/drm/i915/gem/i915_gemfs.c function i915_gemfs_init for details and references.

Quoted 8 lines
Quoted 4 lines

So in short, functionality wise we should be fine either default for using 2M pages or not. If they become the default, we'd probably want an option that would still be able to prevent them for performance regression reasons on older hardware.

To maybe write out my concern better:

Is there plan to enable huge pages by default in shmem?

Not in the next kernel release, but eventually the plan is to allow arbitrary order folios to be used in shmem. So you could ask it to create a 256kB folio for you, if that's the right size to manage memory in.

Quoted 6 lines

How shmem and its various users go about choosing the right size is not quite clear to me yet. Perhaps somebody else will do it before I get to it; I have a lot of different sub-projects to work on at the moment, and shmem isn't blocking any of them. And I have a sneaking suspicion that more work is needed in the swap code to deal with arbitrary order folios, so that's another reason for me to delay looking at this ;-)

I have sent large folios support for shmem for the write and fallocate path some releases ago. The main problem I was facing was a current upstream problem with huge pages when seeking holes/data (fstests generic/285 and generic/436). The strategy suggested was to use large folios in an opportunistic way based on the file size. This hit the same problem we currently have with huge pages and I considered that a regression. We have made some progress to fix seeking in huge pages upstream but is not yet finished. I can send the patches tomorrow for further discussion.

Quoted 1 line
#15 lore raw
In reply to Matthew Wilcox
Quoted 8 lines · Matthew Wilcox
Quoted 7 lines · Christoph Hellwig

Hi all,

Darrick reported that the fairly new XFS xfile code blows up when force enabling large folio for shmem. This series fixes this quickly by disabling large folios for this particular shmem file for now until it can be fixed properly, which will be a lot more invasive.

Quoted 6 lines
Quoted 2 lines

I've added most of you to the CC list as I suspect most other users of shmem_file_setup and friends will have similar issues.

The graphics users _want_ to use large folios. I'm pretty sure they've been tested with this. It's just XFS that didn't know about this feature of shmem.

At least sgx has all kinds of PAGE_SIZE assumptions. I haven't audited (and am probably not qualified to) audit that code, so I wanted to send a headsup to everyone.

#16 lore raw

✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] mm: add a mapping_clear_large_folios helper

In reply to Christoph Hellwig
== Series Details ==

== Series Details ==

Series: series starting with [1/2] mm: add a mapping_clear_large_folios helper
URL : https://patchwork.freedesktop.org/series/128420/
State : warning

== Summary ==

Error: dim checkpatch failed
e1a8add4aba0 mm: add a mapping_clear_large_folios helper
0faf35dc1522 xfs: disable large folio support in xfile_create
-:14: WARNING:BAD_REPORTED_BY_LINK: Reported-by: should be immediately followed by Closes: with a URL to the report #14:

total: 0 errors, 1 warnings, 0 checks, 11 lines checked

#17 lore raw

✗ Fi.CI.SPARSE: warning for series starting with [1/2] mm: add a mapping_clear_large_folios helper

In reply to Christoph Hellwig
== Series Details ==

== Series Details ==

Series: series starting with [1/2] mm: add a mapping_clear_large_folios helper
URL : https://patchwork.freedesktop.org/series/128420/
State : warning

== Summary ==

Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.

#18 lore raw

✗ Fi.CI.BAT: failure for series starting with [1/2] mm: add a mapping_clear_large_folios helper

In reply to Christoph Hellwig
== Series Details ==

== Series Details ==

Series: series starting with [1/2] mm: add a mapping_clear_large_folios helper
URL : https://patchwork.freedesktop.org/series/128420/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_14108 -> Patchwork_128420v1
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_128420v1 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes
introduced in Patchwork_128420v1, please notify your bug team ([email protected]) to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128420v1/index.html

Participating hosts (38 -> 38)
------------------------------

Additional (1): bat-mtlp-8
Missing (1): fi-snb-2520m

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_128420v1:

### CI changes ###

#### Possible regressions ####

* boot:
- bat-rpls-2: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14108/bat-rpls-2/boot.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128420v1/bat-rpls-2/boot.html

Known issues
------------

Here are the changes found in Patchwork_128420v1 that come from known issues:

### CI changes ###

#### Issues hit ####

* boot:
- fi-bsw-n3050: [PASS][3] -> [FAIL][4] ([i915#8293])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14108/fi-bsw-n3050/boot.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128420v1/fi-bsw-n3050/boot.html

### IGT changes ###

#### Issues hit ####

* igt@debugfs_test@basic-hwmon:
- bat-mtlp-8: NOTRUN -> [SKIP][5] ([i915#9318])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128420v1/bat-mtlp-8/igt@[email protected]

* igt@gem_lmem_swapping@verify-random:
- bat-mtlp-8: NOTRUN -> [SKIP][6] ([i915#4613]) +3 other tests skip
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128420v1/bat-mtlp-8/igt@[email protected]

* igt@gem_mmap@basic:
- bat-mtlp-8: NOTRUN -> [SKIP][7] ([i915#4083])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128420v1/bat-mtlp-8/igt@[email protected]

* igt@gem_mmap_gtt@basic:
- bat-mtlp-8: NOTRUN -> [SKIP][8] ([i915#4077]) +2 other tests skip
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128420v1/bat-mtlp-8/igt@[email protected]

* igt@gem_render_tiled_blits@basic:
- bat-mtlp-8: NOTRUN -> [SKIP][9] ([i915#4079]) +1 other test skip
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128420v1/bat-mtlp-8/igt@[email protected]

* igt@i915_pm_rps@basic-api:
- bat-mtlp-8: NOTRUN -> [SKIP][10] ([i915#6621])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128420v1/bat-mtlp-8/igt@[email protected]

* igt@i915_suspend@basic-s3-without-i915:
- bat-mtlp-8: NOTRUN -> [SKIP][11] ([i915#6645])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128420v1/bat-mtlp-8/igt@[email protected]

* igt@kms_addfb_basic@addfb25-y-tiled-small-legacy:
- bat-mtlp-8: NOTRUN -> [SKIP][12] ([i915#5190])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128420v1/bat-mtlp-8/igt@[email protected]

* igt@kms_addfb_basic@basic-y-tiled-legacy:
- bat-mtlp-8: NOTRUN -> [SKIP][13] ([i915#4212]) +8 other tests skip
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128420v1/bat-mtlp-8/igt@[email protected]

* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- bat-mtlp-8: NOTRUN -> [SKIP][14] ([i915#4213]) +1 other test skip
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128420v1/bat-mtlp-8/igt@[email protected]

* igt@kms_dsc@dsc-basic:
- bat-mtlp-8: NOTRUN -> [SKIP][15] ([i915#3555] / [i915#3840] / [i915#9159])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128420v1/bat-mtlp-8/igt@[email protected]

* igt@kms_force_connector_basic@force-load-detect:
- bat-mtlp-8: NOTRUN -> [SKIP][16] ([fdo#109285])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128420v1/bat-mtlp-8/igt@[email protected]

* igt@kms_force_connector_basic@prune-stale-modes:
- bat-mtlp-8: NOTRUN -> [SKIP][17] ([i915#5274])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128420v1/bat-mtlp-8/igt@[email protected]

* igt@kms_pipe_crc_basic@suspend-read-crc:
- bat-atsm-1: NOTRUN -> [SKIP][18] ([i915#1836])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128420v1/bat-atsm-1/igt@[email protected]

* igt@kms_setmode@basic-clone-single-crtc:
- bat-mtlp-8: NOTRUN -> [SKIP][19] ([i915#3555] / [i915#8809])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128420v1/bat-mtlp-8/igt@[email protected]

* igt@prime_vgem@basic-fence-mmap:
- bat-mtlp-8: NOTRUN -> [SKIP][20] ([i915#3708] / [i915#4077]) +1 other test skip
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128420v1/bat-mtlp-8/igt@[email protected]

* igt@prime_vgem@basic-fence-read:
- bat-mtlp-8: NOTRUN -> [SKIP][21] ([i915#3708]) +2 other tests skip
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128420v1/bat-mtlp-8/igt@[email protected]

#### Possible fixes ####

* igt@gem_exec_suspend@basic-s3@lmem0:
- bat-atsm-1: [ABORT][22] -> [PASS][23]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14108/bat-atsm-1/igt@gem_exec_suspend@[email protected]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128420v1/bat-atsm-1/igt@gem_exec_suspend@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[i915#1836]: https://gitlab.freedesktop.org/drm/intel/issues/1836
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190
[i915#5274]: https://gitlab.freedesktop.org/drm/intel/issues/5274
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6645]: https://gitlab.freedesktop.org/drm/intel/issues/6645
[i915#8293]: https://gitlab.freedesktop.org/drm/intel/issues/8293
[i915#8809]: https://gitlab.freedesktop.org/drm/intel/issues/8809
[i915#9159]: https://gitlab.freedesktop.org/drm/intel/issues/9159
[i915#9318]: https://gitlab.freedesktop.org/drm/intel/issues/9318
[i915#9688]: https://gitlab.freedesktop.org/drm/intel/issues/9688

Build changes
-------------

* Linux: CI_DRM_14108 -> Patchwork_128420v1

CI-20190529: 20190529
CI_DRM_14108: c58d1352dd193d8df380a14e95c05455acaf5b82 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7666: 5f97adfd0e1636788a6af5b592f0d15b4f1027c8 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_128420v1: c58d1352dd193d8df380a14e95c05455acaf5b82 @ git://anongit.freedesktop.org/gfx-ci/linux

### Linux commits

7691534a4217 xfs: disable large folio support in xfile_create e80c21ce38cb mm: add a mapping_clear_large_folios helper

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128420v1/index.html

maintainer
#19 lore raw
In reply to Christoph Hellwig
Quoted 7 lines · On Wed, 10 Jan 2024 10:21:07 +0100 Christoph Hellwig <[email protected]> wrote:

Hi all,

Darrick reported that the fairly new XFS xfile code blows up when force enabling large folio for shmem. This series fixes this quickly by disabling large folios for this particular shmem file for now until it can be fixed properly, which will be a lot more invasive.

Patches seems reasonable as a short-term only-affects-xfs thing.

I assume that kernels which contain 137db333b29186 ("xfs: teach xfile to pass back direct-map pages to caller") want this, so a Fixes: that and a cc:stable are appropriate?

#20 lore raw
Quoted 3 lines · Andrew Morton

I assume that kernels which contain 137db333b29186 ("xfs: teach xfile to pass back direct-map pages to caller") want this, so a Fixes: that and a cc:stable are appropriate?

I think it needs to back all the way back to 3934e8ebb7c ("xfs: create a big array data structure") as that only clears the page sized chunk of a new allocation and could lead to corruption / or information leaks.