ata: libata-sata: improve sysfs description for ATA_LPM_UNKNOWN
Niklas Cassel
maintainerPATCH 1/1 ata: libata-sata: improve sysfs description for ATA_LPM_UNKNOWN
Currently, both ATA_LPM_UNKNOWN (0) and ATA_LPM_MAX_POWER (1) displays as "max_performance" in sysfs.
This is quite misleading as they are not the same.
For ATA_LPM_UNKNOWN, ata_eh_set_lpm() will not be called at all, leaving the configuration in unknown state.
For ATA_LPM_MAX_POWER, ata_eh_set_lpm() is called, and setting the policy to ATA_LPM_MAX_POWER.
This also matches the description of the SATA_MOBILE_LPM_POLICY Kconfig:
0 => Keep firmware settings
1 => Maximum performance
Thus, update the sysfs description for ATA_LPM_UNKNOWN to match reality.
While at it, update libata.h to mention that the ascii descriptions are in libata-sata.c and not in libata-scsi.c.
--- drivers/ata/libata-sata.c | 2 +- include/linux/libata.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/ata/libata-sata.c +1 -1
@@ -784,7 +784,7 @@ bool sata_lpm_ignore_phy_events(struct ata_link *link)EXPORT_SYMBOL_GPL (sata_lpm_ignore_phy_events);static const char *ata_lpm_policy_names[] = { - [ATA_LPM_UNKNOWN ] ="max_performance" , + [ATA_LPM_UNKNOWN ] ="keep_firmware_settings" , [ATA_LPM_MAX_POWER ] ="max_performance" , [ATA_LPM_MED_POWER ] ="medium_power" , [ATA_LPM_MED_POWER_WITH_DIPM ] ="med_power_with_dipm" ,
include/linux/libata.h +1 -1
@@ -471,7 +471,7 @@ enum ata_completion_errors {/* * Link power management policy: If you alter this, you also need to -* alter libata-scsi.c (for the ascii descriptions) +* alter libata-sata.c (for the ascii descriptions) */ enum ata_lpm_policy {ATA_LPM_UNKNOWN ,
Signature · 1 line
2.43.0
Quoted 14 lines · Niklas Cassel
Currently, both
ATA_LPM_UNKNOWN(0) andATA_LPM_MAX_POWER(1) displays as "max_performance" in sysfs.This is quite misleading as they are not the same.
For
ATA_LPM_UNKNOWN,ata_eh_set_lpm()will not be called at all, leaving the configuration in unknown state.
ForATA_LPM_MAX_POWER,ata_eh_set_lpm()is called, and setting the policy toATA_LPM_MAX_POWER.This also matches the description of the
SATA_MOBILE_LPM_POLICYKconfig:
0 => Keep firmware settings
1 => Maximum performance
Quoted 6 lines
Thus, update the sysfs description for
ATA_LPM_UNKNOWNto match reality.While at it, update
libata.hto mention that the ascii descriptions are inlibata-sata.cand not inlibata-scsi.c.Signed-off-by Niklas Cassel <[email protected]>
Looks good.
Signature · 2 lines
Damien Le Moal Western Digital Research
Quoted 14 lines · Niklas Cassel
Currently, both
ATA_LPM_UNKNOWN(0) andATA_LPM_MAX_POWER(1) displays as "max_performance" in sysfs.This is quite misleading as they are not the same.
For
ATA_LPM_UNKNOWN,ata_eh_set_lpm()will not be called at all, leaving the configuration in unknown state.
ForATA_LPM_MAX_POWER,ata_eh_set_lpm()is called, and setting the policy toATA_LPM_MAX_POWER.This also matches the description of the
SATA_MOBILE_LPM_POLICYKconfig:
0 => Keep firmware settings
1 => Maximum performance
Quoted 7 lines
Thus, update the sysfs description for
ATA_LPM_UNKNOWNto match reality.While at it, update
libata.hto mention that the ascii descriptions are inlibata-sata.cand not inlibata-scsi.c.Signed-off-by Niklas Cassel <[email protected]>---
Applied:
https://git.kernel.org/pub/scm/linux/kernel/git/libata/linux.git/log/?h=for-6.8-fixes