Skip to contentSkip to conversation

dmaengine: tegra210-adma: Update dependency to ARCH_TEGRA

PATCH In review Peter Robinson 2 participants 2 messages Jan 11, 2024 – Jan 12, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dmaengine: tegra210-adma: Update dependency to ARCH_TEGRA

Update the architecture dependency to be the generic Tegra because the driver works on the four latest Tegra generations not just T210, if you build a kernel with a specific ARCH_TEGRA_xxx_SOC optioon that excludes 210 you don't get this driver.

Fixes 433de642a76c9 ("dmaengine: tegra210-adma: add support for Tegra186/Tegra194")
Cc Jon Hunter <[email protected]>
Cc Thierry Reding <[email protected]>
Cc Sameer Pujar <[email protected]>
Cc Laxman Dewangan <[email protected]>
---
 drivers/dma/Kconfig | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)
drivers/dma/Kconfig +7 -7
index 70ba506dabab5..de6eb370d485d 100644
@@ -629,16 +629,16 @@ config TEGRA20_APB_DMA
 
 config TEGRA210_ADMA
 	tristate "NVIDIA Tegra210 ADMA support"
-	depends on (ARCH_TEGRA_210_SOC || COMPILE_TEST)
+	depends on (ARCH_TEGRA || COMPILE_TEST)
 	select DMA_ENGINE
 	select DMA_VIRTUAL_CHANNELS
 	help
-	  Support for the NVIDIA Tegra210 ADMA controller driver. The
-	  DMA controller has multiple DMA channels and is used to service
-	  various audio clients in the Tegra210 audio processing engine
-	  (APE). This DMA controller transfers data from memory to
-	  peripheral and vice versa. It does not support memory to
-	  memory data transfer.
+	  Support for the NVIDIA Tegra210/Tegra186/Tegra194/Tegra234 ADMA
+	  controller driver. The DMA controller has multiple DMA channels
+	  and is used to service various audio clients in the Tegra210
+	  audio processing engine (APE). This DMA controller transfers
+	  data from memory to peripheral and vice versa. It does not
+	  support memory to memory data transfer.
 
 config TIMB_DMA
 	tristate "Timberdale FPGA DMA support"
Signature · 1 line
2.43.0
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · Peter Robinson

Update the architecture dependency to be the generic Tegra because the driver works on the four latest Tegra generations not just T210, if you build a kernel with a specific ARCH_TEGRA_xxx_SOC optioon that excludes 210 you don't get

s/optioon/option :-)

Quoted 30 lines

this driver.

Fixes 433de642a76c9 ("dmaengine: tegra210-adma: add support for Tegra186/Tegra194")
Cc Jon Hunter <[email protected]>
Cc Thierry Reding <[email protected]>
Cc Sameer Pujar <[email protected]>
Cc Laxman Dewangan <[email protected]>
---
  drivers/dma/Kconfig | 14 +++++++-------
  1 file changed, 7 insertions(+), 7 deletions(-)
drivers/dma/Kconfig +1 -6
index 70ba506dabab5..de6eb370d485d 100644
@@ -629,16 +629,16 @@ config TEGRA20_APB_DMA
 
  config TEGRA210_ADMA
  	tristate "NVIDIA Tegra210 ADMA support"
-	depends on (ARCH_TEGRA_210_SOC || COMPILE_TEST)
+	depends on (ARCH_TEGRA || COMPILE_TEST)
  	select DMA_ENGINE
  	select DMA_VIRTUAL_CHANNELS
  	help
-	  Support for the NVIDIA Tegra210 ADMA controller driver. The
-	  DMA controller has multiple DMA channels and is used to service
-	  various audio clients in the Tegra210 audio processing engine
-	  (APE). This DMA controller transfers data from memory to
-	  peripheral and vice versa. It does not support memory to

drivers/dma/Kconfig config TEGRA20_APB_DMA · line 644

Quoted 10 lines
drivers/dma/Kconfig +6 -1
-	  memory data transfer.
+	  Support for the NVIDIA Tegra210/Tegra186/Tegra194/Tegra234 ADMA
+	  controller driver. The DMA controller has multiple DMA channels
+	  and is used to service various audio clients in the Tegra210
+	  audio processing engine (APE). This DMA controller transfers
+	  data from memory to peripheral and vice versa. It does not
+	  support memory to memory data transfer.
 
  config TIMB_DMA
  	tristate "Timberdale FPGA DMA support"

Looks good to me. Thanks for fixing! Apart from the minor typo ...

Jon

Signature · 1 line
nvpublic