Skip to contentSkip to conversation

mm/vmalloc.c:4652:22: warning: 'addr' is used uninitialized

PATCH kernel test robot 1 participant 1 message Jan 11, 2024 Memory management

lore
Share & tools
lore

kernel test robot

author build bot
#0 lore raw
tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   9e21984d62c56a0f6d1fc6f76b646212cfd7fe88
commit: e88b85b81d5313a69cb62829b957d4a9ecde600b [12999/13245] mm: vmalloc: offload free_vmap_area_lock lock
config: m68k-defconfig (https://download.01.org/0day-ci/archive/20240111/[email protected]/config)
compiler: m68k-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240111/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

All warnings (new ones prefixed by >>):

mm/vmalloc.c: In function 'vmalloc_dump_obj':

>> mm/vmalloc.c:4652:22: warning: 'addr' is used uninitialized [-Wuninitialized]
    4652 |                 va = __find_vmap_area(addr, &vn->busy.root);
         |                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   mm/vmalloc.c:4645:23: note: 'addr' was declared here
    4645 |         unsigned long addr;
         |                       ^~~~

vim +/addr +4652 mm/vmalloc.c

a10aa579878fc6 Christoph Lameter       2008-04-28  4637  
5bb1bb353cfe34 Paul E. McKenney        2021-01-07  4638  #ifdef CONFIG_PRINTK
98f180837a896e Paul E. McKenney        2020-12-08  4639  bool vmalloc_dump_obj(void *object)
98f180837a896e Paul E. McKenney        2020-12-08  4640  {
98f180837a896e Paul E. McKenney        2020-12-08  4641  	void *objp = (void *)PAGE_ALIGN((unsigned long)object);
0818e739b5c061 Joel Fernandes (Google  2023-09-04  4642) 	const void *caller;
0818e739b5c061 Joel Fernandes (Google  2023-09-04  4643) 	struct vmap_area *va;
86817057732a9c Uladzislau Rezki (Sony  2024-01-02  4644) 	struct vmap_node *vn;
0818e739b5c061 Joel Fernandes (Google  2023-09-04  4645) 	unsigned long addr;
0818e739b5c061 Joel Fernandes (Google  2023-09-04  4646) 	unsigned int nr_pages;
86817057732a9c Uladzislau Rezki (Sony  2024-01-02  4647) 	bool success = false;
98f180837a896e Paul E. McKenney        2020-12-08  4648  
86817057732a9c Uladzislau Rezki (Sony  2024-01-02  4649) 	vn = addr_to_node((unsigned long)objp);
86817057732a9c Uladzislau Rezki (Sony  2024-01-02  4650) 
86817057732a9c Uladzislau Rezki (Sony  2024-01-02  4651) 	if (spin_trylock(&vn->busy.lock)) {
86817057732a9c Uladzislau Rezki (Sony  2024-01-02 @4652) 		va = __find_vmap_area(addr, &vn->busy.root);
86817057732a9c Uladzislau Rezki (Sony  2024-01-02  4653) 
86817057732a9c Uladzislau Rezki (Sony  2024-01-02  4654) 		if (va && va->vm) {
86817057732a9c Uladzislau Rezki (Sony  2024-01-02  4655) 			addr = (unsigned long)va->vm->addr;
86817057732a9c Uladzislau Rezki (Sony  2024-01-02  4656) 			caller = va->vm->caller;
86817057732a9c Uladzislau Rezki (Sony  2024-01-02  4657) 			nr_pages = va->vm->nr_pages;
86817057732a9c Uladzislau Rezki (Sony  2024-01-02  4658) 			success = true;
0818e739b5c061 Joel Fernandes (Google  2023-09-04  4659) 		}
0818e739b5c061 Joel Fernandes (Google  2023-09-04  4660) 
86817057732a9c Uladzislau Rezki (Sony  2024-01-02  4661) 		spin_unlock(&vn->busy.lock);
0818e739b5c061 Joel Fernandes (Google  2023-09-04  4662) 	}
86817057732a9c Uladzislau Rezki (Sony  2024-01-02  4663) 
86817057732a9c Uladzislau Rezki (Sony  2024-01-02  4664) 	if (success)
bd34dcd4120d7e Paul E. McKenney        2020-12-09  4665  		pr_cont(" %u-page vmalloc region starting at %#lx allocated at %pS\n",
0818e739b5c061 Joel Fernandes (Google  2023-09-04  4666) 			nr_pages, addr, caller);
86817057732a9c Uladzislau Rezki (Sony  2024-01-02  4667) 
86817057732a9c Uladzislau Rezki (Sony  2024-01-02  4668) 	return success;
98f180837a896e Paul E. McKenney        2020-12-08  4669  }
5bb1bb353cfe34 Paul E. McKenney        2021-01-07  4670  #endif
98f180837a896e Paul E. McKenney        2020-12-08  4671  

:::::: The code at line 4652 was first introduced by commit
:::::: 86817057732a9ce9cefdb6f513b6554a55ebbbbb mm: vmalloc: remove global vmap_area_root rb-tree

:::::: TO: Uladzislau Rezki (Sony) <[email protected]> :::::: CC: Andrew Morton <[email protected]>

Signature · 2 lines
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki