Skip to contentSkip to conversation

man/tc-mirred: don't recommend modprobe

PATCH In review Stephen Hemminger 2 participants 5 messages Jan 11, 2024 – Jan 12, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 man/tc-mirred: don't recommend modprobe

Use ip link add instead of explicit modprobe. Kernel will do correct module loading if necessary.

---
 man/man8/tc-mirred.8 | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
man/man8/tc-mirred.8 +1 -2
index 38833b452d92..2d9795b1b16f 100644
@@ -84,8 +84,7 @@ interface, it is possible to send ingress traffic through an instance of
 
 .RS
 .EX
-# modprobe ifb
-# ip link set ifb0 up
+# ip link add dev ifb0 type ifb
 # tc qdisc add dev ifb0 root sfq
 # tc qdisc add dev eth0 handle ffff: ingress
 # tc filter add dev eth0 parent ffff: u32 \\
Signature · 1 line
2.43.0
#1 lore raw
Quoted 16 lines · Thu, Jan 11, 2024 at 08:34:44PM CET, [email protected] wrote:

Use ip link add instead of explicit modprobe. Kernel will do correct module loading if necessary.

---
man/man8/tc-mirred.8 | 3 +--

1 file changed, 1 insertion(+), 2 deletions(-)
man/man8/tc-mirred.8 +0 -0
index 38833b452d92..2d9795b1b16f 100644
@@ -84,8 +84,7 @@ interface, it is possible to send ingress traffic through an instance of
 

.RS
.EX

man/man8/tc-mirred.8 interface, it is possible to send ingress traffic through an instance of · line 87

Quoted 3 lines
man/man8/tc-mirred.8 +1 -2
-# modprobe ifb
-# ip link set ifb0 up
+# ip link add dev ifb0 type ifb

RTNETLINK answers: File exists

You can't add "ifb0" like this, it is created implicitly on module probe time. Pick a different name.

Quoted 7 lines
# tc qdisc add dev ifb0 root sfq
# tc qdisc add dev eth0 handle ffff: ingress
# tc filter add dev eth0 parent ffff: u32 \\
Signature · 1 line
2.43.0
#2 lore raw
Quoted 23 lines · On Fri, 12 Jan 2024 13:44:47 +0100 Jiri Pirko <[email protected]> wrote:
Quoted 16 lines · Thu, Jan 11, 2024 at 08:34:44PM CET, [email protected] wrote:

Use ip link add instead of explicit modprobe. Kernel will do correct module loading if necessary.

---
man/man8/tc-mirred.8 | 3 +--

1 file changed, 1 insertion(+), 2 deletions(-)
man/man8/tc-mirred.8 +0 -0
index 38833b452d92..2d9795b1b16f 100644
@@ -84,8 +84,7 @@ interface, it is possible to send ingress traffic through an instance of
 

.RS
.EX

man/man8/tc-mirred.8 interface, it is possible to send ingress traffic through an instance of · line 87

Quoted 3 lines
man/man8/tc-mirred.8 +1 -2
-# modprobe ifb
-# ip link set ifb0 up
+# ip link add dev ifb0 type ifb  

RTNETLINK answers: File exists

Quoted 2 lines

You can't add "ifb0" like this, it is created implicitly on module probe time. Pick a different name.

Right.
Looks like ifb is behaving differently than other devices. For example, doing modprobe of dummy creates no device.

#3 lore raw
Quoted 26 lines · Fri, Jan 12, 2024 at 06:09:15PM CET, [email protected] wrote:
Quoted 23 lines · On Fri, 12 Jan 2024 13:44:47 +0100 Jiri Pirko <[email protected]> wrote:
Quoted 16 lines · Thu, Jan 11, 2024 at 08:34:44PM CET, [email protected] wrote:

Use ip link add instead of explicit modprobe. Kernel will do correct module loading if necessary.

---
man/man8/tc-mirred.8 | 3 +--

1 file changed, 1 insertion(+), 2 deletions(-)
man/man8/tc-mirred.8 +0 -0
index 38833b452d92..2d9795b1b16f 100644
@@ -84,8 +84,7 @@ interface, it is possible to send ingress traffic through an instance of
 

.RS
.EX

man/man8/tc-mirred.8 interface, it is possible to send ingress traffic through an instance of · line 87

Quoted 3 lines
man/man8/tc-mirred.8 +1 -2
-# modprobe ifb
-# ip link set ifb0 up
+# ip link add dev ifb0 type ifb  

RTNETLINK answers: File exists

Quoted 6 lines
Quoted 2 lines

You can't add "ifb0" like this, it is created implicitly on module probe time. Pick a different name.

Right.
Looks like ifb is behaving differently than other devices. For example, doing modprobe of dummy creates no device.

Older drivers did do this. Bonding modprobe also created bond0 in the past. Now it does not. I guess ifb behaviour could be changed as well.

Quoted 2 lines
#4 lore raw
Quoted 11 lines · On Fri, 12 Jan 2024 19:21:34 +0100 Jiri Pirko <[email protected]> wrote:
Quoted 7 lines
Quoted 3 lines

You can't add "ifb0" like this, it is created implicitly on module probe time. Pick a different name.

Right.
Looks like ifb is behaving differently than other devices. For example, doing modprobe of dummy creates no device.

Older drivers did do this. Bonding modprobe also created bond0 in the past. Now it does not. I guess ifb behaviour could be changed as well.

In most distros, for bond and dummy, there is this from systemd.conf

options bonding max_bonds=0
options dummy numdummies=0