Remove deprecated command line options
cover Remove deprecated command line options
The -no-hpet, -no-acpi, -async-teardown, -chroot and -singlestep options have been deprecated for at least two releases, so it should be fine if we remove them now.
Thomas Huth (5):
qemu-options: Remove the deprecated -no-hpet option
qemu-options: Remove the deprecated -no-acpi option
qemu-options: Remove the deprecated -async-teardown option
qemu-options: Remove the deprecated -chroot option
qemu-options: Remove the deprecated -singlestep option
docs/about/deprecated.rst | 28 -------------------- docs/about/removed-features.rst | 30 +++++++++++++++++++++ system/vl.c | 37 +------------------------- qemu-options.hx | 46 --------------------------------- 4 files changed, 31 insertions(+), 110 deletions(-)
Signature · 1 line
2.43.0
PATCH 1/5 qemu-options: Remove the deprecated -no-hpet option
It's been marked as deprecated since QEMU 8.0, so it should be fine to remove this now.
--- docs/about/deprecated.rst | 6 ------ docs/about/removed-features.rst | 8 ++++++++ system/vl.c | 4 ---- qemu-options.hx | 7 ------- 4 files changed, 8 insertions(+), 17 deletions(-)
docs/about/deprecated.rst +0 -6
@@ -63,12 +63,6 @@ as short-form boolean values, and passed to plugins as ``arg_name=on``. However, short-form booleans are deprecated and full explicit ``arg_name=on`` form is preferred. -``-no-hpet`` (since 8.0) -'''''''''''''''''''''''' - -The HPET setting has been turned into a machine property. -Use ``-machine hpet=off`` instead. - ``-no-acpi`` (since 8.0) ''''''''''''''''''''''''
docs/about/removed-features.rst +8 -0
@@ -460,6 +460,14 @@ in this case. Note that the default audio backend must be configured on the command line if the ``-nodefaults`` options is used. +``-no-hpet`` (removed in 9.0) +''''''''''''''''''''''''''''' + +The HPET setting has been turned into a machine property. +Use ``-machine hpet=off`` instead. + + + QEMU Machine Protocol (QMP) commands ------------------------------------
system/vl.c +0 -4
@@ -3373,10 +3373,6 @@ void qemu_init(int argc, char **argv)warn_report ("-no-acpi is deprecated, use '-machine acpi=off' instead" );qdict_put_str (machine_opts_dict,"acpi" ,"off" );break ; -case QEMU_OPTION_no_hpet: -warn_report ("-no-hpet is deprecated, use '-machine hpet=off' instead" ); -qdict_put_str (machine_opts_dict,"hpet" ,"off" ); -break ;case QEMU_OPTION_no_reboot: olist =qemu_find_opts ("action" );qemu_opts_parse_noisily (olist,"reboot=shutdown" , false);
qemu-options.hx +0 -7
@@ -2654,13 +2654,6 @@ SRST machine only). ERST -DEF("no-hpet", 0, QEMU_OPTION_no_hpet, - "-no-hpet disable HPET\n", QEMU_ARCH_I386) -SRST -``-no-hpet`` - Disable HPET support. Deprecated, use '-machine hpet=off' instead. -ERST - DEF("acpitable", HAS_ARG, QEMU_OPTION_acpitable, "-acpitable [sig=str][,rev=n][,oem_id=str][,oem_table_id=str][,oem_rev=n][,asl_compiler_id=str][,asl_compiler_rev=n][,{data|file}=file1[:file2]...]\n" " ACPI table description\n", QEMU_ARCH_I386)
Signature · 1 line
2.43.0
Re: [PATCH 1/5] qemu-options: Remove the deprecated -no-hpet option
Quoted 4 lines · Thomas Huth
It's been marked as deprecated since QEMU 8.0, so it should be fine to remove this now.
Signed-off-by Thomas Huth <[email protected]>
PATCH 2/5 qemu-options: Remove the deprecated -no-acpi option
In reply to Thomas HuthIt's been marked as deprecated since QEMU 8.0, so it should be fine to remove this now.
--- docs/about/deprecated.rst | 6 ------ docs/about/removed-features.rst | 5 +++++ system/vl.c | 4 ---- qemu-options.hx | 9 --------- 4 files changed, 5 insertions(+), 19 deletions(-)
docs/about/deprecated.rst +0 -6
@@ -63,12 +63,6 @@ as short-form boolean values, and passed to plugins as ``arg_name=on``. However, short-form booleans are deprecated and full explicit ``arg_name=on`` form is preferred. -``-no-acpi`` (since 8.0) -'''''''''''''''''''''''' - -The ``-no-acpi`` setting has been turned into a machine property. -Use ``-machine acpi=off`` instead. - ``-async-teardown`` (since 8.1) '''''''''''''''''''''''''''''''
docs/about/removed-features.rst +5 -0
@@ -466,6 +466,11 @@ line if the ``-nodefaults`` options is used. The HPET setting has been turned into a machine property. Use ``-machine hpet=off`` instead. +``-no-acpi`` (removed in 9.0) +''''''''''''''''''''''''''''' + +The ``-no-acpi`` setting has been turned into a machine property. +Use ``-machine acpi=off`` instead. QEMU Machine Protocol (QMP) commands
system/vl.c +0 -4
@@ -3369,10 +3369,6 @@ void qemu_init(int argc, char **argv) display_remote++;break ;#endif -case QEMU_OPTION_no_acpi: -warn_report ("-no-acpi is deprecated, use '-machine acpi=off' instead" ); -qdict_put_str (machine_opts_dict,"acpi" ,"off" ); -break ;case QEMU_OPTION_no_reboot: olist =qemu_find_opts ("action" );qemu_opts_parse_noisily (olist,"reboot=shutdown" , false);
qemu-options.hx +0 -9
@@ -2645,15 +2645,6 @@ SRST needed to boot from old floppy disks. ERST -DEF("no-acpi", 0, QEMU_OPTION_no_acpi, - "-no-acpi disable ACPI\n", QEMU_ARCH_I386 | QEMU_ARCH_ARM) -SRST -``-no-acpi`` - Disable ACPI (Advanced Configuration and Power Interface) support. - Use it if your guest OS complains about ACPI problems (PC target - machine only). -ERST - DEF("acpitable", HAS_ARG, QEMU_OPTION_acpitable, "-acpitable [sig=str][,rev=n][,oem_id=str][,oem_table_id=str][,oem_rev=n][,asl_compiler_id=str][,asl_compiler_rev=n][,{data|file}=file1[:file2]...]\n" " ACPI table description\n", QEMU_ARCH_I386)
Signature · 1 line
2.43.0
Re: [PATCH 2/5] qemu-options: Remove the deprecated -no-acpi option
Quoted 4 lines · Thomas Huth
It's been marked as deprecated since QEMU 8.0, so it should be fine to remove this now.
Signed-off-by Thomas Huth <[email protected]>
Leftovers:
docs/specs/tpm.rst: -nographic -no-acpi \ hw/i386/pc.c: * When -no-acpi is used with Q35 machine type, no ACPI is built, hw/i386/pc.c: * When -no-acpi is used with Q35 machine type, no ACPI is built,
Re: [PATCH 2/5] qemu-options: Remove the deprecated -no-acpi option
Quoted 5 lines · Markus Armbruster
Quoted 3 lines · Thomas Huth
It's been marked as deprecated since QEMU 8.0, so it should be fine to remove this now.
Quoted 7 lines
Quoted 1 line
Signed-off-by Thomas Huth <[email protected]>Leftovers:
docs/specs/tpm.rst: -nographic -no-acpi \ hw/i386/pc.c: * When -no-acpi is used with Q35 machine type, no ACPI is built, hw/i386/pc.c: * When -no-acpi is used with Q35 machine type, no ACPI is built,
Thanks, I'll send a v2 to tackle these, too.
Thomas
PATCH 3/5 qemu-options: Remove the deprecated -async-teardown option
In reply to Thomas HuthIt's been marked as deprecated since QEMU 8.1 (and was only available since QEMU 8.0 anyway), so it should be fine to remove this now.
--- docs/about/deprecated.rst | 5 ----- docs/about/removed-features.rst | 5 +++++ system/vl.c | 6 ------ qemu-options.hx | 10 ---------- 4 files changed, 5 insertions(+), 21 deletions(-)
docs/about/deprecated.rst +0 -5
@@ -63,11 +63,6 @@ as short-form boolean values, and passed to plugins as ``arg_name=on``. However, short-form booleans are deprecated and full explicit ``arg_name=on`` form is preferred. -``-async-teardown`` (since 8.1) -''''''''''''''''''''''''''''''' - -Use ``-run-with async-teardown=on`` instead. - ``-chroot`` (since 8.1) '''''''''''''''''''''''
docs/about/removed-features.rst +5 -0
@@ -472,6 +472,11 @@ Use ``-machine hpet=off`` instead. The ``-no-acpi`` setting has been turned into a machine property. Use ``-machine acpi=off`` instead. +``-async-teardown`` (removed in 9.0) +'''''''''''''''''''''''''''''''''''' + +Use ``-run-with async-teardown=on`` instead. + QEMU Machine Protocol (QMP) commands ------------------------------------
system/vl.c +0 -6
@@ -3600,12 +3600,6 @@ void qemu_init(int argc, char **argv)case QEMU_OPTION_daemonize:os_set_daemonize (true);break ; -#if defined(CONFIG_LINUX ) -/* deprecated */ -case QEMU_OPTION_asyncteardown: -init_async_teardown (); -break ; -#endif case QEMU_OPTION_run_with: {const char *str; opts = qemu_opts_parse_noisily(qemu_find_opts("run-with"),
qemu-options.hx +0 -10
@@ -4975,16 +4975,6 @@ HXCOMM Internal use DEF("qtest", HAS_ARG, QEMU_OPTION_qtest, "", QEMU_ARCH_ALL) DEF("qtest-log", HAS_ARG, QEMU_OPTION_qtest_log, "", QEMU_ARCH_ALL) -#ifdef __linux__ -DEF("async-teardown", 0, QEMU_OPTION_asyncteardown, - "-async-teardown enable asynchronous teardown\n", - QEMU_ARCH_ALL) -SRST -``-async-teardown`` - This option is deprecated and should no longer be used. The new option - ``-run-with async-teardown=on`` is a replacement. -ERST -#endif #ifdef CONFIG_POSIX DEF("run-with", HAS_ARG, QEMU_OPTION_run_with, "-run-with [async-teardown=on|off][,chroot=dir]\n"
Signature · 1 line
2.43.0
Re: [PATCH 3/5] qemu-options: Remove the deprecated -async-teardown option
Quoted 4 lines · On Fri, 12 Jan 2024 11:00:57 +0100 Thomas Huth <[email protected]> wrote:
It's been marked as deprecated since QEMU 8.1 (and was only available since QEMU 8.0 anyway), so it should be fine to remove this now.
Signed-off-by Thomas Huth <[email protected]>
Quoted 77 lines
--- docs/about/deprecated.rst | 5 ----- docs/about/removed-features.rst | 5 +++++ system/vl.c | 6 ------ qemu-options.hx | 10 ---------- 4 files changed, 5 insertions(+), 21 deletions(-)docs/about/deprecated.rst +0
-5@@ -63,11 +63,6 @@ as short-form boolean values, and passed to plugins as ``arg_name=on``. However, short-form booleans are deprecated and full explicit ``arg_name=on`` form is preferred. -``-async-teardown`` (since 8.1) -''''''''''''''''''''''''''''''' - -Use ``-run-with async-teardown=on`` instead. - ``-chroot`` (since 8.1) '''''''''''''''''''''''docs/about/removed-features.rst +5
-0@@ -472,6 +472,11 @@ Use ``-machine hpet=off`` instead. The ``-no-acpi`` setting has been turned into a machine property. Use ``-machine acpi=off`` instead. +``-async-teardown`` (removed in 9.0) +'''''''''''''''''''''''''''''''''''' + +Use ``-run-with async-teardown=on`` instead. + QEMU Machine Protocol (QMP) commands ------------------------------------system/vl.c +0
-6@@ -3600,12 +3600,6 @@ void qemu_init(int argc, char **argv)case QEMU_OPTION_daemonize:os_set_daemonize (true);break ; -#if defined(CONFIG_LINUX ) -/* deprecated */ -case QEMU_OPTION_asyncteardown: -init_async_teardown (); -break ; -#endif case QEMU_OPTION_run_with: {const char *str; opts = qemu_opts_parse_noisily(qemu_find_opts("run-with"),qemu-options.hx +0
-10@@ -4975,16 +4975,6 @@ HXCOMM Internal use DEF("qtest", HAS_ARG, QEMU_OPTION_qtest, "", QEMU_ARCH_ALL) DEF("qtest-log", HAS_ARG, QEMU_OPTION_qtest_log, "", QEMU_ARCH_ALL) -#ifdef __linux__ -DEF("async-teardown", 0, QEMU_OPTION_asyncteardown, - "-async-teardown enable asynchronous teardown\n", - QEMU_ARCH_ALL) -SRST -``-async-teardown`` - This option is deprecated and should no longer be used. The new option - ``-run-with async-teardown=on`` is a replacement. -ERST -#endif #ifdef CONFIG_POSIX DEF("run-with", HAS_ARG, QEMU_OPTION_run_with, "-run-with [async-teardown=on|off][,chroot=dir]\n"
Re: [PATCH 3/5] qemu-options: Remove the deprecated -async-teardown option
In reply to Thomas HuthQuoted 4 lines · Thomas Huth
It's been marked as deprecated since QEMU 8.1 (and was only available since QEMU 8.0 anyway), so it should be fine to remove this now.
Signed-off-by Thomas Huth <[email protected]>
PATCH 4/5 qemu-options: Remove the deprecated -chroot option
In reply to Thomas HuthIt's been marked as deprecated since QEMU 8.1, so it should be fine to remove this now.
--- docs/about/deprecated.rst | 5 ----- docs/about/removed-features.rst | 5 +++++ system/vl.c | 5 ----- qemu-options.hx | 12 ------------ 4 files changed, 5 insertions(+), 22 deletions(-)
docs/about/deprecated.rst +0 -5
@@ -63,11 +63,6 @@ as short-form boolean values, and passed to plugins as ``arg_name=on``. However, short-form booleans are deprecated and full explicit ``arg_name=on`` form is preferred. -``-chroot`` (since 8.1) -''''''''''''''''''''''' - -Use ``-run-with chroot=dir`` instead. - ``-singlestep`` (since 8.1) '''''''''''''''''''''''''''
docs/about/removed-features.rst +5 -0
@@ -477,6 +477,11 @@ Use ``-machine acpi=off`` instead. Use ``-run-with async-teardown=on`` instead. +``-chroot`` (removed in 9.0) +'''''''''''''''''''''''''''' + +Use ``-run-with chroot=dir`` instead. + QEMU Machine Protocol (QMP) commands ------------------------------------
system/vl.c +0 -5
@@ -3592,11 +3592,6 @@ void qemu_init(int argc, char **argv)exit (1 ); }break ; -case QEMU_OPTION_chroot: -warn_report ("option is deprecated," -" use '-run-with chroot=...' instead" ); -os_set_chroot (optarg); -break ;case QEMU_OPTION_daemonize:os_set_daemonize (true);break ;
qemu-options.hx +0 -12
@@ -4790,18 +4790,6 @@ SRST ``-nodefaults`` option will disable all those default devices. ERST -#ifndef _WIN32 -DEF("chroot", HAS_ARG, QEMU_OPTION_chroot, \ - "-chroot dir chroot to dir just before starting the VM (deprecated)\n", - QEMU_ARCH_ALL) -#endif -SRST -``-chroot dir`` - Deprecated, use '-run-with chroot=...' instead. - Immediately before starting guest execution, chroot to the specified - directory. Especially useful in combination with -runas. -ERST - #ifndef _WIN32 DEF("runas", HAS_ARG, QEMU_OPTION_runas, \ "-runas user change to user id user just before starting the VM\n" \
Signature · 1 line
2.43.0
Re: [PATCH 4/5] qemu-options: Remove the deprecated -chroot option
Quoted 4 lines · Thomas Huth
It's been marked as deprecated since QEMU 8.1, so it should be fine to remove this now.
Signed-off-by Thomas Huth <[email protected]>
PATCH 5/5 qemu-options: Remove the deprecated -singlestep option
In reply to Thomas HuthIt's been marked as deprecated since QEMU 8.1, so it should be fine to remove this now.
--- docs/about/deprecated.rst | 6 ------ docs/about/removed-features.rst | 7 +++++++ system/vl.c | 18 +----------------- qemu-options.hx | 8 -------- 4 files changed, 8 insertions(+), 31 deletions(-)
docs/about/deprecated.rst +0 -6
@@ -63,12 +63,6 @@ as short-form boolean values, and passed to plugins as ``arg_name=on``. However, short-form booleans are deprecated and full explicit ``arg_name=on`` form is preferred. -``-singlestep`` (since 8.1) -''''''''''''''''''''''''''' - -The ``-singlestep`` option has been turned into an accelerator property, -and given a name that better reflects what it actually does. -Use ``-accel tcg,one-insn-per-tb=on`` instead. User-mode emulator command line arguments -----------------------------------------
docs/about/removed-features.rst +7 -0
@@ -482,6 +482,13 @@ Use ``-run-with async-teardown=on`` instead. Use ``-run-with chroot=dir`` instead. +``-singlestep`` (removed in 9.0) +'''''''''''''''''''''''''''''''' + +The ``-singlestep`` option has been turned into an accelerator property, +and given a name that better reflects what it actually does. +Use ``-accel tcg,one-insn-per-tb=on`` instead. + QEMU Machine Protocol (QMP) commands ------------------------------------
system/vl.c +1 -17
@@ -181,7 +181,6 @@ static const char *log_file;static bool list_data_dirs;static const char *qtest_chrdev;static const char *qtest_log; -static bool opt_one_insn_per_tb;static int has_defaults =1 ;static int default_audio =1 ;
@@ -2308,19 +2307,7 @@ static int do_configure_accelerator(void *opaque, QemuOpts *opts, Error **errp)qemu_opt_foreach (opts, accelerator_set_property, accel, &error_fatal); -/* -* If legacy -singlestep option is set, honour it for TCG and -* silently ignore for any other accelerator (which is how this -* option has always behaved). -*/ -if (opt_one_insn_per_tb) { -/* -* This will always succeed for TCG, and we want to ignore -* the error from trying to set a nonexistent property -* on any other accelerator. -*/ -object_property_set_bool (OBJECT (accel),"one-insn-per-tb" , true,NULL ); - } + ret =accel_init_machine (accel, current_machine);if (ret <0 ) {if (!qtest_with_kvm || ret != -ENOENT ) {
@@ -3057,9 +3044,6 @@ void qemu_init(int argc, char **argv)case QEMU_OPTION_bios:qdict_put_str (machine_opts_dict,"firmware" , optarg);break ; -case QEMU_OPTION_singlestep: - opt_one_insn_per_tb = true; -break ;case QEMU_OPTION_S : autostart =0 ;break ;
qemu-options.hx +0 -8
@@ -4357,14 +4357,6 @@ SRST from a script. ERST -DEF("singlestep", 0, QEMU_OPTION_singlestep, \ - "-singlestep deprecated synonym for -accel tcg,one-insn-per-tb=on\n", QEMU_ARCH_ALL) -SRST -``-singlestep`` - This is a deprecated synonym for the TCG accelerator property - ``one-insn-per-tb``. -ERST - DEF("preconfig", 0, QEMU_OPTION_preconfig, \ "--preconfig pause QEMU before machine is initialized (experimental)\n", QEMU_ARCH_ALL)
Signature · 1 line
2.43.0
Re: [PATCH 5/5] qemu-options: Remove the deprecated -singlestep option
Hi Thomas
+Laurent & Peter
Quoted 98 lines · Thomas Huth
It's been marked as deprecated since QEMU 8.1, so it should be fine to remove this now.
Signed-off-by Thomas Huth <[email protected]>--- docs/about/deprecated.rst | 6 ------ docs/about/removed-features.rst | 7 +++++++ system/vl.c | 18 +----------------- qemu-options.hx | 8 -------- 4 files changed, 8 insertions(+), 31 deletions(-)docs/about/deprecated.rst +0
-6@@ -63,12 +63,6 @@ as short-form boolean values, and passed to plugins as ``arg_name=on``. However, short-form booleans are deprecated and full explicit ``arg_name=on`` form is preferred. -``-singlestep`` (since 8.1) -''''''''''''''''''''''''''' - -The ``-singlestep`` option has been turned into an accelerator property, -and given a name that better reflects what it actually does. -Use ``-accel tcg,one-insn-per-tb=on`` instead. User-mode emulator command line arguments -----------------------------------------docs/about/removed-features.rst +7
-0@@ -482,6 +482,13 @@ Use ``-run-with async-teardown=on`` instead. Use ``-run-with chroot=dir`` instead. +``-singlestep`` (removed in 9.0) +'''''''''''''''''''''''''''''''' + +The ``-singlestep`` option has been turned into an accelerator property, +and given a name that better reflects what it actually does. +Use ``-accel tcg,one-insn-per-tb=on`` instead. + QEMU Machine Protocol (QMP) commands ------------------------------------system/vl.c +1
-17@@ -181,7 +181,6 @@ static const char *log_file;static bool list_data_dirs;static const char *qtest_chrdev;static const char *qtest_log; -static bool opt_one_insn_per_tb;static int has_defaults =1 ;static int default_audio =1 ;@@ -2308,19 +2307,7 @@ static int do_configure_accelerator(void *opaque, QemuOpts *opts, Error **errp)qemu_opt_foreach (opts, accelerator_set_property, accel, &error_fatal); -/* -* If legacy -singlestep option is set, honour it for TCG and -* silently ignore for any other accelerator (which is how this -* option has always behaved). -*/ -if (opt_one_insn_per_tb) { -/* -* This will always succeed for TCG, and we want to ignore -* the error from trying to set a nonexistent property -* on any other accelerator. -*/ -object_property_set_bool (OBJECT (accel),"one-insn-per-tb" , true,NULL ); - } + ret =accel_init_machine (accel, current_machine);if (ret <0 ) {if (!qtest_with_kvm || ret != -ENOENT ) {@@ -3057,9 +3044,6 @@ void qemu_init(int argc, char **argv)case QEMU_OPTION_bios:qdict_put_str (machine_opts_dict,"firmware" , optarg);break ; -case QEMU_OPTION_singlestep: - opt_one_insn_per_tb = true; -break ;case QEMU_OPTION_S : autostart =0 ;break ;qemu-options.hx +0
-1@@ -4357,14 +4357,6 @@ SRST from a script. ERST -DEF("singlestep", 0, QEMU_OPTION_singlestep, \
qemu-options.hx SRST · line 4362
Quoted 10 lines
qemu-options.hx +0
-7- "-singlestep deprecated synonym for -accel tcg,one-insn-per-tb=on\n", QEMU_ARCH_ALL) -SRST -``-singlestep`` - This is a deprecated synonym for the TCG accelerator property - ``one-insn-per-tb``. -ERST - DEF("preconfig", 0, QEMU_OPTION_preconfig, \ "--preconfig pause QEMU before machine is initialized (experimental)\n", QEMU_ARCH_ALL)
This is the system part, what about the user part?
StatusInfo::singlestep was deprecated at the same time, can we remove it?
IOW could we complete your patch with this?
-- >8 --
docs/about/deprecated.rst +0 -0
@@ -63,17 +63,6 @@ as short-form boolean values, and passed to plugins as ``arg_name=on``. However, short-form booleans are deprecated and full explicit
``arg_name=on``
form is preferred.
-
-User-mode emulator command line arguments
------------------------------------------
-
-``-singlestep`` (since 8.1)
-'''''''''''''''''''''''''''
-
-The ``-singlestep`` option has been given a name that better reflects -what it actually does. For both linux-user and bsd-user, use the -new ``-one-insn-per-tb`` option instead.
-
QEMU Machine Protocol (QMP) commands
------------------------------------
@@ -145,20 +134,6 @@ accepted incorrect commands will return an error. Users should make sure that
all arguments passed to ``device_add`` are consistent with the documented property types.
-``StatusInfo`` member ``singlestep`` (since 8.1) -''''''''''''''''''''''''''''''''''''''''''''''''
-
-The ``singlestep`` member of the ``StatusInfo`` returned from the -``query-status`` command is deprecated. This member has a confusing -name and it never did what the documentation claimed or what its name -suggests. We do not believe that anybody is actually using the -information provided in this member.
-
-The information it reports is whether the TCG JIT is in "one -instruction per translated block" mode (which can be set on the -command line or via the HMP, but not via QMP). The information remains -available via the HMP 'info jit' command.
-
QEMU Machine Protocol (QMP) events
----------------------------------
docs/user/main.rst +0 -6
@@ -98,9 +98,6 @@ Debug options: This slows down emulation a lot, but can be useful in some situations, such as when trying to analyse the logs produced by the ``-d`` option. -``-singlestep`` - This is a deprecated synonym for the ``-one-insn-per-tb`` option. - Environment variables: QEMU_STRACE
@@ -251,6 +248,3 @@ Debug options: Run the emulation with one guest instruction per translation block. This slows down emulation a lot, but can be useful in some situations, such as when trying to analyse the logs produced by the ``-d`` option. - -``-singlestep`` - This is a deprecated synonym for the ``-one-insn-per-tb`` option.
qapi/run-state.json +0 -11
@@ -106,25 +106,15 @@ # # @running: true if all VCPUs are runnable, false if not runnable # -# @singlestep: true if using TCG with one guest instruction per -# translation block -# # @status: the virtual machine @RunState # # Features: # -# @deprecated: Member 'singlestep' is deprecated (with no -# replacement). -# # Since: 0.14 # -# Notes: @singlestep is enabled on the command line with '-accel -# tcg,one-insn-per-tb=on', or with the HMP 'one-insn-per-tb' -# command. ## { 'struct': 'StatusInfo', 'data': {'running': 'bool', - 'singlestep': { 'type': 'bool', 'features': [ 'deprecated' ]}, 'status': 'RunState'} } ##
@@ -140,7 +130,6 @@ # # -> { "execute": "query-status" } # <- { "return": { "running": true, -# "singlestep": false, # "status": "running" } } ## { 'command': 'query-status', 'returns': 'StatusInfo',
bsd-user/main.c +0 -0
@@ -163,7 +163,6 @@ static void usage(void)" (use '-d help' for a list of log items)\n" "-D logfile write logs to 'logfile' (default stderr)\n" "-one-insn-per-tb run with one guest instruction per
emulated TB\n"
- "-singlestep deprecated synonym for -one-insn-per-tb\n"
"-strace log system calls\n"
"-trace
[[enable=]<pattern>][,events=<file>][,file=<file>]\n"
" specify tracing options\n"
@@ -391,7 +390,7 @@ int main(int argc, char **argv)
(void) envlist_unsetenv(envlist, "LD_PRELOAD");
} else if (!strcmp(r, "seed")) {
seed_optarg = optarg;
- } else if (!strcmp(r, "singlestep") || !strcmp(r, "one-insn-per-tb")) {
+ } else if (!strcmp(r, "one-insn-per-tb")) {
opt_one_insn_per_tb = true;
} else if (!strcmp(r, "strace")) {
do_strace = 1;linux-user/main.c +0 -0
@@ -500,8 +500,6 @@ static const struct qemu_argument arg_table[] = { {"one-insn-per-tb" , "QEMU_ONE_INSN_PER_TB", false,
handle_arg_one_insn_per_tb,
"", "run with one guest instruction per emulated TB"},
- {"singlestep", "QEMU_SINGLESTEP", false, handle_arg_one_insn_per_tb,
- "", "deprecated synonym for -one-insn-per-tb"},
{"strace", "QEMU_STRACE", false, handle_arg_strace,
"", "log system calls"},
{"seed", "QEMU_RAND_SEED", true, handle_arg_seed,system/runstate.c +0 -8
@@ -242,15 +242,7 @@ bool runstate_needs_reset(void)StatusInfo *qmp_query_status (Error **errp) {StatusInfo *info =g_malloc0 (sizeof (*info)); -AccelState *accel =current_accel (); -/* -* We ignore errors, which will happen if the accelerator -* is not TCG. "singlestep" is meaningless for other accelerators, -* so we will set the StatusInfo field to false for those. -*/ - info->singlestep =object_property_get_bool (OBJECT (accel), -"one-insn-per-tb" ,NULL ); info->running =runstate_is_running (); info->status = current_run_state;
tests/qemu-iotests/183.out +1 -1
@@ -30,13 +30,13 @@ read 65536/65536 bytes at offset 0 'arguments': { 'uri': 'unix:SOCK_DIR/migrate', 'blk': true } } {"return": {}} { 'execute': 'query-status' } -{"return": {"status": "postmigrate", "singlestep": false, "running": false}} +{"return": {"status": "postmigrate", "running": false}} === Do some I/O on the destination === { 'execute': 'query-status' } {"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP},
"event": "RESUME"}
-{"return": {"status": "running", "singlestep": false, "running": true}} +{"return": {"status": "running", "running": true}}
{ 'execute': 'human-monitor-command',
'arguments': { 'command-line':
'qemu-io disk "read -P 0x55 0 64k"' } }tests/qemu-iotests/234.out +0 -0
@@ -15,8 +15,8 @@ Starting migration to B... {"data": {"status": "completed"}, "event": "MIGRATION", "timestamp":
{"microseconds": "USECS", "seconds": "SECS"}}
completed
completed
-{"return": {"running": false, "singlestep": false, "status": "postmigrate"}} -{"return": {"running": true, "singlestep": false, "status": "running"}} +{"return": {"running": false, "status": "postmigrate"}} +{"return": {"running": true, "status": "running"}}
Add a second parent to drive0-file...
{"return": {}}
Restart A with -incoming and second parent...
@@ -32,5 +32,5 @@ Starting migration back to A...
{"data": {"status": "completed"}, "event": "MIGRATION", "timestamp":
{"microseconds": "USECS", "seconds": "SECS"}}
completed
completed
-{"return": {"running": true, "singlestep": false, "status": "running"}} -{"return": {"running": false, "singlestep": false, "status": "postmigrate"}} +{"return": {"running": true, "status": "running"}}
+{"return": {"running": false, "status": "postmigrate"}}
tests/qemu-iotests/262.out +0 -0
@@ -13,5 +13,5 @@ Starting migration to B... {"data": {"status": "completed"}, "event": "MIGRATION", "timestamp":
{"microseconds": "USECS", "seconds": "SECS"}}
completed
completed
-{"return": {"running": false, "singlestep": false, "status": "postmigrate"}} -{"return": {"running": true, "singlestep": false, "status": "running"}} +{"return": {"running": false, "status": "postmigrate"}} +{"return": {"running": true, "status": "running"}}
tests/qemu-iotests/280.out +1 -1
@@ -12,7 +12,7 @@ Enabling migration QMP events on VM... VM is now stopped: completed {"execute": "query-status", "arguments": {}} -{"return": {"running": false, "singlestep": false, "status": "postmigrate"}} +{"return": {"running": false, "status": "postmigrate"}} === Create a snapshot of the disk image === {"execute": "blockdev-create", "arguments": {"job-id": "job0",
"options": {"driver": "file", "filename": "TEST_DIR/PID-top", "size": 0}}}
---
Re: [PATCH 5/5] qemu-options: Remove the deprecated -singlestep option
Quoted 203 lines · Philippe Mathieu-Daudé
Hi Thomas
+Laurent & Peter
Quoted 102 lines · Thomas Huth
It's been marked as deprecated since QEMU 8.1, so it should be fine to remove this now.
Signed-off-by Thomas Huth <[email protected]>---
docs/about/deprecated.rst | 6 ------docs/about/removed-features.rst| 7 +++++++ system/vl.c | 18 +----------------- qemu-options.hx | 8 --------4 files changed, 8 insertions(+), 31 deletions(-)docs/about/deprecated.rst +0
-0@@ -63,12 +63,6 @@ as short-form boolean values, and passed to plugins as``arg_name=on``.
However, short-form booleans are deprecated and full explicit ``arg_name=on`` form is preferred.
-``-singlestep`` (since 8.1)
-'''''''''''''''''''''''''''docs/about/deprecated.rst +0
-4- -The ``-singlestep`` option has been turned into an accelerator property, -and given a name that better reflects what it actually does. -Use ``-accel tcg,one-insn-per-tb=on`` instead.User-mode emulator command line arguments
-----------------------------------------docs/about/removed-features.rst +0
-0@@ -482,6 +482,13 @@ Use ``-run-with async-teardown=on`` instead.Use ``-run-with chroot=dir`` instead.
+``-singlestep`` (removed in 9.0)
+''''''''''''''''''''''''''''''''docs/about/removed-features.rst +5
-0+ +The ``-singlestep`` option has been turned into an accelerator property, +and given a name that better reflects what it actually does. +Use ``-accel tcg,one-insn-per-tb=on`` instead. +QEMU Machine Protocol (QMP) commands
------------------------------------system/vl.c +1
-14@@ -181,7 +181,6 @@ static const char *log_file; static bool list_data_dirs; static const char *qtest_chrdev; static const char *qtest_log; -static bool opt_one_insn_per_tb; static int has_defaults = 1; static int default_audio = 1;@@ -2308,19 +2307,7 @@ static int do_configure_accelerator(void *opaque, QemuOpts *opts, Error **errp) qemu_opt_foreach(opts, accelerator_set_property, accel, &error_fatal); - /* - * If legacy -singlestep option is set, honour it for TCG and - * silently ignore for any other accelerator (which is how this - * option has always behaved). - */ - if (opt_one_insn_per_tb) { - /* - * This will always succeed for TCG, and we want to ignore - * the error from trying to set a nonexistent property - * on any other accelerator. - */ - object_property_set_bool(OBJECT(accel), "one-insn-per-tb", true, NULL); - } + ret = accel_init_machine(accel, current_machine);if (ret < 0) {
if (!qtest_with_kvm || ret !=-ENOENT) {system/vl.c +0
-0@@ -3057,9 +3044,6 @@ void qemu_init(int argc, char **argv)case
QEMU_OPTION_bios:
qdict_put_str(machine_opts_dict, "firmware", optarg); break;
- caseQEMU_OPTION_singlestep:
-opt_one_insn_per_tb= true;
- break;
caseQEMU_OPTION_S:
autostart = 0;
break;qemu-options.hx +0
-0@@ -4357,14 +4357,6 @@ SRSTfrom a script.
ERST
-DEF("singlestep", 0,QEMU_OPTION_singlestep, \
- "-singlestep deprecated synonym for -accel tcg,one-insn-per-tb=on\n",QEMU_ARCH_ALL)qemu-options.hx +0
-6-SRST -``-singlestep`` - This is a deprecated synonym for the TCG accelerator property - ``one-insn-per-tb``. -ERST -Quoted 3 lines
DEF("preconfig", 0,
QEMU_OPTION_preconfig, \
"--preconfig pause QEMU before machine is initialized (experimental)\n",QEMU_ARCH_ALL)This is the system part, what about the user part?
StatusInfo::singlestepwas deprecated at the same time, can we remove it?IOW could we complete your patch with this?
-- >8 --
docs/about/deprecated.rst +0
-0@@ -63,17 +63,6 @@ as short-form boolean values, and passed to plugins as``arg_name=on``.
However, short-form booleans are deprecated and full explicit ``arg_name=on`` form is preferred.docs/about/deprecated.rst +0
-11- -User-mode emulator command line arguments ------------------------------------------ - -``-singlestep`` (since 8.1) -''''''''''''''''''''''''''' - -The ``-singlestep`` option has been given a name that better reflects -what it actually does. For both linux-user and bsd-user, use the -new ``-one-insn-per-tb`` option instead. - QEMU Machine Protocol (QMP) commands ------------------------------------@@ -145,20 +134,6 @@ accepted incorrect commands will return an error. Usersshould make sure that
all arguments passed to ``device_add`` are consistent with the documented property types.-``StatusInfo`` member ``singlestep`` (since 8.1)
-''''''''''''''''''''''''''''''''''''''''''''''''docs/about/deprecated.rst +0
-12- -The ``singlestep`` member of the ``StatusInfo`` returned from the -``query-status`` command is deprecated. This member has a confusing -name and it never did what the documentation claimed or what its name -suggests. We do not believe that anybody is actually using the -information provided in this member. - -The information it reports is whether the TCG JIT is in "one -instruction per translated block" mode (which can be set on the -command line or via the HMP, but not via QMP). The information remains -available via the HMP 'info jit' command. - QEMU Machine Protocol (QMP) events ----------------------------------docs/user/main.rst +0
-6@@ -98,9 +98,6 @@ Debug options: This slows down emulation a lot, but can be useful in some situations, such as when trying to analyse the logs produced by the ``-d`` option. -``-singlestep`` - This is a deprecated synonym for the ``-one-insn-per-tb`` option. - Environment variables: QEMU_STRACE@@ -251,6 +248,3 @@ Debug options: Run the emulation with one guest instruction per translation block. This slows down emulation a lot, but can be useful in some situations, such as when trying to analyse the logs produced by the ``-d`` option. - -``-singlestep`` - This is a deprecated synonym for the ``-one-insn-per-tb`` option.qapi/run-state.json +0
-6@@ -106,25 +106,15 @@ # # @running: true if all VCPUs are runnable, false if not runnable # -# @singlestep: true if using TCG with one guest instruction per -# translation block -# # @status: the virtual machine @RunState # # Features: # -# @deprecated: Member 'singlestep' is deprecated (with no -# replacement). -#
qapi/run-state.json line 118
Quoted 10 lines
qapi/run-state.json +0
-4# Since: 0.14 # -# Notes: @singlestep is enabled on the command line with '-accel -# tcg,one-insn-per-tb=on', or with the HMP 'one-insn-per-tb' -# command. ## { 'struct': 'StatusInfo', 'data': {'running': 'bool', - 'singlestep': { 'type': 'bool', 'features': [ 'deprecated' ]}, 'status': 'RunState'} }
Uh, oh, that's a bigger change already ... can we safely remove the field here without upsetting 3rd party apps that rely on this interface? Anyway, I withdraw my patch for -singlestep ... this should be handled by someone who's more familiar with these pieces of the code.
Thomas
Re: [PATCH 5/5] qemu-options: Remove the deprecated -singlestep option
Quoted 40 lines · Thomas Huth
Quoted 38 lines · Philippe Mathieu-Daudé
Hi Thomas
+Laurent & Peter
Quoted 4 lines · Thomas Huth
It's been marked as deprecated since QEMU 8.1, so it should be fine to remove this now.
Signed-off-by Thomas Huth <[email protected]>
StatusInfo::singlestepwas deprecated at the same time, can we remove it?IOW could we complete your patch with this?
qapi/run-state.json +0
-9@@ -106,25 +106,15 @@ # # @running: true if all VCPUs are runnable, false if not runnable # -# @singlestep: true if using TCG with one guest instruction per -# translation block -# # @status: the virtual machine @RunState # # Features: # -# @deprecated: Member 'singlestep' is deprecated (with no -# replacement). -# # Since: 0.14 # -# Notes: @singlestep is enabled on the command line with '-accel -# tcg,one-insn-per-tb=on', or with the HMP 'one-insn-per-tb' -# command.
Quoted 8 lines
qapi/run-state.json line 118
Quoted 5 lines
qapi/run-state.json +0
-1## { 'struct': 'StatusInfo', 'data': {'running': 'bool', - 'singlestep': { 'type': 'bool', 'features': [ 'deprecated' ]}, 'status': 'RunState'} }Uh, oh, that's a bigger change already ... can we safely remove the field here without upsetting 3rd party apps that rely on this interface?
That was the whole point of marking it 'deprecated' in the JSON, I thought? We don't think anybody's using it, we've given fair warning, isn't the next step "remove it"? Markus, you're the expert on QAPI deprecations...
-- PMM
Re: [PATCH 5/5] qemu-options: Remove the deprecated -singlestep option
Quoted 50 lines · Peter Maydell
Quoted 40 lines · Thomas Huth
Quoted 38 lines · Philippe Mathieu-Daudé
Hi Thomas
+Laurent & Peter
Quoted 4 lines · Thomas Huth
It's been marked as deprecated since QEMU 8.1, so it should be fine to remove this now.
Signed-off-by Thomas Huth <[email protected]>
StatusInfo::singlestepwas deprecated at the same time, can we remove it?IOW could we complete your patch with this?
qapi/run-state.json +0
-9@@ -106,25 +106,15 @@ # # @running: true if all VCPUs are runnable, false if not runnable # -# @singlestep: true if using TCG with one guest instruction per -# translation block -# # @status: the virtual machine @RunState # # Features: # -# @deprecated: Member 'singlestep' is deprecated (with no -# replacement). -# # Since: 0.14 # -# Notes: @singlestep is enabled on the command line with '-accel -# tcg,one-insn-per-tb=on', or with the HMP 'one-insn-per-tb' -# command.Quoted 8 lines
qapi/run-state.json line 118
Quoted 5 lines
qapi/run-state.json +0
-1## { 'struct': 'StatusInfo', 'data': {'running': 'bool', - 'singlestep': { 'type': 'bool', 'features': [ 'deprecated' ]}, 'status': 'RunState'} }Uh, oh, that's a bigger change already ... can we safely remove the field here without upsetting 3rd party apps that rely on this interface?
Quoted 4 lines
That was the whole point of marking it 'deprecated' in the JSON, I thought? We don't think anybody's using it, we've given fair warning, isn't the next step "remove it"? Markus, you're the expert on QAPI deprecations...
Yes, it is fine to delete it without thinking further about possible usage, unless someone steps forward quickly with new information that wasn't known when the deprecation was added....
With regards,
Daniel
Signature · 3 lines
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
Re: [PATCH 5/5] qemu-options: Remove the deprecated -singlestep option
Quoted 51 lines · Daniel P. Berrangé
Quoted 50 lines · Peter Maydell
Quoted 48 lines · Thomas Huth
Quoted 33 lines · Philippe Mathieu-Daudé
Hi Thomas
+Laurent & Peter
Quoted 4 lines · Thomas Huth
It's been marked as deprecated since QEMU 8.1, so it should be fine to remove this now.
Signed-off-by Thomas Huth <[email protected]>
StatusInfo::singlestepwas deprecated at the same time, can we remove it?IOW could we complete your patch with this?
qapi/run-state.json +0
-6@@ -106,25 +106,15 @@ # # @running: true if all VCPUs are runnable, false if not runnable # -# @singlestep: true if using TCG with one guest instruction per -# translation block -# # @status: the virtual machine @RunState # # Features: # -# @deprecated: Member 'singlestep' is deprecated (with no -# replacement). -#qapi/run-state.json line 118
Quoted 10 lines
qapi/run-state.json +0
-4# Since: 0.14 # -# Notes: @singlestep is enabled on the command line with '-accel -# tcg,one-insn-per-tb=on', or with the HMP 'one-insn-per-tb' -# command. ## { 'struct': 'StatusInfo', 'data': {'running': 'bool', - 'singlestep': { 'type': 'bool', 'features': [ 'deprecated' ]}, 'status': 'RunState'} }Uh, oh, that's a bigger change already ... can we safely remove the field here without upsetting 3rd party apps that rely on this interface?
Quoted 8 lines
Quoted 4 lines
That was the whole point of marking it 'deprecated' in the JSON, I thought? We don't think anybody's using it, we've given fair warning, isn't the next step "remove it"? Markus, you're the expert on QAPI deprecations...
Yes, it is fine to delete it without thinking further about possible usage, unless someone steps forward quickly with new information that wasn't known when the deprecation was added....
Concur.
Supporting data:
commit 34c18203d472c5bf969ebd87dc06c7c3a957efc4
Author: Peter Maydell <[email protected]> Date: Mon Apr 17 17:40:41 2023 +0100
qmp: Deprecate 'singlestep' member of StatusInfo
The 'singlestep' member of StatusInfo has never done what the QMP documentation claims it does. What it actually reports is whether TCG is working in "one guest instruction per translation block" mode.
We no longer need this field for the HMP 'info status' command, as we've moved that information to 'info jit'. It seems unlikely that anybody is monitoring the state of this obscure TCG setting via QMP, especially since QMP provides no means for changing the setting. So simply deprecate the field, without providing any replacement.
Until we do eventually delete the member, correct the misstatements in the QAPI documentation about it.
If we do find that there are users for this, then the most likely way we would provide replacement access to the information would be to put the accelerator QOM object at a well-known path such as /machine/accel, which could then be used with the existing qom-set and qom-get commands.
Message-id: [email protected]
docs/about/deprecated.rst +14 -0
@@ -199,6 +199,20 @@ accepted incorrect commands will return an error. Users should make sure that all arguments passed to ``device_add`` are consistent with the documented property types. +``StatusInfo`` member ``singlestep`` (since 8.1) +'''''''''''''''''''''''''''''''''''''''''''''''' + +The ``singlestep`` member of the ``StatusInfo`` returned from the +``query-status`` command is deprecated. This member has a confusing +name and it never did what the documentation claimed or what its name +suggests. We do not believe that anybody is actually using the +information provided in this member. + +The information it reports is whether the TCG JIT is in "one +instruction per translated block" mode (which can be set on the +command line or via the HMP, but not via QMP). The information remains +available via the HMP 'info jit' command. +
[...]
Re: [PATCH 5/5] qemu-options: Remove the deprecated -singlestep option
Quoted 58 lines · Markus Armbruster
Quoted 56 lines · Daniel P. Berrangé
Quoted 54 lines · Peter Maydell
Quoted 40 lines · Thomas Huth
Quoted 38 lines · Philippe Mathieu-Daudé
Hi Thomas
+Laurent & Peter
Quoted 4 lines · Thomas Huth
It's been marked as deprecated since QEMU 8.1, so it should be fine to remove this now.
Signed-off-by Thomas Huth <[email protected]>
StatusInfo::singlestepwas deprecated at the same time, can we remove it?IOW could we complete your patch with this?
qapi/run-state.json +0
-9@@ -106,25 +106,15 @@ # # @running: true if all VCPUs are runnable, false if not runnable # -# @singlestep: true if using TCG with one guest instruction per -# translation block -# # @status: the virtual machine @RunState # # Features: # -# @deprecated: Member 'singlestep' is deprecated (with no -# replacement). -# # Since: 0.14 # -# Notes: @singlestep is enabled on the command line with '-accel -# tcg,one-insn-per-tb=on', or with the HMP 'one-insn-per-tb' -# command.Quoted 8 lines
qapi/run-state.json line 118
Quoted 5 lines
qapi/run-state.json +0
-1## { 'struct': 'StatusInfo', 'data': {'running': 'bool', - 'singlestep': { 'type': 'bool', 'features': [ 'deprecated' ]}, 'status': 'RunState'} }Uh, oh, that's a bigger change already ... can we safely remove the field here without upsetting 3rd party apps that rely on this interface?
That was the whole point of marking it 'deprecated' in the JSON, I thought? We don't think anybody's using it, we've given fair warning, isn't the next step "remove it"? Markus, you're the expert on QAPI deprecations...
Quoted 5 lines
Quoted 3 lines
Yes, it is fine to delete it without thinking further about possible usage, unless someone steps forward quickly with new information that wasn't known when the deprecation was added....
Concur.
Thanks all for the feedback.
Thomas, are you OK to post a v2 with the changes I suggested or do you want me to do it?
Quoted 57 lines
Supporting data:
commit
34c18203d472c5bf969ebd87dc06c7c3a957efc4Author: Peter Maydell <[email protected]> Date: Mon Apr 17 17:40:41 2023 +0100qmp: Deprecate 'singlestep' member of StatusInfo
The 'singlestep' member of StatusInfo has never done what the QMP documentation claims it does. What it actually reports is whether TCG is working in "one guest instruction per translation block" mode.
We no longer need this field for the HMP 'info status' command, as we've moved that information to 'info jit'. It seems unlikely that anybody is monitoring the state of this obscure TCG setting via QMP, especially since QMP provides no means for changing the setting. So simply deprecate the field, without providing any replacement.
Until we do eventually delete the member, correct the misstatements in the QAPI documentation about it.
If we do find that there are users for this, then the most likely way we would provide replacement access to the information would be to put the accelerator QOM object at a well-known path such as /machine/accel, which could then be used with the existing qom-set and qom-get commands.
Signed-off-by Peter Maydell <[email protected]>Reviewed-by Richard Henderson <[email protected]>Reviewed-by Philippe Mathieu-Daudé <[email protected]>Reviewed-by Markus Armbruster <[email protected]>Message-id: [email protected]
docs/about/deprecated.rst +14
-0@@ -199,6 +199,20 @@ accepted incorrect commands will return an error. Users should make sure that all arguments passed to ``device_add`` are consistent with the documented property types. +``StatusInfo`` member ``singlestep`` (since 8.1) +'''''''''''''''''''''''''''''''''''''''''''''''' + +The ``singlestep`` member of the ``StatusInfo`` returned from the +``query-status`` command is deprecated. This member has a confusing +name and it never did what the documentation claimed or what its name +suggests. We do not believe that anybody is actually using the +information provided in this member. + +The information it reports is whether the TCG JIT is in "one +instruction per translated block" mode (which can be set on the +command line or via the HMP, but not via QMP). The information remains +available via the HMP 'info jit' command. +
Re: [PATCH 5/5] qemu-options: Remove the deprecated -singlestep option
Quoted 64 lines · Philippe Mathieu-Daudé
Quoted 63 lines · Markus Armbruster
Quoted 60 lines · Daniel P. Berrangé
Quoted 51 lines · Peter Maydell
Quoted 41 lines · Thomas Huth
Quoted 39 lines · Philippe Mathieu-Daudé
Hi Thomas
+Laurent & Peter
Quoted 4 lines · Thomas Huth
It's been marked as deprecated since QEMU 8.1, so it should be fine to remove this now.
Signed-off-by Thomas Huth <[email protected]>
StatusInfo::singlestepwas deprecated at the same time, can we remove it?IOW could we complete your patch with this?
qapi/run-state.json +0
-9@@ -106,25 +106,15 @@ # # @running: true if all VCPUs are runnable, false if not runnable # -# @singlestep: true if using TCG with one guest instruction per -# translation block -# # @status: the virtual machine @RunState # # Features: # -# @deprecated: Member 'singlestep' is deprecated (with no -# replacement). -# # Since: 0.14 # -# Notes: @singlestep is enabled on the command line with '-accel -# tcg,one-insn-per-tb=on', or with the HMP 'one-insn-per-tb' -# command. ##Quoted 8 lines
qapi/run-state.json line 119
Quoted 5 lines
qapi/run-state.json +0
-1{ 'struct': 'StatusInfo', 'data': {'running': 'bool', - 'singlestep': { 'type': 'bool', 'features': [ 'deprecated' ]}, 'status': 'RunState'} }Uh, oh, that's a bigger change already ... can we safely remove the field here without upsetting 3rd party apps that rely on this interface?
Quoted 4 lines
That was the whole point of marking it 'deprecated' in the JSON, I thought? We don't think anybody's using it, we've given fair warning, isn't the next step "remove it"? Markus, you're the expert on QAPI deprecations...
Yes, it is fine to delete it without thinking further about possible usage, unless someone steps forward quickly with new information that wasn't known when the deprecation was added....
Quoted 6 lines
Quoted 1 line
Concur.
Thanks all for the feedback.
Thomas, are you OK to post a v2 with the changes I suggested or do you want me to do it?
Since your changes were bigger than mine, I think it's just fair if you take credit for the patch. So yes, please go ahead and assemble it as a v2! Thanks!
Thomas
Re: [PATCH 5/5] qemu-options: Remove the deprecated -singlestep option
Quoted 6 lines · Thomas Huth
Quoted 2 lines · Philippe Mathieu-Daudé
Thomas, are you OK to post a v2 with the changes I suggested or do you want me to do it?
Since your changes were bigger than mine, I think it's just fair if you take credit for the patch. So yes, please go ahead and assemble it as a v2! Thanks!
Sent only respin of this patch based on first 4 (untouched):
https://lore.kernel.org/qemu-devel/[email protected]/
(neglected to name it v2)
Re: [PATCH 5/5] qemu-options: Remove the deprecated -singlestep option
In reply to Thomas HuthQuoted 4 lines · Thomas Huth
It's been marked as deprecated since QEMU 8.1, so it should be fine to remove this now.
Signed-off-by Thomas Huth <[email protected]>
Should we drop HMP command singlestep, too?
Re: [PATCH 5/5] qemu-options: Remove the deprecated -singlestep option
Quoted 8 lines · Markus Armbruster
Quoted 4 lines · Thomas Huth
It's been marked as deprecated since QEMU 8.1, so it should be fine to remove this now.
Signed-off-by Thomas Huth <[email protected]>Should we drop HMP command singlestep, too?
Yes, patch on the way.