Skip to contentSkip to conversation

baseband/acc: remove ACC101 variant

PATCH Applied Hernan Vargas 2 participants 4 messages Jan 12, 2024 – Feb 7, 2024

lore
Share & tools
lore
#0 lore raw

cover baseband/acc: remove ACC101 variant

Removing obsolete code for ACC101 variant which will not be productized.

Hernan Vargas (1):
baseband/acc: remove acc101

 doc/guides/bbdevs/acc100.rst           |  18 +-
 doc/guides/rel_notes/release_24_03.rst |   1 +
 drivers/baseband/acc/acc100_pmd.h      |   5 +-
 drivers/baseband/acc/acc101_pmd.h      |  40 ---
 drivers/baseband/acc/rte_acc100_pmd.c  | 425 -------------------------
 5 files changed, 6 insertions(+), 483 deletions(-)
 delete mode 100644 drivers/baseband/acc/acc101_pmd.h
Signature · 1 line
2.37.1
#1 lore raw

PATCH 1/1 baseband/acc: remove acc101

The ACC101 HW variant is not productized, the relevant code is removed as obsolete.

---
 doc/guides/bbdevs/acc100.rst           |  18 +-
 doc/guides/rel_notes/release_24_03.rst |   1 +
 drivers/baseband/acc/acc100_pmd.h      |   5 +-
 drivers/baseband/acc/acc101_pmd.h      |  40 ---
 drivers/baseband/acc/rte_acc100_pmd.c  | 425 -------------------------
 5 files changed, 6 insertions(+), 483 deletions(-)
 delete mode 100644 drivers/baseband/acc/acc101_pmd.h
doc/guides/bbdevs/acc100.rst +4 -14
index de51101e54d5..38a7a11d4ebd 100644
@@ -1,19 +1,17 @@
 ..  SPDX-License-Identifier: BSD-3-Clause
     Copyright(c) 2020 Intel Corporation
 
-Intel(R) ACC100 and ACC101 5G/4G FEC Poll Mode Drivers
+Intel(R) ACC100 5G/4G FEC Poll Mode Drivers
 ======================================================
 
 The BBDEV ACC100 5G/4G FEC poll mode driver (PMD) supports an
 implementation of a VRAN FEC wireless acceleration function.
 This device is also known as Mount Bryce.
-The BBDEV ACC101, also known as Mount Cirrus, is a derivative device from Mount Bryce
-with functional and capacity improvements but still with the same exposed BBDEV capabilities.
 
 Features
 --------
 
-ACC100 and ACC101 5G/4G FEC PMDs support the following features:
+ACC100 5G/4G FEC PMDs support the following features:
 
 - LDPC Encode in the DL (5GNR)
 - LDPC Decode in the UL (5GNR)
@@ -25,7 +23,7 @@ ACC100 and ACC101 5G/4G FEC PMDs support the following features:
 - MSI
 - SR-IOV
 
-ACC100 and ACC101 5G/4G FEC PMDs support the following BBDEV capabilities:
+ACC100 5G/4G FEC PMDs support the following BBDEV capabilities:
 
 * For the LDPC encode operation:
    - ``RTE_BBDEV_LDPC_CRC_24B_ATTACH`` :  set to attach CRC24B to CB(s)
@@ -94,12 +92,11 @@ Initialization
 --------------
 
 When the device first powers up, its PCI Physical Functions (PF) can be listed through these
-commands for ACC100 (device id ``0d5c``) and ACC101 (device id ``57c4``) respectively:
+commands for ACC100:
 
 .. code-block:: console
 
   sudo lspci -vd8086:0d5c
-  sudo lspci -vd8086:57c4
 
 The physical and virtual functions are compatible with Linux UIO drivers:
 ``vfio_pci`` and ``igb_uio``. However, in order to work the 5G/4G
@@ -157,10 +154,3 @@ Specifically for the BBDEV ACC100 PMD, the command below can be used:
 
   ./pf_bb_config ACC100 -c acc100/acc100_config_vf_5g.cfg
   ./test-bbdev.py -e="-c 0xff0 -a${VF_PCI_ADDR}" -c validation -n 64 -b 32 -l 1 -v ./ldpc_dec_default.data
-
-Specifically for the BBDEV ACC101 PMD, the command below can be used:
-
-.. code-block:: console
-
-  ./pf_bb_config ACC101 -c acc101/acc101_config_2vf_4g5g.cfg
-  ./test-bbdev.py -e="-c 0xff0 -a${VF_PCI_ADDR}" -c validation -n 64 -b 32 -l 1 -v ./ldpc_dec_default.data
doc/guides/rel_notes/release_24_03.rst +1 -0
index e9c9717706a0..a964dcf16745 100644
@@ -68,6 +68,7 @@ Removed Items
    Also, make sure to start the actual text at the margin.
    =======================================================
 
+* acc101: Removed obsolete code for non productized HW variant.
 
 API Changes
 -----------
drivers/baseband/acc/acc100_pmd.h +1 -4
index 5a8965fa539b..aff1ef89f231 100644
@@ -23,14 +23,11 @@
 #define rte_bbdev_log_debug(fmt, ...)
 #endif
 
-#define ACC100_VARIANT 0
-#define ACC101_VARIANT 1
-
 /* ACC100 PF and VF driver names */
 #define ACC100PF_DRIVER_NAME           intel_acc100_pf
 #define ACC100VF_DRIVER_NAME           intel_acc100_vf
 
-/* ACC100 PCI vendor & device IDs */
+/* ACC PCI vendor & device IDs */
 #define ACC100_VENDOR_ID           (0x8086)
 #define ACC100_PF_DEVICE_ID        (0x0d5c)
 #define ACC100_VF_DEVICE_ID        (0x0d5d)
drivers/baseband/acc/acc101_pmd.h deleted +0 -40
deleted file mode 100644
index 37df0083306b..000000000000
@@ -1,40 +0,0 @@
-/* SPDX-License-Identifier: BSD-3-Clause
- * Copyright(c) 2022 Intel Corporation
- */
-
-/* ACC101 PCI vendor & device IDs */
-#define ACC101_VENDOR_ID           (0x8086)
-#define ACC101_PF_DEVICE_ID        (0x57c4)
-#define ACC101_VF_DEVICE_ID        (0x57c5)
-
-/* Number of Virtual Functions ACC101 supports */
-#define ACC101_NUM_VFS                  16
-#define ACC101_NUM_QGRPS                8
-#define ACC101_NUM_AQS                  16
-
-#define ACC101_WORDS_IN_ARAM_SIZE (128 * 1024 / 4)
-
-/* Mapping of signals for the available engines */
-#define ACC101_SIG_UL_5G      0
-#define ACC101_SIG_UL_5G_LAST 8
-#define ACC101_SIG_DL_5G      13
-#define ACC101_SIG_DL_5G_LAST 15
-#define ACC101_SIG_UL_4G      16
-#define ACC101_SIG_UL_4G_LAST 19
-#define ACC101_SIG_DL_4G      27
-#define ACC101_SIG_DL_4G_LAST 31
-#define ACC101_NUM_ACCS       5
-
-/* ACC101 Configuration */
-#define ACC101_CFG_DMA_ERROR    0x3D7
-#define ACC101_CFG_AXI_CACHE    0x11
-#define ACC101_CFG_QMGR_HI_P    0x0F0F
-#define ACC101_CFG_PCI_AXI      0xC003
-#define ACC101_CFG_PCI_BRIDGE   0x40006033
-#define ACC101_GPEX_AXIMAP_NUM  17
-#define ACC101_CLOCK_GATING_EN  0x30000
-#define ACC101_DMA_INBOUND      0x104
-/* DDR Size per VF - 512MB by default
- * Can be increased up to 4 GB with single PF/VF
- */
-#define ACC101_HARQ_DDR         (512 * 1)
drivers/baseband/acc/rte_acc100_pmd.c +0 -425

467 lines not on this page · raw message

Signature · 1 line
2.37.1
Reviewed-by on v1 1/1
#2 lore raw

Re: [PATCH v1 1/1] baseband/acc: remove acc101

Quoted 4 lines · Hernan Vargas

The ACC101 HW variant is not productized, the relevant code is removed as obsolete.

Quoted 9 lines
---
  doc/guides/bbdevs/acc100.rst           |  18 +-
  doc/guides/rel_notes/release_24_03.rst |   1 +
  drivers/baseband/acc/acc100_pmd.h      |   5 +-
  drivers/baseband/acc/acc101_pmd.h      |  40 ---
  drivers/baseband/acc/rte_acc100_pmd.c  | 425 -------------------------
  5 files changed, 6 insertions(+), 483 deletions(-)

delete mode 100644 drivers/baseband/acc/acc101_pmd.h

Thanks,
Maxime

#3 lore raw
In reply to Hernan Vargas
Quoted 5 lines · Hernan Vargas

Removing obsolete code for ACC101 variant which will not be productized.

Hernan Vargas (1):
baseband/acc: remove acc101

Quoted 8 lines
  doc/guides/bbdevs/acc100.rst           |  18 +-
  doc/guides/rel_notes/release_24_03.rst |   1 +
  drivers/baseband/acc/acc100_pmd.h      |   5 +-
  drivers/baseband/acc/acc101_pmd.h      |  40 ---
  drivers/baseband/acc/rte_acc100_pmd.c  | 425 -------------------------
  5 files changed, 6 insertions(+), 483 deletions(-)

delete mode 100644 drivers/baseband/acc/acc101_pmd.h

Applied to next-baseband.

Thanks,
Maxime