Skip to contentSkip to conversation

Revert "arm64: dts: imx8mp-dhcom-pdk3: Describe the USB-C connector"

PATCH Applied Fabio Estevam 2 participants 3 messages Jan 13, 2024 – Feb 5, 2024

Subsystems (3)
lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/2 Revert "arm64: dts: imx8mp-dhcom-pdk3: Describe the USB-C connector"

From: Fabio Estevam <[email protected]>

This reverts commit a4dca89fe8a1585af73e362f5f4e3189a00abf8e.

Marek reported:

"This patch breaks USB-C port on this board.

If I plug in USB-C storage device, it is not detected. If I revert this patch, it is detected.

Please drop this patch for now."

Revert it to avoid the regression.

Fixes a4dca89fe8a1 ("arm64: dts: imx8mp-dhcom-pdk3: Describe the USB-C connector")
---
 arch/arm64/boot/dts/freescale/imx8mp-dhcom-pdk3.dts | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)
arch/arm64/boot/dts/freescale/imx8mp-dhcom-pdk3.dts +4 -8
index fea67a9282f0..b749e28e5ede 100644
@@ -175,14 +175,10 @@ typec@3d {
 				pinctrl-names = "default";
 				pinctrl-0 = <&pinctrl_ptn5150>;
 
-				connector {
-					compatible = "usb-c-connector";
-					label = "USB-C";
-
-					port {
-						ptn5150_out_ep: endpoint {
-							remote-endpoint = <&dwc3_0_ep>;
-						};
+				port {
+
+					ptn5150_out_ep: endpoint {
+						remote-endpoint = <&dwc3_0_ep>;
 					};
 				};
 			};
Signature · 7 lines
2.34.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
author reviewer
#1 lore raw

PATCH 2/2 Revert "arm64: dts: imx8mn-var-som-symphony: Describe the USB-C connector"

From: Fabio Estevam <[email protected]>

This reverts commit 095b96b2b8c6dcabf40bbfe4bb99a95fe55c7463.

Marek reported the similar change in imx8mp-dhcom-pdk3.dts caused a regression:

"This patch breaks USB-C port on this board.

If I plug in USB-C storage device, it is not detected. If I revert this patch, it is detected.

Please drop this patch for now."

Revert it here as well.

Fixes 095b96b2b8c6 ("arm64: dts: imx8mn-var-som-symphony: Describe the USB-C connector")
---
 .../boot/dts/freescale/imx8mn-var-som-symphony.dts    | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)
arch/arm64/boot/dts/freescale/imx8mn-var-som-symphony.dts +3 -8
index f38ee2266b25..a6b94d1957c9 100644
@@ -128,14 +128,9 @@ extcon_usbotg1: typec@3d {
 		pinctrl-0 = <&pinctrl_ptn5150>;
 		status = "okay";
 
-		connector {
-			compatible = "usb-c-connector";
-			label = "USB-C";
-
-			port {
-				typec1_dr_sw: endpoint {
-					remote-endpoint = <&usb1_drd_sw>;
-				};
+		port {
+			typec1_dr_sw: endpoint {
+				remote-endpoint = <&usb1_drd_sw>;
 			};
 		};
 	};
Signature · 7 lines
2.34.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Applied
#2 lore raw
In reply to Fabio Estevam
Quoted 11 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

This reverts commit a4dca89fe8a1585af73e362f5f4e3189a00abf8e.

Marek reported:

"This patch breaks USB-C port on this board.

If I plug in USB-C storage device, it is not detected. If I revert this patch, it is detected.

Quoted 8 lines

Please drop this patch for now."

Revert it to avoid the regression.

Fixes a4dca89fe8a1 ("arm64: dts: imx8mp-dhcom-pdk3: Describe the USB-C connector")

Applied both, thanks!

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel