thunderbolt: Fix xdomain rx_lanes_show and tx_lanes_show
Subsystems (2)
PATCH 1/1 thunderbolt: Fix xdomain rx_lanes_show and tx_lanes_show
While reviewing the USB4 Gen4 code, I came across a section that appears to be incorrect. Despite consulting the USB4 v2 and Inter-Domain specifications, I couldn't find a justification for it. Please take a look at the patch email and let me know if there's anything I might be overlooking. Thank you.
PATCH 1/1 thunderbolt: Fix xdomain rx_lanes_show and tx_lanes_show
If the Inter-Domain link is operating in asymmetric TB_LINK_WIDTH_ASYM_TX mode, the rx_lanes_show should return 1 since there is only one receiver and tx_lanes_show should return 3 since there are 3 transmitters.
--- drivers/thunderbolt/xdomain.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/thunderbolt/xdomain.c +4 -4
@@ -1786,13 +1786,13 @@ static ssize_t rx_lanes_show(struct device *dev, struct device_attribute *attr,switch (xd->link_width) {case TB_LINK_WIDTH_SINGLE : -case TB_LINK_WIDTH_ASYM_RX : +case TB_LINK_WIDTH_ASYM_TX : width =1 ;break ;case TB_LINK_WIDTH_DUAL : width =2 ;break ; -case TB_LINK_WIDTH_ASYM_TX : +case TB_LINK_WIDTH_ASYM_RX : width =3 ;break ;default :
@@ -1812,13 +1812,13 @@ static ssize_t tx_lanes_show(struct device *dev, struct device_attribute *attr,switch (xd->link_width) {case TB_LINK_WIDTH_SINGLE : -case TB_LINK_WIDTH_ASYM_TX : +case TB_LINK_WIDTH_ASYM_RX : width =1 ;break ;case TB_LINK_WIDTH_DUAL : width =2 ;break ; -case TB_LINK_WIDTH_ASYM_RX : +case TB_LINK_WIDTH_ASYM_TX : width =3 ;break ;default :
Signature · 1 line
2.39.2
Mika Westerberg
AppliedQuoted 5 lines · Mohammad Rahimi
If the Inter-Domain link is operating in asymmetric
TB_LINK_WIDTH_ASYM_TXmode, therx_lanes_showshould return 1 since there is only one receiver andtx_lanes_showshould return 3 since there are 3 transmitters.Signed-off-by Mohammad Rahimi <[email protected]>
Applied to thunderbolt.git/next, thanks!
This is kind of cosmetic thing because it is not allowed to have asymmetric link over host-to-host connection according to the spec but maybe somewhere in the future...