readahead: use ilog2 instead of a while loop in page_cache_ra_order()
Subsystems (3)
PATCH 1/1 readahead: use ilog2 instead of a while loop in page_cache_ra_order()
From: Pankaj Raghav <[email protected]>
A while loop is used to adjust the new_order to be lower than the ra->size. ilog2 could be used to do the same instead of using a loop.
ilog2 typically resolves to a bit scan reverse instruction. This is particularly useful when ra->size is smaller than the 2^new_order as it resolves in one instruction instead of looping to find the new_order.
No functional changes.
Signed-off-by Pankaj Raghav <[email protected]>
--- mm/readahead.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
mm/readahead.c +2 -4
@@ -500,10 +500,8 @@ void page_cache_ra_order(struct readahead_control *ractl,if (new_order <MAX_PAGECACHE_ORDER ) { new_order +=2 ; -if (new_order >MAX_PAGECACHE_ORDER ) - new_order =MAX_PAGECACHE_ORDER ; -while ((1 << new_order) > ra->size) - new_order--; + new_order = min_t(unsigned int, MAX_PAGECACHE_ORDER, new_order); + new_order = min_t(unsigned int, new_order, ilog2(ra->size)); }filemap_invalidate_lock_shared (mapping);
base-commit: 8d04a7e2ee3fd6aabb8096b00c64db0d735bc874
Signature · 1 line
2.43.0