Skip to contentSkip to conversation

selftests: bonding: add missing build configs

PATCH Applied Jakub Kicinski 4 participants 5 messages Jan 16, 2024

Subsystems (4)
Networking Network drivers Kselftest Bonding driver
lore
Share & tools
lore

Jakub Kicinski

author maintainer
#0 lore raw

PATCH 1/1 selftests: bonding: add missing build configs

bonding tests also try to create bridge, veth and dummy interfaces. These are not currently listed in config.

Fixes bbb774d921e2 ("net: Add tests for bonding and team address list management")
Fixes c078290a2b76 ("selftests: include bonding tests into the kselftest infra")
Signed-off-by Jakub Kicinski <[email protected]>

---
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]

---
 tools/testing/selftests/drivers/net/bonding/config | 3 +++
 1 file changed, 3 insertions(+)
tools/testing/selftests/drivers/net/bonding/config +3 -0
index 70638fa50b2c..f85b16fc5128 100644
@@ -1,2 +1,5 @@
 CONFIG_BONDING=y
+CONFIG_BRIDGE=y
+CONFIG_DUMMY=y
 CONFIG_MACVLAN=y
+CONFIG_VETH=y
Signature · 1 line
2.43.0
Acked-by on v1 1/1
#1 lore raw
Quoted 6 lines · Jakub Kicinski

bonding tests also try to create bridge, veth and dummy interfaces. These are not currently listed in config.

Fixes bbb774d921e2 ("net: Add tests for bonding and team address list management")
Fixes c078290a2b76 ("selftests: include bonding tests into the kselftest infra")
Signed-off-by Jakub Kicinski <[email protected]>
Acked-by Muhammad Usama Anjum <[email protected]>
Quoted 21 lines

---
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]

---
 tools/testing/selftests/drivers/net/bonding/config | 3 +++
 1 file changed, 3 insertions(+)
tools/testing/selftests/drivers/net/bonding/config +3 -0
index 70638fa50b2c..f85b16fc5128 100644
@@ -1,2 +1,5 @@
 CONFIG_BONDING=y
+CONFIG_BRIDGE=y
+CONFIG_DUMMY=y
 CONFIG_MACVLAN=y
+CONFIG_VETH=y
Signature · 2 lines
BR,
Muhammad Usama Anjum
#2 lore raw
In reply to Jakub Kicinski
Quoted 23 lines · Jakub Kicinski

bonding tests also try to create bridge, veth and dummy interfaces. These are not currently listed in config.

Fixes bbb774d921e2 ("net: Add tests for bonding and team address list management")
Fixes c078290a2b76 ("selftests: include bonding tests into the kselftest infra")
Signed-off-by Jakub Kicinski <[email protected]>

---
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]

---
 tools/testing/selftests/drivers/net/bonding/config | 3 +++
 1 file changed, 3 insertions(+)
tools/testing/selftests/drivers/net/bonding/config +0 -0
index 70638fa50b2c..f85b16fc5128 100644

tools/testing/selftests/drivers/net/bonding/config line 5

Quoted 5 lines
tools/testing/selftests/drivers/net/bonding/config +3 -0
@@ -1,2 +1,5 @@
 CONFIG_BONDING=y
+CONFIG_BRIDGE=y
+CONFIG_DUMMY=y
 CONFIG_MACVLAN=y
+CONFIG_VETH=y

Hi,

I tested using the minimal config generated by virtme-ng and the following additional config options need to be enabled for bonding tests:
CONFIG_IPV6=y
CONFIG_NET_ACT_GACT=y
CONFIG_NET_CLS_FLOWER=y
CONFIG_NET_SCH_INGRESS=y
CONFIG_NLMON=y

author maintainer
#3 lore raw
Quoted 8 lines · On Tue, 16 Jan 2024 09:37:40 -0500 Benjamin Poirier wrote:

I tested using the minimal config generated by virtme-ng and the following additional config options need to be enabled for bonding tests:
CONFIG_IPV6=y
CONFIG_NET_ACT_GACT=y
CONFIG_NET_CLS_FLOWER=y
CONFIG_NET_SCH_INGRESS=y
CONFIG_NLMON=y

Perfect! Could you post a patch to add those? I'll apply this one right away to avoid conflicts. Fixes tags would be good to have, if you don't feel like finding each individual commit you can point at mine :)

CI Applied
#4 lore raw
In reply to Jakub Kicinski
This patch was applied to netdev/net.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:

Quoted 8 lines · On Mon, 15 Jan 2024 18:02:01 -0800 you wrote:

bonding tests also try to create bridge, veth and dummy interfaces. These are not currently listed in config.

Fixes bbb774d921e2 ("net: Add tests for bonding and team address list management")
Fixes c078290a2b76 ("selftests: include bonding tests into the kselftest infra")
Signed-off-by Jakub Kicinski <[email protected]>

[...]

Here is the summary with links:
- [net] selftests: bonding: add missing build configs

    https://git.kernel.org/netdev/net/c/03fb8565c880

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html