media: dvb: remove redundant assignment to variable ret
Subsystems (2)
PATCH 1/1 media: dvb: remove redundant assignment to variable ret
The variable ret is being assigned a value but it isn't being read afterwards. The assignment is redundant and so ret can be removed. Also add spaces after , to clean up checkpatch warnings.
Cleans up clang scan build warning:
warning: Although the value stored to 'ret' is used in the enclosing expression, the value is never actually read from 'ret' [deadcode.DeadStores]
Signed-off-by Colin Ian King <[email protected]>
--- drivers/media/dvb-frontends/bcm3510.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/media/dvb-frontends/bcm3510.c +1 -2
@@ -797,7 +797,6 @@ struct dvb_frontend* bcm3510_attach(const struct bcm3510_config *config, struct i2c_adapter *i2c) {struct bcm3510_state * state =NULL ; -int ret;bcm3510_register_value v;/* allocate memory for the internal state */
@@ -816,7 +815,7 @@ struct dvb_frontend* bcm3510_attach(const struct bcm3510_config *config,mutex_init (&state->hab_mutex); -if ((ret =bcm3510_readB (state,0xe0 ,&v)) <0 ) +if (bcm3510_readB (state,0xe0 , &v) <0 ) goto error;deb_info ("Revision: 0x%1x, Layer: 0x%1x.\n" ,v.REVID_e0.REV,v.REVID_e0.LAYER);
Signature · 1 line
2.39.2