blk-mq: Remove the hctx 'run' debugfs attribute
PATCH 1/1 blk-mq: Remove the hctx 'run' debugfs attribute
Nobody uses the debugfs hctx 'run' attribute. Hence remove this attribute and also the code that updates the corresponding member variable.
Suggested-by Jens Axboe <[email protected]>
Cc Gabriel Ryan <[email protected]>
Signed-off-by Bart Van Assche <[email protected]>
--- block/blk-mq-debugfs.c | 18 ------------------ block/blk-mq-sched.c | 2 -- include/linux/blk-mq.h | 3 --- 3 files changed, 23 deletions(-)
block/blk-mq-debugfs.c +0 -18
@@ -479,23 +479,6 @@ static int hctx_sched_tags_bitmap_show(void *data, struct seq_file *m)return res; } -static int hctx_run_show (void *data,struct seq_file *m) -{ -struct blk_mq_hw_ctx *hctx = data; - -seq_printf (m,"%lu\n" , hctx->run); -return 0 ; -} - -static ssize_t hctx_run_write (void *data,const char __user *buf,size_t count, -loff_t *ppos) -{ -struct blk_mq_hw_ctx *hctx = data; - - hctx->run =0 ; -return count; -} -static int hctx_active_show (void *data,struct seq_file *m) {struct blk_mq_hw_ctx *hctx = data;
@@ -624,7 +607,6 @@ static const struct blk_mq_debugfs_attr blk_mq_debugfs_hctx_attrs[] = { {"tags_bitmap", 0400, hctx_tags_bitmap_show}, {"sched_tags", 0400, hctx_sched_tags_show}, {"sched_tags_bitmap", 0400, hctx_sched_tags_bitmap_show}, - {"run", 0600, hctx_run_show, hctx_run_write}, {"active", 0400, hctx_active_show}, {"dispatch_busy", 0400, hctx_dispatch_busy_show}, {"type", 0400, hctx_type_show},
block/blk-mq-sched.c +0 -2
@@ -324,8 +324,6 @@ void blk_mq_sched_dispatch_requests(struct blk_mq_hw_ctx *hctx)if (unlikely (blk_mq_hctx_stopped (hctx) ||blk_queue_quiesced (q)))return ; - hctx->run++; -/* * A return of -EAGAIN is an indication that hctx->dispatch is not * empty and we must run again in order to avoid starving flushes.
include/linux/blk-mq.h +0 -3
@@ -391,9 +391,6 @@ struct blk_mq_hw_ctx {*/ struct blk_mq_tags *sched_tags; -/** @run: Number of dispatched requests. */ -unsigned long run; -/** @numa_node: NUMA node the storage adapter has been connected to. */ unsigned int numa_node;/** @queue_num: Index of this hardware queue. */
Quoted 5 lines · Bart Van Assche
Nobody uses the debugfs hctx 'run' attribute. Hence remove this attribute and also the code that updates the corresponding member variable.
Applied, thanks!
[1/1] blk-mq: Remove the hctx 'run' debugfs attribute
commit: 49e60333d743ae32db3bdde2f93bc818482dd741
Best regards,
Signature · 1 line
Jens Axboe
Quoted 4 lines · Bart Van Assche
Nobody uses the debugfs hctx 'run' attribute. Hence remove this attribute and also the code that updates the corresponding member variable.
Quoted 9 lines
Suggested-by Jens Axboe <[email protected]>Cc Gabriel Ryan <[email protected]>Signed-off-by Bart Van Assche <[email protected]>--- block/blk-mq-debugfs.c | 18 ------------------ block/blk-mq-sched.c | 2 -- include/linux/blk-mq.h | 3 --- 3 files changed, 23 deletions(-)
Reviewed-by Hannes Reinecke <[email protected]>
Cheers,
Hannes
Signature · 5 lines
Dr. Hannes Reinecke Kernel Storage Architect [email protected] +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), GF: Ivo Totev, Andrew McDonald, Werner Knoblich