Skip to contentSkip to conversation

nvme: add module description to stop warnings

PATCH Superseded Chaitanya Kulkarni 3 participants 5 messages Jan 18, 2024

Subsystems (3)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Chaitanya Kulkarni

author maintainer
#0 lore raw

PATCH 1/2 nvme: add module description to stop warnings

Add MODULE_DESCRIPTION() in order to remove warnings & get clean build:-

WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvme/host/nvme-core.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvme/host/nvme.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvme/host/nvme-fabrics.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvme/host/nvme-rdma.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvme/host/nvme-fc.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvme/host/nvme-tcp.o

---
 drivers/nvme/host/core.c    | 1 +
 drivers/nvme/host/fabrics.c | 1 +
 drivers/nvme/host/fc.c      | 1 +
 drivers/nvme/host/pci.c     | 1 +
 drivers/nvme/host/rdma.c    | 1 +
 drivers/nvme/host/tcp.c     | 1 +
 6 files changed, 6 insertions(+)
drivers/nvme/host/core.c +1 -0
index 8971af7fcb2b..fa14e16731c0 100644
@@ -4856,5 +4856,6 @@ static void __exit nvme_core_exit(void)
 
 MODULE_LICENSE("GPL");
 MODULE_VERSION("1.0");
+MODULE_DESCRIPTION("Essential NVMe Host core functionality");
 module_init(nvme_core_init);
 module_exit(nvme_core_exit);
drivers/nvme/host/fabrics.c +1 -0
index aa88606a44c4..ed2fd0a0d688 100644
@@ -1488,6 +1488,7 @@ static void __exit nvmf_exit(void)
 }
 
 MODULE_LICENSE("GPL v2");
+MODULE_DESCRIPTION("Essential NVMeOF Host core functionality");
 
 module_init(nvmf_init);
 module_exit(nvmf_exit);
drivers/nvme/host/fc.c +1 -0
index 05c3159d42e9..522319a4d6f2 100644
@@ -4015,4 +4015,5 @@ static void __exit nvme_fc_exit_module(void)
 module_init(nvme_fc_init_module);
 module_exit(nvme_fc_exit_module);
 
+MODULE_DESCRIPTION("NVMeOF Host FC transport");
 MODULE_LICENSE("GPL v2");
drivers/nvme/host/pci.c +1 -0
index 46d3897b8986..9801dbe09dad 100644
@@ -3529,5 +3529,6 @@ static void __exit nvme_exit(void)
 MODULE_AUTHOR("Matthew Wilcox <[email protected]>");
 MODULE_LICENSE("GPL");
 MODULE_VERSION("1.0");
+MODULE_DESCRIPTION("NVMe PCIe transport");
 module_init(nvme_init);
 module_exit(nvme_exit);
drivers/nvme/host/rdma.c +1 -0
index 2e77c0f25f71..d93c863d036d 100644
@@ -2395,4 +2395,5 @@ static void __exit nvme_rdma_cleanup_module(void)
 module_init(nvme_rdma_init_module);
 module_exit(nvme_rdma_cleanup_module);
 
+MODULE_DESCRIPTION("NVMeOF Host RDMA transport");
 MODULE_LICENSE("GPL v2");
drivers/nvme/host/tcp.c +1 -0
index b234f0674aeb..016a3b7c0791 100644
@@ -2819,4 +2819,5 @@ static void __exit nvme_tcp_cleanup_module(void)
 module_init(nvme_tcp_init_module);
 module_exit(nvme_tcp_cleanup_module);
 
+MODULE_DESCRIPTION("NVMeOF Host TCP transport");
 MODULE_LICENSE("GPL v2");
Signature · 1 line
2.40.0
author maintainer
#1 lore raw

PATCH 2/2 nvmet: add module description to stop warnings

Add MODULE_DESCRIPTION() in order to remove warnings & get clean build:-

WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvme/target/nvmet.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvme/target/nvme-loop.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvme/target/nvmet-rdma.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvme/target/nvmet-fc.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvme/target/nvme-fcloop.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvme/target/nvmet-tcp.o

---
 drivers/nvme/target/core.c   | 1 +
 drivers/nvme/target/fc.c     | 1 +
 drivers/nvme/target/fcloop.c | 1 +
 drivers/nvme/target/loop.c   | 1 +
 drivers/nvme/target/rdma.c   | 1 +
 drivers/nvme/target/tcp.c    | 1 +
 6 files changed, 6 insertions(+)
drivers/nvme/target/core.c +1 -0
index d26aa30f8702..5192f4d71243 100644
@@ -1705,4 +1705,5 @@ static void __exit nvmet_exit(void)
 module_init(nvmet_init);
 module_exit(nvmet_exit);
 
+MODULE_DESCRIPTION("Essential NVMeOF Target core functionality");
 MODULE_LICENSE("GPL v2");
drivers/nvme/target/fc.c +1 -0
index bda7a3009e85..f72f912fc1de 100644
@@ -2945,4 +2945,5 @@ static void __exit nvmet_fc_exit_module(void)
 module_init(nvmet_fc_init_module);
 module_exit(nvmet_fc_exit_module);
 
+MODULE_DESCRIPTION("NVMeOF Target FC transport");
 MODULE_LICENSE("GPL v2");
drivers/nvme/target/fcloop.c +1 -0
index ead349af30f1..49fd1f7380dd 100644
@@ -1650,4 +1650,5 @@ static void __exit fcloop_exit(void)
 module_init(fcloop_init);
 module_exit(fcloop_exit);
 
+MODULE_DESCRIPTION("NVMeOF FC loopback transport");
 MODULE_LICENSE("GPL v2");
drivers/nvme/target/loop.c +1 -0
index 9cb434c58075..35b1ff0cf16b 100644
@@ -688,5 +688,6 @@ static void __exit nvme_loop_cleanup_module(void)
 module_init(nvme_loop_init_module);
 module_exit(nvme_loop_cleanup_module);
 
+MODULE_DESCRIPTION("NVMeOF loopback transport");
 MODULE_LICENSE("GPL v2");
 MODULE_ALIAS("nvmet-transport-254"); /* 254 == NVMF_TRTYPE_LOOP */
drivers/nvme/target/rdma.c +1 -0
index 667f9c04f35d..f7e1ac6ed3ad 100644
@@ -2104,5 +2104,6 @@ static void __exit nvmet_rdma_exit(void)
 module_init(nvmet_rdma_init);
 module_exit(nvmet_rdma_exit);
 
+MODULE_DESCRIPTION("NVMeOF Target RDMA transport");
 MODULE_LICENSE("GPL v2");
 MODULE_ALIAS("nvmet-transport-1"); /* 1 == NVMF_TRTYPE_RDMA */
drivers/nvme/target/tcp.c +1 -0
index 6a1e6bb80062..1f3ea988b671 100644
@@ -2221,5 +2221,6 @@ static void __exit nvmet_tcp_exit(void)
 module_init(nvmet_tcp_init);
 module_exit(nvmet_tcp_exit);
 
+MODULE_DESCRIPTION("NVMeOF Target TCP transport");
 MODULE_LICENSE("GPL v2");
 MODULE_ALIAS("nvmet-transport-3"); /* 3 == NVMF_TRTYPE_TCP */
Signature · 1 line
2.40.0
maintainer
#2 lore raw

Re: [PATCH 2/2] nvmet: add module description to stop warnings

Quoted 24 lines · Chaitanya Kulkarni

Add MODULE_DESCRIPTION() in order to remove warnings & get clean build:-

WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvme/target/nvmet.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvme/target/nvme-loop.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvme/target/nvmet-rdma.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvme/target/nvmet-fc.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvme/target/nvme-fcloop.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvme/target/nvmet-tcp.o

---
  drivers/nvme/target/core.c   | 1 +
  drivers/nvme/target/fc.c     | 1 +
  drivers/nvme/target/fcloop.c | 1 +
  drivers/nvme/target/loop.c   | 1 +
  drivers/nvme/target/rdma.c   | 1 +
  drivers/nvme/target/tcp.c    | 1 +
  6 files changed, 6 insertions(+)
drivers/nvme/target/core.c +0 -0
index d26aa30f8702..5192f4d71243 100644

drivers/nvme/target/core.c static void __exit nvmet_exit(void) · line 1708

Quoted 4 lines
drivers/nvme/target/core.c +1 -0
@@ -1705,4 +1705,5 @@ static void __exit nvmet_exit(void)
  module_init(nvmet_init);
  module_exit(nvmet_exit);
 
+MODULE_DESCRIPTION("Essential NVMeOF Target core functionality");

NVMe target core framework ?

drivers/nvme/target/fc.c static void __exit nvmet_fc_exit_module(void) · line 2948

Quoted 10 lines
drivers/nvme/target/core.c +0 -0
  MODULE_LICENSE("GPL v2");
drivers/nvme/target/fc.c +1 -0
index bda7a3009e85..f72f912fc1de 100644
@@ -2945,4 +2945,5 @@ static void __exit nvmet_fc_exit_module(void)
  module_init(nvmet_fc_init_module);
  module_exit(nvmet_fc_exit_module);
 
+MODULE_DESCRIPTION("NVMeOF Target FC transport");

NVMe target FC transport driver ?

Quoted 16 lines
drivers/nvme/target/fc.c +0 -0
  MODULE_LICENSE("GPL v2");
drivers/nvme/target/fcloop.c +1 -0
index ead349af30f1..49fd1f7380dd 100644
@@ -1650,4 +1650,5 @@ static void __exit fcloop_exit(void)
  module_init(fcloop_init);
  module_exit(fcloop_exit);
 
+MODULE_DESCRIPTION("NVMeOF FC loopback transport");
  MODULE_LICENSE("GPL v2");
drivers/nvme/target/loop.c +0 -0
index 9cb434c58075..35b1ff0cf16b 100644

drivers/nvme/target/loop.c static void __exit nvme_loop_cleanup_module(void) · line 691

Quoted 4 lines
drivers/nvme/target/loop.c +1 -0
@@ -688,5 +688,6 @@ static void __exit nvme_loop_cleanup_module(void)
  module_init(nvme_loop_init_module);
  module_exit(nvme_loop_cleanup_module);
 
+MODULE_DESCRIPTION("NVMeOF loopback transport");

NVMe target loop transport driver ?

drivers/nvme/target/rdma.c static void __exit nvmet_rdma_exit(void) · line 2107

Quoted 11 lines
drivers/nvme/target/loop.c +0 -0
  MODULE_LICENSE("GPL v2");
  MODULE_ALIAS("nvmet-transport-254"); /* 254 == NVMF_TRTYPE_LOOP */
drivers/nvme/target/rdma.c +1 -0
index 667f9c04f35d..f7e1ac6ed3ad 100644
@@ -2104,5 +2104,6 @@ static void __exit nvmet_rdma_exit(void)
  module_init(nvmet_rdma_init);
  module_exit(nvmet_rdma_exit);
 
+MODULE_DESCRIPTION("NVMeOF Target RDMA transport");

NVMe target RDMA transport driver ?

drivers/nvme/target/tcp.c static void __exit nvmet_tcp_exit(void) · line 2224

Quoted 11 lines
drivers/nvme/target/rdma.c +0 -0
  MODULE_LICENSE("GPL v2");
  MODULE_ALIAS("nvmet-transport-1"); /* 1 == NVMF_TRTYPE_RDMA */
drivers/nvme/target/tcp.c +1 -0
index 6a1e6bb80062..1f3ea988b671 100644
@@ -2221,5 +2221,6 @@ static void __exit nvmet_tcp_exit(void)
  module_init(nvmet_tcp_init);
  module_exit(nvmet_tcp_exit);
 
+MODULE_DESCRIPTION("NVMeOF Target TCP transport");

NVMe target TCP transport target ?

Quoted 2 lines
drivers/nvme/target/tcp.c +0 -0
  MODULE_LICENSE("GPL v2");
  MODULE_ALIAS("nvmet-transport-3"); /* 3 == NVMF_TRTYPE_TCP */
#3 lore raw

Re: [PATCH 2/2] nvmet: add module description to stop warnings

Quoted 6 lines

NVMe target TCP transport target ?

Quoted 2 lines

  MODULE_LICENSE("GPL v2"); MODULE_ALIAS("nvmet-transport-3"); /* 3 == NVMF_TRTYPE_TCP */

will send out V2 with your suggestions ...

-ck

maintainer
#4 lore raw
In reply to Chaitanya Kulkarni
Quoted 24 lines · Chaitanya Kulkarni

Add MODULE_DESCRIPTION() in order to remove warnings & get clean build:-

WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvme/host/nvme-core.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvme/host/nvme.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvme/host/nvme-fabrics.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvme/host/nvme-rdma.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvme/host/nvme-fc.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvme/host/nvme-tcp.o

---
  drivers/nvme/host/core.c    | 1 +
  drivers/nvme/host/fabrics.c | 1 +
  drivers/nvme/host/fc.c      | 1 +
  drivers/nvme/host/pci.c     | 1 +
  drivers/nvme/host/rdma.c    | 1 +
  drivers/nvme/host/tcp.c     | 1 +
  6 files changed, 6 insertions(+)
drivers/nvme/host/core.c +0 -0
index 8971af7fcb2b..fa14e16731c0 100644

drivers/nvme/host/core.c static void __exit nvme_core_exit(void) · line 4859

Quoted 4 lines
drivers/nvme/host/core.c +1 -0
@@ -4856,5 +4856,6 @@ static void __exit nvme_core_exit(void)
 
  MODULE_LICENSE("GPL");
  MODULE_VERSION("1.0");
+MODULE_DESCRIPTION("Essential NVMe Host core functionality");

NVMe host core framework ?

drivers/nvme/host/fabrics.c static void __exit nvmf_exit(void) · line 1491

Quoted 11 lines
drivers/nvme/host/core.c +0 -0
  module_init(nvme_core_init);
  module_exit(nvme_core_exit);
drivers/nvme/host/fabrics.c +1 -0
index aa88606a44c4..ed2fd0a0d688 100644
@@ -1488,6 +1488,7 @@ static void __exit nvmf_exit(void)
  }
 
  MODULE_LICENSE("GPL v2");
+MODULE_DESCRIPTION("Essential NVMeOF Host core functionality");

NVMe host fabrics library

drivers/nvme/host/fc.c static void __exit nvme_fc_exit_module(void) · line 4018

Quoted 12 lines
drivers/nvme/host/fabrics.c +0 -0
  module_init(nvmf_init);
  module_exit(nvmf_exit);
drivers/nvme/host/fc.c +1 -0
index 05c3159d42e9..522319a4d6f2 100644
@@ -4015,4 +4015,5 @@ static void __exit nvme_fc_exit_module(void)
  module_init(nvme_fc_init_module);
  module_exit(nvme_fc_exit_module);
 
+MODULE_DESCRIPTION("NVMeOF Host FC transport");

NVMe host FC transport driver ?

drivers/nvme/host/pci.c static void __exit nvme_exit(void) · line 3532

Quoted 10 lines
drivers/nvme/host/fc.c +0 -0
  MODULE_LICENSE("GPL v2");
drivers/nvme/host/pci.c +1 -0
index 46d3897b8986..9801dbe09dad 100644
@@ -3529,5 +3529,6 @@ static void __exit nvme_exit(void)
  MODULE_AUTHOR("Matthew Wilcox <[email protected]>");
  MODULE_LICENSE("GPL");
  MODULE_VERSION("1.0");
+MODULE_DESCRIPTION("NVMe PCIe transport");

NVMe host PCIe transport driver

drivers/nvme/host/rdma.c static void __exit nvme_rdma_cleanup_module(void) · line 2398

Quoted 11 lines
drivers/nvme/host/pci.c +0 -0
  module_init(nvme_init);
  module_exit(nvme_exit);
drivers/nvme/host/rdma.c +1 -0
index 2e77c0f25f71..d93c863d036d 100644
@@ -2395,4 +2395,5 @@ static void __exit nvme_rdma_cleanup_module(void)
  module_init(nvme_rdma_init_module);
  module_exit(nvme_rdma_cleanup_module);
 
+MODULE_DESCRIPTION("NVMeOF Host RDMA transport");

NVMe host RDMA transport driver

drivers/nvme/host/tcp.c static void __exit nvme_tcp_cleanup_module(void) · line 2822

Quoted 10 lines
drivers/nvme/host/rdma.c +0 -0
  MODULE_LICENSE("GPL v2");
drivers/nvme/host/tcp.c +1 -0
index b234f0674aeb..016a3b7c0791 100644
@@ -2819,4 +2819,5 @@ static void __exit nvme_tcp_cleanup_module(void)
  module_init(nvme_tcp_init_module);
  module_exit(nvme_tcp_cleanup_module);
 
+MODULE_DESCRIPTION("NVMeOF Host TCP transport");

NVMe host TCP transport driver ?

Quoted 1 line
drivers/nvme/host/tcp.c +0 -0
  MODULE_LICENSE("GPL v2");