Skip to contentSkip to conversation

qemu-docs: Update options for graphical frontends

PATCH Superseded Yihuan Pan 2 participants 2 messages Jan 18, 2024

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Yihuan Pan

author
#0 lore raw

PATCH 1/1 qemu-docs: Update options for graphical frontends

The command line options -ctrl-grab and -alt-grab have been removed in QEMU 7.1. Instead, use the -display sdl,grab-mod=<modifiers> option to specify the grab modifiers.

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2103

---
 docs/system/keys.rst.inc | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
docs/system/keys.rst.inc +3 -2
index bd9b8e5f6f..44698e301e 100644
@@ -1,7 +1,8 @@
 During the graphical emulation, you can use special key combinations to
 change modes. The default key mappings are shown below, but if you use
-``-alt-grab`` then the modifier is Ctrl-Alt-Shift (instead of Ctrl-Alt)
-and if you use ``-ctrl-grab`` then the modifier is the right Ctrl key
+``-display sdl,grab-mod=lshift-lctrl-lalt`` then the modifier is
+Ctrl-Alt-Shift(instead of Ctrl-Alt) and if you use
+``-display sdl,grab-mod=rctrl`` then the modifier is the right Ctrl key
 (instead of Ctrl-Alt):
 
 Ctrl-Alt-f
Signature · 1 line
2.43.0
#1 lore raw

18.01.2024 09:39, Yihuan Pan :

Quoted 15 lines

The command line options -ctrl-grab and -alt-grab have been removed in QEMU 7.1. Instead, use the -display sdl,grab-mod=<modifiers> option to specify the grab modifiers.

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2103

---
  docs/system/keys.rst.inc | 5 +++--
  1 file changed, 3 insertions(+), 2 deletions(-)
docs/system/keys.rst.inc +0 -0
index bd9b8e5f6f..44698e301e 100644

docs/system/keys.rst.inc line 6

Quoted 8 lines
docs/system/keys.rst.inc +3 -2
@@ -1,7 +1,8 @@
  During the graphical emulation, you can use special key combinations to
  change modes. The default key mappings are shown below, but if you use
-``-alt-grab`` then the modifier is Ctrl-Alt-Shift (instead of Ctrl-Alt)
-and if you use ``-ctrl-grab`` then the modifier is the right Ctrl key
+``-display sdl,grab-mod=lshift-lctrl-lalt`` then the modifier is
+Ctrl-Alt-Shift(instead of Ctrl-Alt) and if you use
+``-display sdl,grab-mod=rctrl`` then the modifier is the right Ctrl key
  (instead of Ctrl-Alt):

A nitpick: please add space before "(instead".

But the whole sentence wants some refinement, or else it is awkward at best. How about something like,

During the graphical emulation, you can use special key combinations from the following table to change modes. By default the modifier is Ctrl-Alt (used in the table below), which can be changed with ``-display`` suboption ``mod=`` where appropriate. For example, ``-display sdl,grab-mod=lshift-lctrl-lalt`` changes the modifier key to Ctrl-Alt-Shift, while ``-display sdl, grab-mod=rctrl`` changes it to the right Ctrl key.

?

Thanks,

/mjt

Quoted 2 lines
docs/system/keys.rst.inc +0 -0
  Ctrl-Alt-f