drm/bridge: tc358767: Limit the Pixel PLL input range
Subsystems (3)
PATCH 1/1 drm/bridge: tc358767: Limit the Pixel PLL input range
According to new configuration spreadsheet from Toshiba for TC9595, the Pixel PLL input clock have to be in range 6..40 MHz. The sheet calculates those PLL input clock as reference clock divided by both pre-dividers. Add the extra limit.
---
Cc: Andrzej Hajda <[email protected]>
Cc: Daniel Vetter <[email protected]>
Cc: David Airlie <[email protected]>
Cc: Jernej Skrabec <[email protected]>
Cc: Jonas Karlman <[email protected]>
Cc: Laurent Pinchart <[email protected]>
Cc: Lucas Stach <[email protected]>
Cc: Neil Armstrong <[email protected]>
Cc: Robert Foss <[email protected]>
Cc: [email protected]
--- drivers/gpu/drm/bridge/tc358767.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
drivers/gpu/drm/bridge/tc358767.c +6 -1
@@ -546,9 +546,14 @@ static int tc_pxl_pll_en(struct tc_data *tc, u32 refclk, u32 pixelclock)continue ;for (i_post =0 ; i_post <ARRAY_SIZE (ext_div); i_post++) {for (div =1 ; div <=16 ; div++) { -u32 clk; +u32 clk, iclk;u64 tmp; +/* PCLK PLL input unit clock ... 6..40 MHz */ + iclk = refclk / (div * ext_div[i_pre]); +if (iclk <6000000 || iclk >40000000 ) +continue ; + tmp = pixelclock * ext_div[i_pre] * ext_div[i_post] * div;do_div (tmp, refclk);
Signature · 1 line
2.43.0
Am Donnerstag, dem 18.01.2024 um 23:02 +0100 schrieb Marek Vasut:
Quoted 6 lines
According to new configuration spreadsheet from Toshiba for TC9595, the Pixel PLL input clock have to be in range 6..40 MHz. The sheet calculates those PLL input clock as reference clock divided by both pre-dividers. Add the extra limit.
Signed-off-by Marek Vasut <[email protected]>
Quoted 35 lines
---
Cc: Andrzej Hajda <[email protected]>
Cc: Daniel Vetter <[email protected]>
Cc: David Airlie <[email protected]>
Cc: Jernej Skrabec <[email protected]>
Cc: Jonas Karlman <[email protected]>
Cc: Laurent Pinchart <[email protected]>
Cc: Lucas Stach <[email protected]>
Cc: Neil Armstrong <[email protected]>
Cc: Robert Foss <[email protected]>
Cc: [email protected]--- drivers/gpu/drm/bridge/tc358767.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)drivers/gpu/drm/bridge/tc358767.c +6
-1@@ -546,9 +546,14 @@ static int tc_pxl_pll_en(struct tc_data *tc, u32 refclk, u32 pixelclock)continue ;for (i_post =0 ; i_post <ARRAY_SIZE (ext_div); i_post++) {for (div =1 ; div <=16 ; div++) { -u32 clk; +u32 clk, iclk;u64 tmp; +/* PCLK PLL input unit clock ... 6..40 MHz */ + iclk = refclk / (div * ext_div[i_pre]); +if (iclk <6000000 || iclk >40000000 ) +continue ; + tmp = pixelclock * ext_div[i_pre] * ext_div[i_post] * div;do_div (tmp, refclk);
Quoted 6 lines · Marek Vasut
According to new configuration spreadsheet from Toshiba for TC9595, the Pixel PLL input clock have to be in range 6..40 MHz. The sheet calculates those PLL input clock as reference clock divided by both pre-dividers. Add the extra limit.
Applied, thanks!
[1/1] drm/bridge: tc358767: Limit the Pixel PLL input range
https://cgit.freedesktop.org/drm/drm-misc/commit/?id=f86ae204bec4
Rob