ARM: imx: Configure GIC clock parent on Data Modul i.MX8M Plus eDM SBC
PATCH 1/1 ARM: imx: Configure GIC clock parent on Data Modul i.MX8M Plus eDM SBC
The CONFIG_SPL_BOARD_INIT lets SPL common code call spl_board_init() during the SPL start up. On this particular system, spl_board_init() is used to reconfigure GIC clock parent to PLL2 500M, which is the configuration expected by the Linux kernel. Enable SPL_BOARD_INIT and fill in the GIC clock configuration code.
---
Cc: Fabio Estevam <[email protected]>
Cc: Stefano Babic <[email protected]>
--- board/data_modul/imx8mp_edm_sbc/spl.c | 13 +++++++++++++ configs/imx8mp_data_modul_edm_sbc_defconfig | 1 + 2 files changed, 14 insertions(+)
board/data_modul/imx8mp_edm_sbc/spl.c +13 -0
@@ -80,6 +80,19 @@ int data_modul_imx_edm_sbc_board_power_init(void)return 0 ; } +void spl_board_init (void ) +{ +/* +* Set GIC clock to 500 MHz for OD VDD_SOC. Kernel driver does not +* allow to change it. Should set the clock after PMIC setting done. +* Default is 400 MHz (system_pll1_800m with div = 2) set by ROM for +* ND VDD_SOC. +*/ +clock_enable (CCGR_GIC ,0 ); +clock_set_target_val (GIC_CLK_ROOT ,CLK_ROOT_ON |CLK_ROOT_SOURCE_SEL (5 )); +clock_enable (CCGR_GIC ,1 ); +} +int spl_board_boot_device (enum boot_device boot_dev_spl) {if (boot_dev_spl ==SPI_NOR_BOOT )/* SPI NOR */
configs/imx8mp_data_modul_edm_sbc_defconfig +1 -0
@@ -56,6 +56,7 @@ CONFIG_SPL_MAX_SIZE=0x25000 CONFIG_SPL_HAS_BSS_LINKER_SECTION=y CONFIG_SPL_BSS_START_ADDR=0x96fc00 CONFIG_SPL_BSS_MAX_SIZE=0x400 +CONFIG_SPL_BOARD_INIT=y CONFIG_SPL_BOOTROM_SUPPORT=y # CONFIG_SPL_RAW_IMAGE_SUPPORT is not set # CONFIG_SPL_SHARES_INIT_SP_ADDR is not set
Signature · 1 line
2.43.0
Fabio Estevam
reviewerHi Marek,
Quoted 6 lines · Marek Vasut
The
CONFIG_SPL_BOARD_INITlets SPL common code callspl_board_init()during the SPL start up. On this particular system,spl_board_init()is used to reconfigure GIC clock parent to PLL2 500M, which is the configuration expected by the Linux kernel. EnableSPL_BOARD_INITand fill in the GIC clock configuration code.
Please add an explanation about the "configuration expected by the Linux kernel".
In the comments below, you explain that this is needed for overdrive mode.
It would be great to have such a comment in the commit log as well.
Thanks