wifi: iwlegacy: Use kcalloc() instead of kzalloc()
PATCH 1/1 wifi: iwlegacy: Use kcalloc() instead of kzalloc()
As noted in the "Deprecated Interfaces, Language Features, Attributes, and Conventions" documentation [1], size calculations (especially multiplication) should not be performed in memory allocator (or similar) function arguments due to the risk of them overflowing. This could lead to values wrapping around and a smaller allocation being made than the caller was expecting. Using those allocations could lead to linear overflows of heap memory and other misbehaviors.
So, use the purpose specific kcalloc() function instead of the argument size * count in the kzalloc() function.
Also, it is preferred to use sizeof(*pointer) instead of sizeof(type) due to the type of the variable can change and one needs not change the former (unlike the latter).
--- drivers/net/wireless/intel/iwlegacy/common.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/net/wireless/intel/iwlegacy/common.c +1 -3
@@ -3438,9 +3438,7 @@ il_init_geos(struct il_priv *il)if (!channels)return -ENOMEM ; - rates = -kzalloc ((sizeof (struct ieee80211_rate ) *RATE_COUNT_LEGACY ), -GFP_KERNEL ); + rates =kcalloc (RATE_COUNT_LEGACY ,sizeof (*rates),GFP_KERNEL );if (!rates) {kfree (channels);return -ENOMEM ;
--
2.25.1
Quoted 11 lines · Erick Archer
As noted in the "Deprecated Interfaces, Language Features, Attributes, and Conventions" documentation [1], size calculations (especially multiplication) should not be performed in memory allocator (or similar) function arguments due to the risk of them overflowing. This could lead to values wrapping around and a smaller allocation being made than the caller was expecting. Using those allocations could lead to linear overflows of heap memory and other misbehaviors.
So, use the purpose specific
kcalloc()function instead of the argument size * count in thekzalloc()function.
Quoted 7 lines
Also, it is preferred to use
sizeof(*pointer)instead of sizeof(type) due to the type of the variable can change and one needs not change the former (unlike the latter).
Thanks!
Signature · 1 line
Gustavo
Quoted 23 lines
--- drivers/net/wireless/intel/iwlegacy/common.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)drivers/net/wireless/intel/iwlegacy/common.c +1
-4@@ -3438,9 +3438,7 @@ il_init_geos(struct il_priv *il)if (!channels)return -ENOMEM ; - rates = -kzalloc ((sizeof (struct ieee80211_rate ) *RATE_COUNT_LEGACY ), -GFP_KERNEL ); + rates =kcalloc (RATE_COUNT_LEGACY ,sizeof (*rates),GFP_KERNEL );if (!rates) {kfree (channels);return -ENOMEM ; --2.25.1
Quoted 11 lines · Erick Archer
As noted in the "Deprecated Interfaces, Language Features, Attributes, and Conventions" documentation [1], size calculations (especially multiplication) should not be performed in memory allocator (or similar) function arguments due to the risk of them overflowing. This could lead to values wrapping around and a smaller allocation being made than the caller was expecting. Using those allocations could lead to linear overflows of heap memory and other misbehaviors.
So, use the purpose specific
kcalloc()function instead of the argument size * count in thekzalloc()function.
Quoted 7 lines
Also, it is preferred to use
sizeof(*pointer)instead of sizeof(type) due to the type of the variable can change and one needs not change the former (unlike the latter).
Quoted 15 lines · Erick Archer
As noted in the "Deprecated Interfaces, Language Features, Attributes, and Conventions" documentation [1], size calculations (especially multiplication) should not be performed in memory allocator (or similar) function arguments due to the risk of them overflowing. This could lead to values wrapping around and a smaller allocation being made than the caller was expecting. Using those allocations could lead to linear overflows of heap memory and other misbehaviors.
So, use the purpose specific
kcalloc()function instead of the argument size * count in thekzalloc()function.Also, it is preferred to use
sizeof(*pointer)instead of sizeof(type) due to the type of the variable can change and one needs not change the former (unlike the latter).
Quoted 5 lines
Signed-off-by Erick Archer <[email protected]>Reviewed-by Gustavo A. R. Silva <[email protected]>
Patch applied to wireless-next.git, thanks.
acf868ff60b1 wifi: iwlegacy: Use kcalloc() instead of kzalloc()
Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches