pinctrl: pinctrl-zynqmp: Use devm_kcalloc() instead of devm_kzalloc()
Subsystems (3)
PATCH 1/1 pinctrl: pinctrl-zynqmp: Use devm_kcalloc() instead of devm_kzalloc()
As noted in the "Deprecated Interfaces, Language Features, Attributes, and Conventions" documentation [1], size calculations (especially multiplication) should not be performed in memory allocator (or similar) function arguments due to the risk of them overflowing. This could lead to values wrapping around and a smaller allocation being made than the caller was expecting. Using those allocations could lead to linear overflows of heap memory and other misbehaviors.
So, use the purpose specific devm_kcalloc() function instead of the argument size * count in the devm_kzalloc() function.
--- drivers/pinctrl/pinctrl-zynqmp.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/pinctrl/pinctrl-zynqmp.c +4 -4
@@ -562,7 +562,7 @@ static int zynqmp_pinctrl_prepare_func_groups(struct device *dev, u32 fid,const char **fgroups;int ret, index, i; - fgroups =devm_kzalloc (dev,sizeof (*fgroups) * func->ngroups,GFP_KERNEL ); + fgroups =devm_kcalloc (dev, func->ngroups,sizeof (*fgroups),GFP_KERNEL );if (!fgroups)return -ENOMEM ;
@@ -754,7 +754,7 @@ static int zynqmp_pinctrl_prepare_function_info(struct device *dev,if (ret)return ret; - funcs =devm_kzalloc (dev,sizeof (*funcs) * pctrl->nfuncs,GFP_KERNEL ); + funcs =devm_kcalloc (dev, pctrl->nfuncs,sizeof (*funcs),GFP_KERNEL );if (!funcs)return -ENOMEM ;
@@ -768,7 +768,7 @@ static int zynqmp_pinctrl_prepare_function_info(struct device *dev, pctrl->ngroups += funcs[i].ngroups; } - groups =devm_kzalloc (dev,sizeof (*groups) * pctrl->ngroups,GFP_KERNEL ); + groups =devm_kcalloc (dev, pctrl->ngroups,sizeof (*groups),GFP_KERNEL );if (!groups)return -ENOMEM ;
@@ -830,7 +830,7 @@ static int zynqmp_pinctrl_prepare_pin_desc(struct device *dev,if (ret)return ret; - pins =devm_kzalloc (dev,sizeof (*pins) * *npins,GFP_KERNEL ); + pins =devm_kcalloc (dev, *npins,sizeof (*pins),GFP_KERNEL );if (!pins)return -ENOMEM ;
--
2.25.1
Quoted 8 lines · Erick Archer
As noted in the "Deprecated Interfaces, Language Features, Attributes, and Conventions" documentation [1], size calculations (especially multiplication) should not be performed in memory allocator (or similar) function arguments due to the risk of them overflowing. This could lead to values wrapping around and a smaller allocation being made than the caller was expecting. Using those allocations could lead to linear overflows of heap memory and other misbehaviors.
Quoted 6 lines
So, use the purpose specific
devm_kcalloc()function instead of the argument size * count in thedevm_kzalloc()function.
Thanks!
Signature · 1 line
Gustavo
Quoted 48 lines
--- drivers/pinctrl/pinctrl-zynqmp.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)drivers/pinctrl/pinctrl-zynqmp.c +4
-5@@ -562,7 +562,7 @@ static int zynqmp_pinctrl_prepare_func_groups(struct device *dev, u32 fid,const char **fgroups;int ret, index, i; - fgroups =devm_kzalloc (dev,sizeof (*fgroups) * func->ngroups,GFP_KERNEL ); + fgroups =devm_kcalloc (dev, func->ngroups,sizeof (*fgroups),GFP_KERNEL );if (!fgroups)return -ENOMEM ;@@ -754,7 +754,7 @@ static int zynqmp_pinctrl_prepare_function_info(struct device *dev,if (ret)return ret; - funcs =devm_kzalloc (dev,sizeof (*funcs) * pctrl->nfuncs,GFP_KERNEL ); + funcs =devm_kcalloc (dev, pctrl->nfuncs,sizeof (*funcs),GFP_KERNEL );if (!funcs)return -ENOMEM ;@@ -768,7 +768,7 @@ static int zynqmp_pinctrl_prepare_function_info(struct device *dev, pctrl->ngroups += funcs[i].ngroups; } - groups =devm_kzalloc (dev,sizeof (*groups) * pctrl->ngroups,GFP_KERNEL ); + groups =devm_kcalloc (dev, pctrl->ngroups,sizeof (*groups),GFP_KERNEL );if (!groups)return -ENOMEM ;@@ -830,7 +830,7 @@ static int zynqmp_pinctrl_prepare_pin_desc(struct device *dev,if (ret)return ret; - pins =devm_kzalloc (dev,sizeof (*pins) * *npins,GFP_KERNEL ); + pins =devm_kcalloc (dev, *npins,sizeof (*pins),GFP_KERNEL );if (!pins)return -ENOMEM ; --2.25.1
Quoted 59 lines · Erick Archer
As noted in the "Deprecated Interfaces, Language Features, Attributes, and Conventions" documentation [1], size calculations (especially multiplication) should not be performed in memory allocator (or similar) function arguments due to the risk of them overflowing. This could lead to values wrapping around and a smaller allocation being made than the caller was expecting. Using those allocations could lead to linear overflows of heap memory and other misbehaviors.
So, use the purpose specific
devm_kcalloc()function instead of the argument size * count in thedevm_kzalloc()function.Signed-off-by Erick Archer <[email protected]>--- drivers/pinctrl/pinctrl-zynqmp.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)drivers/pinctrl/pinctrl-zynqmp.c +4
-5@@ -562,7 +562,7 @@ static int zynqmp_pinctrl_prepare_func_groups(struct device *dev, u32 fid,const char **fgroups;int ret, index, i; - fgroups =devm_kzalloc (dev,sizeof (*fgroups) * func->ngroups,GFP_KERNEL ); + fgroups =devm_kcalloc (dev, func->ngroups,sizeof (*fgroups),GFP_KERNEL );if (!fgroups)return -ENOMEM ;@@ -754,7 +754,7 @@ static int zynqmp_pinctrl_prepare_function_info(struct device *dev,if (ret)return ret; - funcs =devm_kzalloc (dev,sizeof (*funcs) * pctrl->nfuncs,GFP_KERNEL ); + funcs =devm_kcalloc (dev, pctrl->nfuncs,sizeof (*funcs),GFP_KERNEL );if (!funcs)return -ENOMEM ;@@ -768,7 +768,7 @@ static int zynqmp_pinctrl_prepare_function_info(struct device *dev, pctrl->ngroups += funcs[i].ngroups; } - groups =devm_kzalloc (dev,sizeof (*groups) * pctrl->ngroups,GFP_KERNEL ); + groups =devm_kcalloc (dev, pctrl->ngroups,sizeof (*groups),GFP_KERNEL );if (!groups)return -ENOMEM ;@@ -830,7 +830,7 @@ static int zynqmp_pinctrl_prepare_pin_desc(struct device *dev,if (ret)return ret; - pins =devm_kzalloc (dev,sizeof (*pins) * *npins,GFP_KERNEL ); + pins =devm_kcalloc (dev, *npins,sizeof (*pins),GFP_KERNEL );if (!pins)return -ENOMEM ; --
Quoted 2 lines
2.25.1
Thanks,
Michal
Quoted 8 lines · Erick Archer
As noted in the "Deprecated Interfaces, Language Features, Attributes, and Conventions" documentation [1], size calculations (especially multiplication) should not be performed in memory allocator (or similar) function arguments due to the risk of them overflowing. This could lead to values wrapping around and a smaller allocation being made than the caller was expecting. Using those allocations could lead to linear overflows of heap memory and other misbehaviors.
Quoted 6 lines
So, use the purpose specific
devm_kcalloc()function instead of the argument size * count in thedevm_kzalloc()function.
Patch applied!
Yours,
Linus Walleij