Skip to contentSkip to conversation

kbuild: fix W= flags in the help message

PATCH In review Masahiro Yamada 2 participants 3 messages Jan 20, 2024 – Jan 24, 2024 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kbuild: fix W= flags in the help message

W=c and W=e are supported.

---

 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Makefile +1 -1
index f288eb2dc8fd..8c6a935c62e6 100644
@@ -1653,7 +1653,7 @@ help:
 	@echo  '                       (sparse by default)'
 	@echo  '  make C=2   [targets] Force check of all c source with $$CHECK'
 	@echo  '  make RECORDMCOUNT_WARN=1 [targets] Warn about ignored mcount sections'
-	@echo  '  make W=n   [targets] Enable extra build checks, n=1,2,3 where'
+	@echo  '  make W=n   [targets] Enable extra build checks, n=1,2,3,c,e where'
 	@echo  '		1: warnings which may be relevant and do not occur too often'
 	@echo  '		2: warnings which occur quite often but may still be relevant'
 	@echo  '		3: more obscure warnings, can most likely be ignored'
Signature · 1 line
2.40.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 13 lines · Masahiro Yamada

W=c and W=e are supported.

---

 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Makefile +0 -0
index f288eb2dc8fd..8c6a935c62e6 100644

Makefile help: · line 1656

Quoted 5 lines
Makefile +1 -1
@@ -1653,7 +1653,7 @@ help:
 	@echo  '                       (sparse by default)'
 	@echo  '  make C=2   [targets] Force check of all c source with $$CHECK'
 	@echo  '  make RECORDMCOUNT_WARN=1 [targets] Warn about ignored mcount sections'
-	@echo  '  make W=n   [targets] Enable extra build checks, n=1,2,3 where'
+	@echo  '  make W=n   [targets] Enable extra build checks, n=1,2,3,c,e where'

In the top of scripts/Makefile.extrawarn we have kind of a duplication of this description. Might you want to update that too?

#2 lore raw
Quoted 10 lines · Nicolas Schier
Quoted 8 lines · Masahiro Yamada

W=c and W=e are supported.

---

 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 13 lines

Makefile help: · line 1656

Quoted 10 lines
Makefile +1 -1
index f288eb2dc8fd..8c6a935c62e6 100644
@@ -1653,7 +1653,7 @@ help:
      @echo  '                       (sparse by default)'
      @echo  '  make C=2   [targets] Force check of all c source with $$CHECK'
      @echo  '  make RECORDMCOUNT_WARN=1 [targets] Warn about ignored mcount sections'
-     @echo  '  make W=n   [targets] Enable extra build checks, n=1,2,3 where'
+     @echo  '  make W=n   [targets] Enable extra build checks, n=1,2,3,c,e where'

In the top of scripts/Makefile.extrawarn we have kind of a duplication of this description. Might you want to update that too?

W=e is already mentioned in scripts/Makefile.extrawarn. W=c is handled in scripts/kconfig/Makefile.

So, I believe it is OK as-is.

Quoted 1 line
Signature · 2 lines
Best Regards
Masahiro Yamada