Skip to contentSkip to conversation

arm64: dts: qcom: msm8916-samsung-fortuna: Add initial device trees

PATCH Applied Raymond Hackley 2 participants 6 messages Jan 20, 2024 – Jan 28, 2024

Subsystems (3)

v3 of 4 Applied Latest is v4 →

lore
Share & tools
lore
#0 lore raw

v3 cover arm64: dts: qcom: msm8916-samsung-fortuna: Add initial device trees

Samsung Galaxy Core Prime and Grand Prime are phones based on MSM8916. They are similar to the other Samsung devices based on MSM8916 with only a few minor differences.

This initial commit adds support for:
- fortuna3g (SM-G530H)
- gprimeltecan (SM-G530W)
- grandprimelte (SM-G530FZ)
- rossa (SM-G360G)

The device trees contain initial support with:
- GPIO keys
- Regulator haptic
- SDHCI (internal and external storage)
- USB Device Mode
- UART (on USB connector via the SM5502/SM5504 MUIC)
- WCNSS (WiFi/BT)
- Regulators
- QDSP6 audio
- Speaker/earpiece/headphones/microphones via digital/analog codec in MSM8916/PM8916
- WWAN Internet via BAM-DMUX

There are different variants of Core Prime and Grand Prime, with some differences in accelerometer, NFC and panel.
Core Prime and Grand Prime are similar, with some differences in MUIC, panel and touchscreen.

The common parts are shared in msm8916-samsung-fortuna-common.dtsi and msm8916-samsung-rossa-common.dtsi to reduce duplication.

---
v3: Drop fortunaltezt and heatqlte. Add sound and modem.
/delete-node/ &muic; in rossa-common.dtsi
v2: Use interrupt-extended. Drop fuelgauge, sensors and NFC for now.

#1 lore raw

PATCH v3 1/2 dt-bindings: qcom: Document new msm8916-samsung devices

Document the new following device tree bindings used in their device trees:

- samsung,fortuna3g
- samsung,gprimeltecan
- samsung,grandprimelte
- samsung,rossa

---
 Documentation/devicetree/bindings/arm/qcom.yaml | 4 ++++
 1 file changed, 4 insertions(+)
Documentation/devicetree/bindings/arm/qcom.yaml +4 -0
index 1a5fb889a444..337053ca700b 100644
@@ -244,11 +244,15 @@ properties:
               - samsung,a5u-eur
               - samsung,e5
               - samsung,e7
+              - samsung,fortuna3g
+              - samsung,gprimeltecan
               - samsung,grandmax
+              - samsung,grandprimelte
               - samsung,gt510
               - samsung,gt58
               - samsung,j5
               - samsung,j5x
+              - samsung,rossa
               - samsung,serranove
               - thwc,uf896
               - thwc,ufi001c
Signature · 1 line
2.39.2
#2 lore raw

PATCH v3 2/2 arm64: dts: qcom: msm8916-samsung-fortuna: Add initial device trees

In reply to Raymond Hackley

From: Walter Broemeling <[email protected]>

Samsung Galaxy Core Prime and Grand Prime are phones based on MSM8916. They are similar to the other Samsung devices based on MSM8916 with only a few minor differences.

This initial commit adds support for:
- fortuna3g (SM-G530H)
- gprimeltecan (SM-G530W)
- grandprimelte (SM-G530FZ)
- rossa (SM-G360G)

The device trees contain initial support with:
- GPIO keys
- Regulator haptic
- SDHCI (internal and external storage)
- USB Device Mode
- UART (on USB connector via the SM5502/SM5504 MUIC)
- WCNSS (WiFi/BT)
- Regulators
- QDSP6 audio
- Speaker/earpiece/headphones/microphones via digital/analog codec in MSM8916/PM8916
- WWAN Internet via BAM-DMUX

There are different variants of Core Prime and Grand Prime, with some differences in accelerometer, NFC and panel.
Core Prime and Grand Prime are similar, with some differences in MUIC, panel and touchscreen.

The common parts are shared in msm8916-samsung-fortuna-common.dtsi and msm8916-samsung-rossa-common.dtsi to reduce duplication.

[Joe: Add audio, buttons and WiFi]
[Siddharth: Add fortuna3g]
[Raymond: Add modem, fortuna-common.dtsi, grandprimelte and rossa]
---
 arch/arm64/boot/dts/qcom/Makefile             |   4 +
 .../qcom/msm8916-samsung-fortuna-common.dtsi  | 170 ++++++++++++++++++
 .../dts/qcom/msm8916-samsung-gprimeltecan.dts |  26 +++
 .../qcom/msm8916-samsung-grandprimelte.dts    |  15 ++
 .../qcom/msm8916-samsung-rossa-common.dtsi    |  16 ++
 .../boot/dts/qcom/msm8916-samsung-rossa.dts   |  15 ++
 6 files changed, 246 insertions(+)
 create mode 100644 arch/arm64/boot/dts/qcom/msm8916-samsung-fortuna-common.dtsi
 create mode 100644 arch/arm64/boot/dts/qcom/msm8916-samsung-gprimeltecan.dts
 create mode 100644 arch/arm64/boot/dts/qcom/msm8916-samsung-grandprimelte.dts
 create mode 100644 arch/arm64/boot/dts/qcom/msm8916-samsung-rossa-common.dtsi
 create mode 100644 arch/arm64/boot/dts/qcom/msm8916-samsung-rossa.dts
arch/arm64/boot/dts/qcom/Makefile +4 -0
index 39889d5f8e12..1abd25e19a1f 100644
@@ -23,6 +23,7 @@ dtb-$(CONFIG_ARCH_QCOM)	+= ipq9574-rdp433.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= ipq9574-rdp449.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= ipq9574-rdp453.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= ipq9574-rdp454.dtb
+dtb-$(CONFIG_ARCH_QCOM)	+= msm8216-samsung-fortuna3g.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= msm8916-acer-a1-724.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= msm8916-alcatel-idol347.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= msm8916-asus-z00l.dtb
@@ -35,11 +36,14 @@ dtb-$(CONFIG_ARCH_QCOM)	+= msm8916-samsung-a3u-eur.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= msm8916-samsung-a5u-eur.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= msm8916-samsung-e5.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= msm8916-samsung-e7.dtb
+dtb-$(CONFIG_ARCH_QCOM)	+= msm8916-samsung-gprimeltecan.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= msm8916-samsung-grandmax.dtb
+dtb-$(CONFIG_ARCH_QCOM)	+= msm8916-samsung-grandprimelte.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= msm8916-samsung-gt510.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= msm8916-samsung-gt58.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= msm8916-samsung-j5.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= msm8916-samsung-j5x.dtb
+dtb-$(CONFIG_ARCH_QCOM)	+= msm8916-samsung-rossa.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= msm8916-samsung-serranove.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= msm8916-thwc-uf896.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= msm8916-thwc-ufi001c.dtb
arch/arm64/boot/dts/qcom/msm8916-samsung-fortuna-common.dtsi new file +170 -0

170 lines not on this page · raw message

arch/arm64/boot/dts/qcom/msm8916-samsung-gprimeltecan.dts new file +26 -0
new file mode 100644
index 000000000000..022f250ea21d
@@ -0,0 +1,26 @@
+// SPDX-License-Identifier: GPL-2.0-only
+
+/dts-v1/;
+
+#include "msm8916-samsung-fortuna-common.dtsi"
+
+/ {
+	model = "Samsung Galaxy Grand Prime (SM-G530W)";
+	compatible = "samsung,gprimeltecan", "qcom,msm8916";
+	chassis-type = "handset";
+
+	reserved-memory {
+		/* Firmware for gprimeltecan needs more space */
+		/delete-node/ tz-apps@85a00000;
+
+		/* Additional memory used by Samsung firmware modifications */
+		tz-apps@85500000 {
+			reg = <0x0 0x85500000 0x0 0xb00000>;
+			no-map;
+		};
+	};
+};
+
+&mpss_mem {
+	reg = <0x0 0x86800000 0x0 0x5400000>;
+};
arch/arm64/boot/dts/qcom/msm8916-samsung-grandprimelte.dts new file +15 -0
new file mode 100644
index 000000000000..62b8359a5a85
@@ -0,0 +1,15 @@
+// SPDX-License-Identifier: GPL-2.0-only
+
+/dts-v1/;
+
+#include "msm8916-samsung-fortuna-common.dtsi"
+
+/ {
+	model = "Samsung Galaxy Grand Prime (SM-G530FZ)";
+	compatible = "samsung,grandprimelte", "qcom,msm8916";
+	chassis-type = "handset";
+};
+
+&mpss_mem {
+	reg = <0x0 0x86800000 0x0 0x5400000>;
+};
arch/arm64/boot/dts/qcom/msm8916-samsung-rossa-common.dtsi new file +16 -0
new file mode 100644
index 000000000000..42843771ae2a
@@ -0,0 +1,16 @@
+// SPDX-License-Identifier: GPL-2.0-only
+
+#include "msm8916-samsung-fortuna-common.dtsi"
+
+/* SM5504 MUIC instead of SM5502 */
+/delete-node/ &muic;
+
+&blsp_i2c1 {
+	muic: extcon@14 {
+		compatible = "siliconmitus,sm5504-muic";
+		reg = <0x14>;
+		interrupts-extended = <&tlmm 12 IRQ_TYPE_EDGE_FALLING>;
+		pinctrl-0 = <&muic_int_default>;
+		pinctrl-names = "default";
+	};
+};
arch/arm64/boot/dts/qcom/msm8916-samsung-rossa.dts new file +15 -0
new file mode 100644
index 000000000000..93e795fcee97
@@ -0,0 +1,15 @@
+// SPDX-License-Identifier: GPL-2.0-only
+
+/dts-v1/;
+
+#include "msm8916-samsung-rossa-common.dtsi"
+
+/ {
+	model = "Samsung Galaxy Core Prime LTE";
+	compatible = "samsung,rossa", "qcom,msm8916";
+	chassis-type = "handset";
+};
+
+&mpss_mem {
+	reg = <0x0 0x86800000 0x0 0x5800000>;
+};
Signature · 1 line
2.39.2
maintainer
#3 lore raw
Quoted 3 lines · Raymond Hackley

From: Walter Broemeling <[email protected]>
This initial commit adds support for:
- fortuna3g (SM-G530H)

[..]

Quoted 18 lines
 arch/arm64/boot/dts/qcom/Makefile             |   4 +
 .../qcom/msm8916-samsung-fortuna-common.dtsi  | 170 ++++++++++++++++++
 .../dts/qcom/msm8916-samsung-gprimeltecan.dts |  26 +++
 .../qcom/msm8916-samsung-grandprimelte.dts    |  15 ++
 .../qcom/msm8916-samsung-rossa-common.dtsi    |  16 ++
 .../boot/dts/qcom/msm8916-samsung-rossa.dts   |  15 ++
 6 files changed, 246 insertions(+)
 create mode 100644 arch/arm64/boot/dts/qcom/msm8916-samsung-fortuna-common.dtsi
 create mode 100644 arch/arm64/boot/dts/qcom/msm8916-samsung-gprimeltecan.dts
 create mode 100644 arch/arm64/boot/dts/qcom/msm8916-samsung-grandprimelte.dts
 create mode 100644 arch/arm64/boot/dts/qcom/msm8916-samsung-rossa-common.dtsi
 create mode 100644 arch/arm64/boot/dts/qcom/msm8916-samsung-rossa.dts
arch/arm64/boot/dts/qcom/Makefile +0 -0
index 39889d5f8e12..1abd25e19a1f 100644

arch/arm64/boot/dts/qcom/Makefile dtb-$(CONFIG_ARCH_QCOM) += ipq9574-rdp433.dtb · line 26

Quoted 4 lines
arch/arm64/boot/dts/qcom/Makefile +1 -0
@@ -23,6 +23,7 @@ dtb-$(CONFIG_ARCH_QCOM)	+= ipq9574-rdp433.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= ipq9574-rdp449.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= ipq9574-rdp453.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= ipq9574-rdp454.dtb
+dtb-$(CONFIG_ARCH_QCOM)	+= msm8216-samsung-fortuna3g.dtb

This is missing from the patch.

Regards,
Bjorn

maintainer Applied
#5 lore raw
In reply to Raymond Hackley
Quoted 11 lines · Raymond Hackley

Samsung Galaxy Core Prime and Grand Prime are phones based on MSM8916. They are similar to the other Samsung devices based on MSM8916 with only a few minor differences.

This initial commit adds support for:
- fortuna3g (SM-G530H)
- gprimeltecan (SM-G530W)
- grandprimelte (SM-G530FZ)
- rossa (SM-G360G)

[...]

Applied, thanks!

[1/2] dt-bindings: qcom: Document new msm8916-samsung devices

      commit: 80daa2fa2ff2ce01550713956a6f7e18bbbd3f7f

[2/2] arm64: dts: qcom: msm8916-samsung-fortuna: Add initial device trees
(no commit info)

Best regards,

Signature · 1 line
Bjorn Andersson <[email protected]>