docs/zh_CN/power: Use kcalloc() instead of kzalloc()
PATCH 1/1 docs/zh_CN/power: Use kcalloc() instead of kzalloc()
As noted in the "Deprecated Interfaces, Language Features, Attributes, and Conventions" documentation [1], size calculations (especially multiplication) should not be performed in memory allocator (or similar) function arguments due to the risk of them overflowing. This could lead to values wrapping around and a smaller allocation being made than the caller was expecting. Using those allocations could lead to linear overflows of heap memory and other misbehaviors.
So, in the example code use the purpose specific kcalloc() function instead of the argument size * count in the kzalloc() function.
--- Documentation/translations/zh_CN/power/opp.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/translations/zh_CN/power/opp.rst +1 -1
@@ -274,7 +274,7 @@ dev_pm_opp_get_opp_count { /* 做一些事情 */ num_available = dev_pm_opp_get_opp_count(dev); - speeds = kzalloc(sizeof(u32) * num_available, GFP_KERNEL); + speeds = kcalloc(num_available, sizeof(u32), GFP_KERNEL); /* 按升序填充表 */ freq = 0; while (!IS_ERR(opp = dev_pm_opp_find_freq_ceil(dev, &freq))) {
--
2.25.1
Quoted 23 lines · Erick Archer
As noted in the "Deprecated Interfaces, Language Features, Attributes, and Conventions" documentation [1], size calculations (especially multiplication) should not be performed in memory allocator (or similar) function arguments due to the risk of them overflowing. This could lead to values wrapping around and a smaller allocation being made than the caller was expecting. Using those allocations could lead to linear overflows of heap memory and other misbehaviors.
So, in the example code use the purpose specific
kcalloc()function instead of the argument size * count in thekzalloc()function.Signed-off-by Erick Archer <[email protected]>--- Documentation/translations/zh_CN/power/opp.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Documentation/translations/zh_CN/power/opp.rst +0
-0
Documentation/translations/zh_CN/power/opp.rst dev_pm_opp_get_opp_count · line 277
Quoted 5 lines
Documentation/translations/zh_CN/power/opp.rst +1
-1@@ -274,7 +274,7 @@ dev_pm_opp_get_opp_count { /* 做一些事情 */ num_available = dev_pm_opp_get_opp_count(dev); - speeds = kzalloc(sizeof(u32) * num_available, GFP_KERNEL); + speeds = kcalloc(num_available, sizeof(u32), GFP_KERNEL);
If the translated version is modified, I think the original file should follow as well at Documentation/power/opp.rst line 308:
Documentation/power/opp.rst +0 -0
@@ -305,7 +305,7 @@ dev_pm_opp_get_opp_count
{
/* Do things */
num_available = dev_pm_opp_get_opp_count(dev);
- speeds = kzalloc(sizeof(u32) * num_available, GFP_KERNEL); + speeds = kcalloc(sizeof(u32) * num_available, GFP_KERNEL); /* populate the table in increasing order */
freq = 0;
while (!IS_ERR(opp = dev_pm_opp_find_freq_ceil(dev, &freq))) {
Thanks,
Hu Haowen
Quoted 8 lines
Documentation/translations/zh_CN/power/opp.rst +0
-1/* 按升序填充表 */ freq = 0; while (!IS_ERR(opp = dev_pm_opp_find_freq_ceil(dev, &freq))) { --2.25.1
Hi Hu and Jonathan,
Quoted 48 lines · Hu Haowen
Quoted 23 lines · Erick Archer
As noted in the "Deprecated Interfaces, Language Features, Attributes, and Conventions" documentation [1], size calculations (especially multiplication) should not be performed in memory allocator (or similar) function arguments due to the risk of them overflowing. This could lead to values wrapping around and a smaller allocation being made than the caller was expecting. Using those allocations could lead to linear overflows of heap memory and other misbehaviors.
So, in the example code use the purpose specific
kcalloc()function instead of the argument size * count in thekzalloc()function.Signed-off-by Erick Archer <[email protected]>--- Documentation/translations/zh_CN/power/opp.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Documentation/translations/zh_CN/power/opp.rst +0
-0Documentation/translations/zh_CN/power/opp.rst dev_pm_opp_get_opp_count · line 277
Quoted 5 lines
Documentation/translations/zh_CN/power/opp.rst +1
-1@@ -274,7 +274,7 @@ dev_pm_opp_get_opp_count { /* 做一些事情 */ num_available = dev_pm_opp_get_opp_count(dev); - speeds = kzalloc(sizeof(u32) * num_available, GFP_KERNEL); + speeds = kcalloc(num_available, sizeof(u32), GFP_KERNEL);If the translated version is modified, I think the original file should follow as well at
Documentation/power/opp.rstline 308:Documentation/power/opp.rst +1
-1@@ -305,7 +305,7 @@ dev_pm_opp_get_opp_count { /* Do things */ num_available = dev_pm_opp_get_opp_count(dev); - speeds = kzalloc(sizeof(u32) * num_available, GFP_KERNEL); + speeds = kcalloc(sizeof(u32) * num_available, GFP_KERNEL); /* populate the table in increasing order */ freq = 0; while (!IS_ERR(opp = dev_pm_opp_find_freq_ceil(dev, &freq)))
Quoted 1 line
{
As you both suggested, this change should be made if the original file is changed. Therefore, before this patch I already sent another one [1] that made the proposed changes to the original file.
[1] https://lore.kernel.org/linux-hardening/[email protected]/
But if you prefer, I can send just one patch with the two changes.
Best regards,
Erick
Quoted 13 lines
Thanks,
Hu HaowenQuoted 8 lines
Documentation/translations/zh_CN/power/opp.rst +0
-1/* 按升序填充表 */ freq = 0; while (!IS_ERR(opp = dev_pm_opp_find_freq_ceil(dev, &freq))) { --2.25.1
Jonathan Corbet
maintainerQuoted 23 lines · Erick Archer
As noted in the "Deprecated Interfaces, Language Features, Attributes, and Conventions" documentation [1], size calculations (especially multiplication) should not be performed in memory allocator (or similar) function arguments due to the risk of them overflowing. This could lead to values wrapping around and a smaller allocation being made than the caller was expecting. Using those allocations could lead to linear overflows of heap memory and other misbehaviors.
So, in the example code use the purpose specific
kcalloc()function instead of the argument size * count in thekzalloc()function.Signed-off-by Erick Archer <[email protected]>--- Documentation/translations/zh_CN/power/opp.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Documentation/translations/zh_CN/power/opp.rst +0
-0
Documentation/translations/zh_CN/power/opp.rst dev_pm_opp_get_opp_count · line 277
Quoted 5 lines
Documentation/translations/zh_CN/power/opp.rst +1
-1@@ -274,7 +274,7 @@ dev_pm_opp_get_opp_count { /* 做一些事情 */ num_available = dev_pm_opp_get_opp_count(dev); - speeds = kzalloc(sizeof(u32) * num_available, GFP_KERNEL); + speeds = kcalloc(num_available, sizeof(u32), GFP_KERNEL);
Without addressing the validity of this change, as Hu says, we should never change the translations without fixing the original as well - otherwise they aren't really translations anymore.
Thanks,
jon