Skip to contentSkip to conversation

riscv: Use kcalloc() instead of kzalloc()

PATCH Applied Erick Archer 5 participants 5 messages Jan 20, 2024 – Mar 20, 2024 RISC-V

v1 of 2 Applied 1/1 Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 riscv: Use kcalloc() instead of kzalloc()

As noted in the "Deprecated Interfaces, Language Features, Attributes, and Conventions" documentation [1], size calculations (especially multiplication) should not be performed in memory allocator (or similar) function arguments due to the risk of them overflowing. This could lead to values wrapping around and a smaller allocation being made than the caller was expecting. Using those allocations could lead to linear overflows of heap memory and other misbehaviors.

So, use the purpose specific kcalloc() function instead of the argument count * size in the kzalloc() function.

Also, it is preferred to use sizeof(*pointer) instead of sizeof(type) due to the type of the variable can change and one needs not change the former (unlike the latter).

---
 arch/riscv/kernel/cpufeature.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
arch/riscv/kernel/cpufeature.c +1 -2
index 89920f84d0a3..549a76e34c4e 100644
@@ -901,8 +901,7 @@ static int check_unaligned_access_all_cpus(void)
 {
 	unsigned int cpu;
 	unsigned int cpu_count = num_possible_cpus();
-	struct page **bufs = kzalloc(cpu_count * sizeof(struct page *),
-				     GFP_KERNEL);
+	struct page **bufs = kcalloc(cpu_count, sizeof(*bufs), GFP_KERNEL);
 
 	if (!bufs) {
 		pr_warn("Allocation failure, not measuring misaligned performance\n");

--
2.25.1

reviewer Reviewed-by on v1 1/1
#1 lore raw

Hi Erick,

Quoted 40 lines · Erick Archer

As noted in the "Deprecated Interfaces, Language Features, Attributes, and Conventions" documentation [1], size calculations (especially multiplication) should not be performed in memory allocator (or similar) function arguments due to the risk of them overflowing. This could lead to values wrapping around and a smaller allocation being made than the caller was expecting. Using those allocations could lead to linear overflows of heap memory and other misbehaviors.

So, use the purpose specific kcalloc() function instead of the argument count * size in the kzalloc() function.

Also, it is preferred to use sizeof(*pointer) instead of sizeof(type) due to the type of the variable can change and one needs not change the former (unlike the latter).

---
  arch/riscv/kernel/cpufeature.c | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)
arch/riscv/kernel/cpufeature.c +1 -3
index 89920f84d0a3..549a76e34c4e 100644
@@ -901,8 +901,7 @@ static int check_unaligned_access_all_cpus(void)
  {
  	unsigned int cpu;
  	unsigned int cpu_count = num_possible_cpus();
-	struct page **bufs = kzalloc(cpu_count * sizeof(struct page *),
-				     GFP_KERNEL);
+	struct page **bufs = kcalloc(cpu_count, sizeof(*bufs), GFP_KERNEL);
 
  	if (!bufs) {
  		pr_warn("Allocation failure, not measuring misaligned performance\n");
--

2.25.1

Quoted 4 lines

_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv

You can add:

Thanks,

Alex

Reviewed-by on v1 1/1
#2 lore raw
In reply to Erick Archer
Quoted 37 lines · Erick Archer

As noted in the "Deprecated Interfaces, Language Features, Attributes, and Conventions" documentation [1], size calculations (especially multiplication) should not be performed in memory allocator (or similar) function arguments due to the risk of them overflowing. This could lead to values wrapping around and a smaller allocation being made than the caller was expecting. Using those allocations could lead to linear overflows of heap memory and other misbehaviors.

So, use the purpose specific kcalloc() function instead of the argument count * size in the kzalloc() function.

Also, it is preferred to use sizeof(*pointer) instead of sizeof(type) due to the type of the variable can change and one needs not change the former (unlike the latter).

---
 arch/riscv/kernel/cpufeature.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
arch/riscv/kernel/cpufeature.c +1 -3
index 89920f84d0a3..549a76e34c4e 100644
@@ -901,8 +901,7 @@ static int check_unaligned_access_all_cpus(void)
 {
 	unsigned int cpu;
 	unsigned int cpu_count = num_possible_cpus();
-	struct page **bufs = kzalloc(cpu_count * sizeof(struct page *),
-				     GFP_KERNEL);
+	struct page **bufs = kcalloc(cpu_count, sizeof(*bufs), GFP_KERNEL);
 
 	if (!bufs) {
 		pr_warn("Allocation failure, not measuring misaligned performance\n");
--
Quoted 2 lines

2.25.1

Reviewed-by on v1 1/1
#3 lore raw
In reply to Erick Archer
Quoted 11 lines · Erick Archer

As noted in the "Deprecated Interfaces, Language Features, Attributes, and Conventions" documentation [1], size calculations (especially multiplication) should not be performed in memory allocator (or similar) function arguments due to the risk of them overflowing. This could lead to values wrapping around and a smaller allocation being made than the caller was expecting. Using those allocations could lead to linear overflows of heap memory and other misbehaviors.

So, use the purpose specific kcalloc() function instead of the argument count * size in the kzalloc() function.

Quoted 7 lines

Also, it is preferred to use sizeof(*pointer) instead of sizeof(type) due to the type of the variable can change and one needs not change the former (unlike the latter).

Thanks!

Signature · 1 line
Gustavo
Quoted 22 lines
---
  arch/riscv/kernel/cpufeature.c | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)
arch/riscv/kernel/cpufeature.c +1 -3
index 89920f84d0a3..549a76e34c4e 100644
@@ -901,8 +901,7 @@ static int check_unaligned_access_all_cpus(void)
  {
  	unsigned int cpu;
  	unsigned int cpu_count = num_possible_cpus();
-	struct page **bufs = kzalloc(cpu_count * sizeof(struct page *),
-				     GFP_KERNEL);
+	struct page **bufs = kcalloc(cpu_count, sizeof(*bufs), GFP_KERNEL);
 
  	if (!bufs) {
  		pr_warn("Allocation failure, not measuring misaligned performance\n");
--

2.25.1

#4 lore raw
In reply to Erick Archer
This patch was applied to riscv/linux.git (for-next) by Palmer Dabbelt <[email protected]>:

Hello:

This patch was applied to riscv/linux.git (for-next) by Palmer Dabbelt <[email protected]>:

Quoted 9 lines · On Sat, 20 Jan 2024 14:54:00 +0100 you wrote:

As noted in the "Deprecated Interfaces, Language Features, Attributes, and Conventions" documentation [1], size calculations (especially multiplication) should not be performed in memory allocator (or similar) function arguments due to the risk of them overflowing. This could lead to values wrapping around and a smaller allocation being made than the caller was expecting. Using those allocations could lead to linear overflows of heap memory and other misbehaviors.

[...]

Here is the summary with links:
- riscv: Use kcalloc() instead of kzalloc()

    https://git.kernel.org/riscv/c/28e4748e5e3d

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html