i2c: designware: constify abort_sources
Subsystems (3)
PATCH 1/2 i2c: designware: constify abort_sources
We never modify abort_sources, mark it as const.
--- drivers/i2c/busses/i2c-designware-common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/i2c/busses/i2c-designware-common.c +1 -1
@@ -28,7 +28,7 @@#include "i2c-designware-core.h" -static char *abort_sources[] = { +static const char *const abort_sources[] = { [ABRT_7B_ADDR_NOACK ] ="slave address not acknowledged (7bit mode)" , [ABRT_10ADDR1_NOACK] =
Signature · 1 line
2.35.3
PATCH 2/2 i2c: designware: constify regmap_config
We never modify regmap_config, mark it as const.
--- drivers/i2c/busses/i2c-designware-platdrv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/i2c/busses/i2c-designware-platdrv.c +1 -1
@@ -100,7 +100,7 @@ static int bt1_i2c_write(void *context, unsigned int reg, unsigned int val) BT1_I2C_CTL_GO | BT1_I2C_CTL_WR | (reg & BT1_I2C_CTL_ADDR_MASK)); } -static struct regmap_config bt1_i2c_cfg = { +static const struct regmap_config bt1_i2c_cfg = { .reg_bits =32 , .val_bits =32 , .reg_stride =4 ,
Signature · 1 line
2.35.3
Re: [PATCH v1 2/2] i2c: designware: constify regmap_config
Quoted 7 lines · Raag Jadav
We never modify
regmap_config, mark it as const.Signed-off-by Raag Jadav <[email protected]>--- drivers/i2c/busses/i2c-designware-platdrv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Both:
Re: [PATCH v1 2/2] i2c: designware: constify regmap_config
Quoted 11 lines · Jarkko Nikula
Quoted 7 lines · Raag Jadav
We never modify
regmap_config, mark it as const.Signed-off-by Raag Jadav <[email protected]>--- drivers/i2c/busses/i2c-designware-platdrv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Both:
Acked-by Jarkko Nikula <[email protected]>
Bump.
Anything I can do to move these forward?
Raag
Re: [PATCH v1 2/2] i2c: designware: constify regmap_config
Quoted 9 lines · Raag Jadav
Quoted 8 lines · Jarkko Nikula
Quoted 7 lines · Raag Jadav
We never modify
regmap_config, mark it as const.Signed-off-by Raag Jadav <[email protected]>--- drivers/i2c/busses/i2c-designware-platdrv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 7 lines
Quoted 3 lines
Both:
Acked-by Jarkko Nikula <[email protected]>Bump.
Anything I can do to move these forward?
Hi Andi,
Are these worth moving forward?
Raag
Andi Shyti
maintainerHi Raag,
Quoted 3 lines · Raag Jadav
We never modify
abort_sources, mark it as const.Signed-off-by Raag Jadav <[email protected]>
we meet in a different context :-)
Sorry I have missed this patch. I applied it to i2c/i2c-host. The second patch was already sent here 21ac0359f72a90.
Thanks,
Andi
Quoted 8 lines · Andi Shyti
Hi Raag,
Quoted 3 lines · Raag Jadav
We never modify
abort_sources, mark it as const.Signed-off-by Raag Jadav <[email protected]>we meet in a different context :-)
Small world :)
Quoted 2 lines
Sorry I have missed this patch. I applied it to i2c/i2c-host. The second patch was already sent here
21ac0359f72a90.
Awesome.
Raag