Skip to contentSkip to conversation

insane.bbclass: Allow the warning about virtual/ to be disabled

PATCH In review Peter Kjellerstedt 4 participants 5 messages Jan 22, 2024 – Feb 10, 2024 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 insane.bbclass: Allow the warning about virtual/ to be disabled

Commit f673d3d239799fb1ab50f4aa5d44187666aa0cd7 introduced a warning for virtual/ being used in RPROVIDES and RDEPENDS. Make it possible to disable the warning by removing "virtual-slash from WARN_QA.

---
 meta/classes-global/insane.bbclass | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)
meta/classes-global/insane.bbclass +7 -6
index 828f618cda..4ab7e4069d 100644
@@ -34,7 +34,7 @@ WARN_QA ?= " libdir xorg-driver-abi buildpaths \
             missing-update-alternatives native-last missing-ptest \
             license-exists license-no-generic license-syntax license-format \
             license-incompatible license-file-missing obsolete-license \
-            32bit-time \
+            32bit-time virtual-slash \
             "
 ERROR_QA ?= "dev-so debug-deps dev-deps debug-files arch pkgconfig la \
             perms dep-cmp pkgvarcheck perm-config perm-line perm-link \
@@ -1607,11 +1607,12 @@ python () {
     if (d.getVar(d.expand('DEPENDS:${PN}'))):
         oe.qa.handle_error("pkgvarcheck", "recipe uses DEPENDS:${PN}, should use DEPENDS", d)
 
-    # virtual/ is meaningless for those variables
-    for k in ['RDEPENDS', 'RPROVIDES']:
-        for var in bb.utils.explode_deps(d.getVar(k + ':' + pn) or ""):
-            if var.startswith("virtual/"):
-                bb.warn("%s is set to %s, the substring 'virtual/' holds no meaning in this context. It is suggested to use the 'virtual-' instead." % (k, var))
+    # virtual/ is meaningless for these variables
+    if "virtual-slash" in (d.getVar("ALL_QA") or "").split():
+        for k in ['RDEPENDS', 'RPROVIDES']:
+            for var in bb.utils.explode_deps(d.getVar(k + ':' + pn) or ""):
+                if var.startswith("virtual/"):
+                    oe.qa.handle_error("virtual-slash", "%s is set to %s, but the substring 'virtual/' holds no meaning in this context. It is suggested to use 'virtual-' instead." % (k, var), d)
 
     issues = []
     if (d.getVar('PACKAGES') or "").split():
#1 lore raw
Quoted 8 lines · Peter Kjellerstedt

Commit f673d3d239799fb1ab50f4aa5d44187666aa0cd7 introduced a warning for virtual/ being used in RPROVIDES and RDEPENDS. Make it possible to disable the warning by removing "virtual-slash from WARN_QA.

---
 meta/classes-global/insane.bbclass | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

Whilst I can understand why you might want to make this configurable, I'm not sure if is a great idea since people are just going to turn it off and continue to ignore it :/.

virtual/ in the runtime namespace has never been supported and always been strongly recommended against.

Cheers,

Richard

#2 lore raw
Quoted 5 lines · Richard Purdie
Quoted 4 lines · Peter Kjellerstedt

Commit f673d3d239799fb1ab50f4aa5d44187666aa0cd7 introduced a warning for virtual/ being used in RPROVIDES and RDEPENDS. Make it possible to disable the warning by removing "virtual-slash from WARN_QA.

Quoted 9 lines
Quoted 4 lines
---
 meta/classes-global/insane.bbclass | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

Whilst I can understand why you might want to make this configurable, I'm not sure if is a great idea since people are just going to turn it off and continue to ignore it :/.

It also allows to add it to ERROR_QA :).

#3 lore raw
In reply to Richard Purdie
Quoted 18 lines

-----Original Message-----
From: Richard Purdie <[email protected]>
Sent: den 22 januari 2024 15:02
To: Peter Kjellerstedt <[email protected]>; openembedded- [email protected]
Subject: Re: [OE-core] [PATCH] insane.bbclass: Allow the warning about virtual/ to be disabled

Quoted 8 lines · Peter Kjellerstedt

Commit f673d3d239799fb1ab50f4aa5d44187666aa0cd7 introduced a warning for virtual/ being used in RPROVIDES and RDEPENDS. Make it possible to disable the warning by removing "virtual-slash from WARN_QA.

---
 meta/classes-global/insane.bbclass | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)
Quoted 6 lines

Whilst I can understand why you might want to make this configurable, I'm not sure if is a great idea since people are just going to turn it off and continue to ignore it :/.

virtual/ in the runtime namespace has never been supported and always been strongly recommended against.

We do not produce any package feeds and AFAIK in that case virtual/ works fine for runtime dependencies since it is only a name, just like, e.g., virtual-.

We get a gazillion warnings due to this during parsing, and it is not anything I can solve easily. And since it is just a warning that currently doesn't affect us, I would like to turn it off for now.

And as Martin mentioned, with my change applied, those who want can turn the warning into an error. And being able to do that is typically the only way to actually get rid of all warnings and keep them from coming back.

Quoted 4 lines

Cheers,

Richard

//Peter

A message that is not in the archive (sent off-list or not yet received): [email protected]

#5 lore raw

*ping*

//Peter

Quoted 48 lines

-----Original Message-----
From: [email protected] <[email protected]> On Behalf Of Peter Kjellerstedt
Sent: den 22 januari 2024 15:21
To: Richard Purdie <[email protected]>; [email protected]
Cc: Martin Jansa <[email protected]>
Subject: Re: [OE-core] [PATCH] insane.bbclass: Allow the warning about virtual/ to be disabled

Quoted 16 lines

-----Original Message-----
From: Richard Purdie <[email protected]>
Sent: den 22 januari 2024 15:02
To: Peter Kjellerstedt <[email protected]>; [email protected]
Subject: Re: [OE-core] [PATCH] insane.bbclass: Allow the warning about virtual/ to be disabled

Quoted 8 lines · Peter Kjellerstedt

Commit f673d3d239799fb1ab50f4aa5d44187666aa0cd7 introduced a warning for virtual/ being used in RPROVIDES and RDEPENDS. Make it possible to disable the warning by removing "virtual-slash from WARN_QA.

---
 meta/classes-global/insane.bbclass | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)
Quoted 6 lines

Whilst I can understand why you might want to make this configurable, I'm not sure if is a great idea since people are just going to turn it off and continue to ignore it :/.

virtual/ in the runtime namespace has never been supported and always been strongly recommended against.

We do not produce any package feeds and AFAIK in that case virtual/ works fine for runtime dependencies since it is only a name, just like, e.g., virtual-.

We get a gazillion warnings due to this during parsing, and it is not anything I can solve easily. And since it is just a warning that currently doesn't affect us, I would like to turn it off for now.

And as Martin mentioned, with my change applied, those who want can turn the warning into an error. And being able to do that is typically the only way to actually get rid of all warnings and keep them from coming back.

Quoted 4 lines

Cheers,

Richard

//Peter