powerpc: udbg_memcons: mark functions static
Subsystems (2)
PATCH 1/2 powerpc: udbg_memcons: mark functions static
From: Arnd Bergmann <[email protected]>
ppc64_book3e_allmodconfig has one more driver that triggeres a few missing-prototypes warnings:
arch/powerpc/sysdev/udbg_memcons.c:44:6: error: no previous prototype for 'memcons_putc' [-Werror=missing-prototypes] arch/powerpc/sysdev/udbg_memcons.c:57:5: error: no previous prototype for 'memcons_getc_poll' [-Werror=missing-prototypes] arch/powerpc/sysdev/udbg_memcons.c:80:5: error: no previous prototype for 'memcons_getc' [-Werror=missing-prototypes]
Mark all these function static as there are no other users.
--- arch/powerpc/sysdev/udbg_memcons.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
arch/powerpc/sysdev/udbg_memcons.c +3 -3
@@ -41,7 +41,7 @@ struct memcons memcons = { .input_end = &memcons_input[CONFIG_PPC_MEMCONS_INPUT_SIZE], }; -void memcons_putc (char c) +static void memcons_putc (char c) {char *new_output_pos;
@@ -54,7 +54,7 @@ void memcons_putc(char c) memcons.output_pos = new_output_pos; } -int memcons_getc_poll (void ) +static int memcons_getc_poll (void ) {char c;char *new_input_pos;
@@ -77,7 +77,7 @@ int memcons_getc_poll(void)return -1 ; } -int memcons_getc (void ) +static int memcons_getc (void ) {int c;
Signature · 1 line
2.39.2
PATCH 2/2 powerpc: 85xx: mark local functions static
From: Arnd Bergmann <[email protected]>
These functions are either used in only one file and can just be makde static or need an #include statement to avoid a warning:
arch/powerpc/platforms/85xx/mpc8536_ds.c:30:13: error: no previous prototype for 'mpc8536_ds_pic_init' [-Werror=missing-prototypes] arch/powerpc/platforms/85xx/p1010rdb.c:27:13: error: no previous prototype for 'p1010_rdb_pic_init' [-Werror=missing-prototypes] arch/powerpc/platforms/85xx/p1022_ds.c:373:6: error: no previous prototype for 'p1022ds_set_pixel_clock' [-Werror=missing-prototypes] arch/powerpc/platforms/85xx/p1022_ds.c:422:1: error: no previous prototype for 'p1022ds_valid_monitor_port' [-Werror=missing-prototypes] arch/powerpc/platforms/85xx/p1022_ds.c:435:13: error: no previous prototype for 'p1022_ds_pic_init' [-Werror=missing-prototypes] arch/powerpc/platforms/85xx/p1022_rdk.c:43:6: error: no previous prototype for 'p1022rdk_set_pixel_clock' [-Werror=missing-prototypes] arch/powerpc/platforms/85xx/p1022_rdk.c:92:1: error: no previous prototype for 'p1022rdk_valid_monitor_port' [-Werror=missing-prototypes] arch/powerpc/platforms/85xx/p1022_rdk.c:99:13: error: no previous prototype for 'p1022_rdk_pic_init' [-Werror=missing-prototypes] arch/powerpc/platforms/85xx/socrates_fpga_pic.c:273:13: error: no previous prototype for 'socrates_fpga_pic_init' [-Werror=missing-prototypes] arch/powerpc/platforms/85xx/xes_mpc85xx.c:40:13: error: no previous prototype for 'xes_mpc85xx_pic_init' [-Werror=missing-prototypes] arch/powerpc/platforms/85xx/mvme2500.c:24:13: error: no previous prototype for 'mvme2500_pic_init' [-Werror=missing-prototypes]
--- arch/powerpc/platforms/85xx/mpc8536_ds.c | 2 +- arch/powerpc/platforms/85xx/mvme2500.c | 2 +- arch/powerpc/platforms/85xx/p1010rdb.c | 2 +- arch/powerpc/platforms/85xx/p1022_ds.c | 6 +++--- arch/powerpc/platforms/85xx/p1022_rdk.c | 6 +++--- arch/powerpc/platforms/85xx/socrates_fpga_pic.c | 2 ++ arch/powerpc/platforms/85xx/xes_mpc85xx.c | 2 +- 7 files changed, 12 insertions(+), 10 deletions(-)
arch/powerpc/platforms/85xx/mpc8536_ds.c +1 -1
@@ -27,7 +27,7 @@#include "mpc85xx.h" -void __init mpc8536_ds_pic_init (void ) +static void __init mpc8536_ds_pic_init (void ) {struct mpic *mpic =mpic_alloc (NULL ,0 ,MPIC_BIG_ENDIAN ,0 ,256 ," OpenPIC " );
arch/powerpc/platforms/85xx/mvme2500.c +1 -1
@@ -21,7 +21,7 @@#include "mpc85xx.h" -void __init mvme2500_pic_init (void ) +static void __init mvme2500_pic_init (void ) { struct mpic *mpic = mpic_alloc(NULL, 0, MPIC_BIG_ENDIAN | MPIC_SINGLE_DEST_CPU,
arch/powerpc/platforms/85xx/p1010rdb.c +1 -1
@@ -24,7 +24,7 @@#include "mpc85xx.h" -void __init p1010_rdb_pic_init (void ) +static void __init p1010_rdb_pic_init (void ) { struct mpic *mpic = mpic_alloc(NULL, 0, MPIC_BIG_ENDIAN | MPIC_SINGLE_DEST_CPU,
arch/powerpc/platforms/85xx/p1022_ds.c +3 -3
@@ -370,7 +370,7 @@ static void p1022ds_set_monitor_port(enum fsl_diu_monitor_port port)* * @pixclock: the wavelength, in picoseconds, of the clock */ -void p1022ds_set_pixel_clock (unsigned int pixclock) +static void p1022ds_set_pixel_clock (unsigned int pixclock) {struct device_node *guts_np =NULL ;struct ccsr_guts __iomem *guts;
@@ -418,7 +418,7 @@ void p1022ds_set_pixel_clock(unsigned int pixclock)/** * p1022ds_valid_monitor_port: set the monitor port for sysfs */ -enum fsl_diu_monitor_port +static enum fsl_diu_monitor_port p1022ds_valid_monitor_port (enum fsl_diu_monitor_port port) {switch (port) {
@@ -432,7 +432,7 @@ p1022ds_valid_monitor_port(enum fsl_diu_monitor_port port)#endif -void __init p1022_ds_pic_init (void ) +static void __init p1022_ds_pic_init (void ) { struct mpic *mpic = mpic_alloc(NULL, 0, MPIC_BIG_ENDIAN | MPIC_SINGLE_DEST_CPU,
arch/powerpc/platforms/85xx/p1022_rdk.c +3 -3
@@ -40,7 +40,7 @@* * @pixclock: the wavelength, in picoseconds, of the clock */ -void p1022rdk_set_pixel_clock (unsigned int pixclock) +static void p1022rdk_set_pixel_clock (unsigned int pixclock) {struct device_node *guts_np =NULL ;struct ccsr_guts __iomem *guts;
@@ -88,7 +88,7 @@ void p1022rdk_set_pixel_clock(unsigned int pixclock)/** * p1022rdk_valid_monitor_port: set the monitor port for sysfs */ -enum fsl_diu_monitor_port +static enum fsl_diu_monitor_port p1022rdk_valid_monitor_port (enum fsl_diu_monitor_port port) {return FSL_DIU_PORT_DVI ;
@@ -96,7 +96,7 @@ p1022rdk_valid_monitor_port(enum fsl_diu_monitor_port port)#endif -void __init p1022_rdk_pic_init (void ) +static void __init p1022_rdk_pic_init (void ) { struct mpic *mpic = mpic_alloc(NULL, 0, MPIC_BIG_ENDIAN | MPIC_SINGLE_DEST_CPU,
arch/powerpc/platforms/85xx/socrates_fpga_pic.c +2 -0
@@ -8,6 +8,8 @@#include <linux/of_irq.h> #include <linux/io.h> +#include "socrates_fpga_pic.h" +/* * The FPGA supports 9 interrupt sources, which can be routed to 3 * interrupt request lines of the MPIC. The line to be used can be
arch/powerpc/platforms/85xx/xes_mpc85xx.c +1 -1
@@ -37,7 +37,7 @@#define MPC85xx_L2CTL_L2I 0x40000000/* L2 flash invalidate */ #define MPC85xx_L2CTL_L2SIZ_MASK 0x30000000/* L2 SRAM size (R/O) */ -void __init xes_mpc85xx_pic_init (void ) +static void __init xes_mpc85xx_pic_init (void ) {struct mpic *mpic =mpic_alloc (NULL ,0 ,MPIC_BIG_ENDIAN ,0 ,256 ," OpenPIC " );
Signature · 1 line
2.39.2
Michael Ellerman
AppliedQuoted 8 lines · Arnd Bergmann
ppc64_book3e_allmodconfighas one more driver that triggeres a few missing-prototypes warnings:
arch/powerpc/sysdev/udbg_memcons.c:44:6: error: no previous prototype for 'memcons_putc' [-Werror=missing-prototypes]arch/powerpc/sysdev/udbg_memcons.c:57:5: error: no previous prototype for 'memcons_getc_poll' [-Werror=missing-prototypes]arch/powerpc/sysdev/udbg_memcons.c:80:5: error: no previous prototype for 'memcons_getc' [-Werror=missing-prototypes][...]
Applied to powerpc/fixes.
[1/2] powerpc: udbg_memcons: mark functions static
https://git.kernel.org/powerpc/c/5c84bc8b617bf90e722cc57d447abd9a468d3a52 [2/2] powerpc: 85xx: mark local functions static https://git.kernel.org/powerpc/c/1c57b9f63ab34f01b8c73731cc0efacb5a9a2f16
cheers