Skip to contentSkip to conversation

fs/orangefs: remove ORANGEFS_CACHE_CREATE_FLAGS

PATCH New Vlastimil Babka 1 participant 1 message Jan 23, 2024 Orangefs filesystem

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fs/orangefs: remove ORANGEFS_CACHE_CREATE_FLAGS

The flags were set to SLAB_RED_ZONE when CONFIG_DEBUG_SLAB was enabled. With SLAB gone, this is now dead code so remove it. With SLUB, debugging options including red zoning can be set for orangefs caches by the slab_debug boot parameter.

---
 fs/orangefs/orangefs-cache.c  |  2 +-
 fs/orangefs/orangefs-kernel.h | 10 ----------
 fs/orangefs/super.c           |  2 +-
 3 files changed, 2 insertions(+), 12 deletions(-)
fs/orangefs/orangefs-cache.c +1 -1
index 3b6982bf6bcf..e75e173a9186 100644
@@ -22,7 +22,7 @@ int op_cache_initialize(void)
 	op_cache = kmem_cache_create("orangefs_op_cache",
 				     sizeof(struct orangefs_kernel_op_s),
 				     0,
-				     ORANGEFS_CACHE_CREATE_FLAGS,
+				     0,
 				     NULL);
 
 	if (!op_cache) {
fs/orangefs/orangefs-kernel.h +0 -10
index 926d9c0a428a..e2df7eeadc7a 100644
@@ -93,16 +93,6 @@ enum orangefs_vfs_op_states {
 	OP_VFS_STATE_GIVEN_UP = 16,
 };
 
-/*
- * orangefs kernel memory related flags
- */
-
-#if (defined CONFIG_DEBUG_SLAB)
-#define ORANGEFS_CACHE_CREATE_FLAGS SLAB_RED_ZONE
-#else
-#define ORANGEFS_CACHE_CREATE_FLAGS 0
-#endif
-
 extern const struct xattr_handler * const orangefs_xattr_handlers[];
 
 extern struct posix_acl *orangefs_get_acl(struct inode *inode, int type, bool rcu);
fs/orangefs/super.c +1 -1
index 5254256a224d..d5a71df63d4e 100644
@@ -644,7 +644,7 @@ int orangefs_inode_cache_initialize(void)
 					"orangefs_inode_cache",
 					sizeof(struct orangefs_inode_s),
 					0,
-					ORANGEFS_CACHE_CREATE_FLAGS,
+					0,
 					offsetof(struct orangefs_inode_s,
 						link_target),
 					sizeof_field(struct orangefs_inode_s,
Signature · 1 line
2.43.0